gerlowskija commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1894246273
OK, sounds good - I'll tag you both on a PR shortly that replaces
datastore/store with a combination of "collection" and "indextype".
--
This is an automated message from the Apache Gi
dsmiley commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1894231175
+1 to IndexType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
epugh commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1894221183
a logical Index can either be a single core or made up of many cores in the
form of a collection
--
This is an automated message from the Apache Git Service.
To respond to the message, p
epugh commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1894220549
`IndexType`?And add it to
https://solr.apache.org/guide/solr/latest/getting-started/solr-glossary.html#SolrGlossary-I
?
--
This is an automated message from the Apache Git Service.
To r
gerlowskija commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1894215477
Another slightly less arcane example is the
[DataStoreSolrRequest](https://github.com/apache/solr/pull/2177/files#diff-e13377598540e9ce1e314f17966d3f37cbe71433fe3ec6b91785751aa57df622)
c
epugh commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1894206680
How much do you hate the idea of not having `storeType`?? Could we just
have two methods, one where it's `/core/{name}/select` and the other is
`/collection/{name}/select`? Could we side s
gerlowskija commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1894171295
If you guys prefer "collection" here, that's fine with me. (@epugh - I
agree that some doc changes would be helpful in clarifying that "collection" is
sometimes used generically in the
epugh commented on PR #2177:
URL: https://github.com/apache/solr/pull/2177#issuecomment-1883191148
I am having a bit of heart burn on the term "DataStore"The more I
see it proliferate the more it just seems like a bit of classic Enterprise Java
type naming that doesn't mean anything
gerlowskija merged PR #2177:
URL: https://github.com/apache/solr/pull/2177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
gerlowskija commented on code in PR #2177:
URL: https://github.com/apache/solr/pull/2177#discussion_r1442905887
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -175,6 +175,19 @@ public void setQueryParams(Set queryParams) {
public abstract SolrPa
dsmiley commented on code in PR #2177:
URL: https://github.com/apache/solr/pull/2177#discussion_r1442510069
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -175,6 +175,19 @@ public void setQueryParams(Set queryParams) {
public abstract SolrParams
dsmiley commented on code in PR #2177:
URL: https://github.com/apache/solr/pull/2177#discussion_r1442509698
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -175,6 +175,19 @@ public void setQueryParams(Set queryParams) {
public abstract SolrParams
gerlowskija commented on code in PR #2177:
URL: https://github.com/apache/solr/pull/2177#discussion_r1442460595
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -175,6 +175,19 @@ public void setQueryParams(Set queryParams) {
public abstract SolrPa
gerlowskija opened a new pull request, #2177:
URL: https://github.com/apache/solr/pull/2177
https://issues.apache.org/jira/browse/SOLR-17066
# Description
SOLR-17066 recently expanded the concept of a "default collection" to all
SolrClient implementations, as a migration pa
14 matches
Mail list logo
