Re: [PR] SOLR-17083: Make CoreSorter class configurable [solr]

2023-11-30 Thread via GitHub
dsmiley merged PR #2088: URL: https://github.com/apache/solr/pull/2088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17083: Make CoreSorter class configurable [solr]

2023-11-28 Thread via GitHub
dsmiley commented on PR #2088: URL: https://github.com/apache/solr/pull/2088#issuecomment-1830417075 I filed https://issues.apache.org/jira/browse/SOLR-17087 for the kerberos test flapping failure. I filed https://issues.apache.org/jira/browse/SOLR-17088 for the TestPrepRecovery test fla

Re: [PR] SOLR-17083: Make CoreSorter class configurable [solr]

2023-11-28 Thread via GitHub
pvcnt commented on PR #2088: URL: https://github.com/apache/solr/pull/2088#issuecomment-1830384213 @dsmiley I was thinking: do you think that a `` element should be preferred? On the one hand it might be more consistent with how most plugins, but on the other hand overriding this class migh

Re: [PR] SOLR-17083: Make CoreSorter class configurable [solr]

2023-11-27 Thread via GitHub
pvcnt commented on code in PR #2088: URL: https://github.com/apache/solr/pull/2088#discussion_r1405802992 ## solr/CHANGES.txt: ## @@ -84,6 +84,8 @@ New Features * SOLR-17079: Allow to declare replica placement plugins in solr.xml (Vincent Primault) +* SOLR-16959: Make the

Re: [PR] SOLR-17083: Make CoreSorter class configurable [solr]

2023-11-26 Thread via GitHub
dsmiley commented on code in PR #2088: URL: https://github.com/apache/solr/pull/2088#discussion_r1402765054 ## solr/CHANGES.txt: ## @@ -84,6 +84,8 @@ New Features * SOLR-17079: Allow to declare replica placement plugins in solr.xml (Vincent Primault) +* SOLR-16959: Make t

[PR] SOLR-17083: Make CoreSorter class configurable [solr]

2023-11-22 Thread via GitHub
pvcnt opened a new pull request, #2088: URL: https://github.com/apache/solr/pull/2088 https://issues.apache.org/jira/browse/SOLR-17083 # Description I would like to be able to configure how cores are sorted before being loaded to accommodate more specific needs.