pjmcarthur commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1450781121
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -211,6 +215,17 @@ private NodeConfig(
if (null == this.solrHome) throw new NullPointerException("
pjmcarthur commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1450776885
##
solr/core/src/test/org/apache/solr/cluster/placement/impl/PlacementPluginIntegrationTest.java:
##
@@ -124,25 +124,6 @@ public void testConfigurationInSystemProps() {
pjmcarthur commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1450773853
##
solr/core/src/java/org/apache/solr/api/NodeConfigClusterPluginsSource.java:
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
pvcnt commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1450387463
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -211,6 +215,17 @@ private NodeConfig(
if (null == this.solrHome) throw new NullPointerException("solrH
pvcnt commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1450386197
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -211,6 +215,17 @@ private NodeConfig(
if (null == this.solrHome) throw new NullPointerException("solrH
pjmcarthur commented on PR #2126:
URL: https://github.com/apache/solr/pull/2126#issuecomment-1887907029
@pvcnt FYI - This PR has been updated to handle the replicaPlacementFactory
declared in solr.xml in the same way as cluster singleton plugins.
--
This is an automated message from the A
pjmcarthur commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1449148959
##
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##
@@ -651,6 +651,27 @@ private static PluginInfo[]
getBackupRepositoryPluginInfos(List cfg)
return
dsmiley commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1448196037
##
solr/core/src/java/org/apache/solr/api/ClusterPluginsSourceConfigurator.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
dsmiley commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1445581541
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -223,17 +221,23 @@ private NodeConfig(
if (this.clusterSingletonPlugins != null
&& this.c
dsmiley commented on PR #2126:
URL: https://github.com/apache/solr/pull/2126#issuecomment-1880208066
Let's imagine someone out there has set `disable.configEdit` and is also
posting to `/api/cluster/plugin`. After the proposed change here, a call to
that API is going to get an error (or _s
pjmcarthur commented on PR #2126:
URL: https://github.com/apache/solr/pull/2126#issuecomment-1879279003
I will add the validation.
Regarding piggybacking on the existing `disable.configEdit` property, I like
the idea, but I have one concern.
If there are any Solr deployments out t
dsmiley commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1442145469
##
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##
@@ -165,6 +166,9 @@ public static NodeConfig fromConfig(
if (cloudConfig != null) configBuilder.setC
pvcnt commented on PR #2126:
URL: https://github.com/apache/solr/pull/2126#issuecomment-1877435871
The point I am raising about validation has actually already been raised by
Paul there: https://github.com/apache/solr/pull/2126/files#r1424690508 I think
it would be a mistake to not enforce
dsmiley commented on PR #2126:
URL: https://github.com/apache/solr/pull/2126#issuecomment-1877290383
> I believe it would still be interesting to have at least two different
plugin types to validate that the generic approach is really generic, and what
it takes to add a new type of plugin.
dsmiley commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1441805546
##
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##
@@ -165,6 +166,9 @@ public static NodeConfig fromConfig(
if (cloudConfig != null) configBuilder.setC
dsmiley commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1441792277
##
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##
@@ -165,6 +166,9 @@ public static NodeConfig fromConfig(
if (cloudConfig != null) configBuilder.setC
janhoy commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1441659284
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -929,8 +941,8 @@ public NodeConfig build() {
metricsConfig,
cachesConfig,
pvcnt commented on PR #2126:
URL: https://github.com/apache/solr/pull/2126#issuecomment-1876907601
I believe it would still be interesting to have at least two different
plugin types to validate that the generic approach is really generic, and what
it takes to add a new type of plugin.
dsmiley commented on PR #2126:
URL: https://github.com/apache/solr/pull/2126#issuecomment-1876136104
Agreed that 9.5 should not be released without reconciling the two
approaches.
I think I would prefer to revert SOLR-17079 as it exists today, then merge
this PR SOLR-17096 (after wha
pvcnt commented on PR #2126:
URL: https://github.com/apache/solr/pull/2126#issuecomment-1875808589
I don't know when Solr 9.5 is going to be released, but IMHO we should make
sure that it is not released with two different ways of configuring a cluster
plugin in solr.xml, or even not releas
pjmcarthur commented on PR #2126:
URL: https://github.com/apache/solr/pull/2126#issuecomment-1875774998
@pvcnt @dsmiley I think there should be a follow-up PR that addresses the
replica placement plugin. My understanding is that from a user's perspective,
the configuration of solr.xml wrt.
pvcnt commented on PR #2126:
URL: https://github.com/apache/solr/pull/2126#issuecomment-1868557774
@dsmiley I’ll have a more detailed look after my holidays. But one thing we
should consider is that this PR follows a different design than what I did for
replica placement plugins. For the la
dsmiley commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1435316310
##
solr/core/src/java/org/apache/solr/api/ClusterPluginsSourceConfigurator.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
dsmiley commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1424771268
##
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##
@@ -654,11 +655,28 @@ private static PluginInfo[]
getClusterSingletonPluginInfos(List node
if (node
dsmiley commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1424764915
##
solr/core/src/test-files/solr/solr-50-all.xml:
##
@@ -76,4 +76,9 @@
+
+
+
+
Review Comment:
Enforcement would be ideal but not essential.
--
T
pjmcarthur commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1424690508
##
solr/core/src/test-files/solr/solr-50-all.xml:
##
@@ -76,4 +76,9 @@
+
+
+
+
Review Comment:
I changed the element name here to `clusterSingleto
dsmiley commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1423212973
##
solr/core/src/test/org/apache/solr/api/NodeConfigContainerPluginsSourceTest.java:
##
@@ -0,0 +1,287 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
pjmcarthur commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1423015389
##
solr/core/src/test/org/apache/solr/api/NodeConfigContainerPluginsSourceTest.java:
##
@@ -0,0 +1,287 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
dsmiley commented on PR #2126:
URL: https://github.com/apache/solr/pull/2126#issuecomment-1848042217
Oh I totally missed an important concern that I raised with @pvcnt 's
previous PR #2016. The configuration is very generic (the specific plugins are
effectively untyped in solr.xml). I too
dsmiley commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1420976112
##
solr/core/src/java/org/apache/solr/api/ZkContainerPluginsSource.java:
##
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
pjmcarthur opened a new pull request, #2126:
URL: https://github.com/apache/solr/pull/2126
https://issues.apache.org/jira/browse/SOLR-17096
# Description
It should be possible to install and manage the configuration of a cluster
singleton plugin in an immutable deployment of SolrCl
31 matches
Mail list logo
