Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

dsmiley commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1778547978 ## solr/CHANGES.txt: ## @@ -109,8 +109,11 @@ New Features Improvements - +* SOLR-17158: Users for whom partial results are uninteresting may set p

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

gus-asf commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1778007524 ## solr/core/src/java/org/apache/solr/handler/component/ParallelHttpShardHandler.java: ## @@ -41,57 +39,78 @@ @NotThreadSafe public class ParallelHttpShardHandler extend

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

gus-asf commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1777950640 ## solr/CHANGES.txt: ## @@ -109,8 +109,11 @@ New Features Improvements - +* SOLR-17158: Users for whom partial results are uninteresting may set p

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

dsmiley commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1776344004 ## solr/CHANGES.txt: ## @@ -109,8 +109,11 @@ New Features Improvements - +* SOLR-17158: Users for whom partial results are uninteresting may set p

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

gus-asf commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1777385925 ## solr/core/src/java/org/apache/solr/handler/component/ParallelHttpShardHandler.java: ## @@ -41,57 +39,78 @@ @NotThreadSafe public class ParallelHttpShardHandler extend

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

gerlowskija commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1777144114 ## solr/core/src/java/org/apache/solr/handler/component/ParallelHttpShardHandler.java: ## @@ -41,57 +39,78 @@ @NotThreadSafe public class ParallelHttpShardHandler ex

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

gerlowskija commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1777144114 ## solr/core/src/java/org/apache/solr/handler/component/ParallelHttpShardHandler.java: ## @@ -41,57 +39,78 @@ @NotThreadSafe public class ParallelHttpShardHandler ex

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

gerlowskija commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1777144114 ## solr/core/src/java/org/apache/solr/handler/component/ParallelHttpShardHandler.java: ## @@ -41,57 +39,78 @@ @NotThreadSafe public class ParallelHttpShardHandler ex

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

janhoy commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1776447879 ## solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java: ## @@ -80,6 +94,39 @@ public HttpShardHandler(HttpShardHandlerFactory httpShardHandlerFactor

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

janhoy commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1776427386 ## solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java: ## @@ -80,6 +94,39 @@ public HttpShardHandler(HttpShardHandlerFactory httpShardHandlerFactor

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

gus-asf commented on PR #2666: URL: https://github.com/apache/solr/pull/2666#issuecomment-2375174745 This is now feeling complete, I'll be looking to commit it tomorrow afternoon or perhaps Friday morning to main if nobody objects or requests more time to review. I've had to back of

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

gus-asf commented on PR #2666: URL: https://github.com/apache/solr/pull/2666#issuecomment-2374545882 Also, I've decided to presume that the failure to call transform in the ParallelHttpShardHandler was an oversight. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

gus-asf commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1775211297 ## solr/core/src/java/org/apache/solr/handler/component/ParallelHttpShardHandler.java: ## @@ -45,53 +48,84 @@ public class ParallelHttpShardHandler extends HttpShardHandl

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

sigram commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1774987714 ## solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc: ## @@ -324,9 +324,20 @@ The default value of this parameter is blank, which causes no extra

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

gus-asf commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1773633493 ## solr/CHANGES.txt: ## @@ -109,8 +109,11 @@ New Features Improvements - +* SOLR-17158: Users for whom partial results are uninteresting may set p

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

gus-asf commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1773584764 ## solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java: ## @@ -80,6 +94,39 @@ public HttpShardHandler(HttpShardHandlerFactory httpShardHandlerFacto

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

dsmiley commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1741228085 ## solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java: ## @@ -80,6 +94,39 @@ public HttpShardHandler(HttpShardHandlerFactory httpShardHandlerFacto

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

fsparv commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1737216013 ## solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java: ## @@ -80,6 +94,39 @@ public HttpShardHandler(HttpShardHandlerFactory httpShardHandlerFactor

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

dsmiley commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1736962583 ## solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java: ## @@ -42,13 +45,17 @@ import org.apache.solr.common.params.ShardParams; import org.apache

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

gus-asf commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1736250661 ## solr/core/src/java/org/apache/solr/response/SolrQueryResponse.java: ## @@ -139,30 +142,63 @@ public ReturnFields getReturnFields() { /** * If {@link #getRespon

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

sigram commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1732394489 ## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc: ## @@ -71,6 +71,13 @@ Due to changes in Lucene 9, that isn't possible any more. === Config

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

sigram commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1732394489 ## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc: ## @@ -71,6 +71,13 @@ Due to changes in Lucene 9, that isn't possible any more. === Config

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

gus-asf commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1731444666 ## solr/core/src/java/org/apache/solr/response/SolrQueryResponse.java: ## @@ -139,30 +142,63 @@ public ReturnFields getReturnFields() { /** * If {@link #getRespon

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

gus-asf commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1731443097 ## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc: ## @@ -71,6 +71,13 @@ Due to changes in Lucene 9, that isn't possible any more. === Confi

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

gus-asf commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1731441978 ## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc: ## @@ -71,6 +71,13 @@ Due to changes in Lucene 9, that isn't possible any more. === Confi

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

fsparv commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1731437654 ## solr/core/src/java/org/apache/solr/response/SolrQueryResponse.java: ## @@ -61,7 +64,7 @@ */ public class SolrQueryResponse { public static final String NAME = "res

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

sigram commented on code in PR #2666: URL: https://github.com/apache/solr/pull/2666#discussion_r1731349309 ## solr/CHANGES.txt: ## @@ -109,8 +109,11 @@ New Features Improvements - +* SOLR-17158: Users for whom partial results are uninteresting may set pa

Re: [PR] SOLR-17158 Terminate distributed processing quickly when query limit is reached [solr]

gus-asf commented on PR #2666: URL: https://github.com/apache/solr/pull/2666#issuecomment-2310297839 looking back at https://github.com/apache/solr/pull/2493 I'm exploring if there are ways to also shorten the case where partial results are desired, but possibly due to super short CpuTimeAl