Re: [PR] SOLR-17367 Unbreak the build caused by bad backport [solr]

2024-07-22 Thread via GitHub
janhoy commented on PR #2574: URL: https://github.com/apache/solr/pull/2574#issuecomment-2243991347 Yep, the script deals with most trivial back-ports. A separate 9x PR (like this) is safest route for non-trivial backports. -- This is an automated message from the Apache Git Service. To r

Re: [PR] SOLR-17367 Unbreak the build caused by bad backport [solr]

2024-07-21 Thread via GitHub
dsmiley commented on PR #2574: URL: https://github.com/apache/solr/pull/2574#issuecomment-2241837644 Non-compile is very preventable. FWIW I've increasingly been a fan of our `dev-tools/scripts/cherrypick.sh` which would not have let this happen. Please try it @epugh -- This is an aut

Re: [PR] SOLR-17367 Unbreak the build caused by bad backport [solr]

2024-07-19 Thread via GitHub
epugh commented on PR #2574: URL: https://github.com/apache/solr/pull/2574#issuecomment-2239243194 Thanks for sorting this out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] SOLR-17367 Unbreak the build caused by bad backport [solr]

2024-07-19 Thread via GitHub
janhoy merged PR #2574: URL: https://github.com/apache/solr/pull/2574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org