magibney commented on PR #2591:
URL: https://github.com/apache/solr/pull/2591#issuecomment-2371725359
> Have you deployed it / ran it for a while to see if it behaves sensibly?
Quick status update -- have _not_ yet deployed it locally. This is still
definitely on the radar though, so
github-actions[bot] commented on PR #2591:
URL: https://github.com/apache/solr/pull/2591#issuecomment-2369805690
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity or converting it to draft will remove the stale label. To attract
more reviewers, please t
magibney commented on code in PR #2591:
URL: https://github.com/apache/solr/pull/2591#discussion_r1691461924
##
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java:
##
@@ -246,20 +250,24 @@ public void handleRequest(SolrQueryRequest req,
SolrQueryResponse rsp) {
magibney commented on code in PR #2591:
URL: https://github.com/apache/solr/pull/2591#discussion_r1691465927
##
solr/core/src/java/org/apache/solr/metrics/MaxHistogram.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
magibney commented on code in PR #2591:
URL: https://github.com/apache/solr/pull/2591#discussion_r1691506265
##
solr/core/src/java/org/apache/solr/metrics/MaxHistogram.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
magibney commented on code in PR #2591:
URL: https://github.com/apache/solr/pull/2591#discussion_r1691502929
##
solr/core/src/java/org/apache/solr/metrics/MetricSuppliers.java:
##
@@ -154,17 +155,25 @@ public static Clock getClock(PluginInfo info, String
param) {
private sta
magibney commented on code in PR #2591:
URL: https://github.com/apache/solr/pull/2591#discussion_r1691465927
##
solr/core/src/java/org/apache/solr/metrics/MaxHistogram.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
magibney commented on code in PR #2591:
URL: https://github.com/apache/solr/pull/2591#discussion_r1691464517
##
solr/core/src/java/org/apache/solr/metrics/MaxHistogram.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
magibney commented on code in PR #2591:
URL: https://github.com/apache/solr/pull/2591#discussion_r1691461924
##
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java:
##
@@ -246,20 +250,24 @@ public void handleRequest(SolrQueryRequest req,
SolrQueryResponse rsp) {
dsmiley commented on code in PR #2591:
URL: https://github.com/apache/solr/pull/2591#discussion_r1690411012
##
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java:
##
@@ -246,20 +250,24 @@ public void handleRequest(SolrQueryRequest req,
SolrQueryResponse rsp) {
magibney commented on PR #2591:
URL: https://github.com/apache/solr/pull/2591#issuecomment-2248437989
The core code should be ready for review, but the test coverage is not at
all adequate yet.
There is a test stubbed out, but it's sloppy/too long, and basically exists
only to exerci
magibney opened a new pull request, #2591:
URL: https://github.com/apache/solr/pull/2591
https://issues.apache.org/jira/browse/SOLR-17378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
12 matches
Mail list logo
