iamsanjay commented on PR #2599:
URL: https://github.com/apache/solr/pull/2599#issuecomment-2307201061
git bisect points to this commit!
```
ERROR: The following test(s) have failed:
-
org.apache.solr.client.solrj.impl.ClusterStateProviderTest.testGetClusterState
(:solr:solrj)
dsmiley merged PR #2599:
URL: https://github.com/apache/solr/pull/2599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on PR #2599:
URL: https://github.com/apache/solr/pull/2599#issuecomment-2278047653
+1 Excellent; I'll merge soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1711540601
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -109,7 +109,7 @@ public void getClusterStatus(NamedList results)
boolean withClus
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1711490702
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -109,7 +109,7 @@ public void getClusterStatus(NamedList results)
boolean withClus
dsmiley commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1710003710
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -109,7 +109,7 @@ public void getClusterStatus(NamedList results)
boolean withClusterProp
aparnasuresh85 commented on PR #2599:
URL: https://github.com/apache/solr/pull/2599#issuecomment-2274460985
> Nice! Nearly ready to commit IMO; needs a CHANGES.txt (which I could add
if needed).
Done.
--
This is an automated message from the Apache Git Service.
To respond to the me
dsmiley commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1707539294
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -116,9 +118,19 @@ public void getClusterStatus(NamedList results)
// add live_nodes
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1707163750
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -116,9 +118,19 @@ public void getClusterStatus(NamedList results)
// add live_n
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1707163750
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -116,9 +118,19 @@ public void getClusterStatus(NamedList results)
// add live_n
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1707163750
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -116,9 +118,19 @@ public void getClusterStatus(NamedList results)
// add live_n
dsmiley commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1707112138
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -116,9 +118,19 @@ public void getClusterStatus(NamedList results)
// add live_nodes
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1707086097
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -191,43 +234,23 @@ public void getClusterStatus(NamedList results)
}
Str
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1707084935
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -100,7 +100,13 @@ public class CloudHttp2SolrClientTest extends
SolrC
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1707084246
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -291,7 +297,7 @@ public void testHttpCspPerf() throws Exception {
dsmiley commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1706383802
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -291,7 +297,7 @@ public void testHttpCspPerf() throws Exception {
// l
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1706190275
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -89,14 +93,61 @@ public static Health combine(Collection states) {
}
}
- pu
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1706167903
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -191,43 +234,23 @@ public void getClusterStatus(NamedList results)
}
Str
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1706145292
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -89,14 +93,61 @@ public static Health combine(Collection states) {
}
}
- pu
dsmiley commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1706026056
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -89,14 +93,61 @@ public static Health combine(Collection states) {
}
}
- public Cl
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1705971067
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -84,6 +84,11 @@ public void init(List solrUrls) throws Exception {
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1705971067
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -84,6 +84,11 @@ public void init(List solrUrls) throws Exception {
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1705968724
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -100,7 +100,13 @@ public class CloudHttp2SolrClientTest extends
SolrC
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1705968302
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -291,7 +297,7 @@ public void testHttpCspPerf() throws Exception {
dsmiley commented on PR #2599:
URL: https://github.com/apache/solr/pull/2599#issuecomment-2271538712
@gerlowskija in V2, I'm thinking these are separate endpoints
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1705602496
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -89,14 +93,61 @@ public static Health combine(Collection states) {
}
}
- pu
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1705602142
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -89,14 +93,61 @@ public static Health combine(Collection states) {
}
}
- pu
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1705600615
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -89,14 +93,61 @@ public static Health combine(Collection states) {
}
}
- pu
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1705599886
##
solr/solr-ref-guide/modules/deployment-guide/pages/cluster-node-management.adoc:
##
@@ -99,6 +99,41 @@ Multiple shard names can be specified as a comma-separated
dsmiley commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1704691188
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -89,14 +93,61 @@ public static Health combine(Collection states) {
}
}
- public Cl
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1704679908
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -147,6 +191,7 @@ public void getClusterStatus(NamedList results)
NamedList coll
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1704679669
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -191,43 +236,23 @@ public void getClusterStatus(NamedList results)
}
Str
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1704679560
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -89,14 +93,61 @@ public static Health combine(Collection states) {
}
}
- pu
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1704679393
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ClusterStateProvider.java:
##
@@ -108,8 +112,7 @@ default DocCollection getCollection(String name) throws
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1704678588
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -413,4 +412,11 @@ public String getQuorumHosts() {
}
ret
aparnasuresh85 commented on PR #2599:
URL: https://github.com/apache/solr/pull/2599#issuecomment-2270007674
> Can you please update the ref guide, `cluster-node-management.adoc`, as
well?
Done, let me know if it needs more changes
--
This is an automated message from the Apache Git
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1704678248
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -96,39 +96,43 @@ public static Health combine(Collection states) {
public ClusterSt
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1704677556
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -88,6 +88,9 @@ public class ZkStateReader implements SolrCloseable {
publ
dsmiley commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1704656293
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -89,14 +93,61 @@ public static Health combine(Collection states) {
}
}
- public Cl
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1704648811
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -89,14 +93,61 @@ public static Health combine(Collection states) {
}
}
- pu
dsmiley commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1704589925
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -89,14 +93,61 @@ public static Health combine(Collection states) {
}
}
- public Cl
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1704512149
##
solr/core/src/java/org/apache/solr/handler/admin/ClusterStatus.java:
##
@@ -96,39 +96,43 @@ public static Health combine(Collection states) {
public ClusterSt
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1704511439
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -413,4 +412,11 @@ public String getQuorumHosts() {
}
ret
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1704511273
##
solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java:
##
@@ -976,7 +980,17 @@ public Map execute(
CLUSTERSTATUS,
(req, rsp,
dsmiley commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1702298437
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -413,4 +412,11 @@ public String getQuorumHosts() {
}
return Str
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1702289833
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -88,6 +88,9 @@ public class ZkStateReader implements SolrCloseable {
publ
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1702289620
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ClusterStateProvider.java:
##
@@ -107,9 +111,15 @@ default DocCollection getCollection(String name) throws
aparnasuresh85 commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1702289433
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##
@@ -228,12 +249,9 @@ > getCacheTimeout()) {
}
@SuppressWarnin
dsmiley commented on code in PR #2599:
URL: https://github.com/apache/solr/pull/2599#discussion_r1695854596
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ClusterStateProvider.java:
##
@@ -107,9 +111,15 @@ default DocCollection getCollection(String name) throws
IOExce
49 matches
Mail list logo
