cpoerschke commented on PR #2607:
URL: https://github.com/apache/solr/pull/2607#issuecomment-2277500262
> Pushed 2
[changes](https://github.com/apache/solr/pull/2607/commits/aeadce89abe1f8c8239224161306a0c10055b559):
>
> 1. Integrated [cpoerschke](https://github.com/cpoerschke)'s sugg
cpoerschke merged PR #2607:
URL: https://github.com/apache/solr/pull/2607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache
patsonluk commented on PR #2607:
URL: https://github.com/apache/solr/pull/2607#issuecomment-2276570553
Pushed 2
[changes](https://github.com/apache/solr/pull/2607/commits/aeadce89abe1f8c8239224161306a0c10055b559):
1. Integrated [cpoerschke](https://github.com/cpoerschke)'s suggested
chan
patsonluk commented on PR #2607:
URL: https://github.com/apache/solr/pull/2607#issuecomment-2276546631
Sorry guys. I must have missed the notifications! Lemme summarize all the
changes and make one final commit !
--
This is an automated message from the Apache Git Service.
To respond to t
dsmiley commented on PR #2607:
URL: https://github.com/apache/solr/pull/2607#issuecomment-2276526792
AFAICT, the only remaining step is to _remove_ the CHANGES.txt entry,
possibly update the existing one to include contributors. I could do this or
@cpoerschke .
I'd love to see this bug
cpoerschke commented on code in PR #2607:
URL: https://github.com/apache/solr/pull/2607#discussion_r1703764178
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2056,7 +2056,7 @@ public void reload(String name, UUID coreId) {
newCore = core.reload(co
dsmiley commented on code in PR #2607:
URL: https://github.com/apache/solr/pull/2607#discussion_r1701823507
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2056,7 +2056,7 @@ public void reload(String name, UUID coreId) {
newCore = core.reload(coreC
ellaeln commented on PR #2607:
URL: https://github.com/apache/solr/pull/2607#issuecomment-2265114996
I tested things again and everything looks OK. Is there anything else that
needs to get done before we can move this forward?
--
This is an automated message from the Apache Git Service.
T
dsmiley commented on PR #2607:
URL: https://github.com/apache/solr/pull/2607#issuecomment-2264573626
AFAIUI, This is a bug fix to a regression within 9.7, specifically to
SOLR-17269. No released version has this bug. Therefore I don't think we need
to list this in the bug fix section or p
patsonluk commented on PR #2607:
URL: https://github.com/apache/solr/pull/2607#issuecomment-2263450355
> Planning ahead to PR merge time -- `solr/CHANGES.txt` -- @patsonluk please
could you add an entry in the Solr 9.7 bug fix section, e.g. something like
this?
>
> ```
> SOLR-1738
patsonluk commented on code in PR #2607:
URL: https://github.com/apache/solr/pull/2607#discussion_r1700444070
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2056,7 +2056,7 @@ public void reload(String name, UUID coreId) {
newCore = core.reload(cor
cpoerschke commented on PR #2607:
URL: https://github.com/apache/solr/pull/2607#issuecomment-2262799967
> ... entry in the Solr 9.7 bug fix section ...
Solr 9.7 release dev list thread:
https://lists.apache.org/thread/trhhb1q84gjzz9z9jx931m2p7v3q6wdn
--
This is an automated message
ellaeln commented on PR #2607:
URL: https://github.com/apache/solr/pull/2607#issuecomment-2262794835
ellaeln is good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
cpoerschke commented on PR #2607:
URL: https://github.com/apache/solr/pull/2607#issuecomment-2262786338
Planning ahead to PR merge time -- `solr/CHANGES.txt` -- @patsonluk please
could you add an entry in the Solr 9.7 bug fix section, e.g. something like
this?
```
SOLR-17386: Fix
cpoerschke commented on code in PR #2607:
URL: https://github.com/apache/solr/pull/2607#discussion_r1699960636
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2056,7 +2056,7 @@ public void reload(String name, UUID coreId) {
newCore = core.reload(co
dsmiley commented on code in PR #2607:
URL: https://github.com/apache/solr/pull/2607#discussion_r1699239949
##
solr/core/src/java/org/apache/solr/core/SolrCore.java:
##
@@ -805,6 +792,24 @@ public SolrCore reload(ConfigSet coreConfig) throws
IOException {
}
}
+ /**
+
patsonluk commented on code in PR #2607:
URL: https://github.com/apache/solr/pull/2607#discussion_r1699048655
##
solr/core/src/java/org/apache/solr/core/SyntheticSolrCore.java:
##
@@ -72,4 +88,43 @@ protected RestManager initRestManager() throws SolrException
{
// We do no
patsonluk commented on PR #2607:
URL: https://github.com/apache/solr/pull/2607#issuecomment-2261198296
> new SyntheticSolrCore(
> +coreContainer, coreDescriptor, configSet, dataDir, updateHandler,
delPolicy, prev, reload);
That's a brilliant suggestion! ✨
I will pus
patsonluk commented on code in PR #2607:
URL: https://github.com/apache/solr/pull/2607#discussion_r1698878150
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2056,7 +2056,7 @@ public void reload(String name, UUID coreId) {
newCore = core.reload(cor
patsonluk commented on code in PR #2607:
URL: https://github.com/apache/solr/pull/2607#discussion_r1698868734
##
solr/core/src/java/org/apache/solr/core/SyntheticSolrCore.java:
##
@@ -72,4 +88,43 @@ protected RestManager initRestManager() throws SolrException
{
// We do no
ellaeln commented on code in PR #2607:
URL: https://github.com/apache/solr/pull/2607#discussion_r1698263165
##
solr/core/src/java/org/apache/solr/core/SyntheticSolrCore.java:
##
@@ -72,4 +88,43 @@ protected RestManager initRestManager() throws SolrException
{
// We do not
cpoerschke commented on PR #2607:
URL: https://github.com/apache/solr/pull/2607#issuecomment-2260007256
> At least the change in CoreContainer & SolrCore here are about as trivial
as can be. The complexity is in SyntheticSolrCore.reload().
It seems (from a quick exploration) that fact
cpoerschke commented on code in PR #2607:
URL: https://github.com/apache/solr/pull/2607#discussion_r1698101054
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -2056,7 +2056,7 @@ public void reload(String name, UUID coreId) {
newCore = core.reload(co
ellaeln commented on PR #2607:
URL: https://github.com/apache/solr/pull/2607#issuecomment-2259919632
thanks for this fix, it's very important for us. I'll play with it a bit to
see if there's any potential issue i can spot
--
This is an automated message from the Apache Git Service.
To re
patsonluk opened a new pull request, #2607:
URL: https://github.com/apache/solr/pull/2607
https://issues.apache.org/jira/browse/SOLR-17386
# Description
It was reported that calling /admin/cores?action=RELOAD&core= gives 500
# Cause
This is caused by the change introduced
25 matches
Mail list logo
