Re: [PR] SOLR-17397: Fix SkipExistingDocumentsProcessor to handle child docume… [solr]

epugh merged PR #2631: URL: https://github.com/apache/solr/pull/2631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17397: Fix SkipExistingDocumentsProcessor to handle child docume… [solr]

epugh commented on code in PR #2631: URL: https://github.com/apache/solr/pull/2631#discussion_r1715031554 ## solr/core/src/java/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactory.java: ## @@ -224,6 +224,17 @@ boolean doesDocumentExist(BytesRef indexedDocId) t

Re: [PR] SOLR-17397: Fix SkipExistingDocumentsProcessor to handle child docume… [solr]

timatbw commented on PR #2631: URL: https://github.com/apache/solr/pull/2631#issuecomment-2283973184 Thanks for the reviews. I have pushed a 2nd commit with changes: using `cmd.getPrintableId`, improving test names, adding comments to help read the nested-if. I tried commenting out the `ret

Re: [PR] SOLR-17397: Fix SkipExistingDocumentsProcessor to handle child docume… [solr]

epugh commented on PR #2631: URL: https://github.com/apache/solr/pull/2631#issuecomment-2281278299 Thanks @dsmiley for reviewing. @timatbw if you can go through the various comments, then I think we are good to go to get merged this upcoming week! -- This is an automated message from t

Re: [PR] SOLR-17397: Fix SkipExistingDocumentsProcessor to handle child docume… [solr]

dsmiley commented on code in PR #2631: URL: https://github.com/apache/solr/pull/2631#discussion_r1712555039 ## solr/core/src/java/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactory.java: ## @@ -264,11 +268,23 @@ public void processAdd(AddUpdateCommand cmd) th

Re: [PR] SOLR-17397: Fix SkipExistingDocumentsProcessor to handle child docume… [solr]

dsmiley commented on code in PR #2631: URL: https://github.com/apache/solr/pull/2631#discussion_r1712549704 ## solr/core/src/java/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactory.java: ## @@ -224,6 +224,17 @@ boolean doesDocumentExist(BytesRef indexedDocId)

Re: [PR] SOLR-17397: Fix SkipExistingDocumentsProcessor to handle child docume… [solr]

epugh commented on code in PR #2631: URL: https://github.com/apache/solr/pull/2631#discussion_r1711377616 ## solr/core/src/test/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactoryTest.java: ## @@ -314,6 +314,22 @@ public void testSkippableUpdateIsSkippedIfSki

Re: [PR] SOLR-17397: Fix SkipExistingDocumentsProcessor to handle child docume… [solr]

epugh commented on code in PR #2631: URL: https://github.com/apache/solr/pull/2631#discussion_r1711374955 ## solr/core/src/java/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactory.java: ## @@ -224,6 +224,17 @@ boolean doesDocumentExist(BytesRef indexedDocId) t

Re: [PR] SOLR-17397: Fix SkipExistingDocumentsProcessor to handle child docume… [solr]

timatbw commented on code in PR #2631: URL: https://github.com/apache/solr/pull/2631#discussion_r1711372740 ## solr/core/src/test/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactoryTest.java: ## @@ -314,6 +314,22 @@ public void testSkippableUpdateIsSkippedIfS

Re: [PR] SOLR-17397: Fix SkipExistingDocumentsProcessor to handle child docume… [solr]

timatbw commented on code in PR #2631: URL: https://github.com/apache/solr/pull/2631#discussion_r1711363724 ## solr/core/src/java/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactory.java: ## @@ -224,6 +224,17 @@ boolean doesDocumentExist(BytesRef indexedDocId)

Re: [PR] SOLR-17397: Fix SkipExistingDocumentsProcessor to handle child docume… [solr]

epugh commented on code in PR #2631: URL: https://github.com/apache/solr/pull/2631#discussion_r1711353839 ## solr/core/src/test/org/apache/solr/update/processor/SkipExistingDocumentsProcessorFactoryTest.java: ## @@ -314,6 +314,22 @@ public void testSkippableUpdateIsSkippedIfSki

[PR] SOLR-17397: Fix SkipExistingDocumentsProcessor to handle child docume… [solr]

timatbw opened a new pull request, #2631: URL: https://github.com/apache/solr/pull/2631 …nts too https://issues.apache.org/jira/browse/SOLR-17397 # Description Fix SkipExistingDocumentsProcessor to handle child documents too # Solution Now we det