iamsanjay commented on PR #2633:
URL: https://github.com/apache/solr/pull/2633#issuecomment-2307216717
Backported to 9.x!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
iamsanjay commented on PR #2633:
URL: https://github.com/apache/solr/pull/2633#issuecomment-2307199250
git bisect points to 7af8b82db2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
iamsanjay commented on PR #2633:
URL: https://github.com/apache/solr/pull/2633#issuecomment-2307158372
I was preparing it for backporting and before merge it to 9.x, ran the check
on crave. One test case failed!
```
ERROR: The following test(s) have failed:
-
org.apache.solr.
iamsanjay merged PR #2633:
URL: https://github.com/apache/solr/pull/2633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
iamsanjay commented on PR #2633:
URL: https://github.com/apache/solr/pull/2633#issuecomment-2303625744
If everything looks fine, then going to merge it soon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
iamsanjay commented on code in PR #2633:
URL: https://github.com/apache/solr/pull/2633#discussion_r1712666166
##
solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java:
##
@@ -395,12 +395,12 @@ protected Locale parseLocale(String language, String
country, Stri
epugh commented on code in PR #2633:
URL: https://github.com/apache/solr/pull/2633#discussion_r1712657394
##
solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java:
##
@@ -395,12 +395,12 @@ protected Locale parseLocale(String language, String
country, String v
iamsanjay opened a new pull request, #2633:
URL: https://github.com/apache/solr/pull/2633
[SOLR-17399](https://issues.apache.org/jira/browse/SOLR-17399)
Replace the usage of Locale constructors with the Locale.Builder API, as we
are upgrading to Java 21 where Locale constructors a
