dsmiley commented on PR #2706:
URL: https://github.com/apache/solr/pull/2706#issuecomment-2380893395
I checked out this branch and did `gw assemble` then renamed
`solr/packaging/build/solr-10.0.0-SNAPSHOT/` to have an "-after" suffix. Then
I checked out a recent main (before cross-DC addit
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775253658
##
help/dependencies.txt:
##
@@ -29,60 +29,126 @@ testImplementation - makes a dependency only available for
test classes.
Adding a library dependency
dweiss commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775243765
##
gradle/libs.versions.toml:
##
@@ -0,0 +1,432 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775243589
##
gradle/libs.versions.toml:
##
@@ -0,0 +1,432 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NO
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775234820
##
build.gradle:
##
@@ -139,7 +143,7 @@ apply from: file('gradle/maven/defaults-maven.gradle')
// IDE support, settings and specials.
apply from: file('gradle/ide/
janhoy commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775192261
##
gradle/libs.versions.toml:
##
@@ -0,0 +1,432 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE
dweiss commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775139816
##
help/dependencies.txt:
##
@@ -29,60 +29,126 @@ testImplementation - makes a dependency only available for
test classes.
Adding a library dependency
-
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775109063
##
build.gradle:
##
@@ -139,7 +143,7 @@ apply from: file('gradle/maven/defaults-maven.gradle')
// IDE support, settings and specials.
apply from: file('gradle/ide/
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775107083
##
help/dependencies.txt:
##
@@ -29,60 +29,126 @@ testImplementation - makes a dependency only available for
test classes.
Adding a library dependency
dweiss commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775026121
##
gradle/libs.versions.toml:
##
@@ -0,0 +1,432 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE
dsmiley commented on PR #2706:
URL: https://github.com/apache/solr/pull/2706#issuecomment-2373053917
> spotless and tidy are added to run on build files too
Awesome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
dsmiley commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1774499355
##
build.gradle:
##
@@ -139,7 +143,7 @@ apply from: file('gradle/maven/defaults-maven.gradle')
// IDE support, settings and specials.
apply from: file('gradle/ide/inte
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1761060353
##
help/dependencies.txt:
##
@@ -29,60 +29,126 @@ testImplementation - makes a dependency only available for
test classes.
Adding a library dependency
janhoy commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1761009874
##
help/dependencies.txt:
##
@@ -29,60 +29,126 @@ testImplementation - makes a dependency only available for
test classes.
Adding a library dependency
-
malliaridis commented on PR #2646:
URL: https://github.com/apache/solr/pull/2646#issuecomment-2345913148
This PR is closed in favor to #2706, which does not include all the
dependency updates made here. They will be resolved in separate PRs.
--
This is an automated message from the Apache
malliaridis closed pull request #2646: SOLR-17406: Introduce Version Catalogs
URL: https://github.com/apache/solr/pull/2646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
malliaridis opened a new pull request, #2706:
URL: https://github.com/apache/solr/pull/2706
https://issues.apache.org/jira/browse/SOLR-17406
# Description
With the version catalogs all versions and references to them are managed in
a single file and updated from there.
#
malliaridis commented on PR #2646:
URL: https://github.com/apache/solr/pull/2646#issuecomment-2307147732
Yeah I agree. I already started the process of splitting the PR into two,
one for infra and one for the dependency updates. I am facing a few version
differences with non-conflicting dep
dweiss commented on PR #2646:
URL: https://github.com/apache/solr/pull/2646#issuecomment-2306992445
I would keep any upgrades from infrastructure changes separate. You can then
diff/ compare the final artifacts and see what's changed before doing any
updates.
--
This is an automated mess
malliaridis commented on PR #2646:
URL: https://github.com/apache/solr/pull/2646#issuecomment-2295068582
I think it was a mistake adding
[f402a0b](https://github.com/apache/solr/pull/2646/commits/f402a0b41ce37a7f6861f1d36d6a67ebbd77e3e6)
onwards in the same PR, even thought there were only
malliaridis commented on PR #2646:
URL: https://github.com/apache/solr/pull/2646#issuecomment-2288914963
@iamsanjay That would be great. We probably have to add the
[foojay-resolver-plugin](https://plugins.gradle.org/plugin/org.gradle.toolchains.foojay-resolver-convention)
too at some point
iamsanjay commented on PR #2646:
URL: https://github.com/apache/solr/pull/2646#issuecomment-2288860568
If this change is intended for Solr 10, it should be tested and developed
using Java 21 to ensure there are no hidden surprises. I have one PR that makes
Solr compatible with Java 21, but
malliaridis opened a new pull request, #2646:
URL: https://github.com/apache/solr/pull/2646
https://issues.apache.org/jira/browse/SOLR-17406
# Description
With Gradle it is possible to manage versions and dependencies in gradle
files via version catalogs. This allows us to clea
23 matches
Mail list logo
