dsmiley merged PR #2645:
URL: https://github.com/apache/solr/pull/2645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on PR #2645:
URL: https://github.com/apache/solr/pull/2645#issuecomment-2302035403
For 9.8, I'll add the following under Optimizations:
> SOLR-17408: COLSTATUS command was fetching details remotely from replicas
when this information wasn't asked for. (Mathieu Marie
dsmiley commented on code in PR #2645:
URL: https://github.com/apache/solr/pull/2645#discussion_r1724951708
##
solr/core/src/java/org/apache/solr/handler/admin/ColStatus.java:
##
@@ -176,48 +182,50 @@ public void getColStatus(NamedList results) {
if (url == null) {
mariemat commented on PR #2645:
URL: https://github.com/apache/solr/pull/2645#issuecomment-2301365614
The failed test is a flapper and is not related to my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
mariemat commented on code in PR #2645:
URL: https://github.com/apache/solr/pull/2645#discussion_r1724577931
##
solr/core/src/java/org/apache/solr/handler/admin/ColStatus.java:
##
@@ -176,48 +182,50 @@ public void getColStatus(NamedList results) {
if (url == null) {
dsmiley commented on code in PR #2645:
URL: https://github.com/apache/solr/pull/2645#discussion_r1717131530
##
solr/core/src/java/org/apache/solr/handler/admin/ColStatus.java:
##
@@ -176,48 +182,50 @@ public void getColStatus(NamedList results) {
if (url == null) {
mariemat commented on PR #2645:
URL: https://github.com/apache/solr/pull/2645#issuecomment-2288737426
> Does this change require a a new unit test? Or do the existing tests cover
this?
Previous unit tests cover it
> Seems like a reasonable optimization!
👍
--
This is an a
epugh commented on PR #2645:
URL: https://github.com/apache/solr/pull/2645#issuecomment-2288679297
One more thought that came to mind... I see this as a nice improvement to
the V1 api, but then I wondered, does this also cover V2 api. Did a slight bit
of digging, and based on this comment
epugh commented on code in PR #2645:
URL: https://github.com/apache/solr/pull/2645#discussion_r1716669278
##
solr/core/src/java/org/apache/solr/handler/admin/ColStatus.java:
##
@@ -93,8 +93,14 @@ public void getColStatus(NamedList results) {
if (withRawSizeSummary || withRa
mariemat opened a new pull request, #2645:
URL: https://github.com/apache/solr/pull/2645
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
P
10 matches
Mail list logo
