epugh merged PR #2721:
URL: https://github.com/apache/solr/pull/2721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
malliaridis commented on PR #2721:
URL: https://github.com/apache/solr/pull/2721#issuecomment-2380631255
> You still have to check for each it apepars!! If you find some code that
avoids that, let me know.
I see that you are using the `Option#getOpt()` and `Option#getLongOpt()`
when
epugh commented on PR #2721:
URL: https://github.com/apache/solr/pull/2721#issuecomment-2380625072
I was at the point of merging and the --debug syntax just bugged me. I am
backing it out and just keep --verbose which rings better for me, and still
accomplishs the goal of making -v no lon
epugh commented on code in PR #2721:
URL: https://github.com/apache/solr/pull/2721#discussion_r1779473538
##
solr/core/src/java/org/apache/solr/cli/AssertTool.java:
##
@@ -131,7 +131,9 @@ public List getOptions() {
@Override
public int runTool(CommandLine cli) throws Exc
epugh commented on PR #2721:
URL: https://github.com/apache/solr/pull/2721#issuecomment-2380613513
@malliaridis I was able to integrate OptionGroup for the --debug and
--verbose options in this PR and it works. What I haven't been able to grok
is how to simplify the checking for the flags
malliaridis commented on code in PR #2721:
URL: https://github.com/apache/solr/pull/2721#discussion_r1775057041
##
solr/bin/solr.cmd:
##
@@ -362,23 +362,21 @@ goto done
@echo.
@echo --no-prompt Don't prompt for input; accept all defaults when running
examples that accept
malliaridis commented on code in PR #2721:
URL: https://github.com/apache/solr/pull/2721#discussion_r1772832218
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -308,7 +326,8 @@ protected static void checkSslStoreSysProp(String
solrInstallDir, String key) {
}
epugh commented on code in PR #2721:
URL: https://github.com/apache/solr/pull/2721#discussion_r1774359308
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -137,6 +137,12 @@ public class SolrCLI implements CLIO {
public static final Option OPTION_SOLRURL =
malliaridis commented on PR #2721:
URL: https://github.com/apache/solr/pull/2721#issuecomment-2371449034
`-d` is one of the conflicting flags that we have to resolve anyway. I would
prefer only the long variant in that case, which may be either `debug` or
`verbose`, both are fine and when t
epugh commented on PR #2721:
URL: https://github.com/apache/solr/pull/2721#issuecomment-2371420084
> > I forgot to mention in the ticket that introducing `-d` for `debug` may
require further deprecations where `-d` is used for other options as well.
>
> I am wondering if we should jus
epugh commented on PR #2721:
URL: https://github.com/apache/solr/pull/2721#issuecomment-2371366107
> I forgot to mention in the ticket that introducing `-d` for `debug` may
require further deprecations where `-d` is used for other options as well.
I am wondering if we should just stic
epugh commented on code in PR #2721:
URL: https://github.com/apache/solr/pull/2721#discussion_r1773412097
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -148,9 +154,21 @@ public class SolrCLI implements CLIO {
public static final Option OPTION_VERBOSE =
Review
malliaridis commented on code in PR #2721:
URL: https://github.com/apache/solr/pull/2721#discussion_r1772845049
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -148,9 +154,21 @@ public class SolrCLI implements CLIO {
public static final Option OPTION_VERBOSE =
epugh opened a new pull request, #2721:
URL: https://github.com/apache/solr/pull/2721
https://issues.apache.org/jira/browse/SOLR-17442
# Description
Deprecating -v in favour of -d.
# Solution
Please provide a short description of the approach taken to implement
14 matches
Mail list logo
