dsmiley merged PR #2707:
URL: https://github.com/apache/solr/pull/2707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
AndreyBozhko commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1777433286
##
solr/core/src/java/org/apache/solr/handler/admin/PrepRecoveryOp.java:
##
@@ -191,11 +195,6 @@ public void execute(CallInfo it) throws Exception {
AndreyBozhko commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1777421635
##
solr/CHANGES.txt:
##
@@ -163,6 +163,8 @@ Other Changes
* SOLR-17142: Fix Gradle build sometimes gives spurious "unreferenced license
file" warnings. (Uwe Schin
AndreyBozhko commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1777421365
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##
@@ -1981,29 +1981,18 @@ protected void destroyServers() throws Exception
dsmiley commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1774359207
##
solr/CHANGES.txt:
##
@@ -163,6 +163,8 @@ Other Changes
* SOLR-17142: Fix Gradle build sometimes gives spurious "unreferenced license
file" warnings. (Uwe Schindler)
AndreyBozhko commented on PR #2707:
URL: https://github.com/apache/solr/pull/2707#issuecomment-2372354983
Hi @dsmiley, could you review this once you have time? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
AndreyBozhko commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1759847952
##
solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPI.java:
##
@@ -936,7 +936,7 @@ private void testNewSingleFileAfterSchemaAPI(boolean v2)
throws Exception
AndreyBozhko commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1759847806
##
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##
@@ -729,14 +729,16 @@ public void preClose() {
try {
synchronized (collectionToTerms)
dsmiley commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1758798912
##
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##
@@ -729,14 +729,16 @@ public void preClose() {
try {
synchronized (collectionToTerms) {
-
AndreyBozhko commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1755442168
##
solr/core/src/java/org/apache/solr/schema/ZkIndexSchemaReader.java:
##
@@ -145,6 +145,10 @@ public void process(WatchedEvent event) {
log.warn("ZooKeepe
AndreyBozhko commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1755401081
##
solr/core/src/test/org/apache/solr/pkg/TestPackages.java:
##
@@ -810,10 +813,18 @@ public void testSchemaPlugins() throws Exception {
":fieldType:_pac
AndreyBozhko commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1755401081
##
solr/core/src/test/org/apache/solr/pkg/TestPackages.java:
##
@@ -810,10 +813,18 @@ public void testSchemaPlugins() throws Exception {
":fieldType:_pac
AndreyBozhko commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1755326203
##
solr/core/src/java/org/apache/solr/cloud/ZkShardTerms.java:
##
@@ -421,6 +421,10 @@ private void registerWatcher() throws KeeperException {
return;
AndreyBozhko opened a new pull request, #2707:
URL: https://github.com/apache/solr/pull/2707
https://issues.apache.org/jira/browse/SOLR-17448
# Description
There are quite a few places in Solr codebase where the background task is
created by invoking `ExecutorService#submit(...
14 matches
Mail list logo
