epugh commented on PR #1961:
URL: https://github.com/apache/solr/pull/1961#issuecomment-1745849061
Thanks for this housekeeping!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
epugh merged PR #1961:
URL: https://github.com/apache/solr/pull/1961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
AndreyBozhko commented on code in PR #1961:
URL: https://github.com/apache/solr/pull/1961#discussion_r1344744097
##
solr/solr-ref-guide/modules/indexing-guide/pages/tokenizers.adoc:
##
@@ -772,11 +964,25 @@ The syntax is more limited than
`PatternTokenizerFactory`, but the toke
epugh commented on PR #1961:
URL: https://github.com/apache/solr/pull/1961#issuecomment-1745623646
@AndreyBozhko I added one last question about parameter name, and it looks
good. Nice sleuthing on the missing words ;-). Just check that one, and then
we are ready to merge.
--
This is
epugh commented on code in PR #1961:
URL: https://github.com/apache/solr/pull/1961#discussion_r1344649962
##
solr/solr-ref-guide/modules/indexing-guide/pages/tokenizers.adoc:
##
@@ -772,11 +964,25 @@ The syntax is more limited than
`PatternTokenizerFactory`, but the tokenizatio
AndreyBozhko commented on PR #1961:
URL: https://github.com/apache/solr/pull/1961#issuecomment-1743605262
@epugh This should be ready now for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t