Re: [PR] force the use jdk21 through Crave [solr]

2024-08-14 Thread via GitHub
dsmiley commented on PR #2498: URL: https://github.com/apache/solr/pull/2498#issuecomment-2289360382 @uvatbc thanks for offering to help further (edit our build) if you wish but I wouldn't want any feedback on these PRs to be implied that it is for you to update our build. You give us Crav

Re: [PR] force the use jdk21 through Crave [solr]

2024-08-09 Thread via GitHub
uvatbc commented on PR #2498: URL: https://github.com/apache/solr/pull/2498#issuecomment-2278924832 > If crave.yml change the Java version to 21, `gradlew check` should fail, more specifically the `ecj-lint` version that we are currently using make sure the Java version should be less than

Re: [PR] force the use jdk21 through Crave [solr]

2024-08-09 Thread via GitHub
github-actions[bot] commented on PR #2498: URL: https://github.com/apache/solr/pull/2498#issuecomment-2278892872 This PR has had no activity for 60 days and is now labeled as stale. Any new activity or converting it to draft will remove the stale label. To attract more reviewers, please t

Re: [PR] force the use jdk21 through Crave [solr]

2024-06-09 Thread via GitHub
iamsanjay commented on PR #2498: URL: https://github.com/apache/solr/pull/2498#issuecomment-2157150820 If crave.yml change the Java version to 21, `gradlew check` should fail, more specifically the `ecj-lint` version that we are currently using make sure the Java version should be less than

Re: [PR] force the use jdk21 through Crave [solr]

2024-06-06 Thread via GitHub
dsmiley commented on PR #2498: URL: https://github.com/apache/solr/pull/2498#issuecomment-2153002420 Before this change here, isn't there some existing build image for Solr you @uvatbc worked on ? @iamsanjay assuming the build starts running on JDK 21 (wherever -- CI / Crave / dev ma

Re: [PR] force the use jdk21 through Crave [solr]

2024-06-05 Thread via GitHub
iamsanjay commented on PR #2498: URL: https://github.com/apache/solr/pull/2498#issuecomment-2151167656 I tried running this for #2497 (https://foss.crave.io/app/#/build/info/109489?team=5) > BUILD SUCCESSFUL in 7m 25s > 141 actionable tasks: 114 executed, 27 up-to-date I won

[PR] force the use jdk21 through Crave [solr]

2024-06-05 Thread via GitHub
uvatbc opened a new pull request, #2498: URL: https://github.com/apache/solr/pull/2498 https://issues.apache.org/jira/browse/SOLR-X # Description The Solr project is considering the usage of JDK 21 at some point. We need to control which JDK is used in Crav