Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache9 closed pull request #7046: HBASE-28962 Meta replication is inconsistent after startup when reusi… URL: https://github.com/apache/hbase/pull/7046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache9 commented on PR #7046: URL: https://github.com/apache/hbase/pull/7046#issuecomment-2954450218 Any updates here? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
wchevreuil commented on PR #7046: URL: https://github.com/apache/hbase/pull/7046#issuecomment-2931270562 > Please do not merge this. > > Checked the code on branch-2.6, we also load the meta replica locations from master local region, not zookeeper. So the comment here is incorrect > > [#6448 (comment)](https://github.com/apache/hbase/pull/6448#issuecomment-2755002936) > > Please also revert the changes from existing branches, and let's review what is the root cause of this problem. > > Thanks. > > https://github.com/apache/hbase/blob/2f557ab02995fa54dba0acd85562eca18f3bc3de/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java#L316 @Apache9 is right, since HBASE-26193, present since 2.5.0, we don't rely on ZK for the region states anymore. @richardantal , have you still managed to reproduce this issue on a 2.5/2.6 based deployment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache9 commented on PR #7046: URL: https://github.com/apache/hbase/pull/7046#issuecomment-2930815933 > We run into this issue from time to time. When creating a cluster with storage location set to a storage location of an earlier cluster. Both clusters are set to use meta replication. Only the default replica gets assigned on the new cluster. > > Do you think this change could cause any problems? I agree that before identifying the root cause, you can apply some temporary approaches on your internal branches to 'fix' the problem. But on the open source branch, I think we should find the root cause and then applying the fix. As I've said above, please check whether we have the master local region related changes in your internal branch. And on the unit testing, please try delete everything on zookeeper to simulate your scenario. You can see HBASE-29292 and TestRecreateCluster on how to do this. If you can still produce the problem, we can check again whether we need the changes here. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
richardantal commented on PR #7046: URL: https://github.com/apache/hbase/pull/7046#issuecomment-2929225397 We run into this issue from time to time. When creating a cluster with storage location set to a storage location of an earlier cluster. Both clusters are set to use meta replication. Only the default replica gets assigned on the new cluster. Do you think this change could cause any problems? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache9 commented on PR #6448: URL: https://github.com/apache/hbase/pull/6448#issuecomment-2927262151 @wchevreuil Please check my above comment? I do not think we have found the root cause of this problem, so I prefer we revert the commit first, and re-apply it after we find out the root cause... Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache9 commented on PR #6448: URL: https://github.com/apache/hbase/pull/6448#issuecomment-2927256080 > > Which version were you guys on when you hit this problem? > > This issue is being observed on a 2.4.17 (with some extra backports), but I guess it could also affect higher versions. > > > I still do not get the point that why the regions could be in offline state... > > My reading is that the meta replicas never get assigned, because we never trigger the ModifyTableProcedure to change region replicas count in the meta table descriptor: > > 1. [We will enter the block here because replica count is 3 in the config](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1167) > 2. [This will return 1 because we are running this master for the first time and no meta replica node has been created yet in ZK](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1175) > 3. [This returns false because we are using a root dir of a previous existing cluster, where meta replica was enabled, so the meta descriptor is already 3] (https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1177) > 4. [This too returns false, and we never trigger the ModifyTableProcedure] (https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1185) > 5. Since we miss triggering the ModifyTableProcedure, we never manage to assign the meta replicas, which should occur [here](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java#L244) > > @Apache9 @richardantal does the above make sense? If so, I think the proposed fix should be improved, as it would update the metaDesc with 1 as replica count just to pass [this if check](https://github.com/apache/hbase/pull/6448/files#diff-0e55b368bd805325243956ccd037e06bf8954c2c2cb99b665a1dd4c88f26f97bR1177), create a new descriptor with replica count 3 and trigger the modify proc. > > We should rather just trigger the meta replicas assignment, when we see replica count in table desc is greater than existingReplicasCount. Ah I missed this one. At least on master and branch-3, there is no problem on step 2 because we store region replicas location for meta in master local region, not in zookeeper. So at least I do not think we need this on master and branch-3. Let me check whether branch-2.x also use master local region to store meta region locations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #7046:
URL: https://github.com/apache/hbase/pull/7046#issuecomment-2922360312
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 15s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.6 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 28s | | branch-2.6 passed |
| +1 :green_heart: | compile | 0m 42s | | branch-2.6 passed |
| +1 :green_heart: | javadoc | 0m 26s | | branch-2.6 passed |
| +1 :green_heart: | shadedjars | 5m 35s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 29s | | the patch passed |
| +1 :green_heart: | compile | 0m 41s | | the patch passed |
| +1 :green_heart: | javac | 0m 41s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 24s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 28s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 225m 24s | | hbase-server in the patch
passed. |
| | | 250m 14s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7046/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7046 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 67aebd5896f2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / 31d7b6bb18b30e3b286d8bbbf967dc8c8334e9cb |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7046/3/testReport/
|
| Max. process+thread count | 4189 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7046/3/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #7046:
URL: https://github.com/apache/hbase/pull/7046#issuecomment-2922348979
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 55s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 7s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.6 Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 39s | | branch-2.6 passed |
| +1 :green_heart: | compile | 1m 9s | | branch-2.6 passed |
| +1 :green_heart: | javadoc | 0m 31s | | branch-2.6 passed |
| +1 :green_heart: | shadedjars | 6m 36s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 19s | | the patch passed |
| +1 :green_heart: | compile | 1m 0s | | the patch passed |
| +1 :green_heart: | javac | 1m 0s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 28s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 36s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 215m 42s | | hbase-server in the patch
passed. |
| | | 245m 24s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7046/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7046 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 5f6e7c505f0b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / 31d7b6bb18b30e3b286d8bbbf967dc8c8334e9cb |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7046/3/testReport/
|
| Max. process+thread count | 4419 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7046/3/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #7046:
URL: https://github.com/apache/hbase/pull/7046#issuecomment-2922329624
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 46s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.6 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 20s | | branch-2.6 passed |
| +1 :green_heart: | compile | 0m 50s | | branch-2.6 passed |
| +1 :green_heart: | javadoc | 0m 26s | | branch-2.6 passed |
| +1 :green_heart: | shadedjars | 6m 36s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 11s | | the patch passed |
| +1 :green_heart: | compile | 0m 50s | | the patch passed |
| +1 :green_heart: | javac | 0m 50s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 26s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 36s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 209m 39s | | hbase-server in the patch
passed. |
| | | 236m 44s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7046/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7046 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux c4c6fcd6ce5b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / 31d7b6bb18b30e3b286d8bbbf967dc8c8334e9cb |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7046/3/testReport/
|
| Max. process+thread count | 4499 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7046/3/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #7046:
URL: https://github.com/apache/hbase/pull/7046#issuecomment-2921811359
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 53s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ branch-2.6 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 27s | | branch-2.6 passed |
| +1 :green_heart: | compile | 2m 58s | | branch-2.6 passed |
| +1 :green_heart: | checkstyle | 0m 38s | | branch-2.6 passed |
| +1 :green_heart: | spotbugs | 1m 38s | | branch-2.6 passed |
| +1 :green_heart: | spotless | 0m 49s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 6s | | the patch passed |
| +1 :green_heart: | compile | 2m 55s | | the patch passed |
| +1 :green_heart: | javac | 2m 55s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 37s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 43s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 17m 16s | | Patch does not cause any
errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 44s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 10s | | The patch does not
generate ASF License warnings. |
| | | 38m 59s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7046/3/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7046 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux aef2cab960dd 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / 31d7b6bb18b30e3b286d8bbbf967dc8c8334e9cb |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 78 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7046/3/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #7046:
URL: https://github.com/apache/hbase/pull/7046#issuecomment-2917684667
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 5m 22s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ branch-2.6 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 36s | | branch-2.6 passed |
| +1 :green_heart: | compile | 3m 3s | | branch-2.6 passed |
| +1 :green_heart: | checkstyle | 0m 38s | | branch-2.6 passed |
| +1 :green_heart: | spotbugs | 1m 36s | | branch-2.6 passed |
| +1 :green_heart: | spotless | 0m 47s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 10s | | the patch passed |
| +1 :green_heart: | compile | 2m 58s | | the patch passed |
| +1 :green_heart: | javac | 2m 58s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 37s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 42s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 17m 19s | | Patch does not cause any
errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| -1 :x: | spotless | 0m 37s | | patch has 24 errors when running
spotless:check, run spotless:apply to fix. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 10s | | The patch does not
generate ASF License warnings. |
| | | 46m 10s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7046/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7046 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux b894bdb24ec8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / 74ee25f2eb97a1b0bef13e8d8a4269a9fbf575fd |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| spotless |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7046/2/artifact/yetus-general-check/output/patch-spotless.txt
|
| Max. process+thread count | 78 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7046/2/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
[PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
richardantal opened a new pull request, #7046: URL: https://github.com/apache/hbase/pull/7046 …ng hbase storage location (#6448) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
wchevreuil merged PR #6448: URL: https://github.com/apache/hbase/pull/6448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #6448:
URL: https://github.com/apache/hbase/pull/6448#issuecomment-2903411423
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 32s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 26s | | master passed |
| +1 :green_heart: | compile | 0m 59s | | master passed |
| +1 :green_heart: | javadoc | 0m 28s | | master passed |
| +1 :green_heart: | shadedjars | 7m 21s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 31s | | the patch passed |
| +1 :green_heart: | compile | 1m 1s | | the patch passed |
| +1 :green_heart: | javac | 1m 1s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 31s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 22s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 369m 24s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/9/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 419m 29s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/9/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6448 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 0a99ff1827c7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / fe5075fe6fa3be77234493f135b8ec63451a038e |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/9/testReport/
|
| Max. process+thread count | 4844 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/9/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #6448:
URL: https://github.com/apache/hbase/pull/6448#issuecomment-2902918219
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 29s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 1s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 2s | | master passed |
| +1 :green_heart: | compile | 3m 8s | | master passed |
| +1 :green_heart: | checkstyle | 0m 36s | | master passed |
| +1 :green_heart: | spotbugs | 1m 31s | | master passed |
| +1 :green_heart: | spotless | 0m 44s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 3s | | the patch passed |
| +1 :green_heart: | compile | 3m 8s | | the patch passed |
| +1 :green_heart: | javac | 3m 8s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 38s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 40s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 11m 54s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 43s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 9s | | The patch does not
generate ASF License warnings. |
| | | 38m 23s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/9/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6448 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux db51524c0827 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / fe5075fe6fa3be77234493f135b8ec63451a038e |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 86 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/9/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #6448:
URL: https://github.com/apache/hbase/pull/6448#issuecomment-2901571373
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 13m 32s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 7s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 24m 44s | | master passed |
| +1 :green_heart: | compile | 1m 1s | | master passed |
| +1 :green_heart: | javadoc | 0m 54s | | master passed |
| +1 :green_heart: | shadedjars | 7m 27s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 37s | | the patch passed |
| +1 :green_heart: | compile | 1m 0s | | the patch passed |
| +1 :green_heart: | javac | 1m 0s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 30s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 30s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 349m 55s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/8/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 420m 10s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/8/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6448 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 19add11793f7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e4fa33ecbc82853d1442805f6f2dde12e2642f77 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/8/testReport/
|
| Max. process+thread count | 4641 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/8/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #6448:
URL: https://github.com/apache/hbase/pull/6448#issuecomment-2900395072
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 32s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 6s | | master passed |
| +1 :green_heart: | compile | 3m 22s | | master passed |
| +1 :green_heart: | checkstyle | 0m 48s | | master passed |
| +1 :green_heart: | spotbugs | 1m 51s | | master passed |
| +1 :green_heart: | spotless | 0m 56s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 27s | | the patch passed |
| +1 :green_heart: | compile | 3m 25s | | the patch passed |
| +1 :green_heart: | javac | 3m 25s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 39s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 59s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 13m 32s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 50s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 11s | | The patch does not
generate ASF License warnings. |
| | | 44m 22s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/8/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6448 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux efbbde8070bc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e4fa33ecbc82853d1442805f6f2dde12e2642f77 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 83 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/8/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #6448:
URL: https://github.com/apache/hbase/pull/6448#issuecomment-2899187264
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 45s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 40s | | master passed |
| +1 :green_heart: | compile | 1m 25s | | master passed |
| +1 :green_heart: | javadoc | 0m 44s | | master passed |
| +1 :green_heart: | shadedjars | 8m 46s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 23s | | the patch passed |
| +1 :green_heart: | compile | 1m 27s | | the patch passed |
| +1 :green_heart: | javac | 1m 27s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 41s | | the patch passed |
| +1 :green_heart: | shadedjars | 8m 48s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 232m 45s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/7/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 268m 55s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6448 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 05b6ce7a9cb6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e4fa33ecbc82853d1442805f6f2dde12e2642f77 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/7/testReport/
|
| Max. process+thread count | 5121 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/7/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #6448:
URL: https://github.com/apache/hbase/pull/6448#issuecomment-2898801672
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 31m 14s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 26s | | master passed |
| +1 :green_heart: | compile | 5m 55s | | master passed |
| +1 :green_heart: | checkstyle | 1m 24s | | master passed |
| +1 :green_heart: | spotbugs | 2m 48s | | master passed |
| +1 :green_heart: | spotless | 1m 2s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 35s | | the patch passed |
| +1 :green_heart: | compile | 3m 58s | | the patch passed |
| +1 :green_heart: | javac | 3m 58s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 10s | | the patch passed |
| +1 :green_heart: | spotbugs | 3m 12s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 22m 9s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 1m 8s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 24s | | The patch does not
generate ASF License warnings. |
| | | 104m 14s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/7/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6448 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux d1d9b45a47d0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e4fa33ecbc82853d1442805f6f2dde12e2642f77 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 83 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/7/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
richardantal commented on PR #6448: URL: https://github.com/apache/hbase/pull/6448#issuecomment-2897104087 I ran `mvn spotless:apply` to fix the issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #6448:
URL: https://github.com/apache/hbase/pull/6448#issuecomment-2895685377
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 27s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 18s | | master passed |
| +1 :green_heart: | compile | 0m 58s | | master passed |
| +1 :green_heart: | javadoc | 0m 29s | | master passed |
| +1 :green_heart: | shadedjars | 5m 58s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 6s | | the patch passed |
| +1 :green_heart: | compile | 1m 1s | | the patch passed |
| +1 :green_heart: | javac | 1m 1s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 27s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 55s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 209m 29s | | hbase-server in the patch
passed. |
| | | 235m 1s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6448 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux c1466ee49dd2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / eeba2cb490a069e6aafa176d9641014739cfcfe5 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/6/testReport/
|
| Max. process+thread count | 5367 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/6/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #6448:
URL: https://github.com/apache/hbase/pull/6448#issuecomment-2895105249
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 29s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 14s | | master passed |
| +1 :green_heart: | compile | 3m 6s | | master passed |
| +1 :green_heart: | checkstyle | 0m 37s | | master passed |
| +1 :green_heart: | spotbugs | 1m 34s | | master passed |
| +1 :green_heart: | spotless | 0m 44s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 54s | | the patch passed |
| +1 :green_heart: | compile | 3m 11s | | the patch passed |
| +1 :green_heart: | javac | 3m 11s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 36s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 35s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 11m 21s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| -1 :x: | spotless | 0m 36s | | patch has 43 errors when running
spotless:check, run spotless:apply to fix. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 10s | | The patch does not
generate ASF License warnings. |
| | | 37m 24s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/6/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6448 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 8f1b9e691f4a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / eeba2cb490a069e6aafa176d9641014739cfcfe5 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| spotless |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/6/artifact/yetus-general-check/output/patch-spotless.txt
|
| Max. process+thread count | 86 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/6/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
wchevreuil commented on code in PR #6448:
URL: https://github.com/apache/hbase/pull/6448#discussion_r2098043688
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##
@@ -506,14 +506,17 @@ private void
removeReplicaColumnsIfNeeded(MasterProcedureEnv env) throws IOExcep
private void assignNewReplicasIfNeeded(MasterProcedureEnv env) throws
IOException {
final int oldReplicaCount =
unmodifiedTableDescriptor.getRegionReplication();
final int newReplicaCount = modifiedTableDescriptor.getRegionReplication();
-if (newReplicaCount <= oldReplicaCount) {
+int existingReplicasCount = env.getAssignmentManager().getRegionStates()
+ .getRegionsOfTable(modifiedTableDescriptor.getTableName()).size();
+if (newReplicaCount <= Math.min(oldReplicaCount, existingReplicasCount)) {
Review Comment:
Got it, yeah it seems we need to check for differences between the two descs
and zk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
richardantal commented on code in PR #6448:
URL: https://github.com/apache/hbase/pull/6448#discussion_r2098010364
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##
@@ -506,14 +506,17 @@ private void
removeReplicaColumnsIfNeeded(MasterProcedureEnv env) throws IOExcep
private void assignNewReplicasIfNeeded(MasterProcedureEnv env) throws
IOException {
final int oldReplicaCount =
unmodifiedTableDescriptor.getRegionReplication();
final int newReplicaCount = modifiedTableDescriptor.getRegionReplication();
-if (newReplicaCount <= oldReplicaCount) {
+int existingReplicasCount = env.getAssignmentManager().getRegionStates()
+ .getRegionsOfTable(modifiedTableDescriptor.getTableName()).size();
+if (newReplicaCount <= Math.min(oldReplicaCount, existingReplicasCount)) {
Review Comment:
After we run the createAssignProcedures for the 2 replicas, ZK info will be
correct too.
In the problematic case the oldReplicaCount and newReplicaCount are both
3(the same) so the replica assignment wouldn't happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
wchevreuil commented on code in PR #6448:
URL: https://github.com/apache/hbase/pull/6448#discussion_r2097992238
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##
@@ -506,14 +506,17 @@ private void
removeReplicaColumnsIfNeeded(MasterProcedureEnv env) throws IOExcep
private void assignNewReplicasIfNeeded(MasterProcedureEnv env) throws
IOException {
final int oldReplicaCount =
unmodifiedTableDescriptor.getRegionReplication();
final int newReplicaCount = modifiedTableDescriptor.getRegionReplication();
-if (newReplicaCount <= oldReplicaCount) {
+int existingReplicasCount = env.getAssignmentManager().getRegionStates()
+ .getRegionsOfTable(modifiedTableDescriptor.getTableName()).size();
+if (newReplicaCount <= Math.min(oldReplicaCount, existingReplicasCount)) {
Review Comment:
Yes, I got that. My point is why are you considering the ZK info at all? The
issue we are trying to fix is the fact that ZK info is incorrect, so we
shouldn't take it into account here. Can't we just rely on oldReplicaCount and
newReplicaCount info?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #6448:
URL: https://github.com/apache/hbase/pull/6448#issuecomment-2894294214
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 44s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 50s | | master passed |
| +1 :green_heart: | compile | 1m 31s | | master passed |
| +1 :green_heart: | javadoc | 0m 49s | | master passed |
| +1 :green_heart: | shadedjars | 9m 4s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 29s | | the patch passed |
| +1 :green_heart: | compile | 1m 26s | | the patch passed |
| +1 :green_heart: | javac | 1m 26s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 44s | | the patch passed |
| +1 :green_heart: | shadedjars | 7m 54s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 240m 26s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/5/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 277m 26s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6448 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 235ce0f26390 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / eeba2cb490a069e6aafa176d9641014739cfcfe5 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/5/testReport/
|
| Max. process+thread count | 4926 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/5/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #6448:
URL: https://github.com/apache/hbase/pull/6448#issuecomment-2893389639
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 27s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 18s | | master passed |
| +1 :green_heart: | compile | 3m 11s | | master passed |
| +1 :green_heart: | checkstyle | 0m 37s | | master passed |
| +1 :green_heart: | spotbugs | 1m 38s | | master passed |
| +1 :green_heart: | spotless | 0m 46s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 8s | | the patch passed |
| +1 :green_heart: | compile | 3m 10s | | the patch passed |
| +1 :green_heart: | javac | 3m 10s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 36s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 43s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 12m 5s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| -1 :x: | spotless | 0m 38s | | patch has 43 errors when running
spotless:check, run spotless:apply to fix. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 10s | | The patch does not
generate ASF License warnings. |
| | | 39m 1s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/5/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6448 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux bd85d3401aef 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / eeba2cb490a069e6aafa176d9641014739cfcfe5 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| spotless |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/5/artifact/yetus-general-check/output/patch-spotless.txt
|
| Max. process+thread count | 85 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/5/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
richardantal commented on code in PR #6448:
URL: https://github.com/apache/hbase/pull/6448#discussion_r2096035669
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##
@@ -506,14 +506,17 @@ private void
removeReplicaColumnsIfNeeded(MasterProcedureEnv env) throws IOExcep
private void assignNewReplicasIfNeeded(MasterProcedureEnv env) throws
IOException {
final int oldReplicaCount =
unmodifiedTableDescriptor.getRegionReplication();
final int newReplicaCount = modifiedTableDescriptor.getRegionReplication();
-if (newReplicaCount <= oldReplicaCount) {
+int existingReplicasCount = env.getAssignmentManager().getRegionStates()
+ .getRegionsOfTable(modifiedTableDescriptor.getTableName()).size();
+if (newReplicaCount <= Math.min(oldReplicaCount, existingReplicasCount)) {
Review Comment:
In the problematic case we have the same (3) replica count in the Table
Descriptor and the problem is that only 1 of them exists in ZK. After this we
will assign the other 2 as well.
In my previous implementation I changed the replica count in the
TableDescriptor so it was not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
wchevreuil commented on code in PR #6448:
URL: https://github.com/apache/hbase/pull/6448#discussion_r2095882466
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##
@@ -506,14 +506,17 @@ private void
removeReplicaColumnsIfNeeded(MasterProcedureEnv env) throws IOExcep
private void assignNewReplicasIfNeeded(MasterProcedureEnv env) throws
IOException {
final int oldReplicaCount =
unmodifiedTableDescriptor.getRegionReplication();
final int newReplicaCount = modifiedTableDescriptor.getRegionReplication();
-if (newReplicaCount <= oldReplicaCount) {
+int existingReplicasCount = env.getAssignmentManager().getRegionStates()
+ .getRegionsOfTable(modifiedTableDescriptor.getTableName()).size();
+if (newReplicaCount <= Math.min(oldReplicaCount, existingReplicasCount)) {
Review Comment:
Why do we need to consider the ZK info here? Shouldn't the desc diff be
enough?
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##
@@ -1171,30 +1171,30 @@ private void finishActiveMasterInitialization() throws
IOException, InterruptedE
int replicasNumInConf =
conf.getInt(HConstants.META_REPLICAS_NUM,
HConstants.DEFAULT_META_REPLICA_NUM);
TableDescriptor metaDesc =
tableDescriptors.get(TableName.META_TABLE_NAME);
+ int existingReplicasCount =
+
assignmentManager.getRegionStates().getRegionsOfTable(TableName.META_TABLE_NAME).size();
+
if (metaDesc.getRegionReplication() != replicasNumInConf) {
// it is possible that we already have some replicas before upgrading,
so we must set the
// region replication number in meta TableDescriptor directly first,
without creating a
// ModifyTableProcedure, otherwise it may cause a double assign for
the meta replicas.
-int existingReplicasCount =
-
assignmentManager.getRegionStates().getRegionsOfTable(TableName.META_TABLE_NAME).size();
-if (existingReplicasCount > metaDesc.getRegionReplication()) {
- LOG.info("Update replica count of hbase:meta from {}(in
TableDescriptor)"
-+ " to {}(existing ZNodes)", metaDesc.getRegionReplication(),
existingReplicasCount);
- metaDesc = TableDescriptorBuilder.newBuilder(metaDesc)
+LOG.info("Update replica count of hbase:meta from {}(in
TableDescriptor)"
+ + " to {}(existing ZNodes)", metaDesc.getRegionReplication(),
existingReplicasCount);
+metaDesc = TableDescriptorBuilder.newBuilder(metaDesc)
.setRegionReplication(existingReplicasCount).build();
- tableDescriptors.update(metaDesc);
-}
-// check again, and issue a ModifyTableProcedure if needed
-if (metaDesc.getRegionReplication() != replicasNumInConf) {
- LOG.info(
-"The {} config is {} while the replica count in TableDescriptor is
{}"
- + " for hbase:meta, altering...",
-HConstants.META_REPLICAS_NUM, replicasNumInConf,
metaDesc.getRegionReplication());
- procedureExecutor.submitProcedure(new ModifyTableProcedure(
-procedureExecutor.getEnvironment(),
TableDescriptorBuilder.newBuilder(metaDesc)
- .setRegionReplication(replicasNumInConf).build(),
-null, metaDesc, false, true));
-}
+tableDescriptors.update(metaDesc);
+ }
+ // check again, and issue a ModifyTableProcedure if needed
+ if (metaDesc.getRegionReplication() != replicasNumInConf
+|| existingReplicasCount != metaDesc.getRegionReplication()) {
+LOG.info(
+ "The {} config is {} while the replica count in TableDescriptor is
{}"
++ " for hbase:meta, altering...",
+ HConstants.META_REPLICAS_NUM, replicasNumInConf,
metaDesc.getRegionReplication());
Review Comment:
Let's also log the number of replicas seen on ZK (existingReplicasCount).
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java:
##
@@ -506,14 +506,17 @@ private void
removeReplicaColumnsIfNeeded(MasterProcedureEnv env) throws IOExcep
private void assignNewReplicasIfNeeded(MasterProcedureEnv env) throws
IOException {
final int oldReplicaCount =
unmodifiedTableDescriptor.getRegionReplication();
final int newReplicaCount = modifiedTableDescriptor.getRegionReplication();
-if (newReplicaCount <= oldReplicaCount) {
+int existingReplicasCount = env.getAssignmentManager().getRegionStates()
+ .getRegionsOfTable(modifiedTableDescriptor.getTableName()).size();
+if (newReplicaCount <= Math.min(oldReplicaCount, existingReplicasCount)) {
return;
}
if (isTableEnabled(env)) {
List newReplicas =
env.getAssignmentManager().getRegionStates()
.getRegionsOfTable(getTableName()).stream().filter(RegionReplicaUtil::isDefaultReplica)
-.flatMap(primaryRegion -> IntStream
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #6448:
URL: https://github.com/apache/hbase/pull/6448#issuecomment-2891036752
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 31s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 43s | | master passed |
| +1 :green_heart: | compile | 1m 21s | | master passed |
| +1 :green_heart: | javadoc | 0m 38s | | master passed |
| +1 :green_heart: | shadedjars | 7m 31s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 32s | | the patch passed |
| +1 :green_heart: | compile | 1m 5s | | the patch passed |
| +1 :green_heart: | javac | 1m 5s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 35s | | the patch passed |
| +1 :green_heart: | shadedjars | 9m 35s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 304m 6s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/3/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 339m 25s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6448 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 2e4a16490d16 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / bb893978ad5d298a7c411762d76556ac9e1f0456 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/3/testReport/
|
| Max. process+thread count | 4592 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/3/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #6448:
URL: https://github.com/apache/hbase/pull/6448#issuecomment-2890115161
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 27s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 17s | | master passed |
| +1 :green_heart: | compile | 3m 3s | | master passed |
| +1 :green_heart: | checkstyle | 0m 37s | | master passed |
| +1 :green_heart: | spotbugs | 1m 34s | | master passed |
| +1 :green_heart: | spotless | 0m 45s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 22s | | the patch passed |
| +1 :green_heart: | compile | 4m 5s | | the patch passed |
| +1 :green_heart: | javac | 4m 5s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 39s |
[/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/3/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt)
| hbase-server: The patch generated 3 new + 8 unchanged - 0 fixed = 11 total
(was 8) |
| +1 :green_heart: | spotbugs | 2m 8s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 13m 41s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| -1 :x: | spotless | 0m 48s | | patch has 52 errors when running
spotless:check, run spotless:apply to fix. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 13s | | The patch does not
generate ASF License warnings. |
| | | 43m 11s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/3/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6448 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 07570ca4b379 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / bb893978ad5d298a7c411762d76556ac9e1f0456 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| spotless |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/3/artifact/yetus-general-check/output/patch-spotless.txt
|
| Max. process+thread count | 85 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/3/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
richardantal commented on PR #6448: URL: https://github.com/apache/hbase/pull/6448#issuecomment-2757231788 That is correct, Thanks @wchevreuil for the summary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
wchevreuil commented on PR #6448: URL: https://github.com/apache/hbase/pull/6448#issuecomment-2755002936 > Which version were you guys on when you hit this problem? This issue is being observed on a 2.4.17 (with some extra backports), but I guess it could also affect higher versions. > I still do not get the point that why the regions could be in offline state... My reading is that the meta replicas never get assigned, because we never trigger the ModifyTableProcedure to change region replicas count in the meta table descriptor: 1) [We will enter the block here because replica count is 3 in the config](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1167) 2) [This will return 1 because we are running this master for the first time and no meta replica node has been created yet in ZK](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1175) 3) [This returns false because we are using a root dir of a previous existing cluster, where meta replica was enabled, so the meta descriptor is already 3] (https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1177) 4) [This too returns false, and we never trigger the ModifyTableProcedure] (https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1185) 5) Since we miss triggering the ModifyTableProcedure, we never manage to assign the meta replicas, which should occur [here](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java#L244) @Apache9 @richardantal does the above make sense? If so, I think the proposed fix should be improved, as it would update the metaDesc with 1 as replica count just to pass [this if check](https://github.com/apache/hbase/pull/6448/files#diff-0e55b368bd805325243956ccd037e06bf8954c2c2cb99b665a1dd4c88f26f97bR1177), create a new descriptor with replica count 3 and trigger the modify proc. We should rather just trigger the meta replicas assignment, when we see replica count in table desc is greater than existingReplicasCount. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache9 commented on PR #6448: URL: https://github.com/apache/hbase/pull/6448#issuecomment-2754097141 Which version were you guys on when you hit this problem? I still do not get the point that why the regions could be in offline state... We need to find the root cause, otherwise we may hide other critical bugs... Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
richardantal commented on code in PR #6448:
URL: https://github.com/apache/hbase/pull/6448#discussion_r2013726194
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##
@@ -1157,19 +1157,22 @@ private void finishActiveMasterInitialization() throws
IOException, InterruptedE
int replicasNumInConf =
conf.getInt(HConstants.META_REPLICAS_NUM,
HConstants.DEFAULT_META_REPLICA_NUM);
TableDescriptor metaDesc =
tableDescriptors.get(TableName.META_TABLE_NAME);
- if (metaDesc.getRegionReplication() != replicasNumInConf) {
+ int existingReplicasCount =
+
assignmentManager.getRegionStates().getRegionsOfTable(TableName.META_TABLE_NAME).size();
+
+ if (
+metaDesc.getRegionReplication() != replicasNumInConf
+ || existingReplicasCount != metaDesc.getRegionReplication()
+ ) {
Review Comment:
existingReplicasCount reflects the in-memory state of the AssignmentManager.
In this case it will be 1 because only the FIRST_META_REGIONINFO will be
there.
You are right the problem is that no assignment procedure to be triggered on
the meta replicas because
metaDesc.getRegionReplication() reflects the root.dir state (three, since
it's a previous used rootdir), then we never update the meta descriptor and
this cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
wchevreuil commented on code in PR #6448:
URL: https://github.com/apache/hbase/pull/6448#discussion_r2011985349
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##
@@ -1157,19 +1157,22 @@ private void finishActiveMasterInitialization() throws
IOException, InterruptedE
int replicasNumInConf =
conf.getInt(HConstants.META_REPLICAS_NUM,
HConstants.DEFAULT_META_REPLICA_NUM);
TableDescriptor metaDesc =
tableDescriptors.get(TableName.META_TABLE_NAME);
- if (metaDesc.getRegionReplication() != replicasNumInConf) {
+ int existingReplicasCount =
+
assignmentManager.getRegionStates().getRegionsOfTable(TableName.META_TABLE_NAME).size();
+
+ if (
+metaDesc.getRegionReplication() != replicasNumInConf
+ || existingReplicasCount != metaDesc.getRegionReplication()
+ ) {
Review Comment:
@richardantal , can you confirm on my comment above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
wchevreuil commented on code in PR #6448:
URL: https://github.com/apache/hbase/pull/6448#discussion_r2005439538
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java:
##
@@ -1157,19 +1157,22 @@ private void finishActiveMasterInitialization() throws
IOException, InterruptedE
int replicasNumInConf =
conf.getInt(HConstants.META_REPLICAS_NUM,
HConstants.DEFAULT_META_REPLICA_NUM);
TableDescriptor metaDesc =
tableDescriptors.get(TableName.META_TABLE_NAME);
- if (metaDesc.getRegionReplication() != replicasNumInConf) {
+ int existingReplicasCount =
+
assignmentManager.getRegionStates().getRegionsOfTable(TableName.META_TABLE_NAME).size();
+
+ if (
+metaDesc.getRegionReplication() != replicasNumInConf
+ || existingReplicasCount != metaDesc.getRegionReplication()
+ ) {
Review Comment:
So the issue is that `existingReplicasCount` reflects the state of replicas
in Zookeeper (zero in this case, since it's a fresh start), but
`metaDesc.getRegionReplication()` reflects the root.dir state (three, since
it's a previous used rootdir), then we never update the meta descriptor and
this causes no assignment procedure to be triggered on the meta replicas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
anmolnar commented on PR #6448: URL: https://github.com/apache/hbase/pull/6448#issuecomment-2492352699 > > If it would 3 we wouldn't have this problem. :) > > In the assignmentManager.getRegionStates() we only have 1 online and 2 offline regions for hbase:meta only the 1 online will be returned here https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java#L243-L245 > > I think the problem here is that why there is only 1 online region? Before restarting/upgrading, all these 3 regions should be online? So in general, after upgrading, they could be in other states like CLOSED, but should not be in OFFLINE state? I'm not sure if I understand you correctly, but as far as I remember we were not able to OPEN the 2 other regions even manually. I'm not sure what state they were into, we should double check that, but the only thing which has fixed the problem is to turn off meta replicas and to turn them back on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache9 commented on PR #6448: URL: https://github.com/apache/hbase/pull/6448#issuecomment-2491373977 Any updates here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache9 commented on PR #6448: URL: https://github.com/apache/hbase/pull/6448#issuecomment-2470721905 > If it would 3 we wouldn't have this problem. :) > > In the assignmentManager.getRegionStates() we only have 1 online and 2 offline regions for hbase:meta only the 1 online will be returned here https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java#L243-L245 I think the problem here is that why there is only 1 online region? Before restarting/upgrading, all these 3 regions should be online? So in general, after upgrading, they could be in other states like CLOSED, but should not be in OFFLINE state? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
richardantal commented on PR #6448: URL: https://github.com/apache/hbase/pull/6448#issuecomment-2467739316 @Apache9 Can we go forward and merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
richardantal commented on PR #6448: URL: https://github.com/apache/hbase/pull/6448#issuecomment-2464965508 or we might only have 1 region in the assignmentManager.getRegionStates() for the hbase:meta -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
richardantal commented on PR #6448: URL: https://github.com/apache/hbase/pull/6448#issuecomment-2464954631 If it would 3 we wouldn't have this problem. :) In the assignmentManager.getRegionStates() we only have 1 online and 2 offline regions for hbase:meta only the 1 online will be returned here https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java#L243-L245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache9 commented on PR #6448: URL: https://github.com/apache/hbase/pull/6448#issuecomment-2464852978 In this case why existingReplicasCount could be 1? It should 3 I believe? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
richardantal commented on PR #6448: URL: https://github.com/apache/hbase/pull/6448#issuecomment-2464475044 We have set the meta region replicas to 3 in configuration, and for the cluster A we have the storage location set to "s3a://some-location/cluster-A/hbase" Meta region replicas works fine on cluster A, all of the replicas are assigned. We delete this cluster. We create cluster B with the same storage location set to "s3a://some-location/cluster-A/hbase" , with the same configuration ( meta region replicas set to 3) In this case FIRST_META_REGIONINFO gets assigned only. Compared to the case when we create a new cluster with empty storage we assign the replicas because we do this part as well. https://github.com/apache/hbase/blob/3fbe4fbb68e33f6ed796d268961ae05e19307f65/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L1173-L1182 In case of cluster B replicasNumInConf = 3 metaDesc.getRegionReplication() = 3 existingReplicasCount = 1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache9 commented on PR #6448: URL: https://github.com/apache/hbase/pull/6448#issuecomment-2463600351 Could you please provide more information about how this could happen? For example, we used to set meta region replicas to 3 in configuration, but when upgrading, we changed the meta region replicas to 1 in configuration? Or we just did not set it since here we used a new deploy? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #6448:
URL: https://github.com/apache/hbase/pull/6448#issuecomment-2463059962
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 45s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 55s | | master passed |
| +1 :green_heart: | compile | 0m 57s | | master passed |
| +1 :green_heart: | javadoc | 0m 29s | | master passed |
| +1 :green_heart: | shadedjars | 5m 22s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 56s | | the patch passed |
| +1 :green_heart: | compile | 0m 57s | | the patch passed |
| +1 :green_heart: | javac | 0m 57s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 30s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 17s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 251m 36s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 276m 13s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6448 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux f274297f6d26 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2
18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 25af9e3042ddd25d584498a24ea824b46658806a |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/2/testReport/
|
| Max. process+thread count | 4838 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/2/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #6448:
URL: https://github.com/apache/hbase/pull/6448#issuecomment-2462564041
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 45s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 32s | | master passed |
| +1 :green_heart: | compile | 3m 31s | | master passed |
| +1 :green_heart: | checkstyle | 0m 45s | | master passed |
| +1 :green_heart: | spotbugs | 1m 53s | | master passed |
| +1 :green_heart: | spotless | 0m 51s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 46s | | the patch passed |
| +1 :green_heart: | compile | 4m 0s | | the patch passed |
| +1 :green_heart: | javac | 4m 0s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 52s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 14s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 12m 35s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 49s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 12s | | The patch does not
generate ASF License warnings. |
| | | 43m 11s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6448 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux c88199ba81e0 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2
18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 25af9e3042ddd25d584498a24ea824b46658806a |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 84 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/2/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #6448:
URL: https://github.com/apache/hbase/pull/6448#issuecomment-2462449658
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 48s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 8s | | master passed |
| +1 :green_heart: | compile | 0m 57s | | master passed |
| +1 :green_heart: | javadoc | 0m 30s | | master passed |
| +1 :green_heart: | shadedjars | 5m 18s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 58s | | the patch passed |
| +1 :green_heart: | compile | 0m 57s | | the patch passed |
| +1 :green_heart: | javac | 0m 57s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 29s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 21s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 267m 11s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 292m 31s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6448 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 62bf0c875696 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2
18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 412393b87e1c4801805f03ef376d88ac24074a54 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/1/testReport/
|
| Max. process+thread count | 5104 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/1/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
Apache-HBase commented on PR #6448:
URL: https://github.com/apache/hbase/pull/6448#issuecomment-2461907111
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 44s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 5s | | master passed |
| +1 :green_heart: | compile | 2m 53s | | master passed |
| +1 :green_heart: | checkstyle | 0m 38s | | master passed |
| +1 :green_heart: | spotbugs | 1m 37s | | master passed |
| +1 :green_heart: | spotless | 0m 47s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 6s | | the patch passed |
| +1 :green_heart: | compile | 4m 0s | | the patch passed |
| +1 :green_heart: | javac | 4m 0s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 54s |
[/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/1/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt)
| hbase-server: The patch generated 5 new + 7 unchanged - 0 fixed = 12 total
(was 7) |
| +1 :green_heart: | spotbugs | 2m 13s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 13m 23s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| -1 :x: | spotless | 0m 38s | | patch has 63 errors when running
spotless:check, run spotless:apply to fix. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 12s | | The patch does not
generate ASF License warnings. |
| | | 40m 59s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6448 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 8469d5fa70c4 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2
18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 412393b87e1c4801805f03ef376d88ac24074a54 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| spotless |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/1/artifact/yetus-general-check/output/patch-spotless.txt
|
| Max. process+thread count | 87 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6448/1/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
[PR] HBASE-28962 Meta replication is inconsistent after startup when reusi… [hbase]
richardantal opened a new pull request, #6448: URL: https://github.com/apache/hbase/pull/6448 …ng hbase storage location -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
