Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-05 Thread via GitHub


petersomogyi merged PR #7070:
URL: https://github.com/apache/hbase/pull/7070


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-05 Thread via GitHub


petersomogyi merged PR #7069:
URL: https://github.com/apache/hbase/pull/7069


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-05 Thread via GitHub


petersomogyi merged PR #7068:
URL: https://github.com/apache/hbase/pull/7068


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-05 Thread via GitHub


petersomogyi commented on PR #7070:
URL: https://github.com/apache/hbase/pull/7070#issuecomment-2944938600

   In the 2 runs different tests failed and none of them seem to be related to 
this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-05 Thread via GitHub


Apache-HBase commented on PR #7070:
URL: https://github.com/apache/hbase/pull/7070#issuecomment-2944402962

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 49s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2.6 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 22s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  compile  |   0m 56s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  javadoc  |   0m 28s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  shadedjars  |   6m 41s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 24s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 16s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 16s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 36s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   7m  8s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 275m 52s |  |  hbase-server in the patch 
passed.  |
   |  |   | 306m 49s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7070 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 969b0f14495f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.6 / 917259a9ea2bb5c64a5ff5af1ac508e454aa3639 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/2/testReport/
 |
   | Max. process+thread count | 4489 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-05 Thread via GitHub


Apache-HBase commented on PR #7069:
URL: https://github.com/apache/hbase/pull/7069#issuecomment-2944539035

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 49s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 45s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m  7s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 40s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   7m 11s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 35s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 34s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 33s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 49s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |  10m 17s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 279m 12s |  |  hbase-server in the patch 
passed.  |
   |  |   | 315m 46s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7069 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 56201e44392f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 00abc4dd9843c8eff9180ec9d7714ebcd3b202fa |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/2/testReport/
 |
   | Max. process+thread count | 4593 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-05 Thread via GitHub


Apache-HBase commented on PR #7070:
URL: https://github.com/apache/hbase/pull/7070#issuecomment-2944227948

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 45s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  6s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2.6 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 50s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  compile  |   0m 59s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  javadoc  |   0m 32s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  shadedjars  |   6m 46s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 36s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  1s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  1s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 30s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 52s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 243m 32s |  |  hbase-server in the patch 
passed.  |
   |  |   | 273m  7s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7070 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 447250ef1a9a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.6 / 917259a9ea2bb5c64a5ff5af1ac508e454aa3639 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/2/testReport/
 |
   | Max. process+thread count | 4292 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-05 Thread via GitHub


Apache-HBase commented on PR #7069:
URL: https://github.com/apache/hbase/pull/7069#issuecomment-2944220917

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 50s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 23s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   0m 51s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 27s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   6m 40s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  9s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 52s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 52s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 25s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 37s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 232m 42s |  |  hbase-server in the patch 
passed.  |
   |  |   | 261m  1s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7069 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 35827ad4ce78 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 00abc4dd9843c8eff9180ec9d7714ebcd3b202fa |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/2/testReport/
 |
   | Max. process+thread count | 4438 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-05 Thread via GitHub


Apache-HBase commented on PR #7069:
URL: https://github.com/apache/hbase/pull/7069#issuecomment-2944111099

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 47s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 36s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   0m 41s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m 29s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 28s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 42s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 42s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 24s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m  6s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 215m  3s |  |  hbase-server in the patch 
passed.  |
   |  |   | 238m 57s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7069 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 7c29ab5094ab 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 00abc4dd9843c8eff9180ec9d7714ebcd3b202fa |
   | Default Java | Temurin-1.8.0_412-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/2/testReport/
 |
   | Max. process+thread count | 4266 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-05 Thread via GitHub


Apache-HBase commented on PR #7070:
URL: https://github.com/apache/hbase/pull/7070#issuecomment-2944060252

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   1m 17s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2.6 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 55s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  compile  |   0m 48s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  javadoc  |   0m 35s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  shadedjars  |   6m 10s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 44s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 56s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 56s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 27s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m  9s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 209m 12s | 
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   |  |   | 238m 14s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7070 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux b42c589e00e2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.6 / 917259a9ea2bb5c64a5ff5af1ac508e454aa3639 |
   | Default Java | Temurin-1.8.0_412-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/2/testReport/
 |
   | Max. process+thread count | 3960 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-05 Thread via GitHub


Apache-HBase commented on PR #7070:
URL: https://github.com/apache/hbase/pull/7070#issuecomment-2943425061

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   1m 22s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ branch-2.6 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 31s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  compile  |   3m 29s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 43s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  spotbugs  |   1m 50s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  spotless  |   1m  1s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 28s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 26s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 26s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 41s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   1m 56s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  24m 22s |  |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   1m  9s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 15s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  51m 13s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7070 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux 4e6ad561defe 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.6 / 917259a9ea2bb5c64a5ff5af1ac508e454aa3639 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   | Max. process+thread count | 78 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-05 Thread via GitHub


Apache-HBase commented on PR #7069:
URL: https://github.com/apache/hbase/pull/7069#issuecomment-2943420937

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 47s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 26s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   3m  4s |  |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 39s |  |  branch-2 passed  |
   | +1 :green_heart: |  spotbugs  |   1m 36s |  |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   0m 49s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  9s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m  0s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m  0s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 38s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   1m 45s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  17m 33s |  |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 45s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 11s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  39m 19s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7069 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux 0d21597580a7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 00abc4dd9843c8eff9180ec9d7714ebcd3b202fa |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   | Max. process+thread count | 79 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-04 Thread via GitHub


Apache-HBase commented on PR #7069:
URL: https://github.com/apache/hbase/pull/7069#issuecomment-2941417983

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   1m  5s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 15s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   0m 50s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 37s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   6m 19s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 38s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 53s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 53s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 31s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 19s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 387m 42s | 
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   |  |   | 429m 16s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7069 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 9c60b0e9d16c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 00abc4dd9843c8eff9180ec9d7714ebcd3b202fa |
   | Default Java | Temurin-1.8.0_412-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/1/testReport/
 |
   | Max. process+thread count | 4067 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-04 Thread via GitHub


Apache-HBase commented on PR #7069:
URL: https://github.com/apache/hbase/pull/7069#issuecomment-2941183296

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   1m  0s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  8s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m  7s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   1m 37s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 52s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   9m 47s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 42s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 23s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 23s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 36s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   8m  7s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 279m 58s | 
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   |  |   | 318m 20s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7069 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux af9c300bbf8f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 00abc4dd9843c8eff9180ec9d7714ebcd3b202fa |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/1/testReport/
 |
   | Max. process+thread count | 4532 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-04 Thread via GitHub


Apache-HBase commented on PR #7070:
URL: https://github.com/apache/hbase/pull/7070#issuecomment-2941100485

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 55s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  6s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2.6 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 53s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  compile  |   1m 14s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  javadoc  |   0m 40s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  shadedjars  |   8m  3s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 48s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  6s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  6s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 36s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   8m  1s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 282m 12s | 
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   |  |   | 317m  1s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7070 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 936848689f47 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.6 / 917259a9ea2bb5c64a5ff5af1ac508e454aa3639 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/1/testReport/
 |
   | Max. process+thread count | 4256 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-04 Thread via GitHub


Apache-HBase commented on PR #7070:
URL: https://github.com/apache/hbase/pull/7070#issuecomment-2941047913

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 43s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  6s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2.6 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m  8s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  compile  |   1m  4s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  javadoc  |   0m 33s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  shadedjars  |   6m 57s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 20s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 12s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 12s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 34s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 48s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 271m 27s | 
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   |  |   | 302m  4s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7070 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 66b6c51d88f3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.6 / 917259a9ea2bb5c64a5ff5af1ac508e454aa3639 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/1/testReport/
 |
   | Max. process+thread count | 4460 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-04 Thread via GitHub


Apache-HBase commented on PR #7070:
URL: https://github.com/apache/hbase/pull/7070#issuecomment-2940983529

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   1m 11s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  6s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2.6 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 55s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  compile  |   1m  8s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  javadoc  |   0m 40s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  shadedjars  |   8m 22s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 57s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m  9s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m  9s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 35s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   8m 27s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 248m 45s | 
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt)
 |  hbase-server in the patch failed.  |
   |  |   | 282m 53s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7070 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 0235f691eeec 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.6 / 917259a9ea2bb5c64a5ff5af1ac508e454aa3639 |
   | Default Java | Temurin-1.8.0_412-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/1/testReport/
 |
   | Max. process+thread count | 4234 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-04 Thread via GitHub


Apache-HBase commented on PR #7069:
URL: https://github.com/apache/hbase/pull/7069#issuecomment-2940911012

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 42s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  6s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 26s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   0m 57s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   0m 29s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   6m 43s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  7s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 51s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 51s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 40s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 231m 13s |  |  hbase-server in the patch 
passed.  |
   |  |   | 259m 33s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7069 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux e031bc4e84df 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 00abc4dd9843c8eff9180ec9d7714ebcd3b202fa |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/1/testReport/
 |
   | Max. process+thread count | 4424 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-04 Thread via GitHub


Apache-HBase commented on PR #7068:
URL: https://github.com/apache/hbase/pull/7068#issuecomment-2940824249

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 32s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-3 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 20s |  |  branch-3 passed  |
   | +1 :green_heart: |  compile  |   1m  2s |  |  branch-3 passed  |
   | +1 :green_heart: |  javadoc  |   0m 29s |  |  branch-3 passed  |
   | +1 :green_heart: |  shadedjars  |   6m  9s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  5s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 57s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 57s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 26s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m  1s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 214m 33s |  |  hbase-server in the patch 
passed.  |
   |  |   | 241m 12s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7068/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7068 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux b0d41fd1e564 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-3 / fb3ab1bf1a7402d5d838038d6642be2477bfec40 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7068/1/testReport/
 |
   | Max. process+thread count | 5493 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7068/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-04 Thread via GitHub


Apache-HBase commented on PR #7069:
URL: https://github.com/apache/hbase/pull/7069#issuecomment-2940276177

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   1m  0s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 49s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   3m 32s |  |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 44s |  |  branch-2 passed  |
   | +1 :green_heart: |  spotbugs  |   1m 55s |  |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   0m 59s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 13s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 31s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 31s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 43s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   2m  0s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  24m  1s |  |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 52s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 11s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  50m 45s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7069 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux 3e797ea26e0d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 00abc4dd9843c8eff9180ec9d7714ebcd3b202fa |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   | Max. process+thread count | 77 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7069/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-04 Thread via GitHub


Apache-HBase commented on PR #7070:
URL: https://github.com/apache/hbase/pull/7070#issuecomment-2940258884

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   1m 12s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ branch-2.6 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 26s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  compile  |   3m 37s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 45s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  spotbugs  |   1m 53s |  |  branch-2.6 passed  |
   | +1 :green_heart: |  spotless  |   0m 52s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 59s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 42s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 42s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 51s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   2m 31s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  19m 40s |  |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 53s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 14s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  46m 52s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7070 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux 0eaa77c372d1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.6 / 917259a9ea2bb5c64a5ff5af1ac508e454aa3639 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   | Max. process+thread count | 81 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7070/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-04 Thread via GitHub


Apache-HBase commented on PR #7068:
URL: https://github.com/apache/hbase/pull/7068#issuecomment-2940176925

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 31s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ branch-3 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 15s |  |  branch-3 passed  |
   | +1 :green_heart: |  compile  |   3m 18s |  |  branch-3 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 38s |  |  branch-3 passed  |
   | +1 :green_heart: |  spotbugs  |   1m 37s |  |  branch-3 passed  |
   | +1 :green_heart: |  spotless  |   0m 49s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  2s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 19s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 19s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 39s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   2m 23s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  13m 23s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 53s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 11s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  42m 19s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7068/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7068 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux 434424876d8e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-3 / fb3ab1bf1a7402d5d838038d6642be2477bfec40 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 84 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7068/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



[PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-04 Thread via GitHub


petersomogyi opened a new pull request, #7070:
URL: https://github.com/apache/hbase/pull/7070

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



[PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-04 Thread via GitHub


petersomogyi opened a new pull request, #7069:
URL: https://github.com/apache/hbase/pull/7069

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



[PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-04 Thread via GitHub


petersomogyi opened a new pull request, #7068:
URL: https://github.com/apache/hbase/pull/7068

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-04 Thread via GitHub


petersomogyi merged PR #7059:
URL: https://github.com/apache/hbase/pull/7059


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-03 Thread via GitHub


Apache-HBase commented on PR #7059:
URL: https://github.com/apache/hbase/pull/7059#issuecomment-2935582236

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 38s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m  2s |  |  master passed  |
   | +1 :green_heart: |  compile  |   1m  2s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   0m 32s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   6m 21s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 10s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 22s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 22s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   0m 37s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 23s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 218m 46s |  |  hbase-server in the patch 
passed.  |
   |  |   | 247m 54s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7059/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7059 |
   | Optional Tests | javac javadoc unit compile shadedjars |
   | uname | Linux 8887b1039fe2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 48d7a92bc80fa208cd9baed9e4c20b58b85b685a |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7059/2/testReport/
 |
   | Max. process+thread count | 5130 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7059/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-03 Thread via GitHub


Apache-HBase commented on PR #7059:
URL: https://github.com/apache/hbase/pull/7059#issuecomment-2934700319

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 46s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 37s |  |  master passed  |
   | +1 :green_heart: |  compile  |   3m 38s |  |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 41s |  |  master passed  |
   | +1 :green_heart: |  spotbugs  |   1m 40s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 49s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  7s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 17s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 17s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  1s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   0m 37s |  |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   1m 40s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  12m 13s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 44s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 10s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  40m 43s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7059/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7059 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux 96248c01b14e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 48d7a92bc80fa208cd9baed9e4c20b58b85b685a |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 84 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7059/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-03 Thread via GitHub


petersomogyi commented on code in PR #7059:
URL: https://github.com/apache/hbase/pull/7059#discussion_r2123204689


##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java:
##
@@ -726,12 +726,27 @@ private synchronized long 
submitSnapshotProcedure(SnapshotDescription snapshot,
   .submitProcedure(new MasterProcedureUtil.NonceProcedureRunnable(master, 
nonceGroup, nonce) {
 @Override
 protected void run() throws IOException {
+  TableDescriptor tableDescriptor =
+
master.getTableDescriptors().get(TableName.valueOf(snapshot.getTable()));
+  MasterCoprocessorHost cpHost = 
getMaster().getMasterCoprocessorHost();
+  User user = RpcServer.getRequestUser().orElse(null);
+  org.apache.hadoop.hbase.client.SnapshotDescription snapshotDesc =
+ProtobufUtil.createSnapshotDesc(snapshot);
+
+  if (cpHost != null) {
+cpHost.preSnapshot(snapshotDesc, tableDescriptor, user);

Review Comment:
   That can expected from coprocessors, like AccessDeniedException.



##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java:
##
@@ -726,12 +726,27 @@ private synchronized long 
submitSnapshotProcedure(SnapshotDescription snapshot,
   .submitProcedure(new MasterProcedureUtil.NonceProcedureRunnable(master, 
nonceGroup, nonce) {
 @Override
 protected void run() throws IOException {
+  TableDescriptor tableDescriptor =
+
master.getTableDescriptors().get(TableName.valueOf(snapshot.getTable()));
+  MasterCoprocessorHost cpHost = 
getMaster().getMasterCoprocessorHost();
+  User user = RpcServer.getRequestUser().orElse(null);
+  org.apache.hadoop.hbase.client.SnapshotDescription snapshotDesc =
+ProtobufUtil.createSnapshotDesc(snapshot);
+
+  if (cpHost != null) {
+cpHost.preSnapshot(snapshotDesc, tableDescriptor, user);

Review Comment:
   That can be expected from coprocessors, like AccessDeniedException.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-03 Thread via GitHub


Apache-HBase commented on PR #7059:
URL: https://github.com/apache/hbase/pull/7059#issuecomment-2934464893

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   3m 32s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
    _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 39s |  |  master passed  |
   | +1 :green_heart: |  compile  |   4m 11s |  |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 46s |  |  master passed  |
   | +1 :green_heart: |  spotbugs  |   1m 53s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 56s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m  3s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 54s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 54s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   0m 43s | 
[/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7059/1/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt)
 |  hbase-server: The patch generated 1 new + 4 unchanged - 0 fixed = 5 total 
(was 4)  |
   | +1 :green_heart: |  spotbugs  |   1m 56s |  |  the patch passed  |
   | +1 :green_heart: |  hadoopcheck  |  17m 32s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | -1 :x: |  spotless  |   0m 59s |  |  patch has 21 errors when running 
spotless:check, run spotless:apply to fix.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 13s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  56m  6s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7059/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7059 |
   | Optional Tests | dupname asflicense javac spotbugs checkstyle codespell 
detsecrets compile hadoopcheck hbaseanti spotless |
   | uname | Linux 791d1396e469 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 4fa1424e583a9b76ffca83c690202fe20695ab2f |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | spotless | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7059/1/artifact/yetus-general-check/output/patch-spotless.txt
 |
   | Max. process+thread count | 87 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7059/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-03 Thread via GitHub


Copilot commented on code in PR #7059:
URL: https://github.com/apache/hbase/pull/7059#discussion_r2123172794


##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java:
##
@@ -726,12 +726,27 @@ private synchronized long 
submitSnapshotProcedure(SnapshotDescription snapshot,
   .submitProcedure(new MasterProcedureUtil.NonceProcedureRunnable(master, 
nonceGroup, nonce) {
 @Override
 protected void run() throws IOException {
+  TableDescriptor tableDescriptor =
+
master.getTableDescriptors().get(TableName.valueOf(snapshot.getTable()));
+  MasterCoprocessorHost cpHost = 
getMaster().getMasterCoprocessorHost();
+  User user = RpcServer.getRequestUser().orElse(null);
+  org.apache.hadoop.hbase.client.SnapshotDescription snapshotDesc =
+ProtobufUtil.createSnapshotDesc(snapshot);
+
+  if (cpHost != null) {
+cpHost.preSnapshot(snapshotDesc, tableDescriptor, user);

Review Comment:
   Consider wrapping the preSnapshot hook call in a try-catch block or ensuring 
that any exceptions it may throw are appropriately handled, so that a failure 
in the coprocessor does not disrupt the snapshot procedure submission.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



[PR] HBASE-29361 Snapshot coprocessor hooks called inside SnapshotProcedure [hbase]

2025-06-03 Thread via GitHub


petersomogyi opened a new pull request, #7059:
URL: https://github.com/apache/hbase/pull/7059

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]