[jira] [Commented] (HBASE-29345) testWALClosureFailureAndCleanup fails due to missing lease recovery wait during close

2025-05-30 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-29345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955334#comment-17955334
 ] 

Hudson commented on HBASE-29345:


Results for branch branch-2.5
[build #696 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/696/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/696/General_20Nightly_20Build_20Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/696/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/696/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/696/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk17 hadoop3 checks{color}
-- For more information [see jdk17 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/696/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk17 hadoop 3.2.4 backward compatibility checks{color}
-- For more information [see jdk17 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/696/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk17 hadoop 3.3.5 backward compatibility checks{color}
-- For more information [see jdk17 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/696/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk17 hadoop 3.3.6 backward compatibility checks{color}
-- For more information [see jdk17 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/696/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 source release artifact{color}
-- Something went wrong with this stage, [check relevant console 
output|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/696//console].


(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console 
output|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/696//console].


> testWALClosureFailureAndCleanup fails due to missing lease recovery wait 
> during close
> -
>
> Key: HBASE-29345
> URL: https://issues.apache.org/jira/browse/HBASE-29345
> Project: HBase
>  Issue Type: Bug
>  Components: wal
>Affects Versions: 2.7.0
>Reporter: Vinayak Hegde
>Assignee: Vinayak Hegde
>Priority: Major
>  Labels: pull-request-available, test
> Fix For: 2.7.0, 2.6.3, 2.5.12
>
>
> The issue was in {{{}testWALClosureFailureAndCleanup{}}}, where the test code 
> wasn’t waiting for the file lease recovery to complete before checking the 
> cleanup status. Adding a wait before the check resolves the issue.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-29345) testWALClosureFailureAndCleanup fails due to missing lease recovery wait during close

2025-05-30 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-29345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955192#comment-17955192
 ] 

Hudson commented on HBASE-29345:


Results for branch branch-2
[build #1277 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1277/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1277/General_20Nightly_20Build_20Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1277/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1277/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1277/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk17 hadoop3 checks{color}
-- For more information [see jdk17 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1277/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk17 hadoop 3.3.5 backward compatibility checks{color}
-- For more information [see jdk17 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1277/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk17 hadoop 3.3.6 backward compatibility checks{color}
-- For more information [see jdk17 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1277/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk17 hadoop 3.4.0 backward compatibility checks{color}
-- For more information [see jdk17 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1277/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test for HBase 2 {color}
(/) {color:green}+1 client integration test for 3.3.5 {color}
(/) {color:green}+1 client integration test for 3.3.6 {color}
(/) {color:green}+1 client integration test for 3.4.0 {color}
(/) {color:green}+1 client integration test for 3.4.1 {color}


> testWALClosureFailureAndCleanup fails due to missing lease recovery wait 
> during close
> -
>
> Key: HBASE-29345
> URL: https://issues.apache.org/jira/browse/HBASE-29345
> Project: HBase
>  Issue Type: Bug
>  Components: wal
>Affects Versions: 2.7.0
>Reporter: Vinayak Hegde
>Assignee: Vinayak Hegde
>Priority: Major
>  Labels: pull-request-available, test
> Fix For: 2.7.0, 2.6.3, 2.5.12
>
>
> The issue was in {{{}testWALClosureFailureAndCleanup{}}}, where the test code 
> wasn’t waiting for the file lease recovery to complete before checking the 
> cleanup status. Adding a wait before the check resolves the issue.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-29345) testWALClosureFailureAndCleanup fails due to missing lease recovery wait during close

2025-05-28 Thread Istvan Toth (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-29345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954514#comment-17954514
 ] 

Istvan Toth commented on HBASE-29345:
-

So the test that this fixes was never added to master.
Not ideal, but this fix is fine for now.

> testWALClosureFailureAndCleanup fails due to missing lease recovery wait 
> during close
> -
>
> Key: HBASE-29345
> URL: https://issues.apache.org/jira/browse/HBASE-29345
> Project: HBase
>  Issue Type: Bug
>  Components: wal
>Affects Versions: 2.7.0
>Reporter: Vinayak Hegde
>Assignee: Vinayak Hegde
>Priority: Major
>  Labels: pull-request-available, test
>
> The issue was in {{{}testWALClosureFailureAndCleanup{}}}, where the test code 
> wasn’t waiting for the file lease recovery to complete before checking the 
> cleanup status. Adding a wait before the check resolves the issue.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-29345) testWALClosureFailureAndCleanup fails due to missing lease recovery wait during close

2025-05-28 Thread Vinayak Hegde (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-29345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954513#comment-17954513
 ] 

Vinayak Hegde commented on HBASE-29345:
---

There are two things to note:
 # This change: https://issues.apache.org/jira/browse/HBASE-28665 adds the test 
{{{}testWALClosureFailureAndCleanup{}}}, and it has been added to both 
{{branch-2}} and {{{}branch-2.5{}}}.

 # This change: https://issues.apache.org/jira/browse/HBASE-28637 adds file 
lease recovery before closing the file (an asynchronous operation that takes 
some time), and it has been added to {{master}} and {{{}branch-2{}}}.

So, the issue is present in {{{}branch-2{}}}.

> testWALClosureFailureAndCleanup fails due to missing lease recovery wait 
> during close
> -
>
> Key: HBASE-29345
> URL: https://issues.apache.org/jira/browse/HBASE-29345
> Project: HBase
>  Issue Type: Bug
>  Components: wal
>Affects Versions: 2.7.0
>Reporter: Vinayak Hegde
>Assignee: Vinayak Hegde
>Priority: Major
>  Labels: pull-request-available, test
>
> The issue was in {{{}testWALClosureFailureAndCleanup{}}}, where the test code 
> wasn’t waiting for the file lease recovery to complete before checking the 
> cleanup status. Adding a wait before the check resolves the issue.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)