Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3109887918 Thank you Duo and David for the approvals, will wait another day and merge this tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
PDavid commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2225658368 ## dev-support/jenkins/Dockerfile: ## @@ -14,21 +14,112 @@ # See the License for the specific language governing permissions and # limitations under the License. -# Dockerfile for hbase-operator-tools pre-commit build. -# https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build - -FROM maven:3.9-eclipse-temurin-8 - -# hadolint ignore=DL3008 -RUN apt-get -q update && apt-get -q install --no-install-recommends -y \ - binutils \ - git \ - rsync \ - shellcheck \ - patch \ - wget && \ +# Dockerfile for hbase-thirdparty pre-commit build. +# +# +# Built in multiple stages so as to avoid re-downloading large binaries when +# tweaking unrelated aspects of the image. +FROM ubuntu:22.04 AS base_image Review Comment: Thanks, then we can leave it as it is. :ok_hand: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2225644761 ## dev-support/jenkins/Dockerfile: ## @@ -14,21 +14,112 @@ # See the License for the specific language governing permissions and # limitations under the License. -# Dockerfile for hbase-operator-tools pre-commit build. -# https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build - -FROM maven:3.9-eclipse-temurin-8 - -# hadolint ignore=DL3008 -RUN apt-get -q update && apt-get -q install --no-install-recommends -y \ - binutils \ - git \ - rsync \ - shellcheck \ - patch \ - wget && \ +# Dockerfile for hbase-thirdparty pre-commit build. +# +# +# Built in multiple stages so as to avoid re-downloading large binaries when +# tweaking unrelated aspects of the image. +FROM ubuntu:22.04 AS base_image Review Comment: hey david, just sticked to what is being used in hbase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
PDavid commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2225552542 ## dev-support/jenkins/Dockerfile: ## @@ -14,21 +14,112 @@ # See the License for the specific language governing permissions and # limitations under the License. -# Dockerfile for hbase-operator-tools pre-commit build. -# https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build - -FROM maven:3.9-eclipse-temurin-8 - -# hadolint ignore=DL3008 -RUN apt-get -q update && apt-get -q install --no-install-recommends -y \ - binutils \ - git \ - rsync \ - shellcheck \ - patch \ - wget && \ +# Dockerfile for hbase-thirdparty pre-commit build. +# +# +# Built in multiple stages so as to avoid re-downloading large binaries when +# tweaking unrelated aspects of the image. +FROM ubuntu:22.04 AS base_image Review Comment: Just out of curiosity: Is there a specific reason why we would like to use 22.04 'Jammy Jellyfish' (LTS)? It is a bit older Ubuntu version, we might consider newer version, for example: 24.04 'Noble Numbat' (LTS). Checking at https://hub.docker.com/_/ubuntu 22.04 is also a supported version though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache9 commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3103076181 And the javac output are all warnings, not sure why yetus report it as error... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r767563 ## pom.xml: ## @@ -245,11 +280,7 @@ org.apache.maven.plugins maven-compiler-plugin - 3.11.0 - -1.8 -1.8 - + 3.13.0 Review Comment: Yes the implementation is same as you explained and it works fine now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache9 commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3103061699 What is our yetus version? In java 17 we do not have js script engine, IIRC we switch to use xmllint to check xml format in newer version of yetus. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache9 commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r762171 ## pom.xml: ## @@ -245,11 +280,7 @@ org.apache.maven.plugins maven-compiler-plugin - 3.11.0 - -1.8 -1.8 - + 3.13.0 Review Comment: > yes right, just that the plugin was supposed to handle converting it to source and target, doesnot work though, just doesnot fail anymore. https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html#usage-on-jdk-8 OK, if it is does not fail I think the current solution is fine. We set --release in parent, and for the two modules which needs to be built with JDK8, we set source and target. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r754666 ## pom.xml: ## @@ -245,11 +280,7 @@ org.apache.maven.plugins maven-compiler-plugin - 3.11.0 - -1.8 -1.8 - + 3.13.0 Review Comment: yes right, just that the plugin was supposed to handle converting it to source and target, doesnot work though; although it doesnot fail build anymore. https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html#usage-on-jdk-8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r754666 ## pom.xml: ## @@ -245,11 +280,7 @@ org.apache.maven.plugins maven-compiler-plugin - 3.11.0 - -1.8 -1.8 - + 3.13.0 Review Comment: yes right, just that the plugin was supposed to handle converting it to source and target, doesnot work though, just doesnot fail anymore. https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html#usage-on-jdk-8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache9 commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r753284 ## pom.xml: ## @@ -245,11 +280,7 @@ org.apache.maven.plugins maven-compiler-plugin - 3.11.0 - -1.8 -1.8 - + 3.13.0 Review Comment: OK, we use two profiles to do this... https://github.com/apache/hbase/blob/5100735657c7f5ab5a23404c2a002e2ec8ccb0d9/pom.xml#L3011 I'm not sure whether this works for multi jdk build here... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache9 commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r739654 ## pom.xml: ## @@ -245,11 +280,7 @@ org.apache.maven.plugins maven-compiler-plugin - 3.11.0 - -1.8 -1.8 - + 3.13.0 Review Comment: I think this means java 8 still do not support --release option? Let me check how we deal with this in hbase2... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3102498398 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 0s | hadolint was not available. | | +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 56s | root in master failed. | | -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. | | -1 :x: | compile | 0m 15s | root in master failed. | | +1 :green_heart: | javadoc | 0m 16s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 17s | the patch passed | | +1 :green_heart: | compile | 0m 45s | the patch passed | | -1 :x: | javac | 0m 12s | hbase-shaded-protobuf generated 19 new + 0 unchanged - 21 fixed = 19 total (was 21) | | -1 :x: | javac | 0m 7s | hbase-unsafe generated 8 new + 0 unchanged - 18 fixed = 8 total (was 18) | | -1 :x: | javac | 0m 15s | root generated 27 new + 0 unchanged - 39 fixed = 27 total (was 39) | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). | | +1 :green_heart: | javadoc | 0m 27s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 11s | hbase-shaded-protobuf in the patch passed. | | +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. | | +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. | | +1 :green_heart: | unit | 0m 7s | hbase-unsafe in the patch passed. | | +1 :green_heart: | unit | 0m 44s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 6m 56s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | dev-support/toolchains-jenkins.xml | | | hbase-shaded-jetty-12-plus-core/pom.xml | | | hbase-shaded-jetty-12-plus-ee8/pom.xml | | | hbase-shaded-protobuf/pom.xml | | | hbase-unsafe/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint | | uname | Linux b1657e36ec46 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / 1e93a44 | | Default Java | Eclipse Adoptium-17.0.11+9 | | mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt | | compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/artifact/yetus-precommit-check/output/branch-compile-root.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-shaded-protobuf.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-unsafe.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/artifact/yetus-precommit-check/output/diff-compile-javac-root.txt | | xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/artifact/yetus-precommit-
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3102471844 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/54/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r327795
##
pom.xml:
##
@@ -125,8 +127,17 @@
true
-MM-dd'T'HH:mm
${maven.build.timestamp}
-1.8
-${compileSource}
+
+
1.8
Review Comment:
Question: any better name suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r256508 ## hbase-shaded-protobuf/pom.xml: ## @@ -29,6 +29,13 @@ hbase-shaded-protobuf Apache HBase Patched and Relocated (Shaded) Protobuf Pulls down protobuf, patches it, compiles, and then relocates/shades. + +
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r326562
##
pom.xml:
##
@@ -245,11 +280,7 @@
org.apache.maven.plugins
maven-compiler-plugin
- 3.11.0
-
-1.8
-1.8
-
+ 3.13.0
Review Comment:
> Should I remove from main pom.xml and just set below explicitly for jdk 8
modules?
>
> ```
> ${java.release.version}
> ${java.release.version}
> ```
Updated PR to remove compiler source and target from main pom.xml and moved
to only reqd modules!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r256508 ## hbase-shaded-protobuf/pom.xml: ## @@ -29,6 +29,13 @@ hbase-shaded-protobuf Apache HBase Patched and Relocated (Shaded) Protobuf Pulls down protobuf, patches it, compiles, and then relocates/shades. + +
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r318266
##
pom.xml:
##
@@ -125,8 +127,19 @@
true
-MM-dd'T'HH:mm
${maven.build.timestamp}
-1.8
-${compileSource}
+
+1.8
+17
Review Comment:
> We do not need to use java 8 for protobuf?
Sorry? But we are already doing that. We are using java 8 for unsafe and
protobuf both.
##
pom.xml:
##
@@ -125,8 +127,19 @@
true
-MM-dd'T'HH:mm
${maven.build.timestamp}
-1.8
-${compileSource}
+
+1.8
+17
Review Comment:
> sure will rename as java.version
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r318266
##
pom.xml:
##
@@ -125,8 +127,19 @@
true
-MM-dd'T'HH:mm
${maven.build.timestamp}
-1.8
-${compileSource}
+
+1.8
+17
Review Comment:
> We do not need to use java 8 for protobuf?
Sorry? But we are already doing that. We are using java 8 for unsafe and
protobuf both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r309750
##
pom.xml:
##
@@ -125,8 +127,19 @@
true
-MM-dd'T'HH:mm
${maven.build.timestamp}
-1.8
-${compileSource}
+
+1.8
+17
Review Comment:
sure will rename as java.version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r283619
##
pom.xml:
##
@@ -125,8 +127,19 @@
true
-MM-dd'T'HH:mm
${maven.build.timestamp}
-1.8
-${compileSource}
+
+
1.8
+17
+8
+${java.release.version}
Review Comment:
duplicates
https://github.com/apache/hbase-thirdparty/pull/142/files#r2216993155, answered
there!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r282459
##
pom.xml:
##
@@ -245,11 +280,7 @@
org.apache.maven.plugins
maven-compiler-plugin
- 3.11.0
-
-1.8
-1.8
-
+ 3.13.0
Review Comment:
Should I remove from main pom.xml and just set below explicitly for jdk 8
modules?
```
${java.release.version}
${java.release.version}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r270829 ## pom.xml: ## @@ -245,11 +280,7 @@ org.apache.maven.plugins maven-compiler-plugin - 3.11.0 - -1.8 -1.8 - + 3.13.0 Review Comment: If I do not set them it fails for with error: ``` [INFO] --- compiler:3.13.0:compile (default-compile) @ hbase-shaded-protobuf --- [INFO] Toolchain in maven-compiler-plugin: JDK[/Users/nihjain/adoptopenjdk-8.jdk/Contents/Home] [INFO] Recompiling the module because of changed source code. [INFO] Compiling 206 source files with javac [forked debug release 8] to target/classes [INFO] - [WARNING] COMPILATION WARNING : [INFO] - [WARNING] [options] bootstrap class path not set in conjunction with -source 1.7 [INFO] 1 warning [INFO] - [INFO] - [ERROR] COMPILATION ERROR : [INFO] - [ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/ProtobufToStringOutput.java:[18,33] error: lambda expressions are not supported in -source 1.7 (use -source 8 or higher to enable lambda expressions) [INFO] 1 error [INFO] - [INFO] [INFO] Reactor Summary for Apache HBase Third-Party Libs 4.1.12-SNAPSHOT: [INFO] [INFO] Apache HBase Third-Party Libs .. SUCCESS [ 1.254 s] [INFO] Apache HBase Patched and Relocated (Shaded) Protobuf FAILURE [ 5.708 s] [INFO] Apache HBase Relocated (Shaded) Netty Libs . SKIPPED [INFO] Apache HBase Relocated (Shaded) netty-tcnative Libs SKIPPED [INFO] Apache HBase Relocated (Shaded) GSON Libs .. SKIPPED [INFO] Apache HBase Relocated (Shaded) Third-party Miscellaneous Libs SKIPPED [INFO] Apache HBase Relocated (Shaded) Jetty Libs . SKIPPED [INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: Core SKIPPED [INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8 SKIPPED [INFO] Apache HBase Relocated (Shaded) Jersey Libs SKIPPED [INFO] Apache HBase Relocated (Shaded) jackson-jaxrs-json-provider SKIPPED [INFO] Apache HBase Drop-in noop HTrace replacement ... SKIPPED [INFO] Apache HBase Unsafe Wrapper SKIPPED [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 7.207 s [INFO] Finished at: 2025-07-22T17:13:58+05:30 [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project hbase-shaded-protobuf: Compilation failure [ERROR] /Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/ProtobufToStringOutput.java:[18,33] error: lambda expressions are not supported in -source 1.7 [ERROR] (use -source 8 or higher to enable lambda expressions) [ERROR] [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :hbase-shaded-protobuf ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r256508 ## hbase-shaded-protobuf/pom.xml: ## @@ -29,6 +29,13 @@ hbase-shaded-protobuf Apache HBase Patched and Relocated (Shaded) Protobuf Pulls down protobuf, patches it, compiles, and then relocates/shades. + +
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r256508 ## hbase-shaded-protobuf/pom.xml: ## @@ -29,6 +29,13 @@ hbase-shaded-protobuf Apache HBase Patched and Relocated (Shaded) Protobuf Pulls down protobuf, patches it, compiles, and then relocates/shades. + +
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r256508 ## hbase-shaded-protobuf/pom.xml: ## @@ -29,6 +29,13 @@ hbase-shaded-protobuf Apache HBase Patched and Relocated (Shaded) Protobuf Pulls down protobuf, patches it, compiles, and then relocates/shades. + +
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache9 commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r108566
##
pom.xml:
##
@@ -125,8 +127,19 @@
true
-MM-dd'T'HH:mm
${maven.build.timestamp}
-1.8
-${compileSource}
+
+
1.8
+17
+8
+${java.release.version}
Review Comment:
This is for hbase-unsafe only? It should be 8 or 1.8?
##
hbase-shaded-protobuf/pom.xml:
##
@@ -29,6 +29,13 @@
hbase-shaded-protobuf
Apache HBase Patched and Relocated (Shaded) Protobuf
Pulls down protobuf, patches it, compiles, and then
relocates/shades.
+
+
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache9 commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r105563
##
pom.xml:
##
@@ -125,8 +127,19 @@
true
-MM-dd'T'HH:mm
${maven.build.timestamp}
-1.8
-${compileSource}
+
+1.8
+17
Review Comment:
We do not need to use java 8 for protobuf?
And this should be java.version instead of java.secondary.version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101735103 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 0s | hadolint was not available. | | +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 37s | root in master failed. | | -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. | | -1 :x: | compile | 0m 15s | root in master failed. | | +1 :green_heart: | javadoc | 0m 17s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 18s | the patch passed | | +1 :green_heart: | compile | 0m 45s | the patch passed | | -1 :x: | javac | 0m 11s | hbase-shaded-protobuf generated 19 new + 0 unchanged - 21 fixed = 19 total (was 21) | | -1 :x: | javac | 0m 7s | hbase-unsafe generated 8 new + 0 unchanged - 18 fixed = 8 total (was 18) | | -1 :x: | javac | 0m 16s | root generated 27 new + 0 unchanged - 39 fixed = 27 total (was 39) | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | xml | 0m 1s | The patch has 6 ill-formed XML file(s). | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 11s | hbase-shaded-protobuf in the patch passed. | | +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. | | +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. | | +1 :green_heart: | unit | 0m 6s | hbase-unsafe in the patch passed. | | +1 :green_heart: | unit | 0m 48s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 6m 34s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | dev-support/toolchains-jenkins.xml | | | hbase-shaded-jetty-12-plus-core/pom.xml | | | hbase-shaded-jetty-12-plus-ee8/pom.xml | | | hbase-shaded-protobuf/pom.xml | | | hbase-unsafe/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint | | uname | Linux e4a665868e12 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / 1e93a44 | | Default Java | Eclipse Adoptium-17.0.11+9 | | mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt | | compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/artifact/yetus-precommit-check/output/branch-compile-root.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-shaded-protobuf.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-unsafe.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/artifact/yetus-precommit-check/output/diff-compile-javac-root.txt | | xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/artifact/yetus-precommit-
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101718586 > TODO: Javac need to check! Javac warnings are expected, not sure why we are seeing now. Was it not coming before w/o this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101712047 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/53/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101703481 XML not sure what is the problem. TODO: Javac need to check! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2221738494
##
dev-support/jenkins/Dockerfile:
##
@@ -14,21 +14,112 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Dockerfile for hbase-operator-tools pre-commit build.
-# https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build
-
-FROM maven:3.9-eclipse-temurin-8
-
-# hadolint ignore=DL3008
-RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
- binutils \
- git \
- rsync \
- shellcheck \
- patch \
- wget && \
+# Dockerfile for hbase-thirdparty pre-commit build.
+#
+#
+# Built in multiple stages so as to avoid re-downloading large binaries when
+# tweaking unrelated aspects of the image.
+FROM ubuntu:22.04 AS base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update && \
+ DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends
-y \
+ca-certificates=20211016 \
+curl='7.81.0-*' \
+locales='2.35-*' \
+bash='5.1-*' \
+binutils='2.38-*' \
+build-essential=12.9ubuntu3 \
+git='1:2.34.1-*' \
+rsync='3.2.3-*' \
+tar='1.34+dfsg-*' \
+wget='1.21.2-*' \
+shellcheck='0.8.0-*' \
+patch='2.7.6-*' \
+&& \
apt-get clean && \
-rm -rf /var/lib/apt/lists/*
+rm -rf /var/lib/apt/lists/* \
+&& \
+locale-gen en_US.UTF-8
+ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en LC_ALL=en_US.UTF-8
+
+##
+# download sundry dependencies
+#
+
+FROM base_image AS maven_download_image
+ENV MAVEN_VERSION='3.9.8'
+ENV
MAVEN_URL="https://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz";
+ENV
MAVEN_SHA512='7d171def9b85846bf757a2cec94b7529371068a0670df14682447224e57983528e97a6d1b850327e4ca02b139abaab7fcb93c4315119e6f0ffb3f0cbc0d0b9a2'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/maven.tar.gz
"${MAVEN_URL}" && \
+ echo "${MAVEN_SHA512} */tmp/maven.tar.gz" | sha512sum -c -
+
+FROM base_image AS openjdk8_download_image
+ENV
OPENJDK8_URL='https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u412-b08/OpenJDK8U-jdk_x64_linux_hotspot_8u412b08.tar.gz'
+ENV
OPENJDK8_SHA256='b9884a96f78543276a6399c3eb8c2fd8a80e6b432ea50e87d3d12d495d1d2808'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output
/tmp/adoptopenjdk8.tar.gz "${OPENJDK8_URL}" && \
+ echo "${OPENJDK8_SHA256} */tmp/adoptopenjdk8.tar.gz" | sha256sum -c -
+
+FROM base_image AS openjdk17_download_image
+ENV
OPENJDK17_URL='https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.11%2B9/OpenJDK17U-jdk_x64_linux_hotspot_17.0.11_9.tar.gz'
+ENV
OPENJDK17_SHA256='aa7fb6bb342319d227a838af5c363bfa1b4a670c209372f9e6585bd79da6220c'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output
/tmp/adoptopenjdk17.tar.gz "${OPENJDK17_URL}" && \
+ echo "${OPENJDK17_SHA256} */tmp/adoptopenjdk17.tar.gz" | sha256sum -c -
+
+##
+# build the final image
+#
+
+FROM base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# hadolint ignore=DL3010
+COPY --from=maven_download_image /tmp/maven.tar.gz /tmp/maven.tar.gz
+RUN tar xzf /tmp/maven.tar.gz -C /opt && \
+ ln -s "/opt/$(dirname "$(tar -tf /tmp/maven.tar.gz | head -n1)")" /opt/maven
&& \
+ rm /tmp/maven.tar.gz
+
+##
+# ensure JVMs are available under `/usr/lib/jvm` and prefix each installation
+# as `java-` so as to conform with Yetus's assumptions.
+#
+
+# hadolint ignore=DL3010
+COPY --from=openjdk8_download_image /tmp/adoptopenjdk8.tar.gz
/tmp/adoptopenjdk8.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk8.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk8.tar.gz | head
-n1)")" /usr/lib/jvm/java-8-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-8-adoptopenjdk /usr/lib/jvm/java-8 && \
+ rm /tmp/adoptopenjdk8.tar.gz
+
+# hadolint ignore=DL3010
+COPY --from=openjdk17_download_image /tmp/adoptopenjdk17.tar.gz
/tmp/adoptopenjdk17.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk17.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk17.tar.gz | head
-n1)")" /usr/lib/jvm/java-17-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-17-adoptopenjdk /usr/lib/jvm/java-17 && \
+ rm /tmp/adoptopenjdk17.tar.gz
+
+# configure default environment for Yetus
+ENV MAVEN_HOME='/opt/maven'
+
+# create a wrapper for mvn to always pass the toolchains.xml file
+RUN mv /opt/maven/bin/mvn /opt/maven/bin/mvn-original && \
+cat > /opt/maven/bin/mvn <<'EOF'
+#!/bin/bash
+TOOLCHAIN="${BASEDIR}/dev-support/toolchains-jenkins.xml"
+if [ -f "$TOOLCHAIN" ]; then
+ echo "Bypassed mvn and added: -t ${TOOLCHAIN} as OPTS!"
+ exec ${MAVEN_H
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101683966 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 0s | hadolint was not available. | | +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 58s | root in master failed. | | -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. | | -1 :x: | compile | 0m 15s | root in master failed. | | +1 :green_heart: | javadoc | 0m 17s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 19s | the patch passed | | +1 :green_heart: | compile | 0m 45s | the patch passed | | -1 :x: | javac | 0m 12s | hbase-shaded-protobuf generated 19 new + 0 unchanged - 21 fixed = 19 total (was 21) | | -1 :x: | javac | 0m 6s | hbase-unsafe generated 8 new + 0 unchanged - 18 fixed = 8 total (was 18) | | -1 :x: | javac | 0m 16s | root generated 27 new + 0 unchanged - 39 fixed = 27 total (was 39) | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | xml | 0m 1s | The patch has 6 ill-formed XML file(s). | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 10s | hbase-shaded-protobuf in the patch passed. | | +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. | | +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. | | +1 :green_heart: | unit | 0m 7s | hbase-unsafe in the patch passed. | | +1 :green_heart: | unit | 0m 56s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. | | | | 7m 18s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | dev-support/toolchains-jenkins.xml | | | hbase-shaded-jetty-12-plus-core/pom.xml | | | hbase-shaded-jetty-12-plus-ee8/pom.xml | | | hbase-shaded-protobuf/pom.xml | | | hbase-unsafe/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint | | uname | Linux d9b68afbc552 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / 1e93a44 | | Default Java | Eclipse Adoptium-17.0.11+9 | | mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt | | compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/artifact/yetus-precommit-check/output/branch-compile-root.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-shaded-protobuf.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-unsafe.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/artifact/yetus-precommit-check/output/diff-compile-javac-root.txt | | xml | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/artifact/yetus-precommit-
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101677161 Code is ready for review. CC: @Apache9 @stoty @ndimiduk @apurtell -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101659394 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/52/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101382918 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 0s | hadolint was not available. | | +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 1m 0s | root in master failed. | | -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. | | -1 :x: | compile | 0m 15s | root in master failed. | | +1 :green_heart: | javadoc | 0m 17s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 24s | the patch passed | | +1 :green_heart: | compile | 0m 44s | the patch passed | | -1 :x: | javac | 0m 11s | hbase-shaded-protobuf generated 19 new + 0 unchanged - 21 fixed = 19 total (was 21) | | -1 :x: | javac | 0m 6s | hbase-unsafe generated 8 new + 0 unchanged - 18 fixed = 8 total (was 18) | | -1 :x: | javac | 0m 16s | root generated 27 new + 0 unchanged - 39 fixed = 27 total (was 39) | | +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. | | -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). | | +1 :green_heart: | javadoc | 0m 27s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 11s | hbase-shaded-protobuf in the patch passed. | | +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. | | +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. | | +1 :green_heart: | unit | 0m 8s | hbase-unsafe in the patch passed. | | +1 :green_heart: | unit | 0m 56s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 7m 39s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | dev-support/toolchains-jenkins.xml | | | hbase-shaded-jetty-12-plus-core/pom.xml | | | hbase-shaded-jetty-12-plus-ee8/pom.xml | | | hbase-shaded-protobuf/pom.xml | | | hbase-unsafe/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint | | uname | Linux 3ec8e5f798a4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / 1e93a44 | | Default Java | Eclipse Adoptium-17.0.11+9 | | mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt | | compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/artifact/yetus-precommit-check/output/branch-compile-root.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-shaded-protobuf.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-unsafe.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/artifact/yetus-precommit-check/output/diff-compile-javac-root.txt | | whitespace | https://ci-h
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3101362243 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/51/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2221350476
##
pom.xml:
##
@@ -519,28 +573,65 @@
org.apache.maven.plugins
maven-enforcer-plugin
-
-
-
- ${compileSource}
-
-module-info
-
**.glassfish.jersey.internal.jsr166.SubmissionPublisher*
-
**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*
-
- true
-
-test
-
- HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version
${compileSource} or earlier
+
+
+
+enforce-jdk8-bytecode
+
+ enforce
+
+verify
+
+
+
+ ${java.min.version}
+
+module-info
+
**.glassfish.jersey.internal.jsr166.SubmissionPublisher*
+
**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*
+
+ true
+
+test
+
+ HBase has unsupported dependencies.
+ hbase-unsafe requires to be compiled with version 1.8
of the JDK to properly build from source. You appear to be using a newer
dependency. You can use
either "mvn -version" or "mvn enforcer:display-info" to verify what version
is active.
Non-release builds can temporarily build with a newer JDK version by setting
the
'compileSource' property (eg. mvn -DcompileSource=1.8 clean
package).
-
-
-
+
+
+ ${skipJdk8BytecodeCheck}
+
+
+
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2221350077
##
pom.xml:
##
@@ -519,28 +573,65 @@
org.apache.maven.plugins
maven-enforcer-plugin
-
-
-
- ${compileSource}
-
-module-info
-
**.glassfish.jersey.internal.jsr166.SubmissionPublisher*
-
**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*
-
- true
-
-test
-
- HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version
${compileSource} or earlier
+
+
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2221228029
##
pom.xml:
##
@@ -125,8 +127,19 @@
true
-MM-dd'T'HH:mm
${maven.build.timestamp}
-1.8
-${compileSource}
+
+1.8
+17
+8
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2221225477
##
pom.xml:
##
@@ -125,8 +127,19 @@
true
-MM-dd'T'HH:mm
${maven.build.timestamp}
-1.8
-${compileSource}
+
+1.8
+17
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2221213842
##
pom.xml:
##
@@ -125,8 +127,19 @@
true
-MM-dd'T'HH:mm
${maven.build.timestamp}
-1.8
-${compileSource}
+
+1.8
+17
Review Comment:
Sure let me update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2217146867
##
pom.xml:
##
@@ -519,28 +573,65 @@
org.apache.maven.plugins
maven-enforcer-plugin
-
-
-
- ${compileSource}
-
-module-info
-
**.glassfish.jersey.internal.jsr166.SubmissionPublisher*
-
**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*
-
- true
-
-test
-
- HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version
${compileSource} or earlier
+
+
+
+enforce-jdk8-bytecode
+
+ enforce
+
+verify
+
+
+
+ ${java.min.version}
+
+module-info
+
**.glassfish.jersey.internal.jsr166.SubmissionPublisher*
+
**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*
+
+ true
+
+test
+
+ HBase has unsupported dependencies.
+ hbase-unsafe requires to be compiled with version 1.8
of the JDK to properly build from source. You appear to be using a newer
dependency. You can use
either "mvn -version" or "mvn enforcer:display-info" to verify what version
is active.
Non-release builds can temporarily build with a newer JDK version by setting
the
'compileSource' property (eg. mvn -DcompileSource=1.8 clean
package).
-
-
-
+
+
+ ${skipJdk8BytecodeCheck}
+
+
+
Review Comment:
yes yes right need to change docs comments everywhere as per current
implementation, still todo. let me fox these and make pr non draft today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2217146867
##
pom.xml:
##
@@ -519,28 +573,65 @@
org.apache.maven.plugins
maven-enforcer-plugin
-
-
-
- ${compileSource}
-
-module-info
-
**.glassfish.jersey.internal.jsr166.SubmissionPublisher*
-
**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*
-
- true
-
-test
-
- HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version
${compileSource} or earlier
+
+
+
+enforce-jdk8-bytecode
+
+ enforce
+
+verify
+
+
+
+ ${java.min.version}
+
+module-info
+
**.glassfish.jersey.internal.jsr166.SubmissionPublisher*
+
**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*
+
+ true
+
+test
+
+ HBase has unsupported dependencies.
+ hbase-unsafe requires to be compiled with version 1.8
of the JDK to properly build from source. You appear to be using a newer
dependency. You can use
either "mvn -version" or "mvn enforcer:display-info" to verify what version
is active.
Non-release builds can temporarily build with a newer JDK version by setting
the
'compileSource' property (eg. mvn -DcompileSource=1.8 clean
package).
-
-
-
+
+
+ ${skipJdk8BytecodeCheck}
+
+
+
Review Comment:
yes ues right need to change docs comments everywhere as per current
implementation, still todo. let me fox these and make pr non draft today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache9 commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2217109468
##
pom.xml:
##
@@ -125,8 +127,19 @@
true
-MM-dd'T'HH:mm
${maven.build.timestamp}
-1.8
-${compileSource}
+
+1.8
+17
+8
Review Comment:
Oh, we already have a releaseTarget, then I suggest we just change the
java.min.version to hbase.unsafe.java.version.
##
pom.xml:
##
@@ -519,28 +573,65 @@
org.apache.maven.plugins
maven-enforcer-plugin
-
-
-
- ${compileSource}
-
-module-info
-
**.glassfish.jersey.internal.jsr166.SubmissionPublisher*
-
**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*
-
- true
-
-test
-
- HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version
${compileSource} or earlier
+
+
+
+enforce-jdk8-bytecode
+
+ enforce
+
+verify
+
+
+
+ ${java.min.version}
Review Comment:
Should be 8 or 1.8?
##
pom.xml:
##
@@ -519,28 +573,65 @@
org.apache.maven.plugins
maven-enforcer-plugin
-
-
-
- ${compileSource}
-
-module-info
-
**.glassfish.jersey.internal.jsr166.SubmissionPublisher*
-
**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*
-
- true
-
-test
-
- HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version
${compileSource} or earlier
+
+
Review Comment:
The comment is incorrect.
##
pom.xml:
##
@@ -519,28 +573,65 @@
org.apache.maven.plugins
maven-enforcer-plugin
-
-
-
- ${compileSource}
-
-module-info
-
**.glassfish.jersey.internal.jsr166.SubmissionPublisher*
-
**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*
-
- true
-
-test
-
- HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version
${compileSource} or earlier
+
+
+
+enforce-jdk8-bytecode
+
+ enforce
+
+verify
+
+
+
+ ${java.min.version}
+
+module-info
+
**.glassfish.jersey.internal.jsr166.SubmissionPublisher*
+
**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*
+
+ true
+
+test
+
+ HBase has unsupported dependencies.
+ hbase-unsafe requires to be compiled with version 1.8
of the JDK to properly build from source. You appear to be using a newer
dependency. You can use
either "mvn -version" or "mvn enforcer:display-info" to verify what version
is active.
Non-release builds can temporarily build with a newer JDK version by setting
the
'compileSource' property (eg. mvn -DcompileSource=1.8 clean
package).
-
-
-
+
+
+ ${skipJdk8BytecodeCheck}
+
+
+
Review Comment:
JDK17 bytecode for jetty module only :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache9 commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2217109148
##
pom.xml:
##
@@ -125,8 +127,19 @@
true
-MM-dd'T'HH:mm
${maven.build.timestamp}
-1.8
-${compileSource}
+
+1.8
+17
Review Comment:
I suggest we change the java.min.version to something like
'java.release.version', and set it to 8. And introduce a special property like
'hbase.unsafe.java.version', and set it to 1.8.
So we can use java.version or jdk.version as the name for this property and
set it 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216993155 ## pom.xml: ## @@ -245,11 +280,7 @@ org.apache.maven.plugins maven-compiler-plugin - 3.11.0 - -1.8 -1.8 - + 3.13.0 Review Comment: bump to 3.13.0 as it allows to use release with jdk 8 as well! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216997781 ## hbase-shaded-protobuf/pom.xml: ## @@ -29,6 +29,13 @@ hbase-shaded-protobuf Apache HBase Patched and Relocated (Shaded) Protobuf Pulls down protobuf, patches it, compiles, and then relocates/shades. + +
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216993155 ## pom.xml: ## @@ -245,11 +280,7 @@ org.apache.maven.plugins maven-compiler-plugin - 3.11.0 - -1.8 -1.8 - + 3.13.0 Review Comment: note: bumped to 3.13.0 as it allows to use release with jdk 8 as well! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216993856
##
dev-support/jenkins/Dockerfile:
##
@@ -14,21 +14,112 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Dockerfile for hbase-operator-tools pre-commit build.
-# https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build
-
-FROM maven:3.9-eclipse-temurin-8
-
-# hadolint ignore=DL3008
-RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
- binutils \
- git \
- rsync \
- shellcheck \
- patch \
- wget && \
+# Dockerfile for hbase-thirdparty pre-commit build.
+#
+#
+# Built in multiple stages so as to avoid re-downloading large binaries when
+# tweaking unrelated aspects of the image.
+FROM ubuntu:22.04 AS base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update && \
+ DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends
-y \
+ca-certificates=20211016 \
+curl='7.81.0-*' \
+locales='2.35-*' \
+bash='5.1-*' \
+binutils='2.38-*' \
+build-essential=12.9ubuntu3 \
+git='1:2.34.1-*' \
+rsync='3.2.3-*' \
+tar='1.34+dfsg-*' \
+wget='1.21.2-*' \
+shellcheck='0.8.0-*' \
+patch='2.7.6-*' \
+&& \
apt-get clean && \
-rm -rf /var/lib/apt/lists/*
+rm -rf /var/lib/apt/lists/* \
+&& \
+locale-gen en_US.UTF-8
+ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en LC_ALL=en_US.UTF-8
+
+##
+# download sundry dependencies
+#
+
+FROM base_image AS maven_download_image
+ENV MAVEN_VERSION='3.9.8'
+ENV
MAVEN_URL="https://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz";
+ENV
MAVEN_SHA512='7d171def9b85846bf757a2cec94b7529371068a0670df14682447224e57983528e97a6d1b850327e4ca02b139abaab7fcb93c4315119e6f0ffb3f0cbc0d0b9a2'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/maven.tar.gz
"${MAVEN_URL}" && \
+ echo "${MAVEN_SHA512} */tmp/maven.tar.gz" | sha512sum -c -
+
+FROM base_image AS openjdk8_download_image
+ENV
OPENJDK8_URL='https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u412-b08/OpenJDK8U-jdk_x64_linux_hotspot_8u412b08.tar.gz'
+ENV
OPENJDK8_SHA256='b9884a96f78543276a6399c3eb8c2fd8a80e6b432ea50e87d3d12d495d1d2808'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output
/tmp/adoptopenjdk8.tar.gz "${OPENJDK8_URL}" && \
+ echo "${OPENJDK8_SHA256} */tmp/adoptopenjdk8.tar.gz" | sha256sum -c -
+
+FROM base_image AS openjdk17_download_image
+ENV
OPENJDK17_URL='https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.11%2B9/OpenJDK17U-jdk_x64_linux_hotspot_17.0.11_9.tar.gz'
+ENV
OPENJDK17_SHA256='aa7fb6bb342319d227a838af5c363bfa1b4a670c209372f9e6585bd79da6220c'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output
/tmp/adoptopenjdk17.tar.gz "${OPENJDK17_URL}" && \
+ echo "${OPENJDK17_SHA256} */tmp/adoptopenjdk17.tar.gz" | sha256sum -c -
+
+##
+# build the final image
+#
+
+FROM base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# hadolint ignore=DL3010
+COPY --from=maven_download_image /tmp/maven.tar.gz /tmp/maven.tar.gz
+RUN tar xzf /tmp/maven.tar.gz -C /opt && \
+ ln -s "/opt/$(dirname "$(tar -tf /tmp/maven.tar.gz | head -n1)")" /opt/maven
&& \
+ rm /tmp/maven.tar.gz
+
+##
+# ensure JVMs are available under `/usr/lib/jvm` and prefix each installation
+# as `java-` so as to conform with Yetus's assumptions.
+#
+
+# hadolint ignore=DL3010
+COPY --from=openjdk8_download_image /tmp/adoptopenjdk8.tar.gz
/tmp/adoptopenjdk8.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk8.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk8.tar.gz | head
-n1)")" /usr/lib/jvm/java-8-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-8-adoptopenjdk /usr/lib/jvm/java-8 && \
+ rm /tmp/adoptopenjdk8.tar.gz
+
+# hadolint ignore=DL3010
+COPY --from=openjdk17_download_image /tmp/adoptopenjdk17.tar.gz
/tmp/adoptopenjdk17.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk17.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk17.tar.gz | head
-n1)")" /usr/lib/jvm/java-17-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-17-adoptopenjdk /usr/lib/jvm/java-17 && \
+ rm /tmp/adoptopenjdk17.tar.gz
+
+# configure default environment for Yetus
+ENV MAVEN_HOME='/opt/maven'
+
+# create a wrapper for mvn to always pass the toolchains.xml file
+RUN mv /opt/maven/bin/mvn /opt/maven/bin/mvn-original && \
+cat > /opt/maven/bin/mvn <<'EOF'
+#!/bin/bash
+TOOLCHAIN="${BASEDIR}/dev-support/toolchains-jenkins.xml"
+if [ -f "$TOOLCHAIN" ]; then
+ echo "Bypassed mvn and added: -t ${TOOLCHAIN} as OPTS!"
+ exec ${MAVEN_H
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090955690 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 0s | hadolint was not available. | | +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 36s | root in master failed. | | -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. | | -1 :x: | compile | 0m 14s | root in master failed. | | +1 :green_heart: | javadoc | 0m 17s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 16s | the patch passed | | +1 :green_heart: | compile | 0m 44s | the patch passed | | -1 :x: | javac | 0m 11s | hbase-shaded-protobuf generated 19 new + 0 unchanged - 21 fixed = 19 total (was 21) | | -1 :x: | javac | 0m 6s | hbase-unsafe generated 8 new + 0 unchanged - 18 fixed = 8 total (was 18) | | -1 :x: | javac | 0m 16s | root generated 27 new + 0 unchanged - 39 fixed = 27 total (was 39) | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 11s | hbase-shaded-protobuf in the patch passed. | | +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. | | +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. | | +1 :green_heart: | unit | 0m 6s | hbase-unsafe in the patch passed. | | +1 :green_heart: | unit | 0m 45s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 6m 26s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | dev-support/toolchains-jenkins.xml | | | hbase-shaded-jetty-12-plus-core/pom.xml | | | hbase-shaded-jetty-12-plus-ee8/pom.xml | | | hbase-shaded-protobuf/pom.xml | | | hbase-unsafe/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint | | uname | Linux b3742e966585 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / 1e93a44 | | Default Java | Eclipse Adoptium-17.0.11+9 | | mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt | | compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/artifact/yetus-precommit-check/output/branch-compile-root.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-shaded-protobuf.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-unsafe.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/artifact/yetus-precommit-check/output/diff-compile-javac-root.txt | | whitespace | https://ci-h
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216994170 ## README.md: ## @@ -92,14 +92,72 @@ modern JDKs. Due to a bug in JDK, we cannot generate this code using a more modern version of the JDK. See [HBASE-26773](https://issues.apache.org/jira/browse/HBASE-26773) for details. +## Jetty 12 and Dual JDK Requirement + +Starting with version 4.1.12, this project requires JDK 8 and JDK 17 to accommodate different HBase versions: + +- **HBase 2.x**: Uses JDK 8 compatible modules (including `hbase-shaded-jetty` with Jetty 9) +- **HBase 3.x**: Uses JDK 17 modules (including `hbase-shaded-jetty-12-plus-*` with Jetty 12) + +### Why Dual JDK Support? + +Jetty 12 requires JDK 17 for compilation, but HBase 2.x deployments cannot move to Jetty 12 for JDK 8 compatibility. Our solution provides a single release containing modules for both JDK versions, eliminating the need for separate branches or releases. + +### Why toolchains are required? +Maven needs explicit toolchain configuration to automatically select JDK 8 for existing modules and JDK 17 for Jetty 12 modules. Environment variables alone are insufficient. + +### Files +- `generate-toolchains.sh` - Script to generate toolchains.xml with configurable paths +- `toolchains.xml` - Generated Maven toolchains configuration file (not checked in) + ## Build/Deploy -To build, make sure that your environment uses JDK8, then just run: +### Local Development Setup + +1. **Install both JDK versions**: JDK 8 and JDK 17 +2. **Set environment variables**: + ```sh + export JAVA8_HOME=/path/to/your/jdk8 + export JAVA17_HOME=/path/to/your/jdk17 + ``` +3. **Choose your toolchain setup approach** (see options below) + +### Toolchain Setup Options + +**Option 1: Project-local toolchains.xml** +```sh +# Generate and use project-specific toolchains +export JAVA8_HOME=/path/to/your/jdk8 +export JAVA17_HOME=/path/to/your/jdk17 +./dev-support/generate-toolchains.sh + +mvn clean install -t toolchains.xml +``` + +**Option 2: Global Maven toolchains setup** +```sh +# Setup toolchains in ~/.m2/ directory +export JAVA8_HOME=/path/to/your/jdk8 +export JAVA17_HOME=/path/to/your/jdk17 +./dev-support/generate-toolchains.sh +cp toolchains.xml ~/.m2/toolchains.xml +mvn clean install +``` + +### CI/Jenkins Setup + +For Jenkins/CI environments, the project auto-detects Java installations at standard paths: Review Comment: update based on implementation/hack! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216993856
##
dev-support/jenkins/Dockerfile:
##
@@ -14,21 +14,112 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Dockerfile for hbase-operator-tools pre-commit build.
-# https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build
-
-FROM maven:3.9-eclipse-temurin-8
-
-# hadolint ignore=DL3008
-RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
- binutils \
- git \
- rsync \
- shellcheck \
- patch \
- wget && \
+# Dockerfile for hbase-thirdparty pre-commit build.
+#
+#
+# Built in multiple stages so as to avoid re-downloading large binaries when
+# tweaking unrelated aspects of the image.
+FROM ubuntu:22.04 AS base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update && \
+ DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends
-y \
+ca-certificates=20211016 \
+curl='7.81.0-*' \
+locales='2.35-*' \
+bash='5.1-*' \
+binutils='2.38-*' \
+build-essential=12.9ubuntu3 \
+git='1:2.34.1-*' \
+rsync='3.2.3-*' \
+tar='1.34+dfsg-*' \
+wget='1.21.2-*' \
+shellcheck='0.8.0-*' \
+patch='2.7.6-*' \
+&& \
apt-get clean && \
-rm -rf /var/lib/apt/lists/*
+rm -rf /var/lib/apt/lists/* \
+&& \
+locale-gen en_US.UTF-8
+ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en LC_ALL=en_US.UTF-8
+
+##
+# download sundry dependencies
+#
+
+FROM base_image AS maven_download_image
+ENV MAVEN_VERSION='3.9.8'
+ENV
MAVEN_URL="https://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz";
+ENV
MAVEN_SHA512='7d171def9b85846bf757a2cec94b7529371068a0670df14682447224e57983528e97a6d1b850327e4ca02b139abaab7fcb93c4315119e6f0ffb3f0cbc0d0b9a2'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/maven.tar.gz
"${MAVEN_URL}" && \
+ echo "${MAVEN_SHA512} */tmp/maven.tar.gz" | sha512sum -c -
+
+FROM base_image AS openjdk8_download_image
+ENV
OPENJDK8_URL='https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u412-b08/OpenJDK8U-jdk_x64_linux_hotspot_8u412b08.tar.gz'
+ENV
OPENJDK8_SHA256='b9884a96f78543276a6399c3eb8c2fd8a80e6b432ea50e87d3d12d495d1d2808'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output
/tmp/adoptopenjdk8.tar.gz "${OPENJDK8_URL}" && \
+ echo "${OPENJDK8_SHA256} */tmp/adoptopenjdk8.tar.gz" | sha256sum -c -
+
+FROM base_image AS openjdk17_download_image
+ENV
OPENJDK17_URL='https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.11%2B9/OpenJDK17U-jdk_x64_linux_hotspot_17.0.11_9.tar.gz'
+ENV
OPENJDK17_SHA256='aa7fb6bb342319d227a838af5c363bfa1b4a670c209372f9e6585bd79da6220c'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output
/tmp/adoptopenjdk17.tar.gz "${OPENJDK17_URL}" && \
+ echo "${OPENJDK17_SHA256} */tmp/adoptopenjdk17.tar.gz" | sha256sum -c -
+
+##
+# build the final image
+#
+
+FROM base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# hadolint ignore=DL3010
+COPY --from=maven_download_image /tmp/maven.tar.gz /tmp/maven.tar.gz
+RUN tar xzf /tmp/maven.tar.gz -C /opt && \
+ ln -s "/opt/$(dirname "$(tar -tf /tmp/maven.tar.gz | head -n1)")" /opt/maven
&& \
+ rm /tmp/maven.tar.gz
+
+##
+# ensure JVMs are available under `/usr/lib/jvm` and prefix each installation
+# as `java-` so as to conform with Yetus's assumptions.
+#
+
+# hadolint ignore=DL3010
+COPY --from=openjdk8_download_image /tmp/adoptopenjdk8.tar.gz
/tmp/adoptopenjdk8.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk8.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk8.tar.gz | head
-n1)")" /usr/lib/jvm/java-8-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-8-adoptopenjdk /usr/lib/jvm/java-8 && \
+ rm /tmp/adoptopenjdk8.tar.gz
+
+# hadolint ignore=DL3010
+COPY --from=openjdk17_download_image /tmp/adoptopenjdk17.tar.gz
/tmp/adoptopenjdk17.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk17.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk17.tar.gz | head
-n1)")" /usr/lib/jvm/java-17-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-17-adoptopenjdk /usr/lib/jvm/java-17 && \
+ rm /tmp/adoptopenjdk17.tar.gz
+
+# configure default environment for Yetus
+ENV MAVEN_HOME='/opt/maven'
+
+# create a wrapper for mvn to always pass the toolchains.xml file
+RUN mv /opt/maven/bin/mvn /opt/maven/bin/mvn-original && \
+cat > /opt/maven/bin/mvn <<'EOF'
+#!/bin/bash
+TOOLCHAIN="${BASEDIR}/dev-support/toolchains-jenkins.xml"
+if [ -f "$TOOLCHAIN" ]; then
+ echo "Bypassed mvn and added: -t ${TOOLCHAIN} as OPTS!"
+ exec ${MAVEN_H
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216993419
##
pom.xml:
##
@@ -125,8 +127,19 @@
true
-MM-dd'T'HH:mm
${maven.build.timestamp}
-1.8
-${compileSource}
+
+1.8
+17
Review Comment:
is this name fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216992384
##
dev-support/jenkins/Dockerfile:
##
@@ -14,21 +14,112 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Dockerfile for hbase-operator-tools pre-commit build.
-# https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build
-
-FROM maven:3.9-eclipse-temurin-8
-
-# hadolint ignore=DL3008
-RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
- binutils \
- git \
- rsync \
- shellcheck \
- patch \
- wget && \
+# Dockerfile for hbase-thirdparty pre-commit build.
+#
+#
+# Built in multiple stages so as to avoid re-downloading large binaries when
+# tweaking unrelated aspects of the image.
+FROM ubuntu:22.04 AS base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update && \
+ DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends
-y \
+ca-certificates=20211016 \
+curl='7.81.0-*' \
+locales='2.35-*' \
+bash='5.1-*' \
+binutils='2.38-*' \
+build-essential=12.9ubuntu3 \
+git='1:2.34.1-*' \
+rsync='3.2.3-*' \
+tar='1.34+dfsg-*' \
+wget='1.21.2-*' \
+shellcheck='0.8.0-*' \
+patch='2.7.6-*' \
+&& \
apt-get clean && \
-rm -rf /var/lib/apt/lists/*
+rm -rf /var/lib/apt/lists/* \
+&& \
+locale-gen en_US.UTF-8
+ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en LC_ALL=en_US.UTF-8
+
+##
+# download sundry dependencies
+#
+
+FROM base_image AS maven_download_image
+ENV MAVEN_VERSION='3.9.8'
+ENV
MAVEN_URL="https://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz";
+ENV
MAVEN_SHA512='7d171def9b85846bf757a2cec94b7529371068a0670df14682447224e57983528e97a6d1b850327e4ca02b139abaab7fcb93c4315119e6f0ffb3f0cbc0d0b9a2'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/maven.tar.gz
"${MAVEN_URL}" && \
+ echo "${MAVEN_SHA512} */tmp/maven.tar.gz" | sha512sum -c -
+
+FROM base_image AS openjdk8_download_image
+ENV
OPENJDK8_URL='https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u412-b08/OpenJDK8U-jdk_x64_linux_hotspot_8u412b08.tar.gz'
+ENV
OPENJDK8_SHA256='b9884a96f78543276a6399c3eb8c2fd8a80e6b432ea50e87d3d12d495d1d2808'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output
/tmp/adoptopenjdk8.tar.gz "${OPENJDK8_URL}" && \
+ echo "${OPENJDK8_SHA256} */tmp/adoptopenjdk8.tar.gz" | sha256sum -c -
+
+FROM base_image AS openjdk17_download_image
+ENV
OPENJDK17_URL='https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.11%2B9/OpenJDK17U-jdk_x64_linux_hotspot_17.0.11_9.tar.gz'
+ENV
OPENJDK17_SHA256='aa7fb6bb342319d227a838af5c363bfa1b4a670c209372f9e6585bd79da6220c'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output
/tmp/adoptopenjdk17.tar.gz "${OPENJDK17_URL}" && \
+ echo "${OPENJDK17_SHA256} */tmp/adoptopenjdk17.tar.gz" | sha256sum -c -
+
+##
+# build the final image
+#
+
+FROM base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# hadolint ignore=DL3010
+COPY --from=maven_download_image /tmp/maven.tar.gz /tmp/maven.tar.gz
+RUN tar xzf /tmp/maven.tar.gz -C /opt && \
+ ln -s "/opt/$(dirname "$(tar -tf /tmp/maven.tar.gz | head -n1)")" /opt/maven
&& \
+ rm /tmp/maven.tar.gz
+
+##
+# ensure JVMs are available under `/usr/lib/jvm` and prefix each installation
+# as `java-` so as to conform with Yetus's assumptions.
+#
+
+# hadolint ignore=DL3010
+COPY --from=openjdk8_download_image /tmp/adoptopenjdk8.tar.gz
/tmp/adoptopenjdk8.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk8.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk8.tar.gz | head
-n1)")" /usr/lib/jvm/java-8-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-8-adoptopenjdk /usr/lib/jvm/java-8 && \
+ rm /tmp/adoptopenjdk8.tar.gz
+
+# hadolint ignore=DL3010
+COPY --from=openjdk17_download_image /tmp/adoptopenjdk17.tar.gz
/tmp/adoptopenjdk17.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk17.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk17.tar.gz | head
-n1)")" /usr/lib/jvm/java-17-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-17-adoptopenjdk /usr/lib/jvm/java-17 && \
+ rm /tmp/adoptopenjdk17.tar.gz
+
+# configure default environment for Yetus
+ENV MAVEN_HOME='/opt/maven'
+
+# create a wrapper for mvn to always pass the toolchains.xml file
+RUN mv /opt/maven/bin/mvn /opt/maven/bin/mvn-original && \
+cat > /opt/maven/bin/mvn <<'EOF'
+#!/bin/bash
+TOOLCHAIN="${BASEDIR}/dev-support/toolchains-jenkins.xml"
Review Comment:
DISCUSS: Should I call new command as mvn_wrap and pass this as command to
yetus? Not
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2216992384
##
dev-support/jenkins/Dockerfile:
##
@@ -14,21 +14,112 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Dockerfile for hbase-operator-tools pre-commit build.
-# https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build
-
-FROM maven:3.9-eclipse-temurin-8
-
-# hadolint ignore=DL3008
-RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
- binutils \
- git \
- rsync \
- shellcheck \
- patch \
- wget && \
+# Dockerfile for hbase-thirdparty pre-commit build.
+#
+#
+# Built in multiple stages so as to avoid re-downloading large binaries when
+# tweaking unrelated aspects of the image.
+FROM ubuntu:22.04 AS base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update && \
+ DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends
-y \
+ca-certificates=20211016 \
+curl='7.81.0-*' \
+locales='2.35-*' \
+bash='5.1-*' \
+binutils='2.38-*' \
+build-essential=12.9ubuntu3 \
+git='1:2.34.1-*' \
+rsync='3.2.3-*' \
+tar='1.34+dfsg-*' \
+wget='1.21.2-*' \
+shellcheck='0.8.0-*' \
+patch='2.7.6-*' \
+&& \
apt-get clean && \
-rm -rf /var/lib/apt/lists/*
+rm -rf /var/lib/apt/lists/* \
+&& \
+locale-gen en_US.UTF-8
+ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en LC_ALL=en_US.UTF-8
+
+##
+# download sundry dependencies
+#
+
+FROM base_image AS maven_download_image
+ENV MAVEN_VERSION='3.9.8'
+ENV
MAVEN_URL="https://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz";
+ENV
MAVEN_SHA512='7d171def9b85846bf757a2cec94b7529371068a0670df14682447224e57983528e97a6d1b850327e4ca02b139abaab7fcb93c4315119e6f0ffb3f0cbc0d0b9a2'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output /tmp/maven.tar.gz
"${MAVEN_URL}" && \
+ echo "${MAVEN_SHA512} */tmp/maven.tar.gz" | sha512sum -c -
+
+FROM base_image AS openjdk8_download_image
+ENV
OPENJDK8_URL='https://github.com/adoptium/temurin8-binaries/releases/download/jdk8u412-b08/OpenJDK8U-jdk_x64_linux_hotspot_8u412b08.tar.gz'
+ENV
OPENJDK8_SHA256='b9884a96f78543276a6399c3eb8c2fd8a80e6b432ea50e87d3d12d495d1d2808'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output
/tmp/adoptopenjdk8.tar.gz "${OPENJDK8_URL}" && \
+ echo "${OPENJDK8_SHA256} */tmp/adoptopenjdk8.tar.gz" | sha256sum -c -
+
+FROM base_image AS openjdk17_download_image
+ENV
OPENJDK17_URL='https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.11%2B9/OpenJDK17U-jdk_x64_linux_hotspot_17.0.11_9.tar.gz'
+ENV
OPENJDK17_SHA256='aa7fb6bb342319d227a838af5c363bfa1b4a670c209372f9e6585bd79da6220c'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl --location --fail --silent --show-error --output
/tmp/adoptopenjdk17.tar.gz "${OPENJDK17_URL}" && \
+ echo "${OPENJDK17_SHA256} */tmp/adoptopenjdk17.tar.gz" | sha256sum -c -
+
+##
+# build the final image
+#
+
+FROM base_image
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# hadolint ignore=DL3010
+COPY --from=maven_download_image /tmp/maven.tar.gz /tmp/maven.tar.gz
+RUN tar xzf /tmp/maven.tar.gz -C /opt && \
+ ln -s "/opt/$(dirname "$(tar -tf /tmp/maven.tar.gz | head -n1)")" /opt/maven
&& \
+ rm /tmp/maven.tar.gz
+
+##
+# ensure JVMs are available under `/usr/lib/jvm` and prefix each installation
+# as `java-` so as to conform with Yetus's assumptions.
+#
+
+# hadolint ignore=DL3010
+COPY --from=openjdk8_download_image /tmp/adoptopenjdk8.tar.gz
/tmp/adoptopenjdk8.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk8.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk8.tar.gz | head
-n1)")" /usr/lib/jvm/java-8-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-8-adoptopenjdk /usr/lib/jvm/java-8 && \
+ rm /tmp/adoptopenjdk8.tar.gz
+
+# hadolint ignore=DL3010
+COPY --from=openjdk17_download_image /tmp/adoptopenjdk17.tar.gz
/tmp/adoptopenjdk17.tar.gz
+RUN mkdir -p /usr/lib/jvm && \
+ tar xzf /tmp/adoptopenjdk17.tar.gz -C /usr/lib/jvm && \
+ ln -s "/usr/lib/jvm/$(basename "$(tar -tf /tmp/adoptopenjdk17.tar.gz | head
-n1)")" /usr/lib/jvm/java-17-adoptopenjdk && \
+ ln -s /usr/lib/jvm/java-17-adoptopenjdk /usr/lib/jvm/java-17 && \
+ rm /tmp/adoptopenjdk17.tar.gz
+
+# configure default environment for Yetus
+ENV MAVEN_HOME='/opt/maven'
+
+# create a wrapper for mvn to always pass the toolchains.xml file
+RUN mv /opt/maven/bin/mvn /opt/maven/bin/mvn-original && \
+cat > /opt/maven/bin/mvn <<'EOF'
+#!/bin/bash
+TOOLCHAIN="${BASEDIR}/dev-support/toolchains-jenkins.xml"
Review Comment:
DISCUSS: Should I call new command as mvn_wrap and pass this as command to
yetus?
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090894213 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/50/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090854255 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 0s | hadolint was not available. | | +0 :ok: | markdownlint | 0m 1s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 36s | root in master failed. | | -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. | | -1 :x: | compile | 0m 14s | root in master failed. | | +1 :green_heart: | javadoc | 0m 16s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 18s | the patch passed | | +1 :green_heart: | compile | 0m 44s | the patch passed | | -1 :x: | javac | 0m 11s | hbase-shaded-protobuf generated 19 new + 0 unchanged - 21 fixed = 19 total (was 21) | | -1 :x: | javac | 0m 6s | hbase-unsafe generated 8 new + 0 unchanged - 18 fixed = 8 total (was 18) | | -1 :x: | javac | 0m 16s | root generated 27 new + 0 unchanged - 39 fixed = 27 total (was 39) | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). | | +1 :green_heart: | javadoc | 0m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 11s | hbase-shaded-protobuf in the patch passed. | | +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch passed. | | +1 :green_heart: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch passed. | | +1 :green_heart: | unit | 0m 7s | hbase-unsafe in the patch passed. | | +1 :green_heart: | unit | 0m 53s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 6m 39s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | dev-support/toolchains-jenkins.xml | | | hbase-shaded-jetty-12-plus-core/pom.xml | | | hbase-shaded-jetty-12-plus-ee8/pom.xml | | | hbase-shaded-protobuf/pom.xml | | | hbase-unsafe/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint | | uname | Linux 4ae443d3d5c4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / 1e93a44 | | Default Java | Eclipse Adoptium-17.0.11+9 | | mvninstall | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/artifact/yetus-precommit-check/output/branch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/artifact/yetus-precommit-check/output/branch-compile-hbase-unsafe.txt | | compile | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/artifact/yetus-precommit-check/output/branch-compile-root.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-shaded-protobuf.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/artifact/yetus-precommit-check/output/diff-compile-javac-hbase-unsafe.txt | | javac | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/artifact/yetus-precommit-check/output/diff-compile-javac-root.txt | | whitespace | https://ci-h
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090828003 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/48/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090830734 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/49/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090825163 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/47/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090824313 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 0s | hadolint was not available. | | +0 :ok: | markdownlint | 0m 1s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 37s | root in master failed. | | -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. | | -1 :x: | compile | 0m 14s | root in master failed. | | +1 :green_heart: | javadoc | 0m 16s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | mvninstall | 0m 3s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | mvninstall | 0m 4s | root in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | compile | 0m 3s | hbase-unsafe in the patch failed. | | -1 :x: | compile | 0m 4s | root in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javac | 0m 3s | hbase-unsafe in the patch failed. | | -1 :x: | javac | 0m 4s | root in the patch failed. | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). | | -1 :x: | javadoc | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | javadoc | 0m 4s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | unit | 0m 3s | root in the patch failed. | | +1 :green_heart: | asflicense | 0m 23s | The patch does not generate ASF License warnings. | | | | 4m 8s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | dev-support/toolchains-jenkins.xml | | | hbase-shaded-jetty-12-plus-core/pom.xml | | | hbase-shaded-jetty-12-plus-ee8/pom.xml | | | hbase-shaded-protobuf/pom.xml | | | hbase-unsafe/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint | | uname | Linux 0c529abef9ef 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | git revision | ma
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090817750 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/46/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090810629 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 57s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 0s | hadolint was not available. | | +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 36s | root in master failed. | | -1 :x: | compile | 0m 5s | hbase-unsafe in master failed. | | -1 :x: | compile | 0m 15s | root in master failed. | | +1 :green_heart: | javadoc | 0m 16s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 3s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | mvninstall | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | mvninstall | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | mvninstall | 0m 4s | root in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | compile | 0m 3s | hbase-unsafe in the patch failed. | | -1 :x: | compile | 0m 4s | root in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javac | 0m 3s | hbase-unsafe in the patch failed. | | -1 :x: | javac | 0m 4s | root in the patch failed. | | +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. | | -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). | | -1 :x: | javadoc | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | javadoc | 0m 4s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | unit | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | unit | 0m 4s | root in the patch failed. | | +1 :green_heart: | asflicense | 0m 23s | The patch does not generate ASF License warnings. | | | | 5m 29s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | dev-support/toolchains-jenkins.xml | | | hbase-shaded-jetty-12-plus-core/pom.xml | | | hbase-shaded-jetty-12-plus-ee8/pom.xml | | | hbase-shaded-protobuf/pom.xml | | | hbase-unsafe/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint | | uname | Linux 3157dcb59464 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | git revision | ma
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090799397 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/45/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090772802 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/40/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090758650 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 0s | hadolint was not available. | | +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 55s | root in master failed. | | -1 :x: | compile | 0m 5s | hbase-unsafe in master failed. | | -1 :x: | compile | 0m 15s | root in master failed. | | +1 :green_heart: | javadoc | 0m 16s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | mvninstall | 0m 3s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | mvninstall | 0m 4s | root in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | compile | 0m 3s | root in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | javac | 0m 3s | root in the patch failed. | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). | | -1 :x: | javadoc | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | javadoc | 0m 4s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | unit | 0m 3s | hbase-unsafe in the patch failed. | | -1 :x: | unit | 0m 4s | root in the patch failed. | | +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 4m 36s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | dev-support/toolchains-jenkins.xml | | | hbase-shaded-jetty-12-plus-core/pom.xml | | | hbase-shaded-jetty-12-plus-ee8/pom.xml | | | hbase-shaded-protobuf/pom.xml | | | hbase-unsafe/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint | | uname | Linux 2a76debe288b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | git revision | ma
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090746695 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/39/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090745695 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 1s | Docker mode activated. | | -1 :x: | docker | 1m 20s | Docker failed to build yetus/unknown:0b6e052. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/38/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090743043 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/38/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2206509059
##
pom.xml:
##
@@ -519,28 +573,65 @@
org.apache.maven.plugins
maven-enforcer-plugin
-
-
-
- ${compileSource}
-
-module-info
-
**.glassfish.jersey.internal.jsr166.SubmissionPublisher*
-
**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*
-
- true
-
-test
-
- HBase has unsupported dependencies.
- HBase requires that all dependencies be compiled with version
${compileSource} or earlier
+
+
+
+enforce-jdk8-bytecode
+
+ enforce
+
+verify
+
+
+
+ ${java.min.version}
+
+module-info
+
**.glassfish.jersey.internal.jsr166.SubmissionPublisher*
+
**.glassfish.jersey.internal.jsr166.JerseyFlowSubscriber*
+
+ true
+
+test
+
+ HBase has unsupported dependencies.
+ hbase-unsafe requires to be compiled with version 1.8
of the JDK to properly build from source. You appear to be using a newer
dependency. You can use
either "mvn -version" or "mvn enforcer:display-info" to verify what version
is active.
Non-release builds can temporarily build with a newer JDK version by setting
the
'compileSource' property (eg. mvn -DcompileSource=1.8 clean
package).
-
-
-
+
+
+ ${skipJdk8BytecodeCheck}
+
+
+
+
+enforce-jdk17-bytecode
+
+ enforce
+
+verify
+
+
+
+ ${compileSource}
+
+module-info
+
+ true
+
+test
+
+ Some modules require JDK 17 bytecode
compatibility.
Review Comment:
update message based on new defaults
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090725539 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/37/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090724659 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 0s | hadolint was not available. | | +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 3s | root in master failed. | | -1 :x: | compile | 0m 4s | root in master failed. | | -1 :x: | compile | 0m 3s | hbase-shaded-protobuf in master failed. | | -1 :x: | compile | 0m 3s | hbase-unsafe in master failed. | | -1 :x: | javadoc | 0m 3s | root in master failed. | | -1 :x: | javadoc | 0m 3s | hbase-shaded-protobuf in master failed. | | -1 :x: | javadoc | 0m 4s | hbase-unsafe in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 3s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | mvninstall | 0m 3s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | mvninstall | 0m 3s | hbase-unsafe in the patch failed. | | -1 :x: | compile | 0m 3s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | javac | 0m 3s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | javac | 0m 18s | root generated 27 new + 0 unchanged - 0 fixed = 27 total (was 0) | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). | | -1 :x: | javadoc | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javadoc | 0m 3s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javadoc | 0m 3s | hbase-unsafe in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 3s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | unit | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | unit | 0m 3s | hbase-unsafe in the patch failed. | | +1 :green_heart: | unit | 0m 48s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. | | | | 4m 28s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | dev-support/toolchains-jenkins.xml | | | hbase-shaded-jetty-12-plus-core/pom.xml | | | hbase-shaded-jetty-12-plus-ee8/pom.xml | | | hbase-shaded-protobuf/pom.xml | | | hbase-unsafe/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint | | uname | Linux 1c7726f12440 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x8
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090716885 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/36/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090705556 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 0s | hadolint was not available. | | +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 3s | root in master failed. | | -1 :x: | compile | 0m 4s | root in master failed. | | -1 :x: | compile | 0m 3s | hbase-shaded-protobuf in master failed. | | -1 :x: | compile | 0m 4s | hbase-unsafe in master failed. | | -1 :x: | javadoc | 0m 3s | root in master failed. | | -1 :x: | javadoc | 0m 3s | hbase-shaded-protobuf in master failed. | | -1 :x: | javadoc | 0m 4s | hbase-unsafe in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 3s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | mvninstall | 0m 3s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | mvninstall | 0m 3s | hbase-unsafe in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | javac | 0m 18s | root generated 27 new + 0 unchanged - 0 fixed = 27 total (was 0) | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | -1 :x: | xml | 0m 1s | The patch has 6 ill-formed XML file(s). | | -1 :x: | javadoc | 0m 3s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javadoc | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 3s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | unit | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | unit | 0m 3s | hbase-unsafe in the patch failed. | | +1 :green_heart: | unit | 0m 49s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 4m 31s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | dev-support/toolchains-jenkins.xml | | | hbase-shaded-jetty-12-plus-core/pom.xml | | | hbase-shaded-jetty-12-plus-ee8/pom.xml | | | hbase-shaded-protobuf/pom.xml | | | hbase-unsafe/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint | | uname | Linux f4806f4cebbf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x8
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090694095 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/35/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090691843 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 0s | hadolint was not available. | | +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 3s | root in master failed. | | -1 :x: | compile | 0m 3s | root in master failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in master failed. | | -1 :x: | compile | 0m 3s | hbase-unsafe in master failed. | | -1 :x: | javadoc | 0m 3s | root in master failed. | | -1 :x: | javadoc | 0m 3s | hbase-shaded-protobuf in master failed. | | -1 :x: | javadoc | 0m 4s | hbase-unsafe in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 3s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 3s | root in the patch failed. | | -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | mvninstall | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | mvninstall | 0m 3s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | compile | 0m 3s | root in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | compile | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | compile | 0m 3s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | javac | 0m 3s | root in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javac | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javac | 0m 3s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-unsafe in the patch failed. | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | -1 :x: | xml | 0m 1s | The patch has 6 ill-formed XML file(s). | | -1 :x: | javadoc | 0m 3s | root in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javadoc | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javadoc | 0m 3s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 3s | root in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | unit | 0m 3s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | unit | 0m 3s | hbase-unsafe in the patch failed. | | +0 :ok: | asflicense | 0m 17s | ASF License check generated no output? | | | | 2m 39s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | dev-support/toolchains-jenkins.xml | | | hbase-shaded-jetty-12-plus-core/pom.xml | | | hbase-shaded-jetty-12-plus-ee8/pom.xml | | | hbase-shaded-protobuf/pom.xml | | | hbase-unsafe/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javad
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090687485 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/34/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090668688 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/33/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090665523 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/32/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090665573 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker mode activated. | | -1 :x: | docker | 0m 0s | Docker failed to build yetus/unknown:0b6e052. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/32/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090663299 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker mode activated. | | -1 :x: | docker | 0m 0s | Docker failed to build yetus/unknown:0b6e052. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/31/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090663248 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/31/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090653824 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 0s | hadolint was not available. | | +0 :ok: | markdownlint | 0m 1s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 8s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 4s | root in master failed. | | -1 :x: | compile | 0m 4s | root in master failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in master failed. | | -1 :x: | compile | 0m 4s | hbase-unsafe in master failed. | | -1 :x: | javadoc | 0m 4s | root in master failed. | | -1 :x: | javadoc | 0m 4s | hbase-shaded-protobuf in master failed. | | -1 :x: | javadoc | 0m 5s | hbase-unsafe in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 3s | root in the patch failed. | | -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | mvninstall | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | compile | 0m 3s | root in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | compile | 0m 3s | hbase-unsafe in the patch failed. | | -1 :x: | javac | 0m 3s | root in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javac | 0m 3s | hbase-unsafe in the patch failed. | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). | | -1 :x: | javadoc | 0m 4s | root in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 4s | root in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | unit | 0m 3s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-unsafe in the patch failed. | | +0 :ok: | asflicense | 0m 20s | ASF License check generated no output? | | | | 3m 8s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | dev-support/toolchains-jenkins.xml | | | hbase-shaded-jetty-12-plus-core/pom.xml | | | hbase-shaded-jetty-12-plus-ee8/pom.xml | | | hbase-shaded-protobuf/pom.xml | | | hbase-unsafe/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint | | uname | Linux 2e59bb279b17 5.4.0-1103-aws #
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090655012 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/30/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090648254 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/29/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090628881 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 1s | hadolint was not available. | | +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 38s | root in master failed. | | -1 :x: | compile | 0m 7s | hbase-unsafe in master failed. | | -1 :x: | compile | 0m 17s | root in master failed. | | +1 :green_heart: | javadoc | 0m 17s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | mvninstall | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | mvninstall | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | mvninstall | 0m 4s | root in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | compile | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | compile | 0m 4s | root in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javac | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | javac | 0m 4s | root in the patch failed. | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | xml | 0m 1s | The patch has 6 ill-formed XML file(s). | | -1 :x: | javadoc | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javadoc | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | javadoc | 0m 4s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 4s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | unit | 0m 4s | root in the patch failed. | | +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. | | | | 4m 19s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | dev-support/toolchains-jenkins.xml | | | hbase-shaded-jetty-12-plus-core/pom.xml | | | hbase-shaded-jetty-12-plus-ee8/pom.xml | | | hbase-shaded-protobuf/pom.xml | | | hbase-unsafe/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint | | uname | Linux 76e90ac113c9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/jenkins/personality.sh | | git revision | master / 1e93a44 | | D
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090618450 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/28/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090599035 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/27/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090559814 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 0s | hadolint was not available. | | +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 58s | root in master failed. | | -1 :x: | compile | 0m 6s | hbase-unsafe in master failed. | | -1 :x: | compile | 0m 19s | root in master failed. | | +1 :green_heart: | javadoc | 0m 23s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 7s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 5s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | mvninstall | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | mvninstall | 0m 6s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | mvninstall | 0m 5s | hbase-unsafe in the patch failed. | | -1 :x: | mvninstall | 0m 6s | root in the patch failed. | | -1 :x: | compile | 0m 6s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | compile | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | compile | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | compile | 0m 5s | hbase-unsafe in the patch failed. | | -1 :x: | compile | 0m 5s | root in the patch failed. | | -1 :x: | javac | 0m 6s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javac | 0m 4s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javac | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javac | 0m 5s | hbase-unsafe in the patch failed. | | -1 :x: | javac | 0m 5s | root in the patch failed. | | +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | xml | 0m 0s | The patch has 6 ill-formed XML file(s). | | -1 :x: | javadoc | 0m 5s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | javadoc | 0m 7s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | javadoc | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | javadoc | 0m 5s | hbase-unsafe in the patch failed. | | -1 :x: | javadoc | 0m 4s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 5s | hbase-shaded-protobuf in the patch failed. | | -1 :x: | unit | 0m 5s | hbase-shaded-jetty-12-plus-core in the patch failed. | | -1 :x: | unit | 0m 5s | hbase-shaded-jetty-12-plus-ee8 in the patch failed. | | -1 :x: | unit | 0m 4s | hbase-unsafe in the patch failed. | | -1 :x: | unit | 0m 5s | root in the patch failed. | | +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. | | | | 5m 53s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | dev-support/toolchains-jenkins.xml | | | hbase-shaded-jetty-12-plus-core/pom.xml | | | hbase-shaded-jetty-12-plus-ee8/pom.xml | | | hbase-shaded-protobuf/pom.xml | | | hbase-unsafe/pom.xml | | | pom.xml | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint | | uname | Linux f7ab5dfdc2f6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/jenkins/personality.sh | | git revision | master / 1e93a44 | | D
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090545767 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/26/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090428858 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | ||| _ Prechecks _ | | -1 :x: | maven | 0m 3s | ERROR: maven was not available. | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/25/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint | | uname | Linux 62b8883b6ef2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / 1e93a44 | | Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/25/console | | versions | git=2.34.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090427176 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/25/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090425454 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | -1 :x: | maven | 0m 3s | ERROR: maven was not available. | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/24/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint xml javac javadoc unit compile markdownlint | | uname | Linux ebbc955b8a52 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / 1e93a44 | | Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/24/console | | versions | git=2.34.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090423513 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/24/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090420005 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/23/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090402644 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -1 :x: | yetus | 0m 2s | Unprocessed flag(s): --mvn-opts | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/22/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/142 | | Console output | https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/22/console | | versions | git=2.34.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29225 Add module for Jetty 12 with EE8 to hbase-thirdparty [hbase-thirdparty]
Apache-HBase commented on PR #142: URL: https://github.com/apache/hbase-thirdparty/pull/142#issuecomment-3090400865 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-142/22/console in case of problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
