Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-06-02 Thread via GitHub


NihalJain merged PR #6993:
URL: https://github.com/apache/hbase/pull/6993


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-06-01 Thread via GitHub


NihalJain commented on PR #6993:
URL: https://github.com/apache/hbase/pull/6993#issuecomment-2928904101

   Thank you @stoty for the review, I will merge this in next 2 hours.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-31 Thread via GitHub


Apache-HBase commented on PR #6993:
URL: https://github.com/apache/hbase/pull/6993#issuecomment-2926481907

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 30s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 21s |  |  master passed  |
   | +1 :green_heart: |  compile  |   2m 10s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   2m 46s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   6m 12s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 19s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m  7s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 13s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 13s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   2m 46s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m  4s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 287m 39s |  |  root in the patch passed.  |
   |  |   | 324m 46s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6993 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 0ddbaee8f2af 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / bbedbe49584bc8dcda8f43da9f8b0cd6f8ce3aa8 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/7/testReport/
 |
   | Max. process+thread count | 8308 (vs. ulimit of 3) |
   | modules | C: hbase-build-configuration hbase-examples hbase-shaded 
hbase-shaded/hbase-shaded-check-invariants 
hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/7/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-31 Thread via GitHub


Apache-HBase commented on PR #6993:
URL: https://github.com/apache/hbase/pull/6993#issuecomment-2925978187

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 34s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  shelldocs  |   0m  0s |  |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 41s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 31s |  |  master passed  |
   | +1 :green_heart: |  compile  |   8m  3s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 49s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m  5s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   8m 15s |  |  the patch passed  |
   | -0 :warning: |  javac  |   8m 15s | 
[/results-compile-javac-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/7/artifact/yetus-general-check/output/results-compile-javac-root.txt)
 |  root generated 489 new + 1250 unchanged - 24 fixed = 1739 total (was 1274)  
|
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  shellcheck  |   0m  1s |  |  No new issues.  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  hadoopcheck  |  12m  3s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 43s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 52s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  46m 40s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/7/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6993 |
   | Optional Tests | dupname asflicense javac codespell detsecrets xmllint 
hadoopcheck spotless compile shellcheck shelldocs |
   | uname | Linux e58f074ddd76 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / bbedbe49584bc8dcda8f43da9f8b0cd6f8ce3aa8 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 188 (vs. ulimit of 3) |
   | modules | C: hbase-build-configuration hbase-examples hbase-shaded 
hbase-shaded/hbase-shaded-check-invariants 
hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/7/console 
|
   | versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-31 Thread via GitHub


Apache-HBase commented on PR #6993:
URL: https://github.com/apache/hbase/pull/6993#issuecomment-2924752247

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 28s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  shelldocs  |   0m  0s |  |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 45s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 34s |  |  master passed  |
   | +1 :green_heart: |  compile  |   8m  4s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 49s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m  5s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   8m 24s |  |  the patch passed  |
   | -0 :warning: |  javac  |   8m 24s | 
[/results-compile-javac-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/6/artifact/yetus-general-check/output/results-compile-javac-root.txt)
 |  root generated 489 new + 1250 unchanged - 24 fixed = 1739 total (was 1274)  
|
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  shellcheck  |   0m  1s |  |  No new issues.  |
   | +1 :green_heart: |  xmllint  |   0m  1s |  |  No new issues.  |
   | +1 :green_heart: |  hadoopcheck  |  12m  4s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 44s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 52s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  46m 58s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/6/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6993 |
   | Optional Tests | dupname asflicense javac codespell detsecrets xmllint 
hadoopcheck spotless compile shellcheck shelldocs |
   | uname | Linux fa44cdb5dd41 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / bbedbe49584bc8dcda8f43da9f8b0cd6f8ce3aa8 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 188 (vs. ulimit of 3) |
   | modules | C: hbase-build-configuration hbase-examples hbase-shaded 
hbase-shaded/hbase-shaded-check-invariants 
hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/6/console 
|
   | versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-29 Thread via GitHub


NihalJain commented on PR #6993:
URL: https://github.com/apache/hbase/pull/6993#issuecomment-2920362982

   Failures are not related!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-27 Thread via GitHub


Apache-HBase commented on PR #6993:
URL: https://github.com/apache/hbase/pull/6993#issuecomment-2915161114

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 26s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  8s |  |  master passed  |
   | +1 :green_heart: |  compile  |   2m  4s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   2m 45s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   6m  0s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   4m 42s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 57s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 10s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 10s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   2m 44s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m  1s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 232m 17s | 
[/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/5/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt)
 |  root in the patch failed.  |
   |  |   | 280m 56s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6993 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 51ecdcdf3f54 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 1d96a8f778f09e586062b50f3088ce8013e59ece |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/5/testReport/
 |
   | Max. process+thread count | 6233 (vs. ulimit of 3) |
   | modules | C: hbase-build-configuration hbase-examples hbase-shaded 
hbase-shaded/hbase-shaded-check-invariants 
hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/5/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-27 Thread via GitHub


Apache-HBase commented on PR #6993:
URL: https://github.com/apache/hbase/pull/6993#issuecomment-2914742916

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 32s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  shelldocs  |   0m  0s |  |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  1s |  |  The patch does not contain 
any @author tags.  |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 24s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 40s |  |  master passed  |
   | +1 :green_heart: |  compile  |  10m 57s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   1m 25s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   4m 49s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m  3s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  13m  1s |  |  the patch passed  |
   | -0 :warning: |  javac  |  13m  1s | 
[/results-compile-javac-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/5/artifact/yetus-general-check/output/results-compile-javac-root.txt)
 |  root generated 489 new + 1248 unchanged - 24 fixed = 1737 total (was 1272)  
|
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  shellcheck  |   0m  1s |  |  No new issues.  |
   | +1 :green_heart: |  xmllint  |   0m  1s |  |  No new issues.  |
   | +1 :green_heart: |  hadoopcheck  |  17m  7s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   1m 11s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   1m 51s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  71m 43s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/5/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6993 |
   | Optional Tests | dupname asflicense javac codespell detsecrets xmllint 
hadoopcheck spotless compile shellcheck shelldocs |
   | uname | Linux 9fc621566d3b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 1d96a8f778f09e586062b50f3088ce8013e59ece |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 188 (vs. ulimit of 3) |
   | modules | C: hbase-build-configuration hbase-examples hbase-shaded 
hbase-shaded/hbase-shaded-check-invariants 
hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/5/console 
|
   | versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-27 Thread via GitHub


NihalJain commented on code in PR #7002:
URL: https://github.com/apache/hbase/pull/7002#discussion_r2109837047


##
hbase-build-configuration/pom.xml:
##
@@ -82,6 +82,8 @@
 -XDcompilePolicy=simple
 
 -Xplugin:ErrorProne -XepDisableWarningsInGeneratedCode 
-XepExcludedPaths:.*/target/.* -Xep:FallThrough:OFF -Xep:MutablePublicArray:OFF 
-Xep:ClassNewInstance:ERROR -Xep:MissingDefault:ERROR -Xep:BanJNDI:WARN
+

Review Comment:
   Should I drop this or let it be here given "Error Prone 2.31.0 is the latest 
version which supports running on JDK 11"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-20 Thread via GitHub


Apache-HBase commented on PR #7002:
URL: https://github.com/apache/hbase/pull/7002#issuecomment-2895184726

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   1m  3s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 38s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   2m 41s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   2m 52s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   6m 41s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m 16s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 51s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 27s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 27s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m 52s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   7m 39s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 329m 40s | 
[/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt)
 |  root in the patch failed.  |
   |  |   | 374m 32s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7002 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux b424e9829a7c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 4131b811230cd6e489ce0f64baf0e71f9d412274 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/2/testReport/
 |
   | Max. process+thread count | 8168 (vs. ulimit of 3) |
   | modules | C: hbase-build-configuration hbase-shaded 
hbase-shaded/hbase-shaded-check-invariants 
hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-20 Thread via GitHub


Apache-HBase commented on PR #7002:
URL: https://github.com/apache/hbase/pull/7002#issuecomment-2894951789

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 42s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 55s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   2m 10s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   2m 22s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   6m 18s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 37s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m 56s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m  9s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m  9s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   2m 48s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 28s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 274m 21s | 
[/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt)
 |  root in the patch failed.  |
   |  |   | 311m 13s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7002 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux bc05aa0e5262 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 4131b811230cd6e489ce0f64baf0e71f9d412274 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/2/testReport/
 |
   | Max. process+thread count | 8309 (vs. ulimit of 3) |
   | modules | C: hbase-build-configuration hbase-shaded 
hbase-shaded/hbase-shaded-check-invariants 
hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-20 Thread via GitHub


Apache-HBase commented on PR #7002:
URL: https://github.com/apache/hbase/pull/7002#issuecomment-2894131577

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   5m 21s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  shelldocs  |   0m  1s |  |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
    _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m 17s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 21s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   8m 14s |  |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   1m  5s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m 48s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 28s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   7m 40s |  |  the patch passed  |
   | -0 :warning: |  javac  |   7m 40s | 
[/results-compile-javac-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/2/artifact/yetus-general-check/output/results-compile-javac-root.txt)
 |  root generated 13 new + 1254 unchanged - 1 fixed = 1267 total (was 1255)  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  shellcheck  |   0m  7s |  |  No new issues.  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  hadoopcheck  |  39m 52s |  |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   1m 25s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   1m 25s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  81m 36s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7002 |
   | Optional Tests | dupname asflicense javac codespell detsecrets xmllint 
hadoopcheck spotless compile shellcheck shelldocs |
   | uname | Linux 4500c30033ed 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 4131b811230cd6e489ce0f64baf0e71f9d412274 |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   | Max. process+thread count | 78 (vs. ulimit of 3) |
   | modules | C: hbase-build-configuration hbase-shaded 
hbase-shaded/hbase-shaded-check-invariants 
hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/2/console 
|
   | versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-20 Thread via GitHub


Apache-HBase commented on PR #7002:
URL: https://github.com/apache/hbase/pull/7002#issuecomment-2893623067

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 46s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  7s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   2m 11s |  |  branch-2 passed  |
   | +1 :green_heart: |  javadoc  |   2m 32s |  |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   6m 26s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m 37s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 12s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 20s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 20s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   3m  7s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   6m 38s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 273m 31s | 
[/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt)
 |  root in the patch failed.  |
   |  |   | 312m 55s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7002 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 48684603c70f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / a37dd70f246657affeec77dad6ea6da4d993440a |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/1/testReport/
 |
   | Max. process+thread count | 8848 (vs. ulimit of 3) |
   | modules | C: hbase-build-configuration hbase-shaded 
hbase-shaded/hbase-shaded-check-invariants 
hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #7002:
URL: https://github.com/apache/hbase/pull/7002#discussion_r2096987990


##
pom.xml:
##
@@ -637,7 +637,9 @@
 -->
 8.29
 3.1.0
-2.28.0
+
+2.31.0

Review Comment:
   > Also, we have some additional changes setup for plugin in master lets it 
run though. See https://github.com/apache/hbase/pull/6001
   
   We run errorProne with JDK17 in master hence it passes through, therefore 
copying plugin changes in branch-2 is no good!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #7002:
URL: https://github.com/apache/hbase/pull/7002#discussion_r2096976539


##
pom.xml:
##
@@ -1586,6 +1586,17 @@
   test
 
   
+  

Review Comment:
   Yes sound like a good idea. Let me add that as another commit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #7002:
URL: https://github.com/apache/hbase/pull/7002#discussion_r2096964781


##
pom.xml:
##
@@ -637,7 +637,9 @@
 -->
 8.29
 3.1.0
-2.28.0
+
+2.31.0

Review Comment:
   Refer https://errorprone.info/docs/installation
   
   We cannot go any beyond 2.31.0 on branch-2, as otherwise compile fails with 
error:
   ```
   [INFO] -
   [ERROR] COMPILATION ERROR : 
   [INFO] -
   [ERROR] An unknown compilation problem occurred
   [INFO] 1 error
   [INFO] -
   compiler message file broken: key=compiler.misc.msg.bug arguments=11.0.23, 
{1}, {2}, {3}, {4}, {5}, {6}, {7}
   java.lang.UnsupportedClassVersionError: 
com/google/errorprone/ErrorProneJavacPlugin has been compiled by a more recent 
version of the Java Runtime (class file version 61.0), this version of the Java 
Runtime only recognizes class file versions up to 55.0
at java.base/java.lang.ClassLoader.defineClass1(Native Method)
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1022)
at 
java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174)
at 
java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:555)
at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:458)
at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:452)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:451)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:594)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:398)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.nextProviderClass(ServiceLoader.java:1210)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1221)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1265)
at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1300)
at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1385)
at 
jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:210)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.prepareCompiler(JavacTaskImpl.java:199)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:101)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:147)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:100)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:94)
at 
org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCompiler.java:126)
at 
org.codehaus.plexus.compiler.javac.JavacCompiler.performCompile(JavacCompiler.java:174)
at 
org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1134)
at 
org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:187)
at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:126)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:328)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:316)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:75)
at 
org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:162)
at 
org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:159)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:105)
at 
org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:193)
at 
org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:180)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
a

Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


stoty commented on code in PR #7002:
URL: https://github.com/apache/hbase/pull/7002#discussion_r2096967559


##
pom.xml:
##
@@ -1586,6 +1586,17 @@
   test
 
   
+  

Review Comment:
   Maybe put this in a profile ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #7002:
URL: https://github.com/apache/hbase/pull/7002#discussion_r2096964781


##
pom.xml:
##
@@ -637,7 +637,9 @@
 -->
 8.29
 3.1.0
-2.28.0
+
+2.31.0

Review Comment:
   Refer https://errorprone.info/docs/installation
   
   We cannot go any beyond 2.31.0 as otherwise compile fails with error:
   ```
   [INFO] -
   [ERROR] COMPILATION ERROR : 
   [INFO] -
   [ERROR] An unknown compilation problem occurred
   [INFO] 1 error
   [INFO] -
   compiler message file broken: key=compiler.misc.msg.bug arguments=11.0.23, 
{1}, {2}, {3}, {4}, {5}, {6}, {7}
   java.lang.UnsupportedClassVersionError: 
com/google/errorprone/ErrorProneJavacPlugin has been compiled by a more recent 
version of the Java Runtime (class file version 61.0), this version of the Java 
Runtime only recognizes class file versions up to 55.0
at java.base/java.lang.ClassLoader.defineClass1(Native Method)
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1022)
at 
java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174)
at 
java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:555)
at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:458)
at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:452)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:451)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:594)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:398)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.nextProviderClass(ServiceLoader.java:1210)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1221)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1265)
at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1300)
at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1385)
at 
jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:210)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.prepareCompiler(JavacTaskImpl.java:199)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:101)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:147)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:100)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:94)
at 
org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCompiler.java:126)
at 
org.codehaus.plexus.compiler.javac.JavacCompiler.performCompile(JavacCompiler.java:174)
at 
org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1134)
at 
org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:187)
at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:126)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:328)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:316)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:75)
at 
org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:162)
at 
org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:159)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:105)
at 
org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:193)
at 
org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:180)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 
java.base/j

Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #7002:
URL: https://github.com/apache/hbase/pull/7002#discussion_r2096964781


##
pom.xml:
##
@@ -637,7 +637,9 @@
 -->
 8.29
 3.1.0
-2.28.0
+
+2.31.0

Review Comment:
   Refer https://errorprone.info/docs/installation
   
   We cannot go any beyond 2.31.0 as otherwise compile fails with error.
   
   We have some additional changes setup for plugin in master lets it run 
though. See https://github.com/apache/hbase/pull/6001
   
   CC: @stoty @ndimiduk @Apache9 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #7002:
URL: https://github.com/apache/hbase/pull/7002#discussion_r2096947851


##
pom.xml:
##
@@ -637,7 +637,7 @@
 -->
 8.29
 3.1.0
-2.28.0
+2.38.0

Review Comment:
   Okay seems this was deliberately not bumped beyond 2.28.0 even though 
previous release of hbase thirdparty was having 2.36.0? With 2.38.0 build fails 
with error
   ```
   [INFO] -
   [ERROR] COMPILATION ERROR : 
   [INFO] -
   [ERROR] An unknown compilation problem occurred
   [INFO] 1 error
   [INFO] -
   compiler message file broken: key=compiler.misc.msg.bug arguments=11.0.23, 
{1}, {2}, {3}, {4}, {5}, {6}, {7}
   java.lang.UnsupportedClassVersionError: 
com/google/errorprone/ErrorProneJavacPlugin has been compiled by a more recent 
version of the Java Runtime (class file version 61.0), this version of the Java 
Runtime only recognizes class file versions up to 55.0
at java.base/java.lang.ClassLoader.defineClass1(Native Method)
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1022)
at 
java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174)
at 
java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:555)
at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:458)
at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:452)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:451)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:594)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:398)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.nextProviderClass(ServiceLoader.java:1210)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1221)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1265)
at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1300)
at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1385)
at 
jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:210)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.prepareCompiler(JavacTaskImpl.java:199)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:101)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:147)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:100)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:94)
at 
org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCompiler.java:126)
at 
org.codehaus.plexus.compiler.javac.JavacCompiler.performCompile(JavacCompiler.java:174)
at 
org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1134)
at 
org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:187)
at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:126)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:328)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:316)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:75)
at 
org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:162)
at 
org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:159)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:105)
at 
org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:193)
at 
org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:180)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.j

Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #7002:
URL: https://github.com/apache/hbase/pull/7002#discussion_r2096947851


##
pom.xml:
##
@@ -637,7 +637,7 @@
 -->
 8.29
 3.1.0
-2.28.0
+2.38.0

Review Comment:
   Okay seems this was deliberately not bumped beyond 2.28.0 even though 
previous release of hbase thirdparty was having 2.36.0? 
   
   With 2.38.0 build fails with following error, need to revert this change.
   ```
   [INFO] -
   [ERROR] COMPILATION ERROR : 
   [INFO] -
   [ERROR] An unknown compilation problem occurred
   [INFO] 1 error
   [INFO] -
   compiler message file broken: key=compiler.misc.msg.bug arguments=11.0.23, 
{1}, {2}, {3}, {4}, {5}, {6}, {7}
   java.lang.UnsupportedClassVersionError: 
com/google/errorprone/ErrorProneJavacPlugin has been compiled by a more recent 
version of the Java Runtime (class file version 61.0), this version of the Java 
Runtime only recognizes class file versions up to 55.0
at java.base/java.lang.ClassLoader.defineClass1(Native Method)
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1022)
at 
java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174)
at 
java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:555)
at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:458)
at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:452)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:451)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:594)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:398)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.nextProviderClass(ServiceLoader.java:1210)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1221)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1265)
at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1300)
at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1385)
at 
jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:210)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.prepareCompiler(JavacTaskImpl.java:199)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:101)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:147)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:100)
at 
jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:94)
at 
org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCompiler.java:126)
at 
org.codehaus.plexus.compiler.javac.JavacCompiler.performCompile(JavacCompiler.java:174)
at 
org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1134)
at 
org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:187)
at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:126)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:328)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:316)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:75)
at 
org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:162)
at 
org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:159)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:105)
at 
org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:193)
at 
org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:180)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/ja

Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


Apache-HBase commented on PR #7002:
URL: https://github.com/apache/hbase/pull/7002#issuecomment-2892867917

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 51s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  shelldocs  |   0m  1s |  |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
    _ branch-2 Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 20s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 22s |  |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   5m 58s |  |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   0m 47s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m  6s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m  5s |  |  the patch passed  |
   | -1 :x: |  compile  |   0m 17s | 
[/patch-compile-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/1/artifact/yetus-general-check/output/patch-compile-root.txt)
 |  root in the patch failed.  |
   | -0 :warning: |  javac  |   0m 17s | 
[/patch-compile-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/1/artifact/yetus-general-check/output/patch-compile-root.txt)
 |  root in the patch failed.  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  shellcheck  |   0m  1s |  |  No new issues.  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  hadoopcheck  |  18m 41s |  |  Patch does not cause any 
errors with Hadoop 2.10.2 or 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 46s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 46s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  39m  7s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/7002 |
   | Optional Tests | dupname asflicense javac codespell detsecrets xmllint 
hadoopcheck spotless compile shellcheck shelldocs |
   | uname | Linux 2055a04faa7f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / a37dd70f246657affeec77dad6ea6da4d993440a |
   | Default Java | Eclipse Adoptium-11.0.23+9 |
   | Max. process+thread count | 71 (vs. ulimit of 3) |
   | modules | C: hbase-build-configuration hbase-shaded 
hbase-shaded/hbase-shaded-check-invariants 
hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7002/1/console 
|
   | versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2096127762


##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   > No, I mean maven-shade-plugin 3.6.0 and byte-buddy 1.15.11 That 
combination handles anything up to Java 24.
   > 
   > But if maven-shade-plugin 3.6.0 solves all problems by itself, then we 
don't have to update byte-buddy now.
   
   Ah got it! Let's make byte-buddy change later, if that is fine. As you 
rightly pointed we currently are on 1.12.19, which maybe causes issue with Java 
24.
   
   ```
   [INFO] +- org.mockito:mockito-core:jar:4.11.0:test
   [INFO] |  +- net.bytebuddy:byte-buddy:jar:1.12.19:test
   [INFO] |  +- net.bytebuddy:byte-buddy-agent:jar:1.12.19:test
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2096127762


##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   > No, I mean maven-shade-plugin 3.6.0 and byte-buddy 1.15.11 That 
combination handles anything up to Java 24.
   > 
   > But if maven-shade-plugin 3.6.0 solves all problems by itself, then we 
don't have to update byte-buddy now.
   
   Ah got it! Let's make byte-buddy change later, if that is fine. As you 
rightly pointed we currently getting 1.12.19 transitively via mockito, which 
maybe causes issue with Java 24.
   
   ```
   [INFO] +- org.mockito:mockito-core:jar:4.11.0:test
   [INFO] |  +- net.bytebuddy:byte-buddy:jar:1.12.19:test
   [INFO] |  +- net.bytebuddy:byte-buddy-agent:jar:1.12.19:test
   
   ```



##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   > No, I mean maven-shade-plugin 3.6.0 and byte-buddy 1.15.11 That 
combination handles anything up to Java 24.
   > 
   > But if maven-shade-plugin 3.6.0 solves all problems by itself, then we 
don't have to update byte-buddy now.
   
   Ah got it! Let's make byte-buddy change later, if that is fine? As you 
rightly pointed we currently getting 1.12.19 transitively via mockito, which 
maybe causes issue with Java 24.
   
   ```
   [INFO] +- org.mockito:mockito-core:jar:4.11.0:test
   [INFO] |  +- net.bytebuddy:byte-buddy:jar:1.12.19:test
   [INFO] |  +- net.bytebuddy:byte-buddy-agent:jar:1.12.19:test
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2096127762


##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   > No, I mean maven-shade-plugin 3.6.0 and byte-buddy 1.15.11 That 
combination handles anything up to Java 24.
   > 
   > But if maven-shade-plugin 3.6.0 solves all problems by itself, then we 
don't have to update byte-buddy now.
   
   Ah got it! Let's make byte-buddy change later, if that is fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #7002:
URL: https://github.com/apache/hbase/pull/7002#discussion_r2096113215


##
pom.xml:
##
@@ -1586,6 +1586,17 @@
   test
 
   
+  

Review Comment:
   TODO: Drop before commit!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


stoty commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2096100211


##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   No, I mean maven-shade-plugin 3.6.0 and byte-buddy 1.15.11
   That combination handles anything up to Java 24.
   
   But if maven-shade-plugin 3.6.0 solves all problems by itself, then we don't 
have to update byte-buddy now.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


stoty commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2096102289


##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   It also enables mockito to work with Java 24.
   
   (Not that HBase supports Java 24 at the moment, but this works on my Hadoop 
Java 24 branch)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


stoty commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2096100211


##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   No, maven-shade-plugin 3.6.0 and byte-buddy 1.15.11
   That combination handles anything up to Java 24.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2096097021


##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   > Also let me raise backport of this PR for branch-2 for CI to run through!
   
   Raised https://github.com/apache/hbase/pull/7002
   
   > You just need to dependencyManage byte-buddy to to 1.15.11 to support up 
to JDK24 by maven-shade-plugin @NihalJain .
   
   Hey @stoty Do you mean I should downgrade back to older maven-shade-plugin 
and dependency manage the bytebuddy coming transitively via maven-shade-plugin 
in our pom? Any reason for preferring to not moving to latest 
maven-shade-plugin, if I got you correctly?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2096066312


##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   ```
   bash % jar -tf 2.17.2/jackson-core-2.17.2.jar
   META-INF/
   META-INF/MANIFEST.MF
   META-INF/FastDoubleParser-LICENSE
   META-INF/LICENSE
   META-INF/NOTICE
   META-INF/services/
   META-INF/services/com.fasterxml.jackson.core.JsonFactory
   com/
   com/fasterxml/
   com/fasterxml/jackson/
   com/fasterxml/jackson/core/
   com/fasterxml/jackson/core/Base64Variant$PaddingReadBehaviour.class
   com/fasterxml/jackson/core/Base64Variant.class
   com/fasterxml/jackson/core/Base64Variants.class
   com/fasterxml/jackson/core/ErrorReportConfiguration$Builder.class
   com/fasterxml/jackson/core/ErrorReportConfiguration.class
   com/fasterxml/jackson/core/FormatFeature.class
   com/fasterxml/jackson/core/FormatSchema.class
   com/fasterxml/jackson/core/JacksonException.class
   com/fasterxml/jackson/core/JsonEncoding.class
   com/fasterxml/jackson/core/JsonFactory$Feature.class
   com/fasterxml/jackson/core/JsonFactory.class
   com/fasterxml/jackson/core/JsonFactoryBuilder.class
   com/fasterxml/jackson/core/JsonGenerationException.class
   com/fasterxml/jackson/core/JsonGenerator$1.class
   com/fasterxml/jackson/core/JsonGenerator$Feature.class
   com/fasterxml/jackson/core/JsonGenerator.class
   com/fasterxml/jackson/core/JsonLocation.class
   com/fasterxml/jackson/core/JsonParseException.class
   com/fasterxml/jackson/core/JsonParser$Feature.class
   com/fasterxml/jackson/core/JsonParser$NumberType.class
   com/fasterxml/jackson/core/JsonParser$NumberTypeFP.class
   com/fasterxml/jackson/core/JsonParser.class
   com/fasterxml/jackson/core/JsonPointer$PointerParent.class
   com/fasterxml/jackson/core/JsonPointer$PointerSegment.class
   com/fasterxml/jackson/core/JsonPointer$Serialization.class
   com/fasterxml/jackson/core/JsonPointer.class
   com/fasterxml/jackson/core/JsonProcessingException.class
   com/fasterxml/jackson/core/JsonStreamContext.class
   com/fasterxml/jackson/core/JsonToken$1.class
   com/fasterxml/jackson/core/JsonToken.class
   com/fasterxml/jackson/core/JsonTokenId.class
   com/fasterxml/jackson/core/JsonpCharacterEscapes.class
   com/fasterxml/jackson/core/ObjectCodec.class
   com/fasterxml/jackson/core/PrettyPrinter.class
   com/fasterxml/jackson/core/SerializableString.class
   com/fasterxml/jackson/core/StreamReadCapability.class
   com/fasterxml/jackson/core/StreamReadConstraints$Builder.class
   com/fasterxml/jackson/core/StreamReadConstraints.class
   com/fasterxml/jackson/core/StreamReadFeature.class
   com/fasterxml/jackson/core/StreamWriteCapability.class
   com/fasterxml/jackson/core/StreamWriteConstraints$Builder.class
   com/fasterxml/jackson/core/StreamWriteConstraints.class
   com/fasterxml/jackson/core/StreamWriteFeature.class
   com/fasterxml/jackson/core/TSFBuilder.class
   com/fasterxml/jackson/core/TokenStreamFactory.class
   com/fasterxml/jackson/core/TreeCodec.class
   com/fasterxml/jackson/core/TreeNode.class
   com/fasterxml/jackson/core/Version.class
   com/fasterxml/jackson/core/Versioned.class
   com/fasterxml/jackson/core/async/
   com/fasterxml/jackson/core/async/ByteArrayFeeder.class
   com/fasterxml/jackson/core/async/ByteBufferFeeder.class
   com/fasterxml/jackson/core/async/NonBlockingInputFeeder.class
   com/fasterxml/jackson/core/async/package-info.class
   com/fasterxml/jackson/core/base/
   com/fasterxml/jackson/core/base/GeneratorBase.class
   com/fasterxml/jackson/core/base/ParserBase.class
   com/fasterxml/jackson/core/base/ParserMinimalBase.class
   com/fasterxml/jackson/core/base/package-info.class
   com/fasterxml/jackson/core/exc/
   com/fasterxml/jackson/core/exc/InputCoercionException.class
   com/fasterxml/jackson/core/exc/StreamConstraintsException.class
   com/fasterxml/jackson/core/exc/StreamReadException.class
   com/fasterxml/jackson/core/exc/StreamWriteException.class
   com/fasterxml/jackson/core/exc/package-info.class
   com/fasterxml/jackson/core/filter/
   com/fasterxml/jackson/core/filter/FilteringGeneratorDelegate.class
   com/fasterxml/jackson/core/filter/FilteringParserDelegate.class
   com/fasterxml/jackson/core/filter/JsonPointerBasedFilter.class
   com/fasterxml/jackson/core/filter/TokenFilter$Inclusion.class
   com/fasterxml/jackson/core/filter/TokenFilter.class
   com/fasterxml/jackson/core/filter/TokenFilterContext.class
   com/fasterxml/jackson/core/format/
   com/fasterxml/jackson/core/format/DataFormatDetector.class
   com/fasterxml/jackson/core/format/DataFormatMatcher.class
   com/fasterxml/jackson/core/format/InputAccessor$Std.class
   com/fasterxml/jackson/core/format/InputAccessor.class
   com/fasterxml/jackson/core/format/MatchStrength.class
   com/fasterxml/jackson/core/format/package-info.class
   com/faste

Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2096066312


##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   ```
   bash % jar -tf 2.17.2/jackson-core-2.17.2.jar
   META-INF/
   META-INF/MANIFEST.MF
   META-INF/FastDoubleParser-LICENSE
   META-INF/LICENSE
   META-INF/NOTICE
   META-INF/services/
   META-INF/services/com.fasterxml.jackson.core.JsonFactory
   com/
   com/fasterxml/
   com/fasterxml/jackson/
   com/fasterxml/jackson/core/
   com/fasterxml/jackson/core/Base64Variant$PaddingReadBehaviour.class
   com/fasterxml/jackson/core/Base64Variant.class
   com/fasterxml/jackson/core/Base64Variants.class
   com/fasterxml/jackson/core/ErrorReportConfiguration$Builder.class
   com/fasterxml/jackson/core/ErrorReportConfiguration.class
   com/fasterxml/jackson/core/FormatFeature.class
   com/fasterxml/jackson/core/FormatSchema.class
   com/fasterxml/jackson/core/JacksonException.class
   com/fasterxml/jackson/core/JsonEncoding.class
   com/fasterxml/jackson/core/JsonFactory$Feature.class
   com/fasterxml/jackson/core/JsonFactory.class
   com/fasterxml/jackson/core/JsonFactoryBuilder.class
   com/fasterxml/jackson/core/JsonGenerationException.class
   com/fasterxml/jackson/core/JsonGenerator$1.class
   com/fasterxml/jackson/core/JsonGenerator$Feature.class
   com/fasterxml/jackson/core/JsonGenerator.class
   com/fasterxml/jackson/core/JsonLocation.class
   com/fasterxml/jackson/core/JsonParseException.class
   com/fasterxml/jackson/core/JsonParser$Feature.class
   com/fasterxml/jackson/core/JsonParser$NumberType.class
   com/fasterxml/jackson/core/JsonParser$NumberTypeFP.class
   com/fasterxml/jackson/core/JsonParser.class
   com/fasterxml/jackson/core/JsonPointer$PointerParent.class
   com/fasterxml/jackson/core/JsonPointer$PointerSegment.class
   com/fasterxml/jackson/core/JsonPointer$Serialization.class
   com/fasterxml/jackson/core/JsonPointer.class
   com/fasterxml/jackson/core/JsonProcessingException.class
   com/fasterxml/jackson/core/JsonStreamContext.class
   com/fasterxml/jackson/core/JsonToken$1.class
   com/fasterxml/jackson/core/JsonToken.class
   com/fasterxml/jackson/core/JsonTokenId.class
   com/fasterxml/jackson/core/JsonpCharacterEscapes.class
   com/fasterxml/jackson/core/ObjectCodec.class
   com/fasterxml/jackson/core/PrettyPrinter.class
   com/fasterxml/jackson/core/SerializableString.class
   com/fasterxml/jackson/core/StreamReadCapability.class
   com/fasterxml/jackson/core/StreamReadConstraints$Builder.class
   com/fasterxml/jackson/core/StreamReadConstraints.class
   com/fasterxml/jackson/core/StreamReadFeature.class
   com/fasterxml/jackson/core/StreamWriteCapability.class
   com/fasterxml/jackson/core/StreamWriteConstraints$Builder.class
   com/fasterxml/jackson/core/StreamWriteConstraints.class
   com/fasterxml/jackson/core/StreamWriteFeature.class
   com/fasterxml/jackson/core/TSFBuilder.class
   com/fasterxml/jackson/core/TokenStreamFactory.class
   com/fasterxml/jackson/core/TreeCodec.class
   com/fasterxml/jackson/core/TreeNode.class
   com/fasterxml/jackson/core/Version.class
   com/fasterxml/jackson/core/Versioned.class
   com/fasterxml/jackson/core/async/
   com/fasterxml/jackson/core/async/ByteArrayFeeder.class
   com/fasterxml/jackson/core/async/ByteBufferFeeder.class
   com/fasterxml/jackson/core/async/NonBlockingInputFeeder.class
   com/fasterxml/jackson/core/async/package-info.class
   com/fasterxml/jackson/core/base/
   com/fasterxml/jackson/core/base/GeneratorBase.class
   com/fasterxml/jackson/core/base/ParserBase.class
   com/fasterxml/jackson/core/base/ParserMinimalBase.class
   com/fasterxml/jackson/core/base/package-info.class
   com/fasterxml/jackson/core/exc/
   com/fasterxml/jackson/core/exc/InputCoercionException.class
   com/fasterxml/jackson/core/exc/StreamConstraintsException.class
   com/fasterxml/jackson/core/exc/StreamReadException.class
   com/fasterxml/jackson/core/exc/StreamWriteException.class
   com/fasterxml/jackson/core/exc/package-info.class
   com/fasterxml/jackson/core/filter/
   com/fasterxml/jackson/core/filter/FilteringGeneratorDelegate.class
   com/fasterxml/jackson/core/filter/FilteringParserDelegate.class
   com/fasterxml/jackson/core/filter/JsonPointerBasedFilter.class
   com/fasterxml/jackson/core/filter/TokenFilter$Inclusion.class
   com/fasterxml/jackson/core/filter/TokenFilter.class
   com/fasterxml/jackson/core/filter/TokenFilterContext.class
   com/fasterxml/jackson/core/format/
   com/fasterxml/jackson/core/format/DataFormatDetector.class
   com/fasterxml/jackson/core/format/DataFormatMatcher.class
   com/fasterxml/jackson/core/format/InputAccessor$Std.class
   com/fasterxml/jackson/core/format/InputAccessor.class
   com/fasterxml/jackson/core/format/MatchStrength.class
   com/fasterxml/jackson/core/format/package-info.class
   com/faste

Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


stoty commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2096058530


##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   You just need to dependencyManage byte-buddy to to 1.15.11 to support up to 
JDK24 by maven-shade-plugin @NihalJain .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


stoty commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2096058530


##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   You just need to dependencyManage byte-buddy to to 1.15.11 to support up to 
JDK24 for maven-shade-plugin @NihalJain .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


stoty commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2096062080


##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   Not that shade-plugin correctly shades the JVM dependent classes, but at 
least it won't fail.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2096046609


##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   > I had checked, previous version were also bringing in similar jdk21 files, 
which maven was able to shade and hence was not failing.  i dont think we need 
to handle these new files.
   
   Let me double check, not sure again! Also let me raise backport of this PR 
for branch-2 for CI to run through!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2096027216


##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   Jackson added support for java 22 and hence these new files are coming in 
which maven fails to shade, but it still supports java 8: 
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.19
   
   I had checked, previous version were also bringing in similar jdk21 files, 
which maven was able to shade and hence was not failing.  i dont think we need 
to handle these new files.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


NihalJain commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2096027216


##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   Jackson added support for java 22 and hence these new files are coming in 
which maven fails to shade, but it still supports java 8: 
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.19
   
   I had checked, previous version were also bringing in similar jdk21 files, 
which maven was able go shade and hence was not failing.  i dont think we need 
to handle these new files.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-19 Thread via GitHub


ndimiduk commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2095984451


##
hbase-shaded/pom.xml:
##
@@ -90,7 +90,7 @@
 
   org.apache.maven.plugins
   maven-shade-plugin
-  3.5.1
+  3.6.0

Review Comment:
   Major class version 66 corresponds to JDK22. We're not ready to adopt that 
version of the JDK yet. So then we cannot upgrade to jackson-core-2.19.0 ? Or 
do we need to use a classifier or some other build trick to limit which jars 
are pulled in?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-16 Thread via GitHub


Apache-HBase commented on PR #6993:
URL: https://github.com/apache/hbase/pull/6993#issuecomment-2887867112

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 41s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --author-ignore-list 
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
    _ Prechecks _ |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m  3s |  |  master passed  |
   | +1 :green_heart: |  compile  |   3m  6s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   4m 16s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   7m 37s |  |  branch has no errors when 
building our shaded downstream artifacts.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   1m  6s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 14s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m 13s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m 13s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   4m  2s |  |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   7m 34s |  |  patch has no errors when 
building our shaded downstream artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  | 291m 31s |  |  root in the patch passed.  |
   |  |   | 338m 51s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6993 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux ae5032d38b9e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 71e9142375c610665c41f30cdc097f40c9d4f600 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/4/testReport/
 |
   | Max. process+thread count | 8318 (vs. ulimit of 3) |
   | modules | C: hbase-build-configuration hbase-examples hbase-shaded 
hbase-shaded/hbase-shaded-check-invariants 
hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/4/console 
|
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-16 Thread via GitHub


Apache-HBase commented on PR #6993:
URL: https://github.com/apache/hbase/pull/6993#issuecomment-2887522861

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 51s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  shelldocs  |   0m  0s |  |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
    _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 21s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 23s |  |  master passed  |
   | +1 :green_heart: |  compile  |  10m 41s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 53s |  |  branch has no errors when 
running spotless:check.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 54s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 23s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  11m 10s |  |  the patch passed  |
   | -0 :warning: |  javac  |  11m 10s | 
[/results-compile-javac-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/4/artifact/yetus-general-check/output/results-compile-javac-root.txt)
 |  root generated 490 new + 1248 unchanged - 24 fixed = 1738 total (was 1272)  
|
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  shellcheck  |   0m  2s |  |  No new issues.  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  hadoopcheck  |  16m 55s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   1m 20s |  |  patch has no errors when 
running spotless:check.  |
    _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   1m 49s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  63m 25s |  |  |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/4/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6993 |
   | Optional Tests | dupname asflicense javac codespell detsecrets xmllint 
hadoopcheck spotless compile shellcheck shelldocs |
   | uname | Linux c4b7ec162c4c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 71e9142375c610665c41f30cdc097f40c9d4f600 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 190 (vs. ulimit of 3) |
   | modules | C: hbase-build-configuration hbase-examples hbase-shaded 
hbase-shaded/hbase-shaded-check-invariants 
hbase-shaded/hbase-shaded-with-hadoop-check-invariants . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6993/4/console 
|
   | versions | git=2.34.1 maven=3.9.8 shellcheck=0.8.0 xmllint=20913 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] HBASE-29317 Bump hbase-thirdparty to 4.1.11 [hbase]

2025-05-16 Thread via GitHub


NihalJain commented on PR #6993:
URL: https://github.com/apache/hbase/pull/6993#issuecomment-2887410184

   Ah protobuf change was missing, re-run with 
https://repository.apache.org/content/repositories/snapshots/org/apache/hbase/thirdparty/hbase-thirdparty/4.1.11-SNAPSHOT/hbase-thirdparty-4.1.11-20250516.182246-5.pom


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]