Re: [PR] HBASE-29356 Incorrect split behavior when region information is missing [hbase]
Apache-HBase commented on PR #7035:
URL: https://github.com/apache/hbase/pull/7035#issuecomment-2936009997
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 28s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 17s | | master passed |
| +1 :green_heart: | compile | 0m 59s | | master passed |
| +1 :green_heart: | javadoc | 0m 28s | | master passed |
| +1 :green_heart: | shadedjars | 6m 8s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 12s | | the patch passed |
| +1 :green_heart: | compile | 0m 58s | | the patch passed |
| +1 :green_heart: | javac | 0m 58s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 27s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 2s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 211m 11s | | hbase-server in the patch
passed. |
| | | 238m 1s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7035 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux b462523c9ea5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b1dd4625137b6cb77fe397194b097bf58ac36c2d |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/3/testReport/
|
| Max. process+thread count | 5374 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/3/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29356 Incorrect split behavior when region information is missing [hbase]
Apache-HBase commented on PR #7035:
URL: https://github.com/apache/hbase/pull/7035#issuecomment-2935016050
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 43s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 6s | | master passed |
| +1 :green_heart: | compile | 5m 1s | | master passed |
| +1 :green_heart: | checkstyle | 0m 48s | | master passed |
| +1 :green_heart: | spotbugs | 2m 20s | | master passed |
| +1 :green_heart: | spotless | 1m 6s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 31s | | the patch passed |
| +1 :green_heart: | compile | 4m 21s | | the patch passed |
| +1 :green_heart: | javac | 4m 21s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 0s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 30s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 15m 51s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 1m 7s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 15s | | The patch does not
generate ASF License warnings. |
| | | 55m 7s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/3/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7035 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 8d206b3bdead 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b1dd4625137b6cb77fe397194b097bf58ac36c2d |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 83 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/3/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29356 Incorrect split behavior when region information is missing [hbase]
qqvpp commented on code in PR #7035:
URL: https://github.com/apache/hbase/pull/7035#discussion_r2123551703
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java:
##
@@ -322,14 +322,27 @@ private double getAverageRegionSizeMb(final
List tableRegions,
avgRegionSize = targetRegionSize;
} else {
final int regionCount = tableRegions.size();
- final long totalSizeMb =
tableRegions.stream().mapToLong(this::getRegionSizeMB).sum();
+ // Count of regions whose size is known
+ int regionCountKnownSize = 0;
+ long totalSizeMb = 0;
+ for (RegionInfo regionInfo : tableRegions) {
+long regionSize = getRegionSizeMB(regionInfo);
+if (regionSize != -1) {
+ totalSizeMb += regionSize;
+ regionCountKnownSize++;
+}
+ }
if (targetRegionCount > 0) {
-avgRegionSize = totalSizeMb / (double) targetRegionCount;
+avgRegionSize =
+ totalSizeMb / (double) targetRegionCount - (regionCount -
regionCountKnownSize);
} else {
-avgRegionSize = totalSizeMb / (double) regionCount;
+avgRegionSize = totalSizeMb / (double) regionCountKnownSize;
Review Comment:
I added the condition, including the test modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29356 Incorrect split behavior when region information is missing [hbase]
qqvpp commented on code in PR #7035:
URL: https://github.com/apache/hbase/pull/7035#discussion_r2123547691
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java:
##
@@ -322,14 +322,27 @@ private double getAverageRegionSizeMb(final
List tableRegions,
avgRegionSize = targetRegionSize;
} else {
final int regionCount = tableRegions.size();
- final long totalSizeMb =
tableRegions.stream().mapToLong(this::getRegionSizeMB).sum();
+ // Count of regions whose size is known
+ int regionCountKnownSize = 0;
+ long totalSizeMb = 0;
+ for (RegionInfo regionInfo : tableRegions) {
+long regionSize = getRegionSizeMB(regionInfo);
+if (regionSize != -1) {
+ totalSizeMb += regionSize;
+ regionCountKnownSize++;
+}
+ }
if (targetRegionCount > 0) {
-avgRegionSize = totalSizeMb / (double) targetRegionCount;
+avgRegionSize =
+ totalSizeMb / (double) targetRegionCount - (regionCount -
regionCountKnownSize);
Review Comment:
I added a condition to verify the denominator and a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29356 Incorrect split behavior when region information is missing [hbase]
ndimiduk commented on code in PR #7035:
URL: https://github.com/apache/hbase/pull/7035#discussion_r2121153914
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java:
##
@@ -322,14 +322,27 @@ private double getAverageRegionSizeMb(final
List tableRegions,
avgRegionSize = targetRegionSize;
} else {
final int regionCount = tableRegions.size();
- final long totalSizeMb =
tableRegions.stream().mapToLong(this::getRegionSizeMB).sum();
+ // Count of regions whose size is known
+ int regionCountKnownSize = 0;
+ long totalSizeMb = 0;
+ for (RegionInfo regionInfo : tableRegions) {
+long regionSize = getRegionSizeMB(regionInfo);
+if (regionSize != -1) {
+ totalSizeMb += regionSize;
+ regionCountKnownSize++;
+}
+ }
if (targetRegionCount > 0) {
-avgRegionSize = totalSizeMb / (double) targetRegionCount;
+avgRegionSize =
+ totalSizeMb / (double) targetRegionCount - (regionCount -
regionCountKnownSize);
} else {
-avgRegionSize = totalSizeMb / (double) regionCount;
+avgRegionSize = totalSizeMb / (double) regionCountKnownSize;
Review Comment:
I think that you also need to protect against a 0 value here, in the same
way.
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java:
##
@@ -322,14 +322,27 @@ private double getAverageRegionSizeMb(final
List tableRegions,
avgRegionSize = targetRegionSize;
} else {
final int regionCount = tableRegions.size();
- final long totalSizeMb =
tableRegions.stream().mapToLong(this::getRegionSizeMB).sum();
+ // Count of regions whose size is known
+ int regionCountKnownSize = 0;
+ long totalSizeMb = 0;
+ for (RegionInfo regionInfo : tableRegions) {
+long regionSize = getRegionSizeMB(regionInfo);
+if (regionSize != -1) {
+ totalSizeMb += regionSize;
+ regionCountKnownSize++;
+}
+ }
if (targetRegionCount > 0) {
-avgRegionSize = totalSizeMb / (double) targetRegionCount;
+avgRegionSize =
+ totalSizeMb / (double) targetRegionCount - (regionCount -
regionCountKnownSize);
Review Comment:
If you're going to adjust the denominator here, I think that you also need
to protect against a value <= 0. In that case, you can throw, like we do on
entry into the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29356 Incorrect split behavior when region information is missing [hbase]
ndimiduk commented on PR #7035: URL: https://github.com/apache/hbase/pull/7035#issuecomment-2930658059 Heya @qqvpp thanks for the contribution. Can you please create for yourself a Jira account? We use Jira for project tracking. https://selfserve.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29356 Incorrect split behavior when region information is missing [hbase]
Apache9 commented on PR #7035: URL: https://github.com/apache/hbase/pull/7035#issuecomment-2927333560 Ping @ndimiduk. Please take a look at this one? Seems reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29356 Incorrect split behavior when region information is missing [hbase]
Apache-HBase commented on PR #7035:
URL: https://github.com/apache/hbase/pull/7035#issuecomment-2911977627
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 36s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 29s | | master passed |
| +1 :green_heart: | compile | 1m 7s | | master passed |
| +1 :green_heart: | javadoc | 0m 35s | | master passed |
| +1 :green_heart: | shadedjars | 6m 58s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 56s | | the patch passed |
| +1 :green_heart: | compile | 1m 25s | | the patch passed |
| +1 :green_heart: | javac | 1m 25s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 47s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 47s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 309m 10s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 341m 1s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7035 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 243fcba9d83b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 09e52d7f5ca5fb2d7752ad3656c50d881d69417d |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/2/testReport/
|
| Max. process+thread count | 4412 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/2/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29356 Incorrect split behavior when region information is missing [hbase]
Apache-HBase commented on PR #7035:
URL: https://github.com/apache/hbase/pull/7035#issuecomment-2911158871
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 58s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 9s | | master passed |
| +1 :green_heart: | compile | 4m 29s | | master passed |
| +1 :green_heart: | checkstyle | 0m 50s | | master passed |
| +1 :green_heart: | spotbugs | 2m 11s | | master passed |
| +1 :green_heart: | spotless | 1m 11s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 20s | | the patch passed |
| +1 :green_heart: | compile | 4m 38s | | the patch passed |
| +1 :green_heart: | javac | 4m 38s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 58s | | the patch passed |
| +1 :green_heart: | spotbugs | 3m 10s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 18m 43s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 1m 11s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 16s | | The patch does not
generate ASF License warnings. |
| | | 59m 0s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7035 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 66887f21fdb4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 09e52d7f5ca5fb2d7752ad3656c50d881d69417d |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 84 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/2/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29356 Incorrect split behavior when region information is missing [hbase]
Apache-HBase commented on PR #7035:
URL: https://github.com/apache/hbase/pull/7035#issuecomment-2910690977
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 27s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 28s | | master passed |
| +1 :green_heart: | compile | 1m 4s | | master passed |
| +1 :green_heart: | javadoc | 0m 30s | | master passed |
| +1 :green_heart: | shadedjars | 6m 10s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 9s | | the patch passed |
| +1 :green_heart: | compile | 0m 58s | | the patch passed |
| +1 :green_heart: | javac | 0m 58s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 26s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 3s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 228m 32s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 257m 50s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7035 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 706ec79c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 467bd83fb59976e61cee8301187122dfeffc0d2b |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/1/testReport/
|
| Max. process+thread count | 5920 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/1/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29356 Incorrect split behavior when region information is missing [hbase]
Apache-HBase commented on PR #7035:
URL: https://github.com/apache/hbase/pull/7035#issuecomment-2910390216
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 34s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 53s | | master passed |
| +1 :green_heart: | compile | 3m 32s | | master passed |
| +1 :green_heart: | checkstyle | 0m 45s | | master passed |
| +1 :green_heart: | spotbugs | 1m 58s | | master passed |
| +1 :green_heart: | spotless | 1m 1s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 36s | | the patch passed |
| +1 :green_heart: | compile | 4m 12s | | the patch passed |
| +1 :green_heart: | javac | 4m 12s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 48s |
[/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/1/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt)
| hbase-server: The patch generated 8 new + 0 unchanged - 0 fixed = 8 total
(was 0) |
| +1 :green_heart: | spotbugs | 2m 16s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 13m 48s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| -1 :x: | spotless | 0m 52s | | patch has 65 errors when running
spotless:check, run spotless:apply to fix. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 16s | | The patch does not
generate ASF License warnings. |
| | | 46m 37s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7035 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 1e5a12103998 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 467bd83fb59976e61cee8301187122dfeffc0d2b |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| spotless |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/1/artifact/yetus-general-check/output/patch-spotless.txt
|
| Max. process+thread count | 84 (vs. ulimit of 3) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7035/1/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29356 Incorrect split behavior when region information is missing [hbase]
Copilot commented on code in PR #7035:
URL: https://github.com/apache/hbase/pull/7035#discussion_r2107423735
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java:
##
@@ -322,14 +322,24 @@ private double getAverageRegionSizeMb(final
List tableRegions,
avgRegionSize = targetRegionSize;
} else {
final int regionCount = tableRegions.size();
- final long totalSizeMb =
tableRegions.stream().mapToLong(this::getRegionSizeMB).sum();
+ // Count of regions whose size is known
+ int regionCountKnownSize = 0;
+ long totalSizeMb = 0;
+ for (RegionInfo regionInfo : tableRegions) {
+long regionSize = getRegionSizeMB(regionInfo);
+if(regionSize != -1) {
+ totalSizeMb += regionSize;
+ regionCountKnownSize++;
+}
+ }
if (targetRegionCount > 0) {
-avgRegionSize = totalSizeMb / (double) targetRegionCount;
+avgRegionSize = totalSizeMb / (double) targetRegionCount -
(regionCount - regionCountKnownSize);
Review Comment:
Subtracting (regionCount - regionCountKnownSize) after the division appears
to yield an incorrect average. Consider computing the average solely based on
the total known region sizes divided by regionCountKnownSize.
```suggestion
avgRegionSize = totalSizeMb / (double) regionCountKnownSize;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
