Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid merged PR #12: URL: https://github.com/apache/hbase-site/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3146664870 ## .htaccess: ## @@ -1,7 +1,15 @@ +# Redirect old HTML pages to new extensionless URLs +Redirect permanent /downloads.html /downloads +Redirect permanent /acid-semantics.html /acid-semantics +Redirect permanent /sponsors.html /sponsors +Redirect permanent /coc.html /code-of-conduct +Redirect permanent /export_control.html /export-control +Redirect permanent /poweredbyhbase.html /powered-by-hbase +Redirect permanent /old_news.html /news # Redirect replication URL to the right section of the book # Rule added 2015-1-12 -- can be removed in 6 months -Redirect permanent /replication.html /book.html#_cluster_replication +Redirect permanent /replication.html https://hbase.apache.org/docs/operational-management/cluster-replication Review Comment: Thanks, good point! 👍 Removed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3146667251 ## .htaccess: ## @@ -1,7 +1,15 @@ +# Redirect old HTML pages to new extensionless URLs +Redirect permanent /downloads.html /downloads +Redirect permanent /acid-semantics.html /acid-semantics +Redirect permanent /sponsors.html /sponsors +Redirect permanent /coc.html /code-of-conduct +Redirect permanent /export_control.html /export-control +Redirect permanent /poweredbyhbase.html /powered-by-hbase +Redirect permanent /old_news.html /news # Redirect replication URL to the right section of the book # Rule added 2015-1-12 -- can be removed in 6 months -Redirect permanent /replication.html /book.html#_cluster_replication +Redirect permanent /replication.html https://hbase.apache.org/docs/operational-management/cluster-replication Review Comment: Good catch, thanks, removed the host from the start of the URL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
petersomogyi commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3146283243 ## .htaccess: ## @@ -1,7 +1,15 @@ +# Redirect old HTML pages to new extensionless URLs +Redirect permanent /downloads.html /downloads +Redirect permanent /acid-semantics.html /acid-semantics +Redirect permanent /sponsors.html /sponsors +Redirect permanent /coc.html /code-of-conduct +Redirect permanent /export_control.html /export-control +Redirect permanent /poweredbyhbase.html /powered-by-hbase +Redirect permanent /old_news.html /news # Redirect replication URL to the right section of the book # Rule added 2015-1-12 -- can be removed in 6 months -Redirect permanent /replication.html /book.html#_cluster_replication +Redirect permanent /replication.html https://hbase.apache.org/docs/operational-management/cluster-replication Review Comment: The comment above could be removed or updated. ## .htaccess: ## @@ -1,7 +1,15 @@ +# Redirect old HTML pages to new extensionless URLs +Redirect permanent /downloads.html /downloads +Redirect permanent /acid-semantics.html /acid-semantics +Redirect permanent /sponsors.html /sponsors +Redirect permanent /coc.html /code-of-conduct +Redirect permanent /export_control.html /export-control +Redirect permanent /poweredbyhbase.html /powered-by-hbase +Redirect permanent /old_news.html /news # Redirect replication URL to the right section of the book # Rule added 2015-1-12 -- can be removed in 6 months -Redirect permanent /replication.html /book.html#_cluster_replication +Redirect permanent /replication.html https://hbase.apache.org/docs/operational-management/cluster-replication Review Comment: Do we need the prefix for the new URL? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129143966 ## supportingprojects.html: ## Review Comment: I did not found this content in our new website but this looks quite outdated (e.g. Tephra is not maintained anymore, etc). Do you think we still need this to or can be deleted? If needed, we can add it to our new website. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129799363 ## .htaccess: ## @@ -1,7 +1,15 @@ +# Redirect old HTML pages to new extensionless URLs +Redirect permanent /downloads.html /downloads +Redirect permanent /acid-semantics.html /acid-semantics +Redirect permanent /sponsors.html /sponsors +Redirect permanent /coc.html /code-of-conduct +Redirect permanent /export_control.html /export-control +Redirect permanent /poweredbyhbase.html /powered-by-hbase +Redirect permanent /old_news.html /news Review Comment: Added these to try to redirect requests for old pages to new ones. I pushed these changes to https://hbase-beta.staged.apache.org/ you can try it out. Redirect seems to work. ```sh $ for page in downloads.html acid-semantics.html sponsors.html export_control.html poweredbyhbase.html old_news.html; do echo "=== $page ===" curl -sI "https://hbase-beta.staged.apache.org/$page"; | grep -E "^HTTP|^Location" done === downloads.html === HTTP/1.1 301 Moved Permanently Location: https://hbase-beta.staged.apache.org/downloads === acid-semantics.html === HTTP/1.1 301 Moved Permanently Location: https://hbase-beta.staged.apache.org/acid-semantics === sponsors.html === HTTP/1.1 301 Moved Permanently Location: https://hbase-beta.staged.apache.org/sponsors === export_control.html === HTTP/1.1 301 Moved Permanently Location: https://hbase-beta.staged.apache.org/export-control === poweredbyhbase.html === HTTP/1.1 301 Moved Permanently Location: https://hbase-beta.staged.apache.org/powered-by-hbase === old_news.html === HTTP/1.1 301 Moved Permanently Location: https://hbase-beta.staged.apache.org/news ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129799363 ## .htaccess: ## @@ -1,7 +1,15 @@ +# Redirect old HTML pages to new extensionless URLs +Redirect permanent /downloads.html /downloads +Redirect permanent /acid-semantics.html /acid-semantics +Redirect permanent /sponsors.html /sponsors +Redirect permanent /coc.html /code-of-conduct +Redirect permanent /export_control.html /export-control +Redirect permanent /poweredbyhbase.html /powered-by-hbase +Redirect permanent /old_news.html /news Review Comment: Added these to try to redirect requests for old pages to new ones. I pushed these changes to https://hbase-beta.staged.apache.org/ you can try it out. Redirect seems to work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12:
URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129523656
##
.htaccess:
##
@@ -1,7 +1,18 @@
+# Redirect old HTML pages to new extensionless URLs
+Redirect permanent /coc.html /code-of-conduct
+Redirect permanent /export_control.html /export-control
+Redirect permanent /poweredbyhbase.html /powered-by-hbase
+Redirect permanent /old_news.html /news
+
+# For downloads, acid-semantics, sponsors pages
+RewriteEngine On
+RewriteCond %{REQUEST_FILENAME} !-f
+RewriteRule ^(.+)\.html$ /$1 [R=301,L]
Review Comment:
Try to redirect requests for old pages to new ones:
- 4 explicit redirects for renamed pages: coc.html → /code-of-conduct,
export_control.html → /export-control, poweredbyhbase.html → /powered-by-hbase,
old_news.html → /news
- 1 generic rewrite rule that handles the 2 same-name pages
(acid-semantics.html → /acid-semantics, downloads.html → /downloads,
sponsors.html → /sponsors) - it only fires when the .html file no longer exists
on disk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12:
URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129523656
##
.htaccess:
##
@@ -1,7 +1,18 @@
+# Redirect old HTML pages to new extensionless URLs
+Redirect permanent /coc.html /code-of-conduct
+Redirect permanent /export_control.html /export-control
+Redirect permanent /poweredbyhbase.html /powered-by-hbase
+Redirect permanent /old_news.html /news
+
+# For downloads, acid-semantics, sponsors pages
+RewriteEngine On
+RewriteCond %{REQUEST_FILENAME} !-f
+RewriteRule ^(.+)\.html$ /$1 [R=301,L]
Review Comment:
Try to redirect requests for old pages to new ones:
- 4 explicit redirects for renamed pages: coc.html → /code-of-conduct,
export_control.html → /export-control, poweredbyhbase.html → /powered-by-hbase,
old_news.html → /news
- 1 generic rewrite rule that handles the 2 same-name pages
(acid-semantics.html → /acid-semantics, downloads.html → /downloads,
sponsors.html → /sponsors) - it only fires when the .html file no longer exists
on disk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12:
URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129523656
##
.htaccess:
##
@@ -1,7 +1,18 @@
+# Redirect old HTML pages to new extensionless URLs
+Redirect permanent /coc.html /code-of-conduct
+Redirect permanent /export_control.html /export-control
+Redirect permanent /poweredbyhbase.html /powered-by-hbase
+Redirect permanent /old_news.html /news
+
+# For downloads, acid-semantics, sponsors pages
+RewriteEngine On
+RewriteCond %{REQUEST_FILENAME} !-f
+RewriteRule ^(.+)\.html$ /$1 [R=301,L]
Review Comment:
- 4 explicit redirects for renamed pages: coc.html → /code-of-conduct,
export_control.html → /export-control, poweredbyhbase.html → /powered-by-hbase,
old_news.html → /news
- 1 generic rewrite rule that handles the 2 same-name pages
(acid-semantics.html → /acid-semantics, downloads.html → /downloads,
sponsors.html → /sponsors) - it only fires when the .html file no longer exists
on disk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129143966 ## supportingprojects.html: ## Review Comment: I did not found this content in our new website but this looks quite outdated (e.g. Tephra is not maintained anymore, etc). Do you think we still need this to be added in our new website? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129131973 ## export_control.html: ## Review Comment: Same content is available in our new website. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129137139 ## sponsors.html: ## Review Comment: Same content is available in our new website. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129135790 ## poweredbyhbase.html: ## Review Comment: Same content is available in our new website. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129129256 ## documentation-1.4.html: ## Review Comment: These documentation-x.y.html pages were a collection of links for the Ref Guide, Ref Guide PDF and API docs. We needed this because of a Maven skin limitation. These are not needed anymore. ## downloads.html: ## Review Comment: Same content is available in our new website. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129117278 ## bulk-loads.html: ## Review Comment: This was basically a link to http://hbase.apache.org/book.html#arch.bulk.load, we have the link in our new website to https://hbase.apache.org/docs/architecture/bulk-loading. ## coc.html: ## Review Comment: Same content is available in our new website. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129111943 ## acid-semantics.html: ## Review Comment: Same content is available in our new website. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129109834 ## pseudo-distributed.html: ## Review Comment: This was only a link to RefGuide: http://hbase.apache.org/book.html#distributed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129102731 ## old_news.html: ## Review Comment: We have all these also on the News page on our new website. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129085850 ## metrics.html: ## Review Comment: Instead of this page we have a link to RefGuide (https://hbase.apache.org/docs/operational-management/metrics-and-monitoring) in our new website. Do you think we still need this page? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129080284 ## integration.html: ## Review Comment: This page does not exist in our new site and this seems to have very outdated content. Do you think we still need this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30113 Clean up old HTML pages from our website [hbase-site]
PDavid commented on code in PR #12: URL: https://github.com/apache/hbase-site/pull/12#discussion_r3129074604 ## cygwin.html: ## Review Comment: This page does not exist in our new site. Do you think we still need this content? If yes we can add it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
