Re: [PR] HBASE-30123 Upgrade hbase-server to use junit5 Part13 [hbase]
Apache9 merged PR #8153: URL: https://github.com/apache/hbase/pull/8153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30123 Upgrade hbase-server to use junit5 Part13 [hbase]
Apache9 commented on PR #8153: URL: https://github.com/apache/hbase/pull/8153#issuecomment-4344983852 And I also confirmed that, before and after the PR, there are both 705 tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30123 Upgrade hbase-server to use junit5 Part13 [hbase]
Apache9 commented on PR #8153: URL: https://github.com/apache/hbase/pull/8153#issuecomment-4344974159 #8163 has been merged for fixing the TestFromClientSide3 problem. All checks here are green. Ping @liuxiaocs7 . I used opencode to assist the upgrading so I added .opencode to gitignore. AI has helped doing most of the boiler plate changes, like replacing Category with Tag, etc. TestPrefetch was upgraded manually by me since it contains special opentelemetry rule. TestHFileBlockHeaderCorruption is too special and will be upgraded in #8165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30123 Upgrade hbase-server to use junit5 Part13 [hbase]
Apache9 commented on PR #8153: URL: https://github.com/apache/hbase/pull/8153#issuecomment-4340264178 > Seems `TestFromClientSide3WithCoprocessor` and `TestFromClientSide3` have become unstable in our CI now They take too much time to finish... I downloaded the zip file and checked the log, there is no failure but TestFromClientSide3 take 760s to finish and our timeout limit is 780s... Let me split them... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30123 Upgrade hbase-server to use junit5 Part13 [hbase]
liuxiaocs7 commented on PR #8153: URL: https://github.com/apache/hbase/pull/8153#issuecomment-4334871220 Seems `TestFromClientSide3WithCoprocessor` and `TestFromClientSide3` have become unstable now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-30123 Upgrade hbase-server to use junit5 Part13 [hbase]
Copilot commented on code in PR #8153:
URL: https://github.com/apache/hbase/pull/8153#discussion_r3153729624
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockIOUtils.java:
##
@@ -467,25 +457,21 @@ public void testPositionalReadPrematureEOF() throws
IOException {
when(in.read(position, buf, bufOffset, totalLen)).thenReturn(9);
when(in.read(position, buf, bufOffset, totalLen)).thenReturn(-1);
Review Comment:
In this test, the same Mockito stubbing is applied twice for
`in.read(position, buf, bufOffset, totalLen)`. The second
`when(...).thenReturn(-1)` overrides the first, so the mock will not return `9`
then `-1` as intended, and the test no longer exercises the
partial-read-then-EOF path. Use sequential stubbing (e.g., a single
`thenReturn(9, -1)` or chained `thenReturn(9).thenReturn(-1)`) to model the
intended behavior.
```suggestion
when(in.read(position, buf, bufOffset, totalLen)).thenReturn(9, -1);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
