Re: [PR] docs: correct non-existent bomClassifier element in What's new in Maven 4 [maven-site]
elharo merged PR #1630: URL: https://github.com/apache/maven-site/pull/1630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs: correct non-existent bomClassifier element in What's new in Maven 4 [maven-site]
arimu1 commented on code in PR #1630: URL: https://github.com/apache/maven-site/pull/1630#discussion_r3755107402 ## content/markdown/whatsnewinmaven4.md: ## @@ -152,9 +152,29 @@ the [live coding by Maven maintainer Karl Heinz Marbaise at IntelliJ IDEA Conf 2 **Note**: With Maven 4, it's also possible to exclude dependencies that are declared by BOMs using the existing `` element. -Also note that in Maven 4, importing BOMs with a classifier is now possible. -Therefore, the Maven team suggests that project BOMs should be generated as classified artifacts, using the -`` element. +Also note that in Maven 4 (model version 4.1.0 and later), importing BOMs with a classifier is possible by using the +standard `` element on the import dependency: + +```xml + + + + org.example + example + 1.0.0 + pom + bom + import + + + +``` + +There is no dedicated `` element in the POM model or XSD. Review Comment: Thanks @elharo — good call. Rewrote that note to state only the correct behavior: classified BOM artifacts are attached with a classifier (e.g. via a BOM-building plugin), and consumers import them with the standard `` element as in the example above. Removed the “what doesn’t exist” phrasing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs: correct non-existent bomClassifier element in What's new in Maven 4 [maven-site]
arimu1 commented on PR #1630: URL: https://github.com/apache/maven-site/pull/1630#issuecomment-5248766495 Addressed @elharo’s review: the BOM note now describes only how classified BOMs are produced and imported via standard ``, without saying what elements do not exist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs: correct non-existent bomClassifier element in What's new in Maven 4 [maven-site]
elharo commented on code in PR #1630: URL: https://github.com/apache/maven-site/pull/1630#discussion_r3743626561 ## content/markdown/whatsnewinmaven4.md: ## @@ -152,9 +152,29 @@ the [live coding by Maven maintainer Karl Heinz Marbaise at IntelliJ IDEA Conf 2 **Note**: With Maven 4, it's also possible to exclude dependencies that are declared by BOMs using the existing `` element. -Also note that in Maven 4, importing BOMs with a classifier is now possible. -Therefore, the Maven team suggests that project BOMs should be generated as classified artifacts, using the -`` element. +Also note that in Maven 4 (model version 4.1.0 and later), importing BOMs with a classifier is possible by using the +standard `` element on the import dependency: + +```xml + + + + org.example + example + 1.0.0 + pom + bom + import + + + +``` + +There is no dedicated `` element in the POM model or XSD. Review Comment: don't tell us what doesn't exist. There's an infinite number of things that don't exist -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs: correct non-existent bomClassifier element in What's new in Maven 4 [maven-site]
elharo commented on code in PR #1630: URL: https://github.com/apache/maven-site/pull/1630#discussion_r3743626561 ## content/markdown/whatsnewinmaven4.md: ## @@ -152,9 +152,29 @@ the [live coding by Maven maintainer Karl Heinz Marbaise at IntelliJ IDEA Conf 2 **Note**: With Maven 4, it's also possible to exclude dependencies that are declared by BOMs using the existing `` element. -Also note that in Maven 4, importing BOMs with a classifier is now possible. -Therefore, the Maven team suggests that project BOMs should be generated as classified artifacts, using the -`` element. +Also note that in Maven 4 (model version 4.1.0 and later), importing BOMs with a classifier is possible by using the +standard `` element on the import dependency: + +```xml + + + + org.example + example + 1.0.0 + pom + bom + import + + + +``` + +There is no dedicated `` element in the POM model or XSD. Review Comment: don't tell us what doesn;' exist. There's an infinite number of things that don't exist -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] docs: correct non-existent bomClassifier element in What's new in Maven 4 [maven-site]
arimu1 opened a new pull request, #1630: URL: https://github.com/apache/maven-site/pull/1630 ## Summary Fixes [apache/maven#12661](https://github.com/apache/maven/issues/12661). The [What's new in Maven 4](https://maven.apache.org/whatsnewinmaven4.html#new-packaging-type-bom) page claimed that project BOMs should be generated using a `` element. That element does not exist in the Maven 4.1.0 model or XSD, and there is no example of how to use it. ### Investigation | Claim | Reality | |---|-| | `` POM element | **Does not exist** in `maven.mdo` / XSD 4.1.0 | | Import BOM with classifier | **Supported** for model 4.1.0+ via standard dependency `` (validator skips the "must be empty" rule when `is41OrBeyond`) | | Generating classified BOMs | Done by attaching an additional POM artifact with a classifier (e.g. plugin config such as `bom-builder3`'s `bomClassifier` parameter) — not a model element | This is a documentation correctness fix only (no model/XSD change). ### Changes - Replace the false `` reference with the real import syntax using `` - Add a short import example - Clarify that classified BOMs are attached artifacts, not a POM model element - Keep the existing guidance about importing only external (non-reactor) BOMs ## Testing - Docs-only change; no code build required - Reviewed against `DefaultModelValidator` (classifier allowed for import scope when model ≥ 4.1.0) and confirmed no `bomClassifier` field in `api/maven-api-model` ## Checklist - [x] Addresses a single issue without unrelated changes - [x] Meaningful commit message - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
