[jira] [Commented] (MSOURCES-6) Sources plugin ignores resource includes/excludes
[ https://issues.apache.org/jira/browse/MSOURCES-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17959378#comment-17959378 ] Matthias Bünger commented on MSOURCES-6: This project has moved from Jira to GitHub Issues. This issue was migrated to [apache/maven-source-plugin#101|https://github.com/apache/maven-source-plugin/issues/101]. > Sources plugin ignores resource includes/excludes > - > > Key: MSOURCES-6 > URL: https://issues.apache.org/jira/browse/MSOURCES-6 > Project: Maven Source Plugin (Moved to GitHub Issues) > Issue Type: Bug >Affects Versions: 2.0.1 >Reporter: Matthew Beermann >Assignee: Stephane Nicoll >Priority: Critical > Fix For: 2.0.3 > > Attachments: maven-source-plugin-2.0.2-patches-take2.zip, > maven-source-plugin-2.0.2.patch, maven-sources-plugin-patches.zip, > maven-sources-plugin-patches_v1.1.zip, patch.txt > > > The sources plugin appears to ignore the and filters on > items. I discovered this because I have a project that needs to > package certain files that appear in the project root; e.g. > ., and then I certain files. > Trouble is, when the source plugin runs, it packages up EVERYTHING - > including the stuff in the "target" (output) directory! This leads to a > source attachment that's much too large. Worse, if you forget to clean > between builds, the size of the source jar will increase exponentially with > each build. > Checking out the source code at > http://svn.apache.org/viewvc/maven/plugins/trunk/maven-source-plugin/src/main/java/org/apache/maven/plugin/source/AbstractJarSourceMojo.java?view=markup, > I think the problem is in the addDirectories() method, which is simply > adding resource.getDirectory() and dropping the other information on the > floor. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] Commented: (MSOURCES-6) Sources plugin ignores resource includes/excludes
[ http://jira.codehaus.org/browse/MSOURCES-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_86761 ] Stephane Nicoll commented on MSOURCES-6: Almost done, I've found a regression in current version which generates the archive for POM packaging. > Sources plugin ignores resource includes/excludes > - > > Key: MSOURCES-6 > URL: http://jira.codehaus.org/browse/MSOURCES-6 > Project: Maven 2.x Sources Plugin > Issue Type: Bug >Affects Versions: 2.0.1 >Reporter: Matthew Beermann > Assigned To: Stephane Nicoll >Priority: Critical > Fix For: 2.0.3 > > Attachments: maven-source-plugin-2.0.2-patches-take2.zip, > maven-source-plugin-2.0.2.patch, maven-sources-plugin-patches.zip, > maven-sources-plugin-patches_v1.1.zip, patch.txt > > > The sources plugin appears to ignore the and filters on > items. I discovered this because I have a project that needs to > package certain files that appear in the project root; e.g. > ., and then I certain files. > Trouble is, when the source plugin runs, it packages up EVERYTHING - > including the stuff in the "target" (output) directory! This leads to a > source attachment that's much too large. Worse, if you forget to clean > between builds, the size of the source jar will increase exponentially with > each build. > Checking out the source code at > http://svn.apache.org/viewvc/maven/plugins/trunk/maven-source-plugin/src/main/java/org/apache/maven/plugin/source/AbstractJarSourceMojo.java?view=markup, > I think the problem is in the addDirectories() method, which is simply > adding resource.getDirectory() and dropping the other information on the > floor. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSOURCES-6) Sources plugin ignores resource includes/excludes
[ http://jira.codehaus.org/browse/MSOURCES-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_86758 ] Stephane Nicoll commented on MSOURCES-6: Oh, Jason renamed the Mojos so the patch will be a bit hard to apply. I am looking into it right now as I have another use case which might be interesting. > Sources plugin ignores resource includes/excludes > - > > Key: MSOURCES-6 > URL: http://jira.codehaus.org/browse/MSOURCES-6 > Project: Maven 2.x Sources Plugin > Issue Type: Bug >Affects Versions: 2.0.1 >Reporter: Matthew Beermann > Assigned To: Stephane Nicoll >Priority: Critical > Fix For: 2.0.3 > > Attachments: maven-source-plugin-2.0.2-patches-take2.zip, > maven-source-plugin-2.0.2.patch, maven-sources-plugin-patches.zip, > maven-sources-plugin-patches_v1.1.zip, patch.txt > > > The sources plugin appears to ignore the and filters on > items. I discovered this because I have a project that needs to > package certain files that appear in the project root; e.g. > ., and then I certain files. > Trouble is, when the source plugin runs, it packages up EVERYTHING - > including the stuff in the "target" (output) directory! This leads to a > source attachment that's much too large. Worse, if you forget to clean > between builds, the size of the source jar will increase exponentially with > each build. > Checking out the source code at > http://svn.apache.org/viewvc/maven/plugins/trunk/maven-source-plugin/src/main/java/org/apache/maven/plugin/source/AbstractJarSourceMojo.java?view=markup, > I think the problem is in the addDirectories() method, which is simply > adding resource.getDirectory() and dropping the other information on the > floor. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSOURCES-6) Sources plugin ignores resource includes/excludes
[ http://jira.codehaus.org/browse/MSOURCES-6?page=comments#action_83582 ] Richard van der Hoff commented on MSOURCES-6: - Gah there's supposed to be an extra file in there, which i missed off the patch: src/test/resources/unit/custom-configuration/src/main/resources/excluded-file.txt. Otherwise the modification to the unit test doesn't have any effect and everything still passes. > Sources plugin ignores resource includes/excludes > - > > Key: MSOURCES-6 > URL: http://jira.codehaus.org/browse/MSOURCES-6 > Project: Maven 2.x Sources Plugin > Issue Type: Bug >Affects Versions: 2.0.1 >Reporter: Matthew Beermann >Priority: Critical > Fix For: 2.0.2 > > Attachments: maven-source-plugin-2.0.2.patch, > maven-sources-plugin-patches.zip, maven-sources-plugin-patches_v1.1.zip, > patch.txt > > > The sources plugin appears to ignore the and filters on > items. I discovered this because I have a project that needs to > package certain files that appear in the project root; e.g. > ., and then I certain files. > Trouble is, when the source plugin runs, it packages up EVERYTHING - > including the stuff in the "target" (output) directory! This leads to a > source attachment that's much too large. Worse, if you forget to clean > between builds, the size of the source jar will increase exponentially with > each build. > Checking out the source code at > http://svn.apache.org/viewvc/maven/plugins/trunk/maven-source-plugin/src/main/java/org/apache/maven/plugin/source/AbstractJarSourceMojo.java?view=markup, > I think the problem is in the addDirectories() method, which is simply > adding resource.getDirectory() and dropping the other information on the > floor. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSOURCES-6) Sources plugin ignores resource includes/excludes
[ http://jira.codehaus.org/browse/MSOURCES-6?page=comments#action_70094 ] Carlos Sanchez commented on MSOURCES-6: --- A comment about the patch, to keep backwards comaptibility you can't remove non private methods, so you need to refactor your patch to keep old methods while adding the new ones you need, avoiding code duplication > Sources plugin ignores resource includes/excludes > - > > Key: MSOURCES-6 > URL: http://jira.codehaus.org/browse/MSOURCES-6 > Project: Maven 2.x Sources Plugin > Issue Type: Bug >Affects Versions: 2.0.1 >Reporter: Matthew Beermann >Priority: Critical > Fix For: 2.0.2 > > Attachments: maven-sources-plugin-patches.zip, patch.txt > > > The sources plugin appears to ignore the and filters on > items. I discovered this because I have a project that needs to > package certain files that appear in the project root; e.g. > ., and then I certain files. > Trouble is, when the source plugin runs, it packages up EVERYTHING - > including the stuff in the "target" (output) directory! This leads to a > source attachment that's much too large. Worse, if you forget to clean > between builds, the size of the source jar will increase exponentially with > each build. > Checking out the source code at > http://svn.apache.org/viewvc/maven/plugins/trunk/maven-source-plugin/src/main/java/org/apache/maven/plugin/source/AbstractJarSourceMojo.java?view=markup, > I think the problem is in the addDirectories() method, which is simply > adding resource.getDirectory() and dropping the other information on the > floor. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSOURCES-6) Sources plugin ignores resource includes/excludes
[ http://jira.codehaus.org/browse/MSOURCES-6?page=comments#action_69114 ] Micah Whitacre commented on MSOURCES-6: --- The issue seems to stem from the fact in the SourceBundler class, it uses the DEFAULT_INCLUDES member variable instead of the individually specified for all of the directories. I created a class called SourceDirectory which is supposed to represent both directories specified in the section and the . The information is pulled from POM in the AbstractJarSourceMojo and then it is available to the SourceBundler. I attached a zip file containing the patches I made to make this maven plugin work with that includes the root directory .. > Sources plugin ignores resource includes/excludes > - > > Key: MSOURCES-6 > URL: http://jira.codehaus.org/browse/MSOURCES-6 > Project: Maven 2.x Sources Plugin > Type: Bug > Versions: 2.0.1 > Reporter: Matthew Beermann > Priority: Critical > Fix For: 2.0.2 > Attachments: maven-sources-plugin-patches.zip, patch.txt > > > The sources plugin appears to ignore the and filters on > items. I discovered this because I have a project that needs to > package certain files that appear in the project root; e.g. > ., and then I certain files. > Trouble is, when the source plugin runs, it packages up EVERYTHING - > including the stuff in the "target" (output) directory! This leads to a > source attachment that's much too large. Worse, if you forget to clean > between builds, the size of the source jar will increase exponentially with > each build. > Checking out the source code at > http://svn.apache.org/viewvc/maven/plugins/trunk/maven-source-plugin/src/main/java/org/apache/maven/plugin/source/AbstractJarSourceMojo.java?view=markup, > I think the problem is in the addDirectories() method, which is simply > adding resource.getDirectory() and dropping the other information on the > floor. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
