Re: [I] [MWAR-26] Do not overwrite target unless source is modified [maven-war-plugin]
jira-importer commented on issue #209: URL: https://github.com/apache/maven-war-plugin/issues/209#issuecomment-2967852914 **[Andres March](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=dres1011)** commented This will be a significant patch, since FileUtils currently does all the copying. I will have a go at it and see if I can put something together. Is there any common apache or codehaus libraries that have this type of "copy only if modified" feature? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-26] Do not overwrite target unless source is modified [maven-war-plugin]
jira-importer commented on issue #209: URL: https://github.com/apache/maven-war-plugin/issues/209#issuecomment-2967852930 **[Ernesto S. Tolentino Jr.](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jtolentino)** commented Fixed code formatting in patch to Maven 2 standards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-26] Do not overwrite target unless source is modified [maven-war-plugin]
jira-importer commented on issue #209: URL: https://github.com/apache/maven-war-plugin/issues/209#issuecomment-2967852908 **[Brett Porter](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brettporter)** commented would be a good addition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-26] Do not overwrite target unless source is modified [maven-war-plugin]
jira-importer commented on issue #209: URL: https://github.com/apache/maven-war-plugin/issues/209#issuecomment-2967852945 **[Edwin Punzalan](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=elpunzalan)** commented This patch has been reverted in SVN. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-26] Do not overwrite target unless source is modified [maven-war-plugin]
jira-importer commented on issue #209: URL: https://github.com/apache/maven-war-plugin/issues/209#issuecomment-2967852925 **[Ernesto S. Tolentino Jr.](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jtolentino)** commented Uses methods that only copies when source files are newer than target files. This patch is dependent on PLX-205. Already submitted a patch for PLX-205. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-26] Do not overwrite target unless source is modified [maven-war-plugin]
jira-importer commented on issue #209: URL: https://github.com/apache/maven-war-plugin/issues/209#issuecomment-2967852941 **[Ernesto S. Tolentino Jr.](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jtolentino)** commented Maven 2.0.3 uses plexus-utils-1.1.jar in its lib. This overrides the version used in maven-war-plugin (which is version 1.2-SNAPSHOT) for this patch. Please revert until Maven 2 moves to version 1.2 of plexus-utils. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-26] Do not overwrite target unless source is modified [maven-war-plugin]
jira-importer commented on issue #209: URL: https://github.com/apache/maven-war-plugin/issues/209#issuecomment-2967852953 **[Ernesto S. Tolentino Jr.](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jtolentino)** commented Maven 2.0.3 was already voted on for release. That email was sent by John Casey to maven developers list, subject is [vote] Release Maven 2.0.3 (third RC). So the libraries used in that 2.0.3 won't have any more changes. There will still be a patch for maven-war-plugin in time for its 2.0 release though. Instead of having the code in plexus-utils, it will be in the war plugin. We'll just have to apply the first patch when maven changes the plexus-utils version that it uses to 1.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-26] Do not overwrite target unless source is modified [maven-war-plugin]
jira-importer commented on issue #209: URL: https://github.com/apache/maven-war-plugin/issues/209#issuecomment-2967852955 **[Ernesto S. Tolentino Jr.](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jtolentino)** commented Excludes files without updates when copying. The new methods referenced in this patch will be later changed to their plexus-utils equivalents once Maven 2 moves to 1.4 version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-26] Do not overwrite target unless source is modified [maven-war-plugin]
jira-importer commented on issue #209: URL: https://github.com/apache/maven-war-plugin/issues/209#issuecomment-2967852949 **[Andres March](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=dres1011)** commented Is it not possible to submit an issue for maven and get them to upgrade to 1.2. If not, will you accept a patch that does not require an upgrade? It may be a bit more code but this is a pretty important feature IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-26] Do not overwrite target unless source is modified [maven-war-plugin]
jira-importer commented on issue #209: URL: https://github.com/apache/maven-war-plugin/issues/209#issuecomment-2967852920 **[Ernesto S. Tolentino Jr.](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jtolentino)** commented Almost done but still doing unit tests. Will definitely have a patch ready by tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-26] Do not overwrite target unless source is modified [maven-war-plugin]
jira-importer commented on issue #209: URL: https://github.com/apache/maven-war-plugin/issues/209#issuecomment-2967852935 **[Edwin Punzalan](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=elpunzalan)** commented Patch applied. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
