Re: [I] [MWAR-314] failOnMissingWebXml ignored when webXml set [maven-war-plugin]
jira-importer commented on issue #142: URL: https://github.com/apache/maven-war-plugin/issues/142#issuecomment-2967845489 **[Paweł Ryszawa](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pablo53pl)** commented I've found this a problem too. \ content might have come from inherited (parent) pom.xml along with \ set to some value. Anyway, You may want your a particular project not to fail on missing web.xml. This is not possible with this bug, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-314] failOnMissingWebXml ignored when webXml set [maven-war-plugin]
jira-importer commented on issue #142: URL: https://github.com/apache/maven-war-plugin/issues/142#issuecomment-2967845508 **[Robert Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)** commented Fixed in [d98aee4b2c0e58c89f610f4fa1c613861c4cdcd1](https://gitbox.apache.org/repos/asf?p=maven-war-plugin.git;a=commit;h=d98aee4b2c0e58c89f610f4fa1c613861c4cdcd1) Thanks for the patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-314] failOnMissingWebXml ignored when webXml set [maven-war-plugin]
jira-importer commented on issue #142: URL: https://github.com/apache/maven-war-plugin/issues/142#issuecomment-2967845484 **[Karl Heinz Marbaise](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=khmarbaise)** commented If you set `failOnMissingWebXml` to `false` you say that you don't like to break your build if your `web.xml` does not exist, or is not readable etc. which is your described scenario to set `webXml` to `WhatEver`. Furthermore if you comment out `webXml` you say you don't define web.xml at all and the build succeeded which is based on setting `failOnMissingWebXml` to `false` correct. So from my site of view i will close this issue as not a bug. If you have any objections don't hesitate to reopen the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-314] failOnMissingWebXml ignored when webXml set [maven-war-plugin]
jira-importer commented on issue #142: URL: https://github.com/apache/maven-war-plugin/issues/142#issuecomment-2967845498 **[Karl Heinz Marbaise](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=khmarbaise)** commented First i need a full working example which shows the problem...Apart from that have you tested this also with the current version and not with an old versionof maven-war-plugin ? [Paweł Ryszawa](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pablo53pl) If you set `webXml` it will not fail cause a web.xml is specified and it exists. Settings `webXml` in a parent does not make sense cause it's something that is specific to the web module your are in. Settings `failOnMissingXml` to `false` would the option which would make sense in a parent if you have a larger number of web apps where you might omit the `web.xml` Furthermore we should focus on the subject which is given in the title of this issue otherwise it's hard to see what we are trying to clear up...If there something different than please open an other issue which has a different title. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-314] failOnMissingWebXml ignored when webXml set [maven-war-plugin]
jira-importer commented on issue #142: URL: https://github.com/apache/maven-war-plugin/issues/142#issuecomment-2967845502 **[Andre Tadeu de Carvalho](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=andretadeu)** commented [Karl Heinz Marbaise](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=khmarbaise), I attached the test case and the corresponding **build.log** for this test case. It seems that **failOnMissingWebXml** is not being checked at **WarProjectPackagingTask::handleDeploymentDescriptors**: ``` Caused by: org.apache.maven.plugin.MojoFailureException: The specified web.xml file '/home/andre/workspaces/oss/maven-war-plugin/target/it/MWAR-314/src/main/webapp/WEB-INF/web.xml' does not exist at org.apache.maven.plugins.war.packaging.WarProjectPackagingTask.handleDeploymentDescriptors (WarProjectPackagingTask.java:236) at org.apache.maven.plugins.war.packaging.WarProjectPackagingTask.performPackaging (WarProjectPackagingTask.java:110) at org.apache.maven.plugins.war.AbstractWarMojo.buildWebapp (AbstractWarMojo.java:526) at org.apache.maven.plugins.war.AbstractWarMojo.buildExplodedWebapp (AbstractWarMojo.java:442) at org.apache.maven.plugins.war.WarMojo.performPackaging (WarMojo.java:234) at org.apache.maven.plugins.war.WarMojo.execute (WarMojo.java:197) ``` I will create a pull request for this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-314] failOnMissingWebXml ignored when webXml set [maven-war-plugin]
jira-importer commented on issue #142: URL: https://github.com/apache/maven-war-plugin/issues/142#issuecomment-2967845491 **[Paweł Ryszawa](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pablo53pl)** commented The "inherintance bug" seems more serious... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
