Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853524 **[Marvin King](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pmking)** commented i missed the index.apt and modify the mvn:\ to war:\. I'll remove that note about the overlay war files overwrriting the existing war files. =) the recent fix makes this obsolete. revising for draft4-1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853471 **[Marvin King](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pmking)** commented done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853521 **[Brett Porter](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brettporter)** commented applied, but: -still missing index.html - "introduction" links to a missing overview.html (should be index.html given above) - on usage: "mvn:exploded" is used instead of "war:exploded" and "war:inplace". - in external web sources you say "Warning : Overlayed war files will overwrite the files in your war.", but this shouldn't happen (there are tests to prove it :) thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853476 **[Marvin King](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pmking)** commented will add a new page under configuration for manifest customization -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853493 **[Brett Porter](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brettporter)** commented Applied. still needed: * need an index.html that links to the standard usage, and additional use cases, and paste in the goal references from plugin-info (we should generate that differently later) * rename HOWTO to Usage. * comment out the FAQ in the nav since it's not used yet * the "war:exploded" and "war:inplace" use cases don't appear to be linked in (they should be as:) * building a WAR from the command line (note that they need to have previously run package to compile classes, etc) * building an exploded WAR from the command line (note that they need to have previously run package to compile classes, etc) * building a WAR in place from the command line * use example.com, not ideal.com (that's a real domain) * rename advanced configuration to Examples * jetty6: I think this can be under the main examples menu usage: * give more explanation of what is being done in the use case (same could be applied to other docs) * the links at the bottom make more sense on the index page (or via pages like examples/war-manifest-guide.html that you already have) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853468 **[Brett Porter](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brettporter)** commented please ensure webResources are documented, too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853499 **[Brett Porter](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brettporter)** commented that's meant to just be a : above, not a smiley... :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853553 **[Ernesto S. Tolentino Jr.](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jtolentino)** commented Just wondering why this was reopened? Was there any problem with the current documentation or is this just waiting for the plugin documentation to be released? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853528 **[Marvin King](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pmking)** commented for review draft4-1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853555 **[Brett Porter](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brettporter)** commented it was reopened for the additional patch, but not closed after being applied -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853540 **[Siveton Vincent](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=siveton)** commented Applied. Waiting for review. Staging site is available at: http://people.apache.org/~vsiveton/maven-war-plugin/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853545 **[maartenbrugman](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=maartenbrugman)** commented I'm using the war plug-in. Seems like the updated documentation is nearly finished. It would help people like me a lot if this were published, e.g. I spent several hours figuring out how to exclude an item from the WAR, in the end I found out by reading the source code. Now I see that it is described in the updated docs. So is this ready for publication? I understand that we are all busy, consider this just a polite question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853536 **[Franz Allan Valencia See](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=franz_see)** commented Changes with MWAR-48-maven-war-plugin[draft4-1-1].patch In index.html Added the example "Rapid testing using jetty6" Added the example "Creating skinny wars" In *.apt Reformatted to follow the Maven Plugin Documentation Guidelines in [1] [1] http://docs.codehaus.org/display/MAVEN/Maven+Plugin+Documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853531 **[Brett Porter](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brettporter)** commented applied, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853511 **[Marvin King](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pmking)** commented draft4 for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853505 **[Brett Porter](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brettporter)** commented see Javadoc's overview for a good example of what the index page should be. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853480 **[Marvin King](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pmking)** commented for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853507 **[Marvin King](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pmking)** commented - restructuring -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853461 **[Marvin King](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pmking)** commented rewriting... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] [MWAR-48] review plugin documentation [maven-war-plugin]
jira-importer commented on issue #217: URL: https://github.com/apache/maven-war-plugin/issues/217#issuecomment-2967853455 **[Brett Porter](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brettporter)** commented I have applied this, but would like further revision: - need an index.html - introduction should be usage.html - replace 'm2' with 'mvn' in examples - incorrect formatting of <<\>> - version of 1.0-SNAPSHOT, not 0.0 which is not a very sensible example - instead of talking about modes, talk about "use cases": * WAR as a packaging type * building a WAR from the command line (note that they need to have previously run package to compile classes, etc) * building an exploded WAR from the command line (note that they need to have previously run package to compile classes, etc) * building a WAR in place from the command line - remove defaults at bottom of page - the reference page lists these (and will be improved later) - better explanatory text at the top (the part about it being error prone is irrelevant - nobody does things by hand in Maven) - use \ for things like pom.xml, WEB-INF/lib, target/..., etc - remove the example for putting inplace in the pom, it makes no sense - for the directory diagrams, consider using 'tree': available for cygwin here: http://lassauge.free.fr/cygwin/release/ - be careful with boilerplating documents. Some of these have inconsistencies that have been copy+pasted. - the example links are broken - choose shorter, more concise names for the examples - FAQ should be a normal menu item, not a header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
