Re: [I] [MWAR-52] WAR plugin does not honor the webXml configuration setting [patch included!] [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #222:
URL: 
https://github.com/apache/maven-war-plugin/issues/222#issuecomment-2967853861

   **[Brett 
Porter](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brettporter)**
 commented
   
   fair enough. Fixed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-52] WAR plugin does not honor the webXml configuration setting [patch included!] [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #222:
URL: 
https://github.com/apache/maven-war-plugin/issues/222#issuecomment-2967853851

   **[Brett 
Porter](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brettporter)**
 commented
   
   see the atttached file which shows that it works (at least in my 
environment). Please test whether it works for you "mvn clean package".
   
   if you are running mvn war:war, then it won't work (as expected). You have 
to construct the entire webapp first.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-52] WAR plugin does not honor the webXml configuration setting [patch included!] [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #222:
URL: 
https://github.com/apache/maven-war-plugin/issues/222#issuecomment-2967853856

   **[Andreas 
Schildbach](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=goonie)**
 commented
   
   Your testcase works in my environment, too.
   
   However, just delete myWeb.xml and watch the plugin cry for the wrong file.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-52] WAR plugin does not honor the webXml configuration setting [patch included!] [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #222:
URL: 
https://github.com/apache/maven-war-plugin/issues/222#issuecomment-2967853848

   **[Andreas 
Schildbach](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=goonie)**
 commented
   
   Here is my testcase:
   
   \
\org.apache.maven.plugins\
\maven-war-plugin\
\2.0\
\
\myWeb.xml\
\
   \
   
   [INFO] Error assembling WAR: Deployment descriptor: C:\[...]\WEB-INF\web.xml 
does not exist.
   
   The plugin asks for web.xml, although I have configured myWeb.xml.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-52] WAR plugin does not honor the webXml configuration setting [patch included!] [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #222:
URL: 
https://github.com/apache/maven-war-plugin/issues/222#issuecomment-2967853846

   **[Brett 
Porter](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brettporter)**
 commented
   
   the code is correct. the custom web.xml is copied to WEB-INF/web.xml in the 
exploded webapp, which is what the code you intended to change is referring to.
   
   I have enhanced the test to ensure the bundled web.xml is correct. If you 
have a test case for something that fails, please reopen the issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-52] WAR plugin does not honor the webXml configuration setting [patch included!] [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #222:
URL: 
https://github.com/apache/maven-war-plugin/issues/222#issuecomment-2967853842

   **[Andreas 
Schildbach](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=goonie)**
 commented
   
   The patch again, as a file
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]