Re: [I] [MWAR-54] add targetPath support on the webResources plugin parameter [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #230:
URL: 
https://github.com/apache/maven-war-plugin/issues/230#issuecomment-2967854395

   **[Gordon 
Turner](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=gordo)** 
commented
   
   Can confirm that \ does not appear to be working in 2.0.6.
   
   Should a new bug be logged or should this one be reopened?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-54] add targetPath support on the webResources plugin parameter [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #230:
URL: 
https://github.com/apache/maven-war-plugin/issues/230#issuecomment-2967854380

   **[Maria Odea B. 
Ching](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=oching)** 
commented
   
   Patch applied :) Thanks
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-54] add targetPath support on the webResources plugin parameter [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #230:
URL: 
https://github.com/apache/maven-war-plugin/issues/230#issuecomment-2967854417

   **[Brian 
Weiner](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=klindel)** 
commented
   
   Everyone is having the same problem I was having.  The fix is in 2.0.2 of 
the plugin, not maven.  So specify the version like so:
   
   \org.apache.maven.plugins\
   \maven-war-plugin\
   \2.0.2\
   
   and It'll work fine.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-54] add targetPath support on the webResources plugin parameter [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #230:
URL: 
https://github.com/apache/maven-war-plugin/issues/230#issuecomment-2967854412

   **[Olivier 
Lamy](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=olamy)** 
commented
   
   Have you try with last SNAPSHOT ?
   If it fail with it can you provide a simple project to reproduce the issue ?
   Thanks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-54] add targetPath support on the webResources plugin parameter [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #230:
URL: 
https://github.com/apache/maven-war-plugin/issues/230#issuecomment-2967854409

   
**[ricone](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ric)** 
commented
   
   \ still not working in 2.0.8, please help. thanks a lot
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-54] add targetPath support on the webResources plugin parameter [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #230:
URL: 
https://github.com/apache/maven-war-plugin/issues/230#issuecomment-2967854406

   **[Mark 
Lynde](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mlynde)** 
commented
   
   Still not working in v 2.0.7.. The \ element is ignored and 
everything gets copied to the root of the webappDirectory.  Can an admin please 
reopen this issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-54] add targetPath support on the webResources plugin parameter [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #230:
URL: 
https://github.com/apache/maven-war-plugin/issues/230#issuecomment-2967854384

   **[Nick 
Johnson](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=spatula)** 
commented
   
   This does not seem to be working in 2.0.6.  The \ element is 
ignored and everything gets copied to the root of the webappDirectory.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-54] add targetPath support on the webResources plugin parameter [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #230:
URL: 
https://github.com/apache/maven-war-plugin/issues/230#issuecomment-2967854399

   **[Jay 
Goldman](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brassrat)**
 commented
   
   Actually, there are really 2 problems,
   - this one - which I think should be reopened.
   
   - And, I think there is also a problem with the way the 'src/main/resources' 
directory is handled.
 The on-line doc for the plugin says that 'src/main/resources' files will 
be copied to the target/classes and WEB-INF/classes but they are not, they are 
instaed copied to the WEB-INF directory. You can try to work around this by 
specifying the targetPath ... but, of course, that fails due to the underlying 
problem with targetPath (MWAR-54). Do you want me to open up another problem, 
i.e., that src/main/resource files are not copied where the doc says they are? 
This 'bug' could be 'fixed' by changing the doc :-)
   
   WRT MWAR-54:
   The changes that marvin made to 'fix' the problem were definitely required - 
but they were not sufficient to correct the problem, at least when doing a 
clean build on a windows xp system.
   (note - there are additional fixes that should be made to the logging 
messages to accurately reflect what is going on - but i don't think there is 
anything incorrect about the code in the plugin inself)
   
   I think the underlying problem is the behavior of the copyFileIfModified 
method.
   I have not had the time to setup my machine to build maven (I was able to 
easily build a modified version of the plugin ... maven happily loaded up my 
machine will all the necessary pieces) - so I have not looked at this code.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-54] add targetPath support on the webResources plugin parameter [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #230:
URL: 
https://github.com/apache/maven-war-plugin/issues/230#issuecomment-2967854373

   **[Marvin 
King](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pmking)** 
commented
   
   - added some house keeping code on test cases
   
   - implemented the fixes based on the comment
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-54] add targetPath support on the webResources plugin parameter [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #230:
URL: 
https://github.com/apache/maven-war-plugin/issues/230#issuecomment-2967854389

   **[Jay 
Goldman](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brassrat)**
 commented
   
   It does not appear to be working in 2.0.2. Based upon comments in _War 
overlay can overwrite files in dependant war artifact_ I replaced the use of 
copyFileIfModified in copyResources with an unconditional copy (with an 
explicit creation of any needed directories first)  and the files are copied to 
the correct location. So I think there is something wrong in copyFileIfModified 
when the target file does not exist (haven't  checked the behavior when the 
target file already exists).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-54] add targetPath support on the webResources plugin parameter [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #230:
URL: 
https://github.com/apache/maven-war-plugin/issues/230#issuecomment-2967854370

   **[Brett 
Porter](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=brettporter)**
 commented
   
   there is a problem with this:
   a) doesn't apply straight up (due to imports on the test case). I fixed that.
   b) I commented out the targetPath line in AbstractWarMojo and the test still 
passed - so the test is faulty.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-54] add targetPath support on the webResources plugin parameter [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #230:
URL: 
https://github.com/apache/maven-war-plugin/issues/230#issuecomment-2967854360

   **[Marvin 
King](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pmking)** 
commented
   
   with test case
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] [MWAR-54] add targetPath support on the webResources plugin parameter [maven-war-plugin]

2025-06-12 Thread via GitHub


jira-importer commented on issue #230:
URL: 
https://github.com/apache/maven-war-plugin/issues/230#issuecomment-2967854364

   **[Marvin 
King](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=pmking)** 
commented
   
   see MWAR-48 for documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]