[jira] [Updated] (HDDS-13357) Fix OmSnapshotManager#inFlightSnapshotCount reset logic
[
https://issues.apache.org/jira/browse/HDDS-13357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-13357:
--
Labels: pull-request-available (was: )
> Fix OmSnapshotManager#inFlightSnapshotCount reset logic
> ---
>
> Key: HDDS-13357
> URL: https://issues.apache.org/jira/browse/HDDS-13357
> Project: Apache Ozone
> Issue Type: Sub-task
>Reporter: Nandakumar
>Assignee: Bolin Lin
>Priority: Major
> Labels: pull-request-available
>
> Currently, {{OmSnapshotManager#resetInFlightSnapshotCount}} incorrectly
> assumes that {{LeaderReady}} means that there are no inflight snapshot
> requests. This is not correct, {{LeaderReady}} doesn't mean that the
> StateMachine has applied all the pending transactions.
> We may consider fixing it by waiting all the pending requests in
> notifyLeaderReady().
> Also, it seems to have another bug that the PrepareState could disallow
> snapshot requests. In such case, {{inFlightSnapshotCount}} won't be
> decremented.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Updated] (HDDS-13357) Fix OmSnapshotManager#inFlightSnapshotCount reset logic
[
https://issues.apache.org/jira/browse/HDDS-13357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang updated HDDS-13357:
---
Parent: HDDS-15130 (was: HDDS-13747)
> Fix OmSnapshotManager#inFlightSnapshotCount reset logic
> ---
>
> Key: HDDS-13357
> URL: https://issues.apache.org/jira/browse/HDDS-13357
> Project: Apache Ozone
> Issue Type: Sub-task
>Reporter: Nandakumar
>Priority: Major
>
> Currently, {{OmSnapshotManager#resetInFlightSnapshotCount}} incorrectly
> assumes that {{LeaderReady}} means that there are no inflight snapshot
> requests. This is not correct, {{LeaderReady}} doesn't mean that the
> StateMachine has applied all the pending transactions.
> We may consider fixing it by waiting all the pending requests in
> notifyLeaderReady().
> Also, it seems to have another bug that the PrepareState could disallow
> snapshot requests. In such case, {{inFlightSnapshotCount}} won't be
> decremented.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Updated] (HDDS-13357) Fix OmSnapshotManager#inFlightSnapshotCount reset logic
[
https://issues.apache.org/jira/browse/HDDS-13357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang updated HDDS-13357:
---
Parent: HDDS-13747 (was: HDDS-12940)
> Fix OmSnapshotManager#inFlightSnapshotCount reset logic
> ---
>
> Key: HDDS-13357
> URL: https://issues.apache.org/jira/browse/HDDS-13357
> Project: Apache Ozone
> Issue Type: Sub-task
>Reporter: Nandakumar
>Assignee: Chu Cheng Li
>Priority: Major
>
> Currently, {{OmSnapshotManager#resetInFlightSnapshotCount}} incorrectly
> assumes that {{LeaderReady}} means that there are no inflight snapshot
> requests. This is not correct, {{LeaderReady}} doesn't mean that the
> StateMachine has applied all the pending transactions.
> We may consider fixing it by waiting all the pending requests in
> notifyLeaderReady().
> Also, it seems to have another bug that the PrepareState could disallow
> snapshot requests. In such case, {{inFlightSnapshotCount}} won't be
> decremented.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Updated] (HDDS-13357) Fix OmSnapshotManager#inFlightSnapshotCount reset logic
[
https://issues.apache.org/jira/browse/HDDS-13357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang updated HDDS-13357:
---
Parent: HDDS-12940
Issue Type: Sub-task (was: Bug)
> Fix OmSnapshotManager#inFlightSnapshotCount reset logic
> ---
>
> Key: HDDS-13357
> URL: https://issues.apache.org/jira/browse/HDDS-13357
> Project: Apache Ozone
> Issue Type: Sub-task
>Reporter: Nandakumar
>Assignee: Chu Cheng Li
>Priority: Major
>
> Currently, {{OmSnapshotManager#resetInFlightSnapshotCount}} incorrectly
> assumes that {{LeaderReady}} means that there are no inflight snapshot
> requests. This is not correct, {{LeaderReady}} doesn't mean that the
> StateMachine has applied all the pending transactions.
> We may consider fixing it by waiting all the pending requests in
> notifyLeaderReady().
> Also, it seems to have another bug that the PrepareState could disallow
> snapshot requests. In such case, {{inFlightSnapshotCount}} won't be
> decremented.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
