Re: [PR] HDDS-15190. Add ScmInvoker subclasses for CertificateStore and RootCARotationHandler [ozone]
YutaLin commented on PR #10226: URL: https://github.com/apache/ozone/pull/10226#issuecomment-4443718592 Thanks @adoroszlai for the merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-15190. Add ScmInvoker subclasses for CertificateStore and RootCARotationHandler [ozone]
adoroszlai merged PR #10226: URL: https://github.com/apache/ozone/pull/10226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-15190. Add ScmInvoker subclasses for CertificateStore and RootCARotationHandler [ozone]
adoroszlai commented on PR #10226: URL: https://github.com/apache/ozone/pull/10226#issuecomment-4440271021 Thanks @YutaLin for the patch, @Russole, @szetszwo for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-15190. Add ScmInvoker subclasses for CertificateStore and RootCARotationHandler [ozone]
YutaLin commented on PR #10226: URL: https://github.com/apache/ozone/pull/10226#issuecomment-4427241778 HI @Russole @adoroszlai Thanks for the review, I've made some change. FYI, I don't add `ScmInvokerCodeGenerator.generate` in CertificateStore because it's in different module, and it will have circular dependency If i import the module. It's also not a big problem since we only use it for generate Invoker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-15190. Add ScmInvoker subclasses for CertificateStore and RootCARotationHandler [ozone]
Russole commented on PR #10226: URL: https://github.com/apache/ozone/pull/10226#issuecomment-4425921265 Thanks @adoroszlai, noted. I’ll avoid triggering CI when requesting changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-15190. Add ScmInvoker subclasses for CertificateStore and RootCARotationHandler [ozone]
adoroszlai commented on PR #10226: URL: https://github.com/apache/ozone/pull/10226#issuecomment-4423428809 > One small suggestion: `RootCARotationHandlerInvoker` is marked as generated code, but the method order in `newProxy()` differs from `ScmInvokerCodeGenerator` output. It would be better to keep the generated order for consistency with the other `ScmInvoker` implementations. +1 @Russole if you ask for changes please don't trigger CI, since it will have to be re-run after patch is updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-15190. Add ScmInvoker subclasses for CertificateStore and RootCARotationHandler [ozone]
Russole commented on PR #10226: URL: https://github.com/apache/ozone/pull/10226#issuecomment-4422217631 Thanks @YutaLin. Could you also apply this small consistency update before merge? Since `RootCARotationHandlerInvoker` is marked as generated code, I think it is better to keep it aligned with `ScmInvokerCodeGenerator` output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] HDDS-15190. Add ScmInvoker subclasses for CertificateStore and RootCARotationHandler [ozone]
YutaLin commented on PR #10226: URL: https://github.com/apache/ozone/pull/10226#issuecomment-4416392961 Thanks @Russole for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
