Re: [PR] Bugfix: Disable wasmJs browser tests [solr]
malliaridis commented on code in PR #3195:
URL: https://github.com/apache/solr/pull/3195#discussion_r1961745491
##
solr/ui/build.gradle.kts:
##
@@ -55,14 +55,9 @@ kotlin {
// Note that webpack.config.d/ contains additional
configuration
}
testTask {
-useKarma {
-useChromeHeadless()
-useConfigDirectory(
-project.projectDir
-.resolve("karma.config.d")
-.resolve("wasm")
-)
-}
+// Explicitly disable the wasmJs browser tests, as we do not
have the suitable
+// environments right now (running only tests for JVM)
+enabled = false
Review Comment:
Yes, I agree. I was considering adding a flag, but then I realized that just
a flag won't be sufficient. By using Karma, we also have to make a browser
selection, which, will affect the lock state if we enable a specific browser
(as it adds additional NPM dependencies) and it requires lock state update via
`gradlew kotlinUpgradeYarnLock`.
I would use Mocha instead, but doesn't seem like it works out of the box.
Simply disabling testing for wasmJs fixes one critical issue for our
automations, but doesn't solve the actual problem.
I have created
[SOLR-17676](https://issues.apache.org/jira/browse/SOLR-17676) for keeping
track of this topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Bugfix: Disable wasmJs browser tests [solr]
risdenk commented on code in PR #3195:
URL: https://github.com/apache/solr/pull/3195#discussion_r1960829081
##
solr/ui/build.gradle.kts:
##
@@ -55,14 +55,9 @@ kotlin {
// Note that webpack.config.d/ contains additional
configuration
}
testTask {
-useKarma {
-useChromeHeadless()
-useConfigDirectory(
-project.projectDir
-.resolve("karma.config.d")
-.resolve("wasm")
-)
-}
+// Explicitly disable the wasmJs browser tests, as we do not
have the suitable
+// environments right now (running only tests for JVM)
+enabled = false
Review Comment:
Future reference could have set this via a flag to make it easier to test
locally. We do similar things for say errorprone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Bugfix: Disable wasmJs browser tests [solr]
malliaridis merged PR #3195: URL: https://github.com/apache/solr/pull/3195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] Bugfix: Disable wasmJs browser tests [solr]
malliaridis opened a new pull request, #3195:
URL: https://github.com/apache/solr/pull/3195
# Description
The current test configuration for the new UI module has proven to be
error-prone, as we do not have any guarantees for the installed browsers on any
environment.
# Solution
The current solution is to simply disable the wasmJs tests, and only run the
tests for the JVM target.
For the future, we may introduce runners that have the supported browsers
installed and can run the tests in (headless) browsers.
This solution should prevent the following error from occuring:
```logs
:solr:ui:wasmJsBrowserTest: java.lang.IllegalStateException: Errors occurred
during launch of browser for testing.
- ChromeHeadless
Please make sure that you have installed browsers.
Or change it via
browser {
testTask {
useKarma {
useFirefox()
useChrome()
useSafari()
}
}
}
```
# Tests
The tests in the new UI module are explicitly disabled.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my
code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request
title.
- [x] I have given Solr maintainers
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended, not available for
branches on forks living under an organisation)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
