Re: [PR] GHA renovation [solr]
dsmiley merged PR #3396: URL: https://github.com/apache/solr/pull/3396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] GHA renovation [solr]
dsmiley commented on PR #3396: URL: https://github.com/apache/solr/pull/3396#issuecomment-3124689045 The docker build isn't taking any noticeably longer here than the test runs I see in the GHA dashboard for that script. I want to merge this Tuesday evening. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] GHA renovation [solr]
dsmiley commented on PR #3396: URL: https://github.com/apache/solr/pull/3396#issuecomment-2988675877 The elaborate caching configuration is not in Lucene, despite that same elaborate caching configuration being committed before the lucene-solr split. Thus Lucene devs removed it. In particular, it was @dweiss in apache/lucene#13110 I'm going to further improve this PR to use the nice `.github/actions/prepare-for-build/action.yml` (in Lucene, small tweaks for Solr) refactoring so that each GHA can share it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] GHA renovation [solr]
madrob commented on code in PR #3396:
URL: https://github.com/apache/solr/pull/3396#discussion_r2157362450
##
.github/workflows/docker-test.yml:
##
@@ -17,36 +16,29 @@ jobs:
name: Build and test Docker image
runs-on: ubuntu-latest
+timeout-minutes: 15
env:
SOLR_DOCKER_IMAGE_REPO: github-pr/solr
SOLR_DOCKER_IMAGE_TAG: ${{github.event.number}}
DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
steps:
-# Setup
-- uses: actions/checkout@v4
-- name: Set up JDK 21
+- name: Checkout code
+ uses: actions/checkout@v4
+
+- name: Setup JDK
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: 21
java-package: jdk
+
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4
-- name: Install ACL
- run: sudo apt-get install acl
Review Comment:
Do we not need this any more? @HoustonPutman is probably better to look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[PR] GHA renovation [solr]
dsmiley opened a new pull request, #3396: URL: https://github.com/apache/solr/pull/3396 * branches (all) * timeout-minutes * checkout version * harmonization across scripts (spacing / wording / labels) * remove chmod for gradlew (unnecessary) Caching tweaks: removed this but I'm unsure: https://github.com/apache/lucene-solr/pull/1910 CC @madrob -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
