Re: [PR] IOUtils: add back closeQuietly(Closeable) [solr]
dsmiley merged PR #3199: URL: https://github.com/apache/solr/pull/3199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] IOUtils: add back closeQuietly(Closeable) [solr]
dsmiley commented on PR #3199: URL: https://github.com/apache/solr/pull/3199#issuecomment-2672660493 Ported to branch_9_8 so that it gets in 9.8.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] IOUtils: add back closeQuietly(Closeable) [solr]
mkhludnev commented on PR #3199: URL: https://github.com/apache/solr/pull/3199#issuecomment-2670634374 Ok. ~chatting to deepseek~ referring to JLS 15.12.2.5 calms me down a little. Should be fine, since the most specific method will be chosen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] IOUtils: add back closeQuietly(Closeable) [solr]
mkhludnev commented on PR #3199: URL: https://github.com/apache/solr/pull/3199#issuecomment-2670599951 Hm.. couldn't it cause 'unambiguous error'? I mean now we have two methods with (param) overloaded signature, almost all arguments passed into these methods implement both interfaces. Just worry if javac is able to distinguish between these two methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] IOUtils: add back closeQuietly(Closeable) [solr]
dsmiley opened a new pull request, #3199: URL: https://github.com/apache/solr/pull/3199 To retain compatibility within 9x. Not bringing this to main/10x. This issue was introduced by [SOLR-17593: New home for default http2 client apache/solr#2689](https://github.com/apache/solr/pull/2689) and was seen to be a compatibility issue in the DIH for one: https://github.com/SearchScale/dataimporthandler/issues/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
