Re: [PR] SOLR-17741: Remove addHttpRequestToContext option [solr]
dsmiley merged PR #3325: URL: https://github.com/apache/solr/pull/3325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17741: Remove addHttpRequestToContext option [solr]
gerlowskija commented on code in PR #3325: URL: https://github.com/apache/solr/pull/3325#discussion_r2048741818 ## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc: ## @@ -111,6 +111,8 @@ Users who that don't need to vary JAR access on a per-core basis have several op * CurrencyField has been removed. Users should migrate to the `CurrencyFieldType` implementation. +* The `addHttpRequestToContext` option in `solrconfig.xml` has been removed; it's obsolete. Review Comment: [0] Might be worth augmenting these docs so that users know they can still get at the request object via `SolrQueryRequest.getHttpSolrCall().getReq()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17741: Remove addHttpRequestToContext option [solr]
dsmiley commented on code in PR #3325: URL: https://github.com/apache/solr/pull/3325#discussion_r2042344576 ## solr/core/src/resources/EditableSolrConfigAttributes.json: ## Review Comment: Yup; I just looked for this string everywhere, and yeah, find files I didn't know about either. hmm; `enableRemoteStreaming` and `enableStreamBody shouldn't even be here... SOLR-14853 I forgot to remove them ## solr/solr-ref-guide/modules/configuration-guide/pages/requestdispatcher.adoc: ## @@ -69,21 +69,11 @@ A value of `-1` means MAX_INT, which is also the system default if omitted. This attribute sets a limit in kilobytes on the size of form data (`application/x-www-form-urlencoded`) submitted in a HTTP POST request, which can be used to pass request parameters that will not fit in a URL. A value of `-1` means MAX_INT, which is also the system default if omitted. -`addHttpRequestToContext`:: Review Comment: It *is* documented @epugh . I'm surprised this was ever an option in the first place. Always add it (I would have said)... but nowadays is redundant so don't need it at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] SOLR-17741: Remove addHttpRequestToContext option [solr]
epugh commented on code in PR #3325: URL: https://github.com/apache/solr/pull/3325#discussion_r2042171654 ## solr/core/src/resources/EditableSolrConfigAttributes.json: ## Review Comment: wow, this is yet another magic file I've never heard of! amazing what you find. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] SOLR-17741: Remove addHttpRequestToContext option [solr]
dsmiley opened a new pull request, #3325: URL: https://github.com/apache/solr/pull/3325 in solrconfig.xml/requestDispatcher/requestParsers. Why: Obsolete/redundant with SolrQueryRequest.getHttpSolrCall().getReq() https://issues.apache.org/jira/browse/SOLR-17741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
