[jira] [Commented] (SOLR-13731) javabin must support a 1:1 mapping of the JSON update format
[
https://issues.apache.org/jira/browse/SOLR-13731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929833#comment-17929833
]
David Smiley commented on SOLR-13731:
-
There are many classes in SolrJ and it's not always clear to us/users which
ones are internal, not to mention that in this case, we may disagree. I don't
see why a user using SolrJ would go out of their way to use JavaBinCodec as you
describe. Constructing a SolrInputDocument is easy :).
{{ConcurrentUpdateHttp2SolrClient}} streams updates.
> javabin must support a 1:1 mapping of the JSON update format
> -
>
> Key: SOLR-13731
> URL: https://issues.apache.org/jira/browse/SOLR-13731
> Project: Solr
> Issue Type: Task
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Major
> Fix For: 8.4
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Objects like SolrInputDocument is serialized in such a way that the size is
> known in advance. All objects should ideally support streaming friendly types.
> This is backward compatible . basically javabin will continue to serialize
> using the old format , but will accept more efficient formats as input
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-13731) javabin must support a 1:1 mapping of the JSON update format
[ https://issues.apache.org/jira/browse/SOLR-13731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929615#comment-17929615 ] Noble Paul commented on SOLR-13731: --- Constructing a SolrInputDocument etc is much more complex than streaming a bunch of maps. Yes. users can just construct a payload of a javabin file and post it > javabin must support a 1:1 mapping of the JSON update format > - > > Key: SOLR-13731 > URL: https://issues.apache.org/jira/browse/SOLR-13731 > Project: Solr > Issue Type: Task >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Major > Fix For: 8.4 > > Time Spent: 20m > Remaining Estimate: 0h > > Objects like SolrInputDocument is serialized in such a way that the size is > known in advance. All objects should ideally support streaming friendly types. > This is backward compatible . basically javabin will continue to serialize > using the old format , but will accept more efficient formats as input -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-13731) javabin must support a 1:1 mapping of the JSON update format
[
https://issues.apache.org/jira/browse/SOLR-13731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929568#comment-17929568
]
David Smiley commented on SOLR-13731:
-
I don't get the point. Unless I'm missing something, JavaBinUpdateRequestCodec
only needs to support SolrJ (UpdateRequest). UpdateRequest basically just sends
a SolrInputDocument (or Map.Entry with the same but I digress), so when would
we ever actually receive a Map form of a doc? Would users actually use the
lower level JavaBinCodec class directly to send a Map, as TestCborDataFormat
does? The relevant code is
{{org.apache.solr.client.solrj.request.JavaBinUpdateRequestCodec.StreamingCodec#readOuterMostDocIterator}}
> javabin must support a 1:1 mapping of the JSON update format
> -
>
> Key: SOLR-13731
> URL: https://issues.apache.org/jira/browse/SOLR-13731
> Project: Solr
> Issue Type: Task
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Major
> Fix For: 8.4
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Objects like SolrInputDocument is serialized in such a way that the size is
> known in advance. All objects should ideally support streaming friendly types.
> This is backward compatible . basically javabin will continue to serialize
> using the old format , but will accept more efficient formats as input
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
