[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955984#comment-17955984 ] ASF subversion and git services commented on SOLR-16470: Commit ad45ba3eb2850b5e75d183da71d2ac0e0628077b in solr's branch refs/heads/branch_9x from Jude Muriithi [ https://gitbox.apache.org/repos/asf?p=solr.git;h=ad45ba3eb28 ] SOLR-16470: Include IOException in logs when DirectoryFileStream fails (#3373) Log the DirectoryFileStream IOException on failure - Co-authored-by: jmuriithi3 > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Assignee: Jason Gerlowski >Priority: Major > Labels: V2, newdev, pull-request-available > Fix For: 9.8 > > Time Spent: 8h 40m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |-GET /solr/collName/replication?command=filelist-| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |-GET /api/cores/coreName/replication/files-| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in ReplicationHandler > * [Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.)|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#apis-in-solr] > * [A step-by-step guide to creating APIs using the preferred v2 API > framework|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#writing-jax-rs-apis] > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/2144] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955982#comment-17955982 ] ASF subversion and git services commented on SOLR-16470: Commit 995b7faa74c6a1a0d574ac29091d92c356d5169a in solr's branch refs/heads/main from Jude Muriithi [ https://gitbox.apache.org/repos/asf?p=solr.git;h=995b7faa74c ] SOLR-16470: Include IOException in logs when DirectoryFileStream fails (#3373) Log the DirectoryFileStream IOException on failure - Co-authored-by: jmuriithi3 > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Assignee: Jason Gerlowski >Priority: Major > Labels: V2, newdev, pull-request-available > Fix For: 9.8 > > Time Spent: 8h 40m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |-GET /solr/collName/replication?command=filelist-| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |-GET /api/cores/coreName/replication/files-| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in ReplicationHandler > * [Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.)|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#apis-in-solr] > * [A step-by-step guide to creating APIs using the preferred v2 API > framework|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#writing-jax-rs-apis] > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/2144] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900417#comment-17900417 ] ASF subversion and git services commented on SOLR-16470: Commit 0cf4183c48c6e2118e09e733cd2ed8a3817becd6 in solr's branch refs/heads/branch_9x from Matthew Biscocho [ https://gitbox.apache.org/repos/asf?p=solr.git;h=0cf4183c48c ] SOLR-16470: Create v2 replication "fetch file" API (#2734) New v2 API is available at `GET /api/cores/coreName/replication/files/fileName` - Co-authored-by: Matthew Biscocho Co-authored-by: Jason Gerlowski > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev, pull-request-available > Time Spent: 7h 40m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |-GET /solr/collName/replication?command=filelist-| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |-GET /api/cores/coreName/replication/files-| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in ReplicationHandler > * [Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.)|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#apis-in-solr] > * [A step-by-step guide to creating APIs using the preferred v2 API > framework|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#writing-jax-rs-apis] > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/2144] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900395#comment-17900395 ] ASF subversion and git services commented on SOLR-16470: Commit 6f94c505fc923c452c58c2a3946ee4408ea06fac in solr's branch refs/heads/main from Matthew Biscocho [ https://gitbox.apache.org/repos/asf?p=solr.git;h=6f94c505fc9 ] SOLR-16470: Create v2 replication "fetch file" API (#2734) New v2 API is available at `GET /api/cores/coreName/replication/files/fileName` - Co-authored-by: Matthew Biscocho Co-authored-by: Jason Gerlowski > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev, pull-request-available > Time Spent: 7h 40m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |-GET /solr/collName/replication?command=filelist-| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |-GET /api/cores/coreName/replication/files-| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in ReplicationHandler > * [Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.)|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#apis-in-solr] > * [A step-by-step guide to creating APIs using the preferred v2 API > framework|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#writing-jax-rs-apis] > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/2144] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17886687#comment-17886687 ] Matthew Biscocho commented on SOLR-16470: - Thanks everyone. [PR|https://github.com/apache/solr/pull/2734] made for this last V2 api for this. Not sure why Jira didn't pick it up. Probably missing something so it didn't attach. Added in some things to throw a 400 in the V1 and V2 code path for bad requests. > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 4h 20m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |-GET /solr/collName/replication?command=filelist-| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |-GET /api/cores/coreName/replication/files-| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in ReplicationHandler > * [Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.)|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#apis-in-solr] > * [A step-by-step guide to creating APIs using the preferred v2 API > framework|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#writing-jax-rs-apis] > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/2144] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17886642#comment-17886642 ] Jason Gerlowski commented on SOLR-16470: Agreed - required parameters should be, well, required. A '400' telling users what param they forgot is much better than an opaque stack trace later on. Thanks for working on the 'filecontent' API [~mbiscocho] - if you hit any blockers or have more questions, let me know! > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 4h 20m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |-GET /solr/collName/replication?command=filelist-| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |-GET /api/cores/coreName/replication/files-| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in ReplicationHandler > * [Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.)|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#apis-in-solr] > * [A step-by-step guide to creating APIs using the preferred v2 API > framework|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#writing-jax-rs-apis] > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/2144] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17886479#comment-17886479 ] David Smiley commented on SOLR-16470: - If the API requires certain parameters to respond in a reasonable manner, it should be modified to throw a 400 and tell you what to do. It could also be modified to have different defaults than standard defaults, like org.apache.solr.handler.ExportHandler#handleRequestBody does. > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 4h 20m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |-GET /solr/collName/replication?command=filelist-| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |-GET /api/cores/coreName/replication/files-| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in ReplicationHandler > * [Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.)|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#apis-in-solr] > * [A step-by-step guide to creating APIs using the preferred v2 API > framework|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#writing-jax-rs-apis] > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/2144] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885943#comment-17885943 ] Matthew Biscocho commented on SOLR-16470: - You can ignore my last comment actually. Found a solution here that should work. Will be putting out a PR relatively soon. > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 4h 20m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |-GET /solr/collName/replication?command=filelist-| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |-GET /api/cores/coreName/replication/files-| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in ReplicationHandler > * [Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.)|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#apis-in-solr] > * [A step-by-step guide to creating APIs using the preferred v2 API > framework|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#writing-jax-rs-apis] > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/2144] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885155#comment-17885155 ] Matthew Biscocho commented on SOLR-16470: - I guess this leads me to another question on V2 apis. The filecontent API seems to use an output stream from the [BinaryResponseWriter|https://github.com/apache/solr/blob/997ef80f3a31e1a4dc8619a5bba186b88d378530/solr/core/src/java/org/apache/solr/core/SolrCore.java#L3045] when the wt parameter is set to output these streams of raw bytes. This is a bit different than the other 2 APIs I did which were simple JSON responses with POJO for serialization which isn't applicable here. Is there an example of how v2 api's callback to these response writers for raw bytes output if this has been done already? > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 4h 20m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |-GET /solr/collName/replication?command=filelist-| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |-GET /api/cores/coreName/replication/files-| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in ReplicationHandler > * [Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.)|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#apis-in-solr] > * [A step-by-step guide to creating APIs using the preferred v2 API > framework|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#writing-jax-rs-apis] > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/2144] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[
https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885092#comment-17885092
]
Matthew Biscocho commented on SOLR-16470:
-
Ah ok, think I figured it out. Not a regression, API works fine and I get back
the raw bytes.
{code:java}
curl --output -
'localhost:8983/solr//replication?command=filecontent&cf=./solrconfig.xml&wt=filestream'
{code}
Just looks like if you don't pass all the correct parameters, it's just doing
that useless Object.toString() output and since your commit change, doesn't
have access to call toString on that private object anymore. May not actually
matter since probably nothing internally calls this api like that anyways which
is why no tests fail but we get back a http/500 instead of http/200. If you're
ok with it, maybe I'll throw in an error code with a message response about
some missing parameters and incorrect use of the API.
> Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get
> File List
> ---
>
> Key: SOLR-16470
> URL: https://issues.apache.org/jira/browse/SOLR-16470
> Project: Solr
> Issue Type: Sub-task
> Components: v2 API
>Affects Versions: 9.2
>Reporter: Sanjay Dutt
>Priority: Major
> Labels: V2, newdev
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Replication Handler has no v2 equivalent. This ticket is covering few
> endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream,
> Get File List.
> Existing V1
> |-GET /solr/collName/replication?command=indexversion-|
> |GET /solr/collName/replication?command=filecontent|
> |-GET /solr/collName/replication?command=filelist-|
> Proposed API design
> |-GET /api/cores/coreName/replication/indexversion-|
> |GET /api/cores/coreName/replication/files/filePath|
> |-GET /api/cores/coreName/replication/files-|
> few other pointers that might be helpful, especially for newcomers:
> * The v1 logic for this API lives in ReplicationHandler
> * [Some discussion of how APIs work in Solr (Particularly the "APIs in Solr"
> section.)|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#apis-in-solr]
> * [A step-by-step guide to creating APIs using the preferred v2 API
> framework|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#writing-jax-rs-apis]
> * [A recent PR that adds a v2 API, as an
> example|https://github.com/apache/solr/pull/2144]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885038#comment-17885038 ] Jason Gerlowski commented on SOLR-16470: Huh - I'm not sure this "before" behavior is right either haha. I'm a bit rusty, but AFAIK the API is supposed to return the raw bytes of whatever file was requested. Instead it looks like we're getting a bit of JSON that mostly just gives us some relatively useless Object.toString() output. Maybe there's some parameter that the API requires but doesn't really advertise? Or something else is funky with the API call made by curl? Or maybe there's more than one bug here, and things were truly broken even before [the commit you highlighted|https://github.com/apache/solr/pull/1867] > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 4h 20m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |-GET /solr/collName/replication?command=filelist-| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |-GET /api/cores/coreName/replication/files-| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in ReplicationHandler > * [Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.)|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#apis-in-solr] > * [A step-by-step guide to creating APIs using the preferred v2 API > framework|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#writing-jax-rs-apis] > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/2144] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885045#comment-17885045 ] Matthew Biscocho commented on SOLR-16470: - Not much documentation around this API and wasn't entirely sure what it did until you gave me more context. Let me do more digging to see what else it can do. You might be correct in me missing some parameters here. > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 4h 20m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |-GET /solr/collName/replication?command=filelist-| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |-GET /api/cores/coreName/replication/files-| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in ReplicationHandler > * [Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.)|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#apis-in-solr] > * [A step-by-step guide to creating APIs using the preferred v2 API > framework|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#writing-jax-rs-apis] > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/2144] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[
https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885029#comment-17885029
]
Matthew Biscocho commented on SOLR-16470:
-
Np. Just spinning up a new core and curling it gives that failure
{code:java}
curl 'localhost:8983/solr//replication?command=filecontent' {code}
Going one commit right before the regression, the output looks like so
{code:java}
{
"responseHeader":{
"status":0,
"QTime":0
},
"filestream":"org.apache.solr.handler.ReplicationHandler$DirectoryFileStream:org.apache.solr.handler.ReplicationHandler$DirectoryFileStream@25edb033",
"status":"OK"
}% {code}
> Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get
> File List
> ---
>
> Key: SOLR-16470
> URL: https://issues.apache.org/jira/browse/SOLR-16470
> Project: Solr
> Issue Type: Sub-task
> Components: v2 API
>Affects Versions: 9.2
>Reporter: Sanjay Dutt
>Priority: Major
> Labels: V2, newdev
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Replication Handler has no v2 equivalent. This ticket is covering few
> endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream,
> Get File List.
> Existing V1
> |-GET /solr/collName/replication?command=indexversion-|
> |GET /solr/collName/replication?command=filecontent|
> |-GET /solr/collName/replication?command=filelist-|
> Proposed API design
> |-GET /api/cores/coreName/replication/indexversion-|
> |GET /api/cores/coreName/replication/files/filePath|
> |-GET /api/cores/coreName/replication/files-|
> few other pointers that might be helpful, especially for newcomers:
> * The v1 logic for this API lives in ReplicationHandler
> * [Some discussion of how APIs work in Solr (Particularly the "APIs in Solr"
> section.)|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#apis-in-solr]
> * [A step-by-step guide to creating APIs using the preferred v2 API
> framework|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#writing-jax-rs-apis]
> * [A recent PR that adds a v2 API, as an
> example|https://github.com/apache/solr/pull/2144]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885026#comment-17885026 ] Jason Gerlowski commented on SOLR-16470: Ugh, OK, thanks for finding this Matt! It's not a huge surprise that we don't have explicit tests for the RH "filecontent" API, but I am a little surprised that this bug didn't indirectly cause other test failures. RH-filecontent is used "under the hood" by a lot of functionality in Solr: PULL and TLOG replicas, NRT replica "full recovery", etc. And there are a lot of tests for that higher level functionality. Do you have 'curl' or script or something you used to reproduce? I'll try to reproduce and debug when I get a few spare minutes... > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 4h 20m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |-GET /solr/collName/replication?command=filelist-| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |-GET /api/cores/coreName/replication/files-| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in ReplicationHandler > * [Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.)|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#apis-in-solr] > * [A step-by-step guide to creating APIs using the preferred v2 API > framework|https://github.com/apache/solr/blob/main/dev-docs/apis.adoc#writing-jax-rs-apis] > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/2144] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[
https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1788#comment-1788
]
Matthew Biscocho commented on SOLR-16470:
-
[~gerlowskija] Started to look into the filecontent API and noticed it was
failing with a stack trace. Doing some digging, I believe I found a regression
due to this [commit.|https://github.com/apache/solr/pull/1867] Don't fully
understand what this does yet but was probably not caught because there are no
tests around the filecontent command on this replication API. This will
probably need a fix before migrating this API over to V2
{code:java}
{
"error":{
"msg":"java.lang.IllegalAccessException: access violation: class
org.apache.solr.handler.ReplicationHandler$DirectoryFileStream, from public
Lookup",
"trace":"java.lang.RuntimeException: java.lang.IllegalAccessException:
access violation: class
org.apache.solr.handler.ReplicationHandler$DirectoryFileStream, from public
Lookup\n\tat
org.apache.solr.common.util.Utils.getReflectWriter(Utils.java:928)\n\tat
org.apache.solr.common.util.TextWriter.writeVal(TextWriter.java:114)\n\tat
org.apache.solr.response.TextResponseWriter.writeVal(TextResponseWriter.java:213)\n\tat
org.apache.solr.common.util.TextWriter.writeVal(TextWriter.java:48)\n\tat
org.apache.solr.common.util.JsonTextWriter.writeNamedListAsMapWithDups(JsonTextWriter.java:404)\n\tat
org.apache.solr.common.util.JsonTextWriter.writeNamedList(JsonTextWriter.java:312)\n\tat
org.apache.solr.response.JacksonJsonWriter$WriterImpl.writeResponse(JacksonJsonWriter.java:88)\n\tat
org.apache.solr.response.JacksonJsonWriter.write(JacksonJsonWriter.java:50)\n\tat
org.apache.solr.response.QueryResponseWriterUtil.writeQueryResponse(QueryResponseWriterUtil.java:55)\n\tat
org.apache.solr.servlet.HttpSolrCall.writeResponse(HttpSolrCall.java:1012)\n\tat
org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:600)\n\tat
org.apache.solr.servlet.SolrDispatchFilter.dispatch(SolrDispatchFilter.java:243)\n\tat
org.apache.solr.servlet.SolrDispatchFilter.lambda$doFilter$0(SolrDispatchFilter.java:204)\n\tat
org.apache.solr.servlet.ServletUtils.traceHttpRequestExecution2(ServletUtils.java:241)\n\tat
org.apache.solr.servlet.ServletUtils.rateLimitRequest(ServletUtils.java:209)\n\tat
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:198)\n\tat
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:181)\n\tat
org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:210)\n\tat
org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1635)\n\tat
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:527)\n\tat
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:131)\n\tat
org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:598)\n\tat
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:122)\n\tat
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:223)\n\tat
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1580)\n\tat
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:221)\n\tat
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1384)\n\tat
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:176)\n\tat
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:484)\n\tat
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1553)\n\tat
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:174)\n\tat
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1306)\n\tat
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:129)\n\tat
org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:149)\n\tat
org.eclipse.jetty.server.handler.InetAccessHandler.handle(InetAccessHandler.java:228)\n\tat
org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:141)\n\tat
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:122)\n\tat
org.eclipse.jetty.rewrite.handler.RewriteHandler.handle(RewriteHandler.java:301)\n\tat
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:122)\n\tat
org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:822)\n\tat
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:122)\n\tat
org.eclipse.jetty.server.Server.handle(Server.java:563)\n\tat
org.eclipse.jetty.server.HttpChannel$RequestDispatchable.dispatch(HttpChannel.java:1598)\n\tat
org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:753)\n\tat
org.eclipse.jetty.server.HttpChannel.handle(HttpCha
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876686#comment-17876686 ] Jason Gerlowski commented on SOLR-16470: That's awesome, thanks for volunteering [~mbiscocho] ! bq. Also would be interested in the metrics api to V2 since I touched a decent amount of it for the Prometheus feature work. Is there a Jira for that? I don't think there is. I've tried to pre-create tickets for some of the larger groups of individual APIs (like this ticket for the replication functionality), but some of the more singular APIs fall through the cracks. We should create a new ticket to cover it (probably as a sub-task or child of SOLR-15737?) > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 4h 20m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |-GET /solr/collName/replication?command=filelist-| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |-GET /api/cores/coreName/replication/files-| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in ReplicationHandler > * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.) > * A step-by-step guide to creating APIs using the preferred v2 API framework > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/1061/files] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875605#comment-17875605 ] Matthew Biscocho commented on SOLR-16470: - Hey [~gerlowskija], I'll find time to do those last API's left on these to close out the loop. Also would be interested in the metrics api to V2 since I touched a decent amount of it for the Prometheus feature work. Is there a Jira for that? > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 4h 20m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |-GET /solr/collName/replication?command=filelist-| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |-GET /api/cores/coreName/replication/files-| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in ReplicationHandler > * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.) > * A step-by-step guide to creating APIs using the preferred v2 API framework > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/1061/files] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740170#comment-17740170 ] Jason Gerlowski commented on SOLR-16470: Alright, another API down, thanks Matt! One remaining API for this ticket (get-file-content) if anyone wants to pick it up, and then we can close this out! > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 4h 20m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |-GET /solr/collName/replication?command=filelist-| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |-GET /api/cores/coreName/replication/files-| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in ReplicationHandler > * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.) > * A step-by-step guide to creating APIs using the preferred v2 API framework > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/1061/files] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740167#comment-17740167 ] ASF subversion and git services commented on SOLR-16470: Commit 3847696e38a870f6430e693237f178767695f994 in solr's branch refs/heads/branch_9x from Matthew Biscocho [ https://gitbox.apache.org/repos/asf?p=solr.git;h=3847696e38a ] SOLR-16470 : Create V2 equivalent of V1 Replication: GET files (#1704) No v2 equivalent existed prior to this commit. The new v2 API is `GET /api/cores/cName/replication/files?generation=<123>`. - Co-authored-by: Jason Gerlowski > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 4h 20m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |GET /solr/collName/replication?command=filelist| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |GET /api/cores/coreName/replication/files| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in CollectionsHandler (for the > collection-level APIs) and CoreAdminHandler (for the core-level APIs). > * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.) > * A step-by-step guide to creating APIs using the preferred v2 API framework > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/1061/files] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740168#comment-17740168 ] ASF subversion and git services commented on SOLR-16470: Commit 487a2959fa8b73036e135967ea879f6a6a161808 in solr's branch refs/heads/branch_9x from Mikhail Khludnev [ https://gitbox.apache.org/repos/asf?p=solr.git;h=487a2959fa8 ] SOLR-16470: Inner class is non-static but does not reference enclosing class (#1751) > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 4h 20m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |GET /solr/collName/replication?command=filelist| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |GET /api/cores/coreName/replication/files| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in CollectionsHandler (for the > collection-level APIs) and CoreAdminHandler (for the core-level APIs). > * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.) > * A step-by-step guide to creating APIs using the preferred v2 API framework > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/1061/files] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739842#comment-17739842 ] ASF subversion and git services commented on SOLR-16470: Commit f774922ecf44b18b78435cef8735618bb793ac30 in solr's branch refs/heads/main from Mikhail Khludnev [ https://gitbox.apache.org/repos/asf?p=solr.git;h=f774922ecf4 ] SOLR-16470: Inner class is non-static but does not reference enclosing class (#1751) > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 4h 10m > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |GET /solr/collName/replication?command=filelist| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |GET /api/cores/coreName/replication/files| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in CollectionsHandler (for the > collection-level APIs) and CoreAdminHandler (for the core-level APIs). > * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.) > * A step-by-step guide to creating APIs using the preferred v2 API framework > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/1061/files] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739174#comment-17739174 ] ASF subversion and git services commented on SOLR-16470: Commit 244a29b39e354a2dabe4a5ad70c5bc148c6f8555 in solr's branch refs/heads/main from Matthew Biscocho [ https://gitbox.apache.org/repos/asf?p=solr.git;h=244a29b39e3 ] SOLR-16470 : Create V2 equivalent of V1 Replication: GET files (#1704) No v2 equivalent existed prior to this commit. The new v2 API is `GET /api/cores/cName/replication/files?generation=<123>`. - Co-authored-by: Jason Gerlowski > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 3h > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |GET /solr/collName/replication?command=filelist| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |GET /api/cores/coreName/replication/files| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in CollectionsHandler (for the > collection-level APIs) and CoreAdminHandler (for the core-level APIs). > * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.) > * A step-by-step guide to creating APIs using the preferred v2 API framework > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/1061/files] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726223#comment-17726223 ] Matthew Biscocho commented on SOLR-16470: - Thanks Jason! I do plan on doing finishing up this Jira and doing the other 2 APIs. Will start work on them soon. > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 1h > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |GET /solr/collName/replication?command=filelist| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |GET /api/cores/coreName/replication/files| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in CollectionsHandler (for the > collection-level APIs) and CoreAdminHandler (for the core-level APIs). > * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.) > * A step-by-step guide to creating APIs using the preferred v2 API framework > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/1061/files] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726178#comment-17726178 ] Jason Gerlowski commented on SOLR-16470: Awesome work [~mbiscocho]; let me know if you get the itch to pick up any of these other APIs! > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 1h > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |-GET /solr/collName/replication?command=indexversion-| > |GET /solr/collName/replication?command=filecontent| > |GET /solr/collName/replication?command=filelist| > Proposed API design > |-GET /api/cores/coreName/replication/indexversion-| > |GET /api/cores/coreName/replication/files/filePath| > |GET /api/cores/coreName/replication/files| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in CollectionsHandler (for the > collection-level APIs) and CoreAdminHandler (for the core-level APIs). > * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.) > * A step-by-step guide to creating APIs using the preferred v2 API framework > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/1061/files] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726171#comment-17726171 ] ASF subversion and git services commented on SOLR-16470: Commit bfe93b509f1aa0e09b0f1073f83059b86f697b45 in solr's branch refs/heads/branch_9x from Matthew Biscocho [ https://gitbox.apache.org/repos/asf?p=solr.git;h=bfe93b509f1 ] SOLR-16470: Add v2 API for /replication?command=indexversion (#1620) No v2 equivalent existed prior to this commit. The new v2 API is `GET /api/cores/cName/replication/indexversion`. - Co-authored-by: Jason Gerlowski > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 1h > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |GET /solr/collName/replication?command=indexversion| > |GET /solr/collName/replication?command=filecontent| > |GET /solr/collName/replication?command=filelist| > Proposed API design > |GET /api/cores/coreName/replication/indexversion| > |GET /api/cores/coreName/replication/files/filePath| > |GET /api/cores/coreName/replication/files| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in CollectionsHandler (for the > collection-level APIs) and CoreAdminHandler (for the core-level APIs). > * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.) > * A step-by-step guide to creating APIs using the preferred v2 API framework > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/1061/files] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17723592#comment-17723592 ] ASF subversion and git services commented on SOLR-16470: Commit 4adf5ac5155082e2c64d51fbfa6a01f1a1390858 in solr's branch refs/heads/main from Matthew Biscocho [ https://gitbox.apache.org/repos/asf?p=solr.git;h=4adf5ac5155 ] SOLR-16470: Add v2 API for /replication?command=indexversion (#1620) No v2 equivalent existed prior to this commit. The new v2 API is `GET /api/cores/cName/replication/indexversion`. - Co-authored-by: Jason Gerlowski > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > Time Spent: 1h > Remaining Estimate: 0h > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |GET /solr/collName/replication?command=indexversion| > |GET /solr/collName/replication?command=filecontent| > |GET /solr/collName/replication?command=filelist| > Proposed API design > |GET /api/cores/coreName/replication/indexversion| > |GET /api/cores/coreName/replication/files/filePath| > |GET /api/cores/coreName/replication/files| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in CollectionsHandler (for the > collection-level APIs) and CoreAdminHandler (for the core-level APIs). > * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.) > * A step-by-step guide to creating APIs using the preferred v2 API framework > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/1061/files] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17718321#comment-17718321 ] Jason Gerlowski commented on SOLR-16470: Hi Matthew, and welcome! Good question: I think we would just need core-level bindings for this functionality (i.e. /api/cores/coreName/replication/indexversion). Functionality exposed by the ReplicationHandler typically only makes sense in the context of a specific core. Replicas of the same shard+collection might have totally different index versions and even files, so questions like "what files does this collection have?" don't makes sense or have clear answers in the collection-context. Good luck picking this up and lmk if you have other questions! > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |GET /solr/collName/replication?command=indexversion| > |GET /solr/collName/replication?command=filecontent| > |GET /solr/collName/replication?command=filelist| > Proposed API design > |GET /api/cores/coreName/replication/indexversion| > |GET /api/cores/coreName/replication/files/filePath| > |GET /api/cores/coreName/replication/files| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in CollectionsHandler (for the > collection-level APIs) and CoreAdminHandler (for the core-level APIs). > * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.) > * A step-by-step guide to creating APIs using the preferred v2 API framework > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/1061/files] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[
https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717325#comment-17717325
]
Matthew Biscocho commented on SOLR-16470:
-
[~gerlowskija] New to Solr code base and would like to contribute to this as a
start! For this V2 api, this will need a new endpoint for both collection and
core level and not just the core level from the proposed design, correct?
e.g V2 indexversion: GET /api/cores/\{coreName}/replication/indexversion and
GET /api/cores/\{collectionName}/replication/indexversion
> Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get
> File List
> ---
>
> Key: SOLR-16470
> URL: https://issues.apache.org/jira/browse/SOLR-16470
> Project: Solr
> Issue Type: Sub-task
> Components: v2 API
>Affects Versions: 9.2
>Reporter: Sanjay Dutt
>Priority: Major
> Labels: V2, newdev
>
> Replication Handler has no v2 equivalent. This ticket is covering few
> endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream,
> Get File List.
> Existing V1
> |GET /solr/collName/replication?command=indexversion|
> |GET /solr/collName/replication?command=filecontent|
> |GET /solr/collName/replication?command=filelist|
> Proposed API design
> |GET /api/cores/coreName/replication/indexversion|
> |GET /api/cores/coreName/replication/files/filePath|
> |GET /api/cores/coreName/replication/files|
> few other pointers that might be helpful, especially for newcomers:
> * The v1 logic for this API lives in CollectionsHandler (for the
> collection-level APIs) and CoreAdminHandler (for the core-level APIs).
> * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr"
> section.)
> * A step-by-step guide to creating APIs using the preferred v2 API framework
> * [A recent PR that adds a v2 API, as an
> example|https://github.com/apache/solr/pull/1061/files]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716928#comment-17716928 ] Matthew Biscocho commented on SOLR-16470: - Interested in picking this up and contributing to one of these API's. Has there already been work on any of the handlers yet? > Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get > File List > --- > > Key: SOLR-16470 > URL: https://issues.apache.org/jira/browse/SOLR-16470 > Project: Solr > Issue Type: Sub-task > Components: v2 API >Affects Versions: 9.2 >Reporter: Sanjay Dutt >Priority: Major > Labels: V2, newdev > > Replication Handler has no v2 equivalent. This ticket is covering few > endpoints from ReplicationHandler such as Get IndexVersion, Get FileStream, > Get File List. > Existing V1 > |GET /solr/collName/replication?command=indexversion| > |GET /solr/collName/replication?command=filecontent| > |GET /solr/collName/replication?command=filelist| > Proposed API design > |GET /api/cores/coreName/replication/indexversion| > |GET /api/cores/coreName/replication/files/filePath| > |GET /api/cores/coreName/replication/files| > few other pointers that might be helpful, especially for newcomers: > * The v1 logic for this API lives in CollectionsHandler (for the > collection-level APIs) and CoreAdminHandler (for the core-level APIs). > * Some discussion of how APIs work in Solr (Particularly the "APIs in Solr" > section.) > * A step-by-step guide to creating APIs using the preferred v2 API framework > * [A recent PR that adds a v2 API, as an > example|https://github.com/apache/solr/pull/1061/files] > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
