[jira] [Commented] (SOLR-17334) Minor bugs in Solr dedicated coordinator mode
[
https://issues.apache.org/jira/browse/SOLR-17334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923498#comment-17923498
]
David Smiley commented on SOLR-17334:
-
Neither linked PRs are merged. I think the code is good but lacks tests and
some energy to get it over the finish line. Closing this JIRA doesn't make
sense to me.
> Minor bugs in Solr dedicated coordinator mode
> -
>
> Key: SOLR-17334
> URL: https://issues.apache.org/jira/browse/SOLR-17334
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
>Affects Versions: 9.6
>Reporter: Torsten Bøgh Köster
>Assignee: Noble Paul
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> We recently put dedicated Solr coordinator nodes into production and stumbled
> upon some minor bugs/improvements:
> - The Solr root resource cannot be requested on a coordinator node
> - Coordinator requests are enabled for the {{/select}} handler only
> - From outside proxied and coordinator requests cannot be distinguished
> h3. Solr root resource
> We adopted a general fix from the {{HttpSolrCall}} to check whether the given
> {{collectionName}} is {{{}null{}}}. This fixes requesting the root resource
> (and maybe other similar requests)
> h3. {{/select}} handler only
> Coordinator requests are limited to the {{/select}} handler. In our
> environment we make heavy usage of pre-configured Solr handlers. We could not
> find any reason to limit coordinator calls to the {{/select}} handler and
> removed the limitation.
> h3. Coordinator requests cannot be identified by Solr response
> With any Solr response you cannot distinguish coordinator from proxied (or
> regular) requests. While this is great for consistency it makes testing extra
> hard. We added an extra Solr header field with the coordinator node name
> called {{requestCoordinatorNode}} when debug is enabled. This eases testing
> and debugging a lot.
>
> A Pull Request is in the making!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17334) Minor bugs in Solr dedicated coordinator mode
[
https://issues.apache.org/jira/browse/SOLR-17334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922900#comment-17922900
]
Noble Paul commented on SOLR-17334:
---
yes, this can be closed now
> Minor bugs in Solr dedicated coordinator mode
> -
>
> Key: SOLR-17334
> URL: https://issues.apache.org/jira/browse/SOLR-17334
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
>Affects Versions: 9.6
>Reporter: Torsten Bøgh Köster
>Assignee: Noble Paul
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> We recently put dedicated Solr coordinator nodes into production and stumbled
> upon some minor bugs/improvements:
> - The Solr root resource cannot be requested on a coordinator node
> - Coordinator requests are enabled for the {{/select}} handler only
> - From outside proxied and coordinator requests cannot be distinguished
> h3. Solr root resource
> We adopted a general fix from the {{HttpSolrCall}} to check whether the given
> {{collectionName}} is {{{}null{}}}. This fixes requesting the root resource
> (and maybe other similar requests)
> h3. {{/select}} handler only
> Coordinator requests are limited to the {{/select}} handler. In our
> environment we make heavy usage of pre-configured Solr handlers. We could not
> find any reason to limit coordinator calls to the {{/select}} handler and
> removed the limitation.
> h3. Coordinator requests cannot be identified by Solr response
> With any Solr response you cannot distinguish coordinator from proxied (or
> regular) requests. While this is great for consistency it makes testing extra
> hard. We added an extra Solr header field with the coordinator node name
> called {{requestCoordinatorNode}} when debug is enabled. This eases testing
> and debugging a lot.
>
> A Pull Request is in the making!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17334) Minor bugs in Solr dedicated coordinator mode
[
https://issues.apache.org/jira/browse/SOLR-17334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921874#comment-17921874
]
Anshum Gupta commented on SOLR-17334:
-
is this good to be closed?
> Minor bugs in Solr dedicated coordinator mode
> -
>
> Key: SOLR-17334
> URL: https://issues.apache.org/jira/browse/SOLR-17334
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
>Affects Versions: 9.6
>Reporter: Torsten Bøgh Köster
>Assignee: Noble Paul
>Priority: Major
> Labels: pull-request-available
> Fix For: 9.8
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> We recently put dedicated Solr coordinator nodes into production and stumbled
> upon some minor bugs/improvements:
> - The Solr root resource cannot be requested on a coordinator node
> - Coordinator requests are enabled for the {{/select}} handler only
> - From outside proxied and coordinator requests cannot be distinguished
> h3. Solr root resource
> We adopted a general fix from the {{HttpSolrCall}} to check whether the given
> {{collectionName}} is {{{}null{}}}. This fixes requesting the root resource
> (and maybe other similar requests)
> h3. {{/select}} handler only
> Coordinator requests are limited to the {{/select}} handler. In our
> environment we make heavy usage of pre-configured Solr handlers. We could not
> find any reason to limit coordinator calls to the {{/select}} handler and
> removed the limitation.
> h3. Coordinator requests cannot be identified by Solr response
> With any Solr response you cannot distinguish coordinator from proxied (or
> regular) requests. While this is great for consistency it makes testing extra
> hard. We added an extra Solr header field with the coordinator node name
> called {{requestCoordinatorNode}} when debug is enabled. This eases testing
> and debugging a lot.
>
> A Pull Request is in the making!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17334) Minor bugs in Solr dedicated coordinator mode
[
https://issues.apache.org/jira/browse/SOLR-17334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869683#comment-17869683
]
ella eln commented on SOLR-17334:
-
I think the header is a great Idea. I am developing a fix for costume RH right
now and a header in debug would be a great help, where can I find it?
> Minor bugs in Solr dedicated coordinator mode
> -
>
> Key: SOLR-17334
> URL: https://issues.apache.org/jira/browse/SOLR-17334
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: 9.6
>Reporter: Torsten Bøgh Köster
>Assignee: Noble Paul
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We recently put dedicated Solr coordinator nodes into production and stumbled
> upon some minor bugs/improvements:
> - The Solr root resource cannot be requested on a coordinator node
> - Coordinator requests are enabled for the {{/select}} handler only
> - From outside proxied and coordinator requests cannot be distinguished
> h3. Solr root resource
> We adopted a general fix from the {{HttpSolrCall}} to check whether the given
> {{collectionName}} is {{{}null{}}}. This fixes requesting the root resource
> (and maybe other similar requests)
> h3. {{/select}} handler only
> Coordinator requests are limited to the {{/select}} handler. In our
> environment we make heavy usage of pre-configured Solr handlers. We could not
> find any reason to limit coordinator calls to the {{/select}} handler and
> removed the limitation.
> h3. Coordinator requests cannot be identified by Solr response
> With any Solr response you cannot distinguish coordinator from proxied (or
> regular) requests. While this is great for consistency it makes testing extra
> hard. We added an extra Solr header field with the coordinator node name
> called {{requestCoordinatorNode}} when debug is enabled. This eases testing
> and debugging a lot.
>
> A Pull Request is in the making!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
