[jira] [Commented] (SOLR-17448) Audit usage of ExecutorService#submit in Solr codebase
[ https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945732#comment-17945732 ] ASF subversion and git services commented on SOLR-17448: Commit 849ec5b7c52eb6bf43c2b5b69eb8b2c0d55ab416 in solr's branch refs/heads/add-pki-caching from Sanjay Dutt [ https://gitbox.apache.org/repos/asf?p=solr.git;h=849ec5b7c52 ] SOLR-17448 SOLR-17497: IndexFetcher, catch exception instead of bubbling up uncaught (#2800) (cherry picked from commit cc30093c5ee988555389b50cf2333edf743bb50f) > Audit usage of ExecutorService#submit in Solr codebase > -- > > Key: SOLR-17448 > URL: https://issues.apache.org/jira/browse/SOLR-17448 > Project: Solr > Issue Type: Improvement >Affects Versions: 9.7 >Reporter: Andrey Bozhko >Priority: Minor > Labels: pull-request-available > Fix For: 9.8 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > There are quite a few places in Solr codebase where the background task is > created by invoking `ExecutorService#submit(...)` method - but where the > reference to the returned future is not retained. > So if the background task fails for any reason, and the task doesn't itself > have a try-catch block to log the failure, - the failure will go completely > unnoticed. > > This ticket is to review the usage of ExecutorService#submit method in the > codebase, and replace those with Executor#execute where appropriate. > > Originally brought up in the dev mailing list: > [https://lists.apache.org/thread/5f1965rltcspgw0j8nzcn2qnz9l4s8qm] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17448) Audit usage of ExecutorService#submit in Solr codebase
[ https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895333#comment-17895333 ] ASF subversion and git services commented on SOLR-17448: Commit 4c211ba5be43c63d3b9a7ccf5810b4aa73960e80 in solr's branch refs/heads/branch_9_7 from Sanjay Dutt [ https://gitbox.apache.org/repos/asf?p=solr.git;h=4c211ba5be4 ] SOLR-17448 SOLR-17497: IndexFetcher, catch exception instead of bubbling up uncaught (#2800) (cherry picked from commit cc30093c5ee988555389b50cf2333edf743bb50f) > Audit usage of ExecutorService#submit in Solr codebase > -- > > Key: SOLR-17448 > URL: https://issues.apache.org/jira/browse/SOLR-17448 > Project: Solr > Issue Type: Improvement >Affects Versions: 9.7 >Reporter: Andrey Bozhko >Priority: Minor > Labels: pull-request-available > Fix For: 9.8 > > Time Spent: 2.5h > Remaining Estimate: 0h > > There are quite a few places in Solr codebase where the background task is > created by invoking `ExecutorService#submit(...)` method - but where the > reference to the returned future is not retained. > So if the background task fails for any reason, and the task doesn't itself > have a try-catch block to log the failure, - the failure will go completely > unnoticed. > > This ticket is to review the usage of ExecutorService#submit method in the > codebase, and replace those with Executor#execute where appropriate. > > Originally brought up in the dev mailing list: > [https://lists.apache.org/thread/5f1965rltcspgw0j8nzcn2qnz9l4s8qm] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17448) Audit usage of ExecutorService#submit in Solr codebase
[ https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894874#comment-17894874 ] Andrey Bozhko commented on SOLR-17448: -- Thanks for letting me know - I can take a look and investigate the flaky builds. > Audit usage of ExecutorService#submit in Solr codebase > -- > > Key: SOLR-17448 > URL: https://issues.apache.org/jira/browse/SOLR-17448 > Project: Solr > Issue Type: Improvement >Affects Versions: 9.7 >Reporter: Andrey Bozhko >Priority: Minor > Labels: pull-request-available > Fix For: 9.8 > > Time Spent: 2.5h > Remaining Estimate: 0h > > There are quite a few places in Solr codebase where the background task is > created by invoking `ExecutorService#submit(...)` method - but where the > reference to the returned future is not retained. > So if the background task fails for any reason, and the task doesn't itself > have a try-catch block to log the failure, - the failure will go completely > unnoticed. > > This ticket is to review the usage of ExecutorService#submit method in the > codebase, and replace those with Executor#execute where appropriate. > > Originally brought up in the dev mailing list: > [https://lists.apache.org/thread/5f1965rltcspgw0j8nzcn2qnz9l4s8qm] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17448) Audit usage of ExecutorService#submit in Solr codebase
[ https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894646#comment-17894646 ] ASF subversion and git services commented on SOLR-17448: Commit 9a9d922088c982508f17e537f5db7bf407a1b037 in solr's branch refs/heads/branch_9x from Sanjay Dutt [ https://gitbox.apache.org/repos/asf?p=solr.git;h=9a9d922088c ] SOLR-17448 SOLR-17497: IndexFetcher, catch exception instead of bubbling up uncaught (#2800) (cherry picked from commit cc30093c5ee988555389b50cf2333edf743bb50f) > Audit usage of ExecutorService#submit in Solr codebase > -- > > Key: SOLR-17448 > URL: https://issues.apache.org/jira/browse/SOLR-17448 > Project: Solr > Issue Type: Improvement >Affects Versions: 9.7 >Reporter: Andrey Bozhko >Priority: Minor > Labels: pull-request-available > Fix For: 9.8 > > Time Spent: 2.5h > Remaining Estimate: 0h > > There are quite a few places in Solr codebase where the background task is > created by invoking `ExecutorService#submit(...)` method - but where the > reference to the returned future is not retained. > So if the background task fails for any reason, and the task doesn't itself > have a try-catch block to log the failure, - the failure will go completely > unnoticed. > > This ticket is to review the usage of ExecutorService#submit method in the > codebase, and replace those with Executor#execute where appropriate. > > Originally brought up in the dev mailing list: > [https://lists.apache.org/thread/5f1965rltcspgw0j8nzcn2qnz9l4s8qm] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17448) Audit usage of ExecutorService#submit in Solr codebase
[ https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894640#comment-17894640 ] ASF subversion and git services commented on SOLR-17448: Commit cc30093c5ee988555389b50cf2333edf743bb50f in solr's branch refs/heads/main from Sanjay Dutt [ https://gitbox.apache.org/repos/asf?p=solr.git;h=cc30093c5ee ] SOLR-17448 SOLR-17497: IndexFetcher, catch exception instead of bubbling up uncaught (#2800) > Audit usage of ExecutorService#submit in Solr codebase > -- > > Key: SOLR-17448 > URL: https://issues.apache.org/jira/browse/SOLR-17448 > Project: Solr > Issue Type: Improvement >Affects Versions: 9.7 >Reporter: Andrey Bozhko >Priority: Minor > Labels: pull-request-available > Fix For: 9.8 > > Time Spent: 2.5h > Remaining Estimate: 0h > > There are quite a few places in Solr codebase where the background task is > created by invoking `ExecutorService#submit(...)` method - but where the > reference to the returned future is not retained. > So if the background task fails for any reason, and the task doesn't itself > have a try-catch block to log the failure, - the failure will go completely > unnoticed. > > This ticket is to review the usage of ExecutorService#submit method in the > codebase, and replace those with Executor#execute where appropriate. > > Originally brought up in the dev mailing list: > [https://lists.apache.org/thread/5f1965rltcspgw0j8nzcn2qnz9l4s8qm] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17448) Audit usage of ExecutorService#submit in Solr codebase
[
https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894429#comment-17894429
]
Sanjay Dutt commented on SOLR-17448:
Flaky org.apache.solr.cloud.TestAuthenticationFramework.testBasics
(:solr:core)
{code:java}
Test history:
https://ge.apache.org/scans/tests?search.rootProjectNames=solr-root&tests.container=org.apache.solr.cloud.TestAuthenticationFramework&tests.test=testBasics
http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.cloud.TestAuthenticationFramework.testBasics
Test output:
/home/jenkins/jenkins-slave/workspace/Solr/Solr-Check-9.x/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.cloud.TestAuthenticationFramework.txt
Reproduce with: ./gradlew :solr:core:test --tests
"org.apache.solr.cloud.TestAuthenticationFramework.testBasics" -Ptests.jvms=4
-Ptests.haltonfailure=false "-Ptests.jvmargs=-XX:TieredStopAtLevel=1
-XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m"
-Ptests.seed=BFFF716399BC6DB0 -Ptests.multiplier=2 -Ptests.badapples=false
-Ptests.file.encoding=UTF-8{code}
> Audit usage of ExecutorService#submit in Solr codebase
> --
>
> Key: SOLR-17448
> URL: https://issues.apache.org/jira/browse/SOLR-17448
> Project: Solr
> Issue Type: Improvement
>Affects Versions: 9.7
>Reporter: Andrey Bozhko
>Priority: Minor
> Labels: pull-request-available
> Fix For: 9.8
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> There are quite a few places in Solr codebase where the background task is
> created by invoking `ExecutorService#submit(...)` method - but where the
> reference to the returned future is not retained.
> So if the background task fails for any reason, and the task doesn't itself
> have a try-catch block to log the failure, - the failure will go completely
> unnoticed.
>
> This ticket is to review the usage of ExecutorService#submit method in the
> codebase, and replace those with Executor#execute where appropriate.
>
> Originally brought up in the dev mailing list:
> [https://lists.apache.org/thread/5f1965rltcspgw0j8nzcn2qnz9l4s8qm]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17448) Audit usage of ExecutorService#submit in Solr codebase
[ https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893599#comment-17893599 ] David Smiley commented on SOLR-17448: - BTW there have been some com.carrotsearch.randomizedtesting.UncaughtExceptionError errors cropping up that likely came about due to this refactoring. -- SOLR-17497. It'd be helpful [~andreybozhko] if you could scan the failing builds for this error and see if any of them appear to be related. > Audit usage of ExecutorService#submit in Solr codebase > -- > > Key: SOLR-17448 > URL: https://issues.apache.org/jira/browse/SOLR-17448 > Project: Solr > Issue Type: Improvement >Affects Versions: 9.7 >Reporter: Andrey Bozhko >Priority: Minor > Labels: pull-request-available > Fix For: 9.8 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > There are quite a few places in Solr codebase where the background task is > created by invoking `ExecutorService#submit(...)` method - but where the > reference to the returned future is not retained. > So if the background task fails for any reason, and the task doesn't itself > have a try-catch block to log the failure, - the failure will go completely > unnoticed. > > This ticket is to review the usage of ExecutorService#submit method in the > codebase, and replace those with Executor#execute where appropriate. > > Originally brought up in the dev mailing list: > [https://lists.apache.org/thread/5f1965rltcspgw0j8nzcn2qnz9l4s8qm] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17448) Audit usage of ExecutorService#submit in Solr codebase
[ https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885204#comment-17885204 ] ASF subversion and git services commented on SOLR-17448: Commit 758d1d7156f8d90faa3671c0527746e2ae7eb5de in solr's branch refs/heads/main from Andrey Bozhko [ https://gitbox.apache.org/repos/asf?p=solr.git;h=758d1d7156f ] SOLR-17448: Audit usage of ExecutorService#submit (#2707) Fixed inadvertent suppression of exceptions in the background tasks across the codebase. For certain tasks that were scheduled via ExecutorService#submit, the results of the task execution were never examined which led to the suppression of exceptions. > Audit usage of ExecutorService#submit in Solr codebase > -- > > Key: SOLR-17448 > URL: https://issues.apache.org/jira/browse/SOLR-17448 > Project: Solr > Issue Type: Improvement >Affects Versions: 9.7 >Reporter: Andrey Bozhko >Priority: Minor > Labels: pull-request-available > Time Spent: 2h 20m > Remaining Estimate: 0h > > There are quite a few places in Solr codebase where the background task is > created by invoking `ExecutorService#submit(...)` method - but where the > reference to the returned future is not retained. > So if the background task fails for any reason, and the task doesn't itself > have a try-catch block to log the failure, - the failure will go completely > unnoticed. > > This ticket is to review the usage of ExecutorService#submit method in the > codebase, and replace those with Executor#execute where appropriate. > > Originally brought up in the dev mailing list: > [https://lists.apache.org/thread/5f1965rltcspgw0j8nzcn2qnz9l4s8qm] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
