[jira] [Commented] (SOLR-17548) Switch all public Java APIs from File to Path
[ https://issues.apache.org/jira/browse/SOLR-17548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944716#comment-17944716 ] Matthew Biscocho commented on SOLR-17548: - Yep, this should be finished. > Switch all public Java APIs from File to Path > - > > Key: SOLR-17548 > URL: https://issues.apache.org/jira/browse/SOLR-17548 > Project: Solr > Issue Type: Task >Reporter: David Smiley >Priority: Major > Labels: newdev, pull-request-available > Fix For: main (10.0) > > Time Spent: 2h 50m > Remaining Estimate: 0h > > Change all java.io.File parameters (and return types) of publicly visible > methods/constructors to java.nio.file.Path. > It's acceptable to simply do type conversion back/forth; the conversion could > happen whenever. And it's also acceptable to only do non-tests. The scope > is limited here so as to make this achievable for Solr 10 without much work. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17548) Switch all public Java APIs from File to Path
[ https://issues.apache.org/jira/browse/SOLR-17548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922210#comment-17922210 ] ASF subversion and git services commented on SOLR-17548: Commit b2cf5abf13f303d0e16df05b06e00ceed3828a98 in solr's branch refs/heads/branch_9_8 from Houston Putman [ https://gitbox.apache.org/repos/asf?p=solr.git;h=b2cf5abf13f ] Fix TestReplicationHandler (#3142) Addresses a combination of SOLR-17306 and SOLR-17548. (cherry picked from commit a5b0b98a79559021e44d00b43fff6c020c54f829) > Switch all public Java APIs from File to Path > - > > Key: SOLR-17548 > URL: https://issues.apache.org/jira/browse/SOLR-17548 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Priority: Major > Labels: newdev, pull-request-available > Fix For: main (10.0) > > Time Spent: 2h 50m > Remaining Estimate: 0h > > Change all java.io.File parameters (and return types) of publicly visible > methods/constructors to java.nio.file.Path. > It's acceptable to simply do type conversion back/forth; the conversion could > happen whenever. And it's also acceptable to only do non-tests. The scope > is limited here so as to make this achievable for Solr 10 without much work. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17548) Switch all public Java APIs from File to Path
[ https://issues.apache.org/jira/browse/SOLR-17548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922203#comment-17922203 ] ASF subversion and git services commented on SOLR-17548: Commit 22706cd3d9da0f6a73a3d6004f583add5a5e1992 in solr's branch refs/heads/branch_9x from Houston Putman [ https://gitbox.apache.org/repos/asf?p=solr.git;h=22706cd3d9d ] Fix TestReplicationHandler (#3142) Addresses a combination of SOLR-17306 and SOLR-17548. (cherry picked from commit a5b0b98a79559021e44d00b43fff6c020c54f829) > Switch all public Java APIs from File to Path > - > > Key: SOLR-17548 > URL: https://issues.apache.org/jira/browse/SOLR-17548 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Priority: Major > Labels: newdev, pull-request-available > Fix For: main (10.0) > > Time Spent: 2h 50m > Remaining Estimate: 0h > > Change all java.io.File parameters (and return types) of publicly visible > methods/constructors to java.nio.file.Path. > It's acceptable to simply do type conversion back/forth; the conversion could > happen whenever. And it's also acceptable to only do non-tests. The scope > is limited here so as to make this achievable for Solr 10 without much work. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17548) Switch all public Java APIs from File to Path
[ https://issues.apache.org/jira/browse/SOLR-17548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922183#comment-17922183 ] ASF subversion and git services commented on SOLR-17548: Commit a5b0b98a79559021e44d00b43fff6c020c54f829 in solr's branch refs/heads/main from Houston Putman [ https://gitbox.apache.org/repos/asf?p=solr.git;h=a5b0b98a795 ] Fix TestReplicationHandler (#3142) Addresses a combination of SOLR-17306 and SOLR-17548. > Switch all public Java APIs from File to Path > - > > Key: SOLR-17548 > URL: https://issues.apache.org/jira/browse/SOLR-17548 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Priority: Major > Labels: newdev, pull-request-available > Fix For: main (10.0) > > Time Spent: 2h 50m > Remaining Estimate: 0h > > Change all java.io.File parameters (and return types) of publicly visible > methods/constructors to java.nio.file.Path. > It's acceptable to simply do type conversion back/forth; the conversion could > happen whenever. And it's also acceptable to only do non-tests. The scope > is limited here so as to make this achievable for Solr 10 without much work. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17548) Switch all public Java APIs from File to Path
[ https://issues.apache.org/jira/browse/SOLR-17548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905525#comment-17905525 ] Matthew Biscocho commented on SOLR-17548: - Ended up picking this up. Tried to keep it within scope of just modifying methods/constructors and its return types to Path. I had marked some places with TODO where more work is required to fully move to Path unless it was trivial. The changes for larger work to migrate I had wrote out but will hold them for now and kept it out of the PR. > Switch all public Java APIs from File to Path > - > > Key: SOLR-17548 > URL: https://issues.apache.org/jira/browse/SOLR-17548 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) >Reporter: David Smiley >Priority: Major > Labels: newdev, pull-request-available > Fix For: main (10.0) > > Time Spent: 10m > Remaining Estimate: 0h > > Change all java.io.File parameters (and return types) of publicly visible > methods/constructors to java.nio.file.Path. > It's acceptable to simply do type conversion back/forth; the conversion could > happen whenever. And it's also acceptable to only do non-tests. The scope > is limited here so as to make this achievable for Solr 10 without much work. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
