[jira] [Commented] (SOLR-17772) Tests for examples failing on Windows
[ https://issues.apache.org/jira/browse/SOLR-17772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17966778#comment-17966778 ] Rahul Goswami commented on SOLR-17772: -- [~dsmiley] Yes this can be marked Resolved for 10. > Tests for examples failing on Windows > - > > Key: SOLR-17772 > URL: https://issues.apache.org/jira/browse/SOLR-17772 > Project: Solr > Issue Type: Bug > Components: cli >Reporter: Rahul Goswami >Priority: Minor > Labels: pull-request-available, windows > Time Spent: 10m > Remaining Estimate: 0h > > This change only impacts _*tests*_ on Windows. Post the fix for jvm-opts, > command line execution runs fine. > The start flow via solr.cmd passes a "--script" parameter (which our tests > don't) and uses a different executor inside RunExampleTool from what the > tests use (RunExampleExecutor). Prior to recently merged fix for jvm-opts, > because of these reasons, the tests on Windows would also try to prepare a > command line with bin/solr (instead of bin/solr.cmd). Hence those tests would > pass getting into the "if" block in this PR, although in an unintended way. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17772) Tests for examples failing on Windows
[ https://issues.apache.org/jira/browse/SOLR-17772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17965201#comment-17965201 ] David Smiley commented on SOLR-17772: - Thanks for contributing Rahul! [~epugh] when merging, please clean up the commit message. Is this issue ready to mark as Resolved for 10? > Tests for examples failing on Windows > - > > Key: SOLR-17772 > URL: https://issues.apache.org/jira/browse/SOLR-17772 > Project: Solr > Issue Type: Bug > Components: cli >Reporter: Rahul Goswami >Priority: Minor > Labels: pull-request-available, windows > Time Spent: 10m > Remaining Estimate: 0h > > This change only impacts _*tests*_ on Windows. Post the fix for jvm-opts, > command line execution runs fine. > The start flow via solr.cmd passes a "--script" parameter (which our tests > don't) and uses a different executor inside RunExampleTool from what the > tests use (RunExampleExecutor). Prior to recently merged fix for jvm-opts, > because of these reasons, the tests on Windows would also try to prepare a > command line with bin/solr (instead of bin/solr.cmd). Hence those tests would > pass getting into the "if" block in this PR, although in an unintended way. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17772) Tests for examples failing on Windows
[ https://issues.apache.org/jira/browse/SOLR-17772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955011#comment-17955011 ] ASF subversion and git services commented on SOLR-17772: Commit e714925a32a5146f274c267cc3265aa13be51372 in solr's branch refs/heads/main from Rahul Goswami [ https://gitbox.apache.org/repos/asf?p=solr.git;h=e714925a32a ] SOLR-17772: Tests for examples failing on Windows (#3378) * tests for examples failing on Windows * simplify CLI tests * CHANGES.txt * move entry to 10.0 instead of 9.9 in CHANGES.txt > Tests for examples failing on Windows > - > > Key: SOLR-17772 > URL: https://issues.apache.org/jira/browse/SOLR-17772 > Project: Solr > Issue Type: Bug > Components: cli >Reporter: Rahul Goswami >Priority: Minor > Labels: pull-request-available, windows > Time Spent: 10m > Remaining Estimate: 0h > > This change only impacts _*tests*_ on Windows. Post the fix for jvm-opts, > command line execution runs fine. > The start flow via solr.cmd passes a "--script" parameter (which our tests > don't) and uses a different executor inside RunExampleTool from what the > tests use (RunExampleExecutor). Prior to recently merged fix for jvm-opts, > because of these reasons, the tests on Windows would also try to prepare a > command line with bin/solr (instead of bin/solr.cmd). Hence those tests would > pass getting into the "if" block in this PR, although in an unintended way. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
