[jira] [Commented] (SOLR-17776) Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts
[ https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17986926#comment-17986926 ] ASF subversion and git services commented on SOLR-17776: Commit 5719866a0b5ab6bf881f30010fb01b936e6d3a19 in solr's branch refs/heads/fix-native-access-warning from Houston Putman [ https://gitbox.apache.org/repos/asf?p=solr.git;h=5719866a0b5 ] SOLR-17776: Fix over-checking of http1 flag in Http2SolrClient (#3400) > Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts > > > Key: SOLR-17776 > URL: https://issues.apache.org/jira/browse/SOLR-17776 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Labels: pull-request-available > Fix For: 9.9 > > Time Spent: 2h > Remaining Estimate: 0h > > See the linked dev list thread. Summary: > If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in > 9.8, shifted from deprecated Apache HttpClient based clients): settings > affecting HttpClient construction cannot be customized; an > IllegalStateException will now be thrown if you try. The connection timeout > cannot be customized, but idle & request timeouts can be. Callers (various > places in Solr) should no longer customize the connection timeout. > Additionally, there's a bug wherein withHttpClient usage meant that the idle > & request timeouts couldn't be increased. > The HttpJdkSolrClient wasn't setting the connection timeout as per the > builder configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17776) Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts
[ https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17986933#comment-17986933 ] ASF subversion and git services commented on SOLR-17776: Commit c36283c753e56c635a271497412f81056cbd70e2 in solr's branch refs/heads/fix-native-access-warning from David Smiley [ https://gitbox.apache.org/repos/asf?p=solr.git;h=c36283c753e ] SOLR-17776: Fix test Also improved testRequestTimeoutWithHttpClient to be structured like the idle timeout test. > Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts > > > Key: SOLR-17776 > URL: https://issues.apache.org/jira/browse/SOLR-17776 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Labels: pull-request-available > Fix For: 9.9 > > Time Spent: 2h > Remaining Estimate: 0h > > See the linked dev list thread. Summary: > If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in > 9.8, shifted from deprecated Apache HttpClient based clients): settings > affecting HttpClient construction cannot be customized; an > IllegalStateException will now be thrown if you try. The connection timeout > cannot be customized, but idle & request timeouts can be. Callers (various > places in Solr) should no longer customize the connection timeout. > Additionally, there's a bug wherein withHttpClient usage meant that the idle > & request timeouts couldn't be increased. > The HttpJdkSolrClient wasn't setting the connection timeout as per the > builder configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17776) Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts
[ https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17986922#comment-17986922 ] ASF subversion and git services commented on SOLR-17776: Commit 9b584fa5c6b0d6fb19ba0015b6ad43d242ce4e1a in solr's branch refs/heads/fix-native-access-warning from David Smiley [ https://gitbox.apache.org/repos/asf?p=solr.git;h=9b584fa5c6b ] SOLR-17776: Undo unintended internal edits These were minor internal organizational changes > Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts > > > Key: SOLR-17776 > URL: https://issues.apache.org/jira/browse/SOLR-17776 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Labels: pull-request-available > Fix For: 9.9 > > Time Spent: 2h > Remaining Estimate: 0h > > See the linked dev list thread. Summary: > If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in > 9.8, shifted from deprecated Apache HttpClient based clients): settings > affecting HttpClient construction cannot be customized; an > IllegalStateException will now be thrown if you try. The connection timeout > cannot be customized, but idle & request timeouts can be. Callers (various > places in Solr) should no longer customize the connection timeout. > Additionally, there's a bug wherein withHttpClient usage meant that the idle > & request timeouts couldn't be increased. > The HttpJdkSolrClient wasn't setting the connection timeout as per the > builder configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17776) Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts
[ https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17986921#comment-17986921 ] ASF subversion and git services commented on SOLR-17776: Commit dd89cd604a6dd563f15dfcec4f7a9ce5076b2410 in solr's branch refs/heads/fix-native-access-warning from David Smiley [ https://gitbox.apache.org/repos/asf?p=solr.git;h=dd89cd604a6 ] SOLR-17776: Harmonize SolrJ timeouts (#3357) SolrJ: If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in 9.8, shifted from deprecated Apache HttpClient based clients), settings affecting HttpClient construction cannot be customized; an IllegalStateException will now be thrown if you try. The connection timeout cannot be customized, but idle & request timeouts can be. Callers (various places in Solr) no longer customize the connection timeout. The HttpJdkSolrClient wasn't setting the connection timeout as per the builder configuration. Co-authored-by: Luke Kot-Zaniewski > Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts > > > Key: SOLR-17776 > URL: https://issues.apache.org/jira/browse/SOLR-17776 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Labels: pull-request-available > Fix For: 9.9 > > Time Spent: 2h > Remaining Estimate: 0h > > See the linked dev list thread. Summary: > If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in > 9.8, shifted from deprecated Apache HttpClient based clients): settings > affecting HttpClient construction cannot be customized; an > IllegalStateException will now be thrown if you try. The connection timeout > cannot be customized, but idle & request timeouts can be. Callers (various > places in Solr) should no longer customize the connection timeout. > Additionally, there's a bug wherein withHttpClient usage meant that the idle > & request timeouts couldn't be increased. > The HttpJdkSolrClient wasn't setting the connection timeout as per the > builder configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17776) Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts
[ https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17986492#comment-17986492 ] David Smiley commented on SOLR-17776: - Thanks for the heads-up... I wish the build could notify me directly without your legwork/nagging. > Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts > > > Key: SOLR-17776 > URL: https://issues.apache.org/jira/browse/SOLR-17776 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Labels: pull-request-available > Fix For: 9.9 > > Time Spent: 2h > Remaining Estimate: 0h > > See the linked dev list thread. Summary: > If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in > 9.8, shifted from deprecated Apache HttpClient based clients): settings > affecting HttpClient construction cannot be customized; an > IllegalStateException will now be thrown if you try. The connection timeout > cannot be customized, but idle & request timeouts can be. Callers (various > places in Solr) should no longer customize the connection timeout. > Additionally, there's a bug wherein withHttpClient usage meant that the idle > & request timeouts couldn't be increased. > The HttpJdkSolrClient wasn't setting the connection timeout as per the > builder configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17776) Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts
[ https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17986491#comment-17986491 ] ASF subversion and git services commented on SOLR-17776: Commit e5331626e873ae2fc5ae8e3134c736f3ccc9012e in solr's branch refs/heads/branch_9x from David Smiley [ https://gitbox.apache.org/repos/asf?p=solr.git;h=e5331626e87 ] SOLR-17776: Fix test Also improved testRequestTimeoutWithHttpClient to be structured like the idle timeout test. (cherry picked from commit c36283c753e56c635a271497412f81056cbd70e2) > Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts > > > Key: SOLR-17776 > URL: https://issues.apache.org/jira/browse/SOLR-17776 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Labels: pull-request-available > Fix For: 9.9 > > Time Spent: 2h > Remaining Estimate: 0h > > See the linked dev list thread. Summary: > If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in > 9.8, shifted from deprecated Apache HttpClient based clients): settings > affecting HttpClient construction cannot be customized; an > IllegalStateException will now be thrown if you try. The connection timeout > cannot be customized, but idle & request timeouts can be. Callers (various > places in Solr) should no longer customize the connection timeout. > Additionally, there's a bug wherein withHttpClient usage meant that the idle > & request timeouts couldn't be increased. > The HttpJdkSolrClient wasn't setting the connection timeout as per the > builder configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17776) Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts
[ https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17986488#comment-17986488 ] ASF subversion and git services commented on SOLR-17776: Commit c36283c753e56c635a271497412f81056cbd70e2 in solr's branch refs/heads/main from David Smiley [ https://gitbox.apache.org/repos/asf?p=solr.git;h=c36283c753e ] SOLR-17776: Fix test Also improved testRequestTimeoutWithHttpClient to be structured like the idle timeout test. > Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts > > > Key: SOLR-17776 > URL: https://issues.apache.org/jira/browse/SOLR-17776 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Labels: pull-request-available > Fix For: 9.9 > > Time Spent: 2h > Remaining Estimate: 0h > > See the linked dev list thread. Summary: > If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in > 9.8, shifted from deprecated Apache HttpClient based clients): settings > affecting HttpClient construction cannot be customized; an > IllegalStateException will now be thrown if you try. The connection timeout > cannot be customized, but idle & request timeouts can be. Callers (various > places in Solr) should no longer customize the connection timeout. > Additionally, there's a bug wherein withHttpClient usage meant that the idle > & request timeouts couldn't be increased. > The HttpJdkSolrClient wasn't setting the connection timeout as per the > builder configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17776) Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts
[ https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17986426#comment-17986426 ] Houston Putman commented on SOLR-17776: --- [~dsmiley] Http2SolrClientTest.testIdleTimeoutWithHttpClient and Http2SolrClientTest.testRequestTimeoutWithHttpClient are failing after this: [http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.client.solrj.impl.Http2SolrClientTest.testIdleTimeoutWithHttpClient] > Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts > > > Key: SOLR-17776 > URL: https://issues.apache.org/jira/browse/SOLR-17776 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Labels: pull-request-available > Fix For: 9.9 > > Time Spent: 2h > Remaining Estimate: 0h > > See the linked dev list thread. Summary: > If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in > 9.8, shifted from deprecated Apache HttpClient based clients): settings > affecting HttpClient construction cannot be customized; an > IllegalStateException will now be thrown if you try. The connection timeout > cannot be customized, but idle & request timeouts can be. Callers (various > places in Solr) should no longer customize the connection timeout. > Additionally, there's a bug wherein withHttpClient usage meant that the idle > & request timeouts couldn't be increased. > The HttpJdkSolrClient wasn't setting the connection timeout as per the > builder configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17776) Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts
[ https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985692#comment-17985692 ] ASF subversion and git services commented on SOLR-17776: Commit 5719866a0b5ab6bf881f30010fb01b936e6d3a19 in solr's branch refs/heads/main from Houston Putman [ https://gitbox.apache.org/repos/asf?p=solr.git;h=5719866a0b5 ] SOLR-17776: Fix over-checking of http1 flag in Http2SolrClient (#3400) > Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts > > > Key: SOLR-17776 > URL: https://issues.apache.org/jira/browse/SOLR-17776 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Labels: pull-request-available > Fix For: 9.9 > > Time Spent: 2h > Remaining Estimate: 0h > > See the linked dev list thread. Summary: > If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in > 9.8, shifted from deprecated Apache HttpClient based clients): settings > affecting HttpClient construction cannot be customized; an > IllegalStateException will now be thrown if you try. The connection timeout > cannot be customized, but idle & request timeouts can be. Callers (various > places in Solr) should no longer customize the connection timeout. > Additionally, there's a bug wherein withHttpClient usage meant that the idle > & request timeouts couldn't be increased. > The HttpJdkSolrClient wasn't setting the connection timeout as per the > builder configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17776) Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts
[ https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985693#comment-17985693 ] ASF subversion and git services commented on SOLR-17776: Commit 383d08523c2d73633f49500323ff1dc6b5d4f745 in solr's branch refs/heads/branch_9x from Houston Putman [ https://gitbox.apache.org/repos/asf?p=solr.git;h=383d08523c2 ] SOLR-17776: Fix over-checking of http1 flag in Http2SolrClient (#3400) (cherry picked from commit 5719866a0b5ab6bf881f30010fb01b936e6d3a19) > Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts > > > Key: SOLR-17776 > URL: https://issues.apache.org/jira/browse/SOLR-17776 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Labels: pull-request-available > Fix For: 9.9 > > Time Spent: 2h > Remaining Estimate: 0h > > See the linked dev list thread. Summary: > If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in > 9.8, shifted from deprecated Apache HttpClient based clients): settings > affecting HttpClient construction cannot be customized; an > IllegalStateException will now be thrown if you try. The connection timeout > cannot be customized, but idle & request timeouts can be. Callers (various > places in Solr) should no longer customize the connection timeout. > Additionally, there's a bug wherein withHttpClient usage meant that the idle > & request timeouts couldn't be increased. > The HttpJdkSolrClient wasn't setting the connection timeout as per the > builder configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17776) Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts
[ https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17983427#comment-17983427 ] ASF subversion and git services commented on SOLR-17776: Commit 9dd21d5918563dba53a647760819668a0a754311 in solr's branch refs/heads/branch_9x from David Smiley [ https://gitbox.apache.org/repos/asf?p=solr.git;h=9dd21d59185 ] SOLR-17776: Undo unintended internal edits These were minor internal organizational changes (cherry picked from commit 9b584fa5c6b0d6fb19ba0015b6ad43d242ce4e1a) > Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts > > > Key: SOLR-17776 > URL: https://issues.apache.org/jira/browse/SOLR-17776 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Priority: Major > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > > See the linked dev list thread. Summary: > If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in > 9.8, shifted from deprecated Apache HttpClient based clients): settings > affecting HttpClient construction cannot be customized; an > IllegalStateException will now be thrown if you try. The connection timeout > cannot be customized, but idle & request timeouts can be. Callers (various > places in Solr) should no longer customize the connection timeout. > Additionally, there's a bug wherein withHttpClient usage meant that the idle > & request timeouts couldn't be increased. > The HttpJdkSolrClient wasn't setting the connection timeout as per the > builder configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17776) Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts
[ https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17983425#comment-17983425 ] ASF subversion and git services commented on SOLR-17776: Commit 9b584fa5c6b0d6fb19ba0015b6ad43d242ce4e1a in solr's branch refs/heads/main from David Smiley [ https://gitbox.apache.org/repos/asf?p=solr.git;h=9b584fa5c6b ] SOLR-17776: Undo unintended internal edits These were minor internal organizational changes > Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts > > > Key: SOLR-17776 > URL: https://issues.apache.org/jira/browse/SOLR-17776 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Priority: Major > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > > See the linked dev list thread. Summary: > If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in > 9.8, shifted from deprecated Apache HttpClient based clients): settings > affecting HttpClient construction cannot be customized; an > IllegalStateException will now be thrown if you try. The connection timeout > cannot be customized, but idle & request timeouts can be. Callers (various > places in Solr) should no longer customize the connection timeout. > Additionally, there's a bug wherein withHttpClient usage meant that the idle > & request timeouts couldn't be increased. > The HttpJdkSolrClient wasn't setting the connection timeout as per the > builder configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17776) Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts
[ https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17982896#comment-17982896 ] ASF subversion and git services commented on SOLR-17776: Commit 1a7647136a6e014bc003018c8e627e358cdf2d7c in solr's branch refs/heads/branch_9x from David Smiley [ https://gitbox.apache.org/repos/asf?p=solr.git;h=1a7647136a6 ] SOLR-17776: Harmonize SolrJ timeouts (#3357) SolrJ: If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in 9.8, shifted from deprecated Apache HttpClient based clients), settings affecting HttpClient construction cannot be customized; an IllegalStateException will now be thrown if you try. The connection timeout cannot be customized, but idle & request timeouts can be. Callers (various places in Solr) no longer customize the connection timeout. The HttpJdkSolrClient wasn't setting the connection timeout as per the builder configuration. Co-authored-by: Luke Kot-Zaniewski (cherry picked from commit dd89cd604a6dd563f15dfcec4f7a9ce5076b2410) > Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts > > > Key: SOLR-17776 > URL: https://issues.apache.org/jira/browse/SOLR-17776 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Priority: Major > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > > See the linked dev list thread. Summary: > If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in > 9.8, shifted from deprecated Apache HttpClient based clients): settings > affecting HttpClient construction cannot be customized; an > IllegalStateException will now be thrown if you try. The connection timeout > cannot be customized, but idle & request timeouts can be. Callers (various > places in Solr) should no longer customize the connection timeout. > Additionally, there's a bug wherein withHttpClient usage meant that the idle > & request timeouts couldn't be increased. > The HttpJdkSolrClient wasn't setting the connection timeout as per the > builder configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17776) Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts
[ https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17982888#comment-17982888 ] ASF subversion and git services commented on SOLR-17776: Commit dd89cd604a6dd563f15dfcec4f7a9ce5076b2410 in solr's branch refs/heads/main from David Smiley [ https://gitbox.apache.org/repos/asf?p=solr.git;h=dd89cd604a6 ] SOLR-17776: Harmonize SolrJ timeouts (#3357) SolrJ: If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in 9.8, shifted from deprecated Apache HttpClient based clients), settings affecting HttpClient construction cannot be customized; an IllegalStateException will now be thrown if you try. The connection timeout cannot be customized, but idle & request timeouts can be. Callers (various places in Solr) no longer customize the connection timeout. The HttpJdkSolrClient wasn't setting the connection timeout as per the builder configuration. Co-authored-by: Luke Kot-Zaniewski > Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts > > > Key: SOLR-17776 > URL: https://issues.apache.org/jira/browse/SOLR-17776 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Priority: Major > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > > See the linked dev list thread. Summary: > If Http2SolrClient.Builder.withHttpClient is used, (and it's used more in > 9.8, shifted from deprecated Apache HttpClient based clients): settings > affecting HttpClient construction cannot be customized; an > IllegalStateException will now be thrown if you try. The connection timeout > cannot be customized, but idle & request timeouts can be. Callers (various > places in Solr) should no longer customize the connection timeout. > Additionally, there's a bug wherein withHttpClient usage meant that the idle > & request timeouts couldn't be increased. > The HttpJdkSolrClient wasn't setting the connection timeout as per the > builder configuration. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
