[jira] [Commented] (SOLR-17787) CborResponseWriter should use content-type: application/cbor
[
https://issues.apache.org/jira/browse/SOLR-17787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18042706#comment-18042706
]
ASF subversion and git services commented on SOLR-17787:
Commit d54027c72371576cde52d1679f7b1a33354c6129 in solr's branch
refs/heads/branch_9x from Sanjay Kumar Yadav
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=d54027c7237 ]
SOLR-17787 CBOR should use content-type: application/cbor
CborResponseWriter should use content-type: application/cbor
backport: slightly 26 instead of 25 bytes in the cbor test payload
(cherry picked from commit b7dcde7c9132cc5548a46eed3898cd6b6233b2d1)
> CborResponseWriter should use content-type: application/cbor
>
>
> Key: SOLR-17787
> URL: https://issues.apache.org/jira/browse/SOLR-17787
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
>Reporter: Yohei Kishimoto
>Priority: Minor
> Labels: newdev, pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Currently, when Solr returns a response in CBOR format, the {{Content-Type}}
> header is {{{}application/octet-stream{}}}, the same as it is for javabin.
> However, the RFC for the CBOR format ([RFC
> 8949|https://datatracker.ietf.org/doc/html/rfc8949#name-media-types-registry])
> specifies that {{application/cbor}} should be used as the
> {{{}Content-Type{}}}.
> Modern HTTP client implementations (for example, Spring's {{{}RestClient{}}})
> have a feature that automatically switches the response deserializer based on
> the {{{}Content-Type{}}}. Due to Solr's current implementation, this feature
> cannot be used, requiring the deserializer to be switched manually.
> By using {{Content-Type: application/cbor}} when returning CBOR-formatted
> responses, Solr would comply with internet standards and potentially reduce
> the implementation cost for HTTP clients.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17787) CborResponseWriter should use content-type: application/cbor
[
https://issues.apache.org/jira/browse/SOLR-17787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18042700#comment-18042700
]
ASF subversion and git services commented on SOLR-17787:
Commit 2e14795634dac2535863394039f6d8e986c64758 in solr's branch
refs/heads/branch_10x from Sanjay Kumar Yadav
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=2e14795634d ]
SOLR-17787 CBOR should use content-type: application/cbor
CborResponseWriter should use content-type: application/cbor
> CborResponseWriter should use content-type: application/cbor
>
>
> Key: SOLR-17787
> URL: https://issues.apache.org/jira/browse/SOLR-17787
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
>Reporter: Yohei Kishimoto
>Priority: Minor
> Labels: newdev, pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Currently, when Solr returns a response in CBOR format, the {{Content-Type}}
> header is {{{}application/octet-stream{}}}, the same as it is for javabin.
> However, the RFC for the CBOR format ([RFC
> 8949|https://datatracker.ietf.org/doc/html/rfc8949#name-media-types-registry])
> specifies that {{application/cbor}} should be used as the
> {{{}Content-Type{}}}.
> Modern HTTP client implementations (for example, Spring's {{{}RestClient{}}})
> have a feature that automatically switches the response deserializer based on
> the {{{}Content-Type{}}}. Due to Solr's current implementation, this feature
> cannot be used, requiring the deserializer to be switched manually.
> By using {{Content-Type: application/cbor}} when returning CBOR-formatted
> responses, Solr would comply with internet standards and potentially reduce
> the implementation cost for HTTP clients.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17787) CborResponseWriter should use content-type: application/cbor
[
https://issues.apache.org/jira/browse/SOLR-17787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18042687#comment-18042687
]
ASF subversion and git services commented on SOLR-17787:
Commit b7dcde7c9132cc5548a46eed3898cd6b6233b2d1 in solr's branch
refs/heads/main from Sanjay Kumar Yadav
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=b7dcde7c913 ]
SOLR-17787 CBOR should use content-type: application/cbor
CborResponseWriter should use content-type: application/cbor
> CborResponseWriter should use content-type: application/cbor
>
>
> Key: SOLR-17787
> URL: https://issues.apache.org/jira/browse/SOLR-17787
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
>Reporter: Yohei Kishimoto
>Priority: Minor
> Labels: newdev, pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Currently, when Solr returns a response in CBOR format, the {{Content-Type}}
> header is {{{}application/octet-stream{}}}, the same as it is for javabin.
> However, the RFC for the CBOR format ([RFC
> 8949|https://datatracker.ietf.org/doc/html/rfc8949#name-media-types-registry])
> specifies that {{application/cbor}} should be used as the
> {{{}Content-Type{}}}.
> Modern HTTP client implementations (for example, Spring's {{{}RestClient{}}})
> have a feature that automatically switches the response deserializer based on
> the {{{}Content-Type{}}}. Due to Solr's current implementation, this feature
> cannot be used, requiring the deserializer to be switched manually.
> By using {{Content-Type: application/cbor}} when returning CBOR-formatted
> responses, Solr would comply with internet standards and potentially reduce
> the implementation cost for HTTP clients.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17787) CborResponseWriter should use content-type: application/cbor
[
https://issues.apache.org/jira/browse/SOLR-17787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18041475#comment-18041475
]
Sanjay Kumar Yadav commented on SOLR-17787:
---
[~dsmiley] pull request for the same - https://github.com/apache/solr/pull/3902
> CborResponseWriter should use content-type: application/cbor
>
>
> Key: SOLR-17787
> URL: https://issues.apache.org/jira/browse/SOLR-17787
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
>Reporter: Yohei Kishimoto
>Priority: Minor
> Labels: newdev, pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, when Solr returns a response in CBOR format, the {{Content-Type}}
> header is {{{}application/octet-stream{}}}, the same as it is for javabin.
> However, the RFC for the CBOR format ([RFC
> 8949|https://datatracker.ietf.org/doc/html/rfc8949#name-media-types-registry])
> specifies that {{application/cbor}} should be used as the
> {{{}Content-Type{}}}.
> Modern HTTP client implementations (for example, Spring's {{{}RestClient{}}})
> have a feature that automatically switches the response deserializer based on
> the {{{}Content-Type{}}}. Due to Solr's current implementation, this feature
> cannot be used, requiring the deserializer to be switched manually.
> By using {{Content-Type: application/cbor}} when returning CBOR-formatted
> responses, Solr would comply with internet standards and potentially reduce
> the implementation cost for HTTP clients.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17787) CborResponseWriter should use content-type: application/cbor
[
https://issues.apache.org/jira/browse/SOLR-17787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18041436#comment-18041436
]
Sanjay Kumar Yadav commented on SOLR-17787:
---
[~dsmiley] I am new to Solr and would like contribute starting with this task.
I have gone through
[https://github.com/apache/solr/blob/main/dev-docs/how-to-contribute.adoc] ,
any thing additional needs to consider before starting.
> CborResponseWriter should use content-type: application/cbor
>
>
> Key: SOLR-17787
> URL: https://issues.apache.org/jira/browse/SOLR-17787
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
>Reporter: Yohei Kishimoto
>Priority: Minor
> Labels: newdev
>
> Currently, when Solr returns a response in CBOR format, the {{Content-Type}}
> header is {{{}application/octet-stream{}}}, the same as it is for javabin.
> However, the RFC for the CBOR format ([RFC
> 8949|https://datatracker.ietf.org/doc/html/rfc8949#name-media-types-registry])
> specifies that {{application/cbor}} should be used as the
> {{{}Content-Type{}}}.
> Modern HTTP client implementations (for example, Spring's {{{}RestClient{}}})
> have a feature that automatically switches the response deserializer based on
> the {{{}Content-Type{}}}. Due to Solr's current implementation, this feature
> cannot be used, requiring the deserializer to be switched manually.
> By using {{Content-Type: application/cbor}} when returning CBOR-formatted
> responses, Solr would comply with internet standards and potentially reduce
> the implementation cost for HTTP clients.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
[jira] [Commented] (SOLR-17787) CborResponseWriter should use content-type: application/cbor
[
https://issues.apache.org/jira/browse/SOLR-17787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17977653#comment-17977653
]
David Smiley commented on SOLR-17787:
-
The change should be here
https://github.com/apache/solr/blob/e17078a98a8ebea1a28853d02527f4dc81da4d6b/solr/core/src/java/org/apache/solr/response/CborResponseWriter.java#L54
> CborResponseWriter should use content-type: application/cbor
>
>
> Key: SOLR-17787
> URL: https://issues.apache.org/jira/browse/SOLR-17787
> Project: Solr
> Issue Type: Improvement
>Reporter: Yohei Kishimoto
>Priority: Minor
>
> Currently, when Solr returns a response in CBOR format, the {{Content-Type}}
> header is {{{}application/octet-stream{}}}, the same as it is for javabin.
> However, the RFC for the CBOR format ([RFC
> 8949|https://datatracker.ietf.org/doc/html/rfc8949#name-media-types-registry])
> specifies that {{application/cbor}} should be used as the
> {{{}Content-Type{}}}.
> Modern HTTP client implementations (for example, Spring's {{{}RestClient{}}})
> have a feature that automatically switches the response deserializer based on
> the {{{}Content-Type{}}}. Due to Solr's current implementation, this feature
> cannot be used, requiring the deserializer to be switched manually.
> By using {{Content-Type: application/cbor}} when returning CBOR-formatted
> responses, Solr would comply with internet standards and potentially reduce
> the implementation cost for HTTP clients.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
