[jira] [Updated] (SOLR-17772) Tests for examples failing on Windows
[ https://issues.apache.org/jira/browse/SOLR-17772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ricardo Anguiano updated SOLR-17772: Reporter: Rahul Goswami (was: Rahul Goswami) > Tests for examples failing on Windows > - > > Key: SOLR-17772 > URL: https://issues.apache.org/jira/browse/SOLR-17772 > Project: Solr > Issue Type: Bug > Components: cli >Reporter: Rahul Goswami >Priority: Minor > Labels: pull-request-available, windows > Fix For: 10.0 > > Time Spent: 10m > Remaining Estimate: 0h > > This change only impacts _*tests*_ on Windows. Post the fix for jvm-opts, > command line execution runs fine. > The start flow via solr.cmd passes a "--script" parameter (which our tests > don't) and uses a different executor inside RunExampleTool from what the > tests use (RunExampleExecutor). Prior to recently merged fix for jvm-opts, > because of these reasons, the tests on Windows would also try to prepare a > command line with bin/solr (instead of bin/solr.cmd). Hence those tests would > pass getting into the "if" block in this PR, although in an unintended way. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[jira] [Updated] (SOLR-17772) Tests for examples failing on Windows
[ https://issues.apache.org/jira/browse/SOLR-17772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17772: -- Labels: pull-request-available windows (was: windows) > Tests for examples failing on Windows > - > > Key: SOLR-17772 > URL: https://issues.apache.org/jira/browse/SOLR-17772 > Project: Solr > Issue Type: Bug > Components: cli >Reporter: Rahul Goswami >Priority: Minor > Labels: pull-request-available, windows > Time Spent: 10m > Remaining Estimate: 0h > > This change only impacts _*tests*_ on Windows. Post the fix for jvm-opts, > command line execution runs fine. > The start flow via solr.cmd passes a "--script" parameter (which our tests > don't) and uses a different executor inside RunExampleTool from what the > tests use (RunExampleExecutor). Prior to recently merged fix for jvm-opts, > because of these reasons, the tests on Windows would also try to prepare a > command line with bin/solr (instead of bin/solr.cmd). Hence those tests would > pass getting into the "if" block in this PR, although in an unintended way. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
