Re: [PR] [SOLR-17726] Fix CloudMLTQParser to support copyField in qf [solr]
alessandrobenedetti merged PR #3328: URL: https://github.com/apache/solr/pull/3328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [SOLR-17726] Fix CloudMLTQParser to support copyField in qf [solr]
ilariapet commented on PR #3328: URL: https://github.com/apache/solr/pull/3328#issuecomment-2820139002 > This all makes sense... Two things: > > 1. Instead of working around how RTG works, would it make sense to have RTG return copyField values instead and not need this? I don't know, there could be good technical reasons why RTG does it what it does > 2. I love the descriptive text for the tests that are in your PR. It would be nice to preserve that as a comment in the actual `CloudMLTQParserTest.java` file for the next person! I sometimes struggle to understand why a test exists.. Thanks a lot for the feedback! Regarding the first point, according to the documentation, the goal of RealTime Get (RTG) is to return the latest version of a document. Maybe the reason why `copyField` values aren’t included is to avoid duplicating existing data... including them would just introduce redundancy. That said, we could consider modifying RTG by introducing a parameter like `includeCopyFields` (defaulting to false) to preserve the current behavior while still offering flexibility when those fields are actually needed. Let’s see what others think as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [SOLR-17726] Fix CloudMLTQParser to support copyField in qf [solr]
epugh commented on PR #3328: URL: https://github.com/apache/solr/pull/3328#issuecomment-2812867398 Looks like we need `gradlew tidy` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [SOLR-17726] Fix CloudMLTQParser to support copyField in qf [solr]
epugh commented on PR #3328: URL: https://github.com/apache/solr/pull/3328#issuecomment-2812799193 Love the description. It *could* also be a javadoc right? On the method? But now I am just nit picking! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
