Re: [PR] [SOLR-18114] CloudSolrClient fails deleteById with directUpdatesToLeadersOnly but no route passed [solr]
mlbiscoc merged PR #4219: URL: https://github.com/apache/solr/pull/4219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [SOLR-18114] CloudSolrClient fails deleteById with directUpdatesToLeadersOnly but no route passed [solr]
dsmiley commented on PR #4219: URL: https://github.com/apache/solr/pull/4219#issuecomment-4101736233 Your PR couldn't have anything to do with that. merge anyway. But thanks for bringing it to my attention. It's a chore when sporadically CI hiccups or something, which seems increasingly so. I'll look into this specific matter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [SOLR-18114] CloudSolrClient fails deleteById with directUpdatesToLeadersOnly but no route passed [solr]
mlbiscoc commented on PR #4219: URL: https://github.com/apache/solr/pull/4219#issuecomment-4100491244 Is there something relevant to my PR that won't let SolrJ CI run? I have doubts because it looks like a permission issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [SOLR-18114] CloudSolrClient fails deleteById with directUpdatesToLeadersOnly but no route passed [solr]
dsmiley commented on code in PR #4219: URL: https://github.com/apache/solr/pull/4219#discussion_r2962953671 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java: ## Review Comment: you one-upped me and went to warn :-) LOL sure, what the heck. But you're on the hook if anyone complains ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [SOLR-18114] CloudSolrClient fails deleteById with directUpdatesToLeadersOnly but no route passed [solr]
mlbiscoc commented on code in PR #4219: URL: https://github.com/apache/solr/pull/4219#discussion_r2962797970 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java: ## Review Comment: If we're ok with this, then I added a single `log.warn` message there and added the LogListener test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [SOLR-18114] CloudSolrClient fails deleteById with directUpdatesToLeadersOnly but no route passed [solr]
mlbiscoc commented on code in PR #4219: URL: https://github.com/apache/solr/pull/4219#discussion_r2942911708 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java: ## Review Comment: I only ran into this bug because it was forgotten to pass the the routing info on delete. On the flip side, if this exception didn't occur, deletes would have passed and I never would have known deletes we're being sent in an unoptimized way. One way to catch is to add a log here to a SolrJ client but I think that'd be way to noisy. Maybe a debug log? Or maybe that is the correct way and just never log. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
