Re: [PR] Exclude Kotlin multiplatform tests on -x test [solr]
dsmiley commented on PR #3184: URL: https://github.com/apache/solr/pull/3184#issuecomment-2660938071 Ideally we submit an issue to get JetBrains to fix this and they do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Exclude Kotlin multiplatform tests on -x test [solr]
malliaridis commented on PR #3184: URL: https://github.com/apache/solr/pull/3184#issuecomment-2660860918 @HoustonPutman thanks for the links, very insightful. > We'd have to make those lines, and the other two for desktop and browser, configurable. Not sure what you mean by configurable here. The only alternative to this workaround I could think of is to replace `check -x test` with a custom task for selectively running only the checks we want. But since `gradlew check -x test` is frequently used by devs, it would have some larger impact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Exclude Kotlin multiplatform tests on -x test [solr]
dsmiley commented on PR #3184: URL: https://github.com/apache/solr/pull/3184#issuecomment-2660515602 I took the liberty of merging to expedite resolving failing builds. Thanks Christos for getting this workaround in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Exclude Kotlin multiplatform tests on -x test [solr]
dsmiley merged PR #3184: URL: https://github.com/apache/solr/pull/3184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Exclude Kotlin multiplatform tests on -x test [solr]
dsmiley commented on PR #3184: URL: https://github.com/apache/solr/pull/3184#issuecomment-2660480907 @risdenk do you accept this PR, now that the hack is contained to the offending module? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Exclude Kotlin multiplatform tests on -x test [solr]
HoustonPutman commented on PR #3184: URL: https://github.com/apache/solr/pull/3184#issuecomment-2660443887 - https://github.com/JetBrains/kotlin/blob/master/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/testing/internal/KotlinTestsRegistry.kt#L33 - https://github.com/JetBrains/kotlin/blob/master/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/testing/internal/KotlinTestsRegistry.kt#L40 This is the reason, and I don't think there is any way around it, for now at least. We'd have to make those lines, and the other two for desktop and browser, configurable. Overall yeah +1. I hate the hack, but I'm not sure there is a better way around it for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Exclude Kotlin multiplatform tests on -x test [solr]
dsmiley commented on PR #3184: URL: https://github.com/apache/solr/pull/3184#issuecomment-2660237523 Fundamentally, I think this is a hack, wherever it's placed. But to stop some CI builds from being on fire, maybe this is what we need to do today. Ideally we would better understand exactly why/how these tasks got attached to "check" instead of "test" and fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Exclude Kotlin multiplatform tests on -x test [solr]
malliaridis commented on PR #3184: URL: https://github.com/apache/solr/pull/3184#issuecomment-2660210798 No problem, can move that to the UI module. I was just thinking that since this may not be the only case where we have to exclude specific tasks on `-x test`, it would be better placed in a more global place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Exclude Kotlin multiplatform tests on -x test [solr]
dsmiley commented on PR #3184: URL: https://github.com/apache/solr/pull/3184#issuecomment-2660174255 Yeah; agree with Kevin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
