Re: [PR] Fix DockMakerTest maxCardinality [solr]
dsmiley merged PR #3171: URL: https://github.com/apache/solr/pull/3171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Fix DockMakerTest maxCardinality [solr]
dsmiley commented on PR #3171: URL: https://github.com/apache/solr/pull/3171#issuecomment-2654944730 Will merge tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Fix DockMakerTest maxCardinality [solr]
dsmiley commented on code in PR #3171: URL: https://github.com/apache/solr/pull/3171#discussion_r1948227396 ## solr/benchmark/src/test/org/apache/solr/bench/DockMakerTest.java: ## @@ -200,25 +201,4 @@ public void testWordListZipfian() { assertNotNull(field.getValue().toString()); } - - @Test - public void testGenDoc() { Review Comment: removed because it had no assertions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org